Skip to contentSkip to conversation

send-pull-request: Make -a really imply -c

PATCH New Darren Hart 1 participant 2 messages Aug 1, 2012

lore
Share & tools
lore
#0 lore raw

cover send-pull-request: Make -a really imply -c

The following changes since commit 674d65c94478a1ff33ef9d9c1e49f677091301f4:

imagetest-qemu.bbclass: Fix whitespace issues (2012-08-01 09:08:25 +0100)

are available in the git repository at:
git://git.yoctoproject.org/user-contrib/dvhart/oe-core pullrequest
http://git.yoctoproject.org/cgit.cgi/user-contrib/dvhart/oe-core/log/?h=pullrequest

Darren Hart (1):
send-pull-request: Make -a really imply -c

 scripts/send-pull-request |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 send-pull-request: Make -a really imply -c

The switch statement does not fall through as the comment suggests. This results in -a not implying -c as was intended.

Add the two lines from -c to -a to achieve the intended behavior.

---
 scripts/send-pull-request |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
scripts/send-pull-request +2 -1
index 09f4245..18a53c4 100755
@@ -71,8 +71,9 @@ harvest_recipients()
 while getopts "achp:t:" OPT; do
 	case $OPT in
 	a)
+		AUTO=1
+		GITSOBCC="--signed-off-by-cc"
 		AUTO_CL=1
-		# Fall through to include -c
 		;;
 	c)
 		AUTO=1
Signature · 1 line
1.7.5.4