libxpm-native: add dependency on gettext-native
PATCH 1/1 libxpm-native: add dependency on gettext-native
libxpm needs xgettext. There can be failures if gettext doesn't get built first and it's not available from the host.
The target version doesn't have issues since it will get the dependency indirectly.
Jesse Zhang (1):
libxpm-native: add dependency on gettext-native
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.7
PATCH 1/1 libxpm-native: add dependency on gettext-native
libxpm needs xgettext to build po files. Add explicit dependency on gettext-native.
--- meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +2 -1
@@ -10,7 +10,8 @@ protocol." LICENSE = "BSD" LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5" DEPENDS += "libxext libsm libxt" -PR = "r0" +DEPENDS_virtclass-native = "gettext-native" +PR = "r1" PE = "1" XORG_PN = "libXpm"
Signature · 1 line
1.7.7
Quoted 13 lines · Jesse Zhang
libxpm needs xgettext to build po files. Add explicit dependency on gettext-native.
Signed-off-by Jesse Zhang <[email protected]>--- meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +0
-0
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb protocol." · line 13
Quoted 5 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +1
-1@@ -10,7 +10,8 @@ protocol." LICENSE = "BSD" LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5" DEPENDS += "libxext libsm libxt" -PR = "r0" +DEPENDS_virtclass-native = "gettext-native"
Is there a reason you don't do an inherit gettext here to ensure other bits are set? Also for the native, you maybe able to use the gettext-minimal-native if there is reason you can't use the inherit.
Sau!
Quoted 5 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +1
-0+PR = "r1" PE = "1" XORG_PN = "libXpm"
Hi Saul,
Quoted 9 lines · Saul Wold
Quoted 8 lines · Jesse Zhang
libxpm needs xgettext to build po files. Add explicit dependency on gettext-native.
Signed-off-by Jesse Zhang <[email protected]>--- meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Quoted 12 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb protocol." · line 13
Quoted 10 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +1
-1@@ -10,7 +10,8 @@ protocol." LICENSE = "BSD" LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5" DEPENDS += "libxext libsm libxt" -PR = "r0" +DEPENDS_virtclass-native = "gettext-native"Is there a reason you don't do an inherit gettext here to ensure other bits are set?
Actually I don't know what's the preferred way to do this. What is required by libxpm is the xgettext command; using DEPENDS will be enough to make it available, but I didn't know the other solution.
Quoted 1 line
Also for the native, you maybe able to use the gettext-minimal-native if there is reason you can't use the inherit.
gettext-minimal-native is already pulled in through the implicit dependency chain. But clearly it doesn't provide xgettext?
jesse
Quoted 8 lines
Quoted 6 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +1
-0+PR = "r1" PE = "1" XORG_PN = "libXpm"
Quoted 25 lines · Jesse Zhang
Hi Saul,
Quoted 9 lines · Saul Wold
Quoted 8 lines · Jesse Zhang
libxpm needs xgettext to build po files. Add explicit dependency on gettext-native.
Signed-off-by Jesse Zhang <[email protected]>--- meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)Quoted 12 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb protocol." · line 13
Quoted 10 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +1
-1@@ -10,7 +10,8 @@ protocol." LICENSE = "BSD" LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5" DEPENDS += "libxext libsm libxt" -PR = "r0" +DEPENDS_virtclass-native = "gettext-native"Is there a reason you don't do an inherit gettext here to ensure other bits are set?
Quoted 4 lines
Actually I don't know what's the preferred way to do this. What is required by libxpm is the xgettext command; using DEPENDS will be enough to make it available, but I didn't know the other solution.
Ok, well I am telling you there is another, more correct, way to do this using the inherit gettext, so please try using inherit gettext and see if that works correctly. The meta/classes/gettext.bbclass in conjunction with native.bbclass correctly set the DEPENDS to use gettext-native.
Also, on another note, please modify your patch subject to just say libxpm, this initial confused a couple of us thinking that libxpm was a native specific recipe.
Sau!
Quoted 17 lines
Quoted 1 line
Also for the native, you maybe able to use the gettext-minimal-native if there is reason you can't use the inherit.
gettext-minimal-native is already pulled in through the implicit dependency chain. But clearly it doesn't provide xgettext?
jesse
Quoted 8 lines
Quoted 6 lines
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +1
-0+PR = "r1" PE = "1" XORG_PN = "libXpm"
v2 cover libxpm: inherit gettext
Hi Saul,
Thanks for the advice. I've changed it to use "inherit gettext" instead.
The following changes since commit 054d95edad8d79ef1c6b30681395d50f3c6335b4:
poky.conf: restore Ubuntu 12.04 LTS to tested distro list (2012-08-23 17:23:40 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib szhang/xpm
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=szhang/xpm
Jesse Zhang (1):
libxpm: inherit gettext
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.11.4
PATCH v2 1/1 libxpm: inherit gettext
libxpm requires the xgettext command to build.
--- meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb +4 -1
@@ -1,5 +1,8 @@ require xorg-lib-common.inc +# libxpm requires xgettext to build +inherit gettext + SUMMARY = "Xpm: X Pixmap extension library" DESCRIPTION = "libXpm provides support and common operation for the XPM \
@@ -10,7 +13,7 @@ protocol." LICENSE = "BSD" LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5" DEPENDS += "libxext libsm libxt" -PR = "r0" +PR = "r1" PE = "1" XORG_PN = "libXpm"
Signature · 1 line
1.7.11.4
Saul Wold
AppliedQuoted 12 lines · Jesse Zhang
libxpm needs xgettext. There can be failures if gettext doesn't get built first and it's not available from the host.
The target version doesn't have issues since it will get the dependency indirectly.
Jesse Zhang (1):
libxpm-native: add dependency on gettext-nativemeta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Merged into OE-Core
Thanks
Sau!
Quoted 7 lines · Saul Wold
Quoted 6 lines · Jesse Zhang
libxpm needs xgettext. There can be failures if gettext doesn't get built first and it's not available from the host.
The target version doesn't have issues since it will get the dependency indirectly.
Quoted 7 lines
Quoted 6 lines
Jesse Zhang (1):
libxpm-native: add dependency on gettext-nativemeta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)Merged into OE-Core
I'm not finding this patch in the git repository. I don't think it was actually merged.
--Mark
Quoted 9 lines
Thanks
Sau!_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core