Skip to contentSkip to conversation

Add unique identifier to screen calls

PATCH Applied Mark Hatle 2 participants 3 messages Aug 24, 2012 – Aug 27, 2012

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

cover Add unique identifier to screen calls

The following changes since commit 968cfc0b630fb409430a46b1512d6bf0de225ad1:

build-appliance-image: Add vmx* files and build zip file (2012-08-24 17:32:34 +0100)

are available in the git repository at:
git://git.yoctoproject.org/poky-contrib mhatle/devshell
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mhatle/devshell

Jason Wessel (1):
terminal.py: use unique ids for screen sessions

 meta/lib/oe/terminal.py |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.3.4
author
#1 lore raw

PATCH 1/1 terminal.py: use unique ids for screen sessions

From: Jason Wessel <[email protected]>

When running multiple sets of builds on the same system, it is hard to distinguish which build belongs to which screen session and you can end up resuming the wrong session.

The simple solution is to just append the process id to the screen session invocation to make each unique.

---
 meta/lib/oe/terminal.py |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
meta/lib/oe/terminal.py +3 -1
index 3131798..30e8f92 100644
@@ -94,9 +94,11 @@ class Screen(Terminal):
     command = 'screen -D -m -t "{title}" -S devshell {command}'
 
     def __init__(self, sh_cmd, title=None, env=None):
+        s_id = "devshell_%i" % os.getpid()
+        self.command = "screen -D -m -t \"{title}\" -S %s {command}" % s_id
         Terminal.__init__(self, sh_cmd, title, env)
         logger.warn('Screen started. Please connect in another terminal with '
-                    '"screen -r devshell"')
+                    '"screen -r devshell %s"' % s_id)
 
 
 def prioritized():
Signature · 1 line
1.7.3.4
Applied
#2 lore raw
In reply to Mark Hatle
Quoted 8 lines · Mark Hatle

The following changes since commit 968cfc0b630fb409430a46b1512d6bf0de225ad1:

   build-appliance-image: Add vmx* files and build zip file (2012-08-24 17:32:34 +0100)

are available in the git repository at:
git://git.yoctoproject.org/poky-contrib mhatle/devshell
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mhatle/devshell

Quoted 6 lines

Jason Wessel (1):
terminal.py: use unique ids for screen sessions

  meta/lib/oe/terminal.py |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)

Merged into OE-Core

Thanks
Sau!