add ia32-base.inc
cover add ia32-base.inc
From: Tom Zanussi <[email protected]>
This adds ia32-base to meta/conf/machine/include. See the following link for details:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=2996
The following changes since commit 86a6410fcbfb43e74aa1c9c995a21129d8434f75:
build-appliance-image: Add vmx* files and build zip file (2012-08-24 17:32:57 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib.git tzanussi/ia32-base-again.v1
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/ia32-base-again.v1
Tom Zanussi (1):
ia32-base.inc: new include file
meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 meta/conf/machine/include/ia32-base.inc
Signature · 1 line
1.7.11.4
PATCH 1/1 ia32-base.inc: new include file
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
--- meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 meta/conf/machine/include/ia32-base.inc
meta/conf/machine/include/ia32-base.inc new file +58 -0
@@ -0,0 +1,58 @@ +# +# base machine settings for ia32-architecture BSPs +# + +# +# common settings for Intel-based machines +# +MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \ + acpi serial usbgadget alsa" + +MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts" +MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub" + +IMAGE_FSTYPES += "ext3 cpio.gz live" + +KERNEL_IMAGETYPE ?= "bzImage" + +SERIAL_CONSOLE ?= "115200 ttyS0" + +# +# glibc-related variables +# +GLIBC_ADDONS ?= "nptl" + +# +# kernel-related variables +# +PREFERRED_PROVIDER_virtual/kernel ??= "linux-yocto" +PREFERRED_VERSION_linux-yocto ??= "3.0%" + +# +# XSERVER subcomponents, used to build the XSERVER variable +# +XSERVER_IA32_BASE = "xserver-xorg \ + xf86-input-mouse \ + xf86-input-keyboard \ + xf86-input-evdev \ + xf86-input-synaptics \ + mesa-dri \ + " + +XSERVER_IA32_EXT = "xserver-xorg-extension-dri \ + xserver-xorg-extension-dri2 \ + xserver-xorg-extension-glx \ + xserver-xorg-extension-extmod \ + xserver-xorg-extension-dbe \ + xserver-xorg-module-libint10 \ + " + +XSERVER_IA32_I915 = "xf86-video-intel \ + mesa-dri-driver-i915 \ + " + +XSERVER_IA32_I965 = "xf86-video-intel \ + mesa-dri-driver-i965 \ + " + +XSERVER_IA32_VESA = "xf86-video-vesa"
Signature · 1 line
1.7.11.4
Re: [PATCH 1/1] ia32-base.inc: new include file
Quoted 10 lines · On Fri, 2012-08-24 at 23:34 -0500, [email protected] wrote:
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
Quoted 8 lines
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>--- meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 meta/conf/machine/include/ia32-base.inc
I'd add that there are several reasons for this. Things like atom-pc from meta-yocto could do with accessing this file's content for example so its useful beyond just meta-intel. In the same way we have various core "tune" files in OE-Core, this one has become something similar for IA32. There were recently sstate reuse bugs where the lack of a common include were causing this to get rebuild depending on which machine was selected.
It also allows the yocto-bsp tools to work with OE-Core where they'd currently have failures due to recommending this file.
Cheers,
Richard
Re: [PATCH 1/1] ia32-base.inc: new include file
In reply to [email protected]Op 25 aug. 2012, om 06:34 heeft [email protected] het volgende geschreven:
Quoted 17 lines
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>---
meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++
meta/conf/machine/include/ia32-base.inc line 23
Quoted 3 lines
meta/conf/machine/include/ia32-base.inc new file +3
-0+# glibc-related variables +# +GLIBC_ADDONS ?= "nptl"
That's a distro setting
Re: [PATCH 1/1] ia32-base.inc: new include file
Quoted 2 lines · Koen Kooi
Op 25 aug. 2012, om 06:34 heeft [email protected] het volgende
geschreven:
Quoted 11 lines
Quoted 11 lines
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
Quoted 6 lines
Quoted 6 lines
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>---
meta/conf/machine/include/ia32-base.inc | 58
+++++++++++++++++++++++++++++++++
Quoted 6 lines
meta/conf/machine/include/ia32-base.inc line 23
Quoted 4 lines
meta/conf/machine/include/ia32-base.inc new file +3
-0+# glibc-related variables +# +GLIBC_ADDONS ?= "nptl"That's a distro setting
And its redundant
Quoted 5 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [PATCH 1/1] ia32-base.inc: new include file
Quoted 29 lines · Khem Raj
Quoted 2 lines · Koen Kooi
Op 25 aug. 2012, om 06:34 heeft [email protected] het volgende
geschreven:
Quoted 4 lines
Quoted 4 lines
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See
meta-intel
Quoted 3 lines
Quoted 3 lines
for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this
file:
Quoted 2 lines
Quoted 2 lines
The meta-intel BSPs currently have a number of machine settings
common
Quoted 8 lines
Quoted 8 lines
to all - factor these out into a common include file.
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>---
meta/conf/machine/include/ia32-base.inc | 58+++++++++++++++++++++++++++++++++
Quoted 1 line
Quoted 1 line
Quoted 7 lines
Quoted 5 lines
meta/conf/machine/include/ia32-base.inc line 23
Quoted 3 lines
meta/conf/machine/include/ia32-base.inc new file +3
-0+# glibc-related variables +# +GLIBC_ADDONS ?= "nptl"That's a distro setting
And its redundant
I thought you tried removing this and we ran into issues?
Regardless, I think this is reason to have this in one place where we can clean it up. I tried to untangle the GLIBC_EXTRA_CONF bit that was here until recently and that was more painful than necessary needing patches to meta-intel and meta-yocto. If we get one good include file, we then have one place to clean this kind of thing up and it stops BSP layers having to do their own things badly.
So in summary I think this is a reason to support this change :)
Cheers,
Richard
Re: [PATCH 1/1] ia32-base.inc: new include file
Quoted 36 lines · Richard Purdie
Quoted 35 lines · Khem Raj
Quoted 2 lines · Koen Kooi
Op 25 aug. 2012, om 06:34 heeft [email protected] het volgende
geschreven:
Quoted 4 lines
Quoted 4 lines
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See
meta-intel
Quoted 3 lines
Quoted 3 lines
for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this
file:
Quoted 2 lines
Quoted 2 lines
The meta-intel BSPs currently have a number of machine settings
common
Quoted 8 lines
Quoted 8 lines
to all - factor these out into a common include file.
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>---
meta/conf/machine/include/ia32-base.inc | 58+++++++++++++++++++++++++++++++++
Quoted 6 lines
meta/conf/machine/include/ia32-base.inc line 23
Quoted 4 lines
meta/conf/machine/include/ia32-base.inc new file +3
-0+# glibc-related variables +# +GLIBC_ADDONS ?= "nptl"That's a distro setting
Quoted 3 lines
Quoted 1 line
And its redundant
I thought you tried removing this and we ran into issues?
I did not but I guess someone else did and it
was seemingly because of these settings in meta-intel but I will try to remove it once again and having this in OE core might be beneficial
besides, I think the name of file is misleading as Phil also pointed out
Quoted 17 lines
Regardless, I think this is reason to have this in one place where we can clean it up. I tried to untangle the
GLIBC_EXTRA_CONFbit that was here until recently and that was more painful than necessary needing patches to meta-intel and meta-yocto. If we get one good include file, we then have one place to clean this kind of thing up and it stops BSP layers having to do their own things badly.So in summary I think this is a reason to support this change :)
Cheers,
Richard
Re: [PATCH 1/1] ia32-base.inc: new include file
In reply to Koen KooiQuoted 19 lines · Koen Kooi
Op 25 aug. 2012, om 06:34 heeft [email protected] het volgende geschreven:
Quoted 17 lines
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>---
meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++
Quoted 5 lines
meta/conf/machine/include/ia32-base.inc line 23
Quoted 3 lines
meta/conf/machine/include/ia32-base.inc new file +3
-0+# glibc-related variables +# +GLIBC_ADDONS ?= "nptl"That's a distro setting
Yes and no. It makes sense for architectures to have sane defaults and I class nptl on ia32 as that. We want OE-Core to function distroless but allow distros to change things where it makes sense to them. So I'd argue this is reasonable.
I seem to remember a number of issues where ia32 defaulted to something less sane going back in time and you needed this on every ia32 machine. As has been pointed out, this is probably redundant now. If that is the case, great, lets clean it up. As I mention to Khem, having one place to cleanup is better than a whole load of different places.
So I see more in favour of merging this and working on improvements than not merging it as things stand.
Cheers,
Richard
Re: [PATCH 1/1] ia32-base.inc: new include file
Op 25 aug. 2012, om 13:56 heeft Richard Purdie <[email protected]> het volgende geschreven:
Quoted 26 lines · Koen Kooi
Quoted 19 lines
Op 25 aug. 2012, om 06:34 heeft [email protected] het volgende geschreven:
Quoted 17 lines
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>---
meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++Quoted 5 lines
meta/conf/machine/include/ia32-base.inc line 23
Quoted 3 lines
meta/conf/machine/include/ia32-base.inc new file +3
-0+# glibc-related variables +# +GLIBC_ADDONS ?= "nptl"That's a distro setting
Quoted 4 lines
Yes and no. It makes sense for architectures to have sane defaults and I class nptl on ia32 as that. We want OE-Core to function distroless but allow distros to change things where it makes sense to them. So I'd argue this is reasonable.
So put it in default-distrovars, not in a machine 'tune' file.
Re: [PATCH 1/1] ia32-base.inc: new include file
Quoted 28 lines · Koen Kooi
Op 25 aug. 2012, om 13:56 heeft Richard Purdie <[email protected]> het volgende geschreven:
Quoted 26 lines · Koen Kooi
Quoted 24 lines
Op 25 aug. 2012, om 06:34 heeft [email protected] het volgende geschreven:
Quoted 17 lines
From: Tom Zanussi <[email protected]>
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
Signed-off-by Tom Zanussi <[email protected]>---
meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++meta/conf/machine/include/ia32-base.inc line 23
Quoted 3 lines
meta/conf/machine/include/ia32-base.inc new file +3
-0+# glibc-related variables +# +GLIBC_ADDONS ?= "nptl"That's a distro setting
Quoted 6 lines
Quoted 4 lines
Yes and no. It makes sense for architectures to have sane defaults and I class nptl on ia32 as that. We want OE-Core to function distroless but allow distros to change things where it makes sense to them. So I'd argue this is reasonable.
So put it in default-distrovars, not in a machine 'tune' file.
This was only seemingly needed on x86 for reasons which I no longer understand and are likely historical and irrelevant now. So yes, we could add it there with an arch override. The likely outcome is the thing will just get removed so I'm finding it hard to get worked up about it though.
Cheers,
Richard
Re: [PATCH 1/1] ia32-base.inc: new include file
In reply to [email protected]Quoted 8 lines · On Fri, 2012-08-24 at 23:34 -0500, [email protected] wrote:
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
It doesn't look as though the name "ia32-base" really reflects the contents of this file very accurately. Most of the bits in here seem to have more to do with generic PC architecture and would equally apply to x86-64 (or indeed any architecture -- e.g. "ext2" which doesn't really seem to be a machine property in any meaningful sense). Also, a lot of the stuff in this file seems rather more like distro policy than architecture/machine definition.
That's not to say that I think the idea of having an include file to capture a "PC-type" platform (or, at least, the common use-cases for one) is a bad idea. If there are multiple platforms which want to do that then putting the definitions in a common place does seem sensible, but I think describing it as "ia32-base" is at the same time too specific and too generic.
Quoted 2 lines
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
If these are really intel-specific (and the i915/i965 bits do look like they are), shouldn't they stay in meta-intel? It seems like having variables defined in oe-core, but not referenced by anything in oe-core, is possibly a recipe for future confusion.
p.
Re: [PATCH 1/1] ia32-base.inc: new include file
Quoted 6 lines · Phil Blundell
Quoted 5 lines · On Fri, 2012-08-24 at 23:34 -0500, [email protected] wrote:
This is the ia32-base.inc moved over from meta-intel. See meta-intel for the complete history of contributions to this file.
Here's the initial commit text that explains the purpose of this file:
Quoted 8 lines
Quoted 3 lines
The meta-intel BSPs currently have a number of machine settings common to all - factor these out into a common include file.
It doesn't look as though the name "ia32-base" really reflects the contents of this file very accurately. Most of the bits in here seem to have more to do with generic PC architecture and would equally apply to x86-64
Note that IA32 includes both x86 and x86-64 in contrast to IA64 which is Itanium so the name is actually inclusive.
Quoted 12 lines
(or indeed any architecture -- e.g. "ext2" which doesn't really
seem to be a machine property in any meaningful sense). Also, a lot of the stuff in this file seems rather more like distro policy than architecture/machine definition.That's not to say that I think the idea of having an include file to capture a "PC-type" platform (or, at least, the common use-cases for one) is a bad idea. If there are multiple platforms which want to do that then putting the definitions in a common place does seem sensible, but I think describing it as "ia32-base" is at the same time too specific and too generic.
Quoted 7 lines
Quoted 2 lines
Also add several new intel-specific XSERVER variables for building XSERVER variables in BSPs.
If these are really intel-specific (and the i915/i965 bits do look like they are), shouldn't they stay in meta-intel? It seems like having variables defined in oe-core, but not referenced by anything in oe-core, is possibly a recipe for future confusion.
They are used outside of meta-intel, just like the tune files and other pieces we already have in OE-Core in the machine include directory. Yes, they're only used by a subset of the architectures but I don't think that is a reason to exclude this.
Cheers,
Richard
Saul Wold
AppliedQuoted 16 lines · On 08/24/2012 09:32 PM, [email protected] wrote:
From: Tom Zanussi <[email protected]>
This adds ia32-base to meta/conf/machine/include. See the following link for details:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=2996The following changes since commit
86a6410fcbfb43e74aa1c9c995a21129d8434f75:build-appliance-image: Add vmx* files and build zip file (2012-08-24 17:32:57 +0100)are available in the git repository at:
git://git.yoctoproject.org/poky-contrib.gittzanussi/ia32-base-again.v1
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/ia32-base-again.v1
Quoted 7 lines
Tom Zanussi (1):
ia32-base.inc: new include filemeta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+)create mode 100644 meta/conf/machine/include/ia32-base.inc
Merged into OE-Core
Thanks
Sau!