Skip to contentSkip to conversation

for 3.6 - fix gianfar build failure

PATCH In review Richard Cochran 2 participants 3 messages Sep 21, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover for 3.6 - fix gianfar build failure

The gianfar ethtool time stamping change doesn't even build. This should really get fixed for 3.6 if at all possible.

Thanks,
Richard

Richard Cochran (1):
gianfar: fix phc index build failure

 drivers/net/ethernet/freescale/gianfar_ethtool.c |    1 +
 drivers/net/ethernet/freescale/gianfar_ptp.c     |    4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH 1/1 gianfar: fix phc index build failure

This patch fixes a build failure introduced in commit 66636287. Not only was a global variable inconsistently named, but also it was not exported as it should have been.

This fix is also needed in stable version 3.5.

---
 drivers/net/ethernet/freescale/gianfar_ethtool.c |    1 +
 drivers/net/ethernet/freescale/gianfar_ptp.c     |    4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/freescale/gianfar_ethtool.c +1 -0
index 8971921..ab6762c 100644
@@ -1773,6 +1773,7 @@ static int gfar_get_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
 }
 
 int gfar_phc_index = -1;
+EXPORT_SYMBOL(gfar_phc_index);
 
 static int gfar_get_ts_info(struct net_device *dev,
 			    struct ethtool_ts_info *info)
drivers/net/ethernet/freescale/gianfar_ptp.c +2 -2
index c08e5d4..0daa66b 100644
@@ -515,7 +515,7 @@ static int gianfar_ptp_probe(struct platform_device *dev)
 		err = PTR_ERR(etsects->clock);
 		goto no_clock;
 	}
-	gfar_phc_clock = ptp_clock_index(etsects->clock);
+	gfar_phc_index = ptp_clock_index(etsects->clock);
 
 	dev_set_drvdata(&dev->dev, etsects);
 
@@ -539,7 +539,7 @@ static int gianfar_ptp_remove(struct platform_device *dev)
 	gfar_write(&etsects->regs->tmr_temask, 0);
 	gfar_write(&etsects->regs->tmr_ctrl,   0);
 
-	gfar_phc_clock = -1;
+	gfar_phc_index = -1;
 	ptp_clock_unregister(etsects->clock);
 	iounmap(etsects->regs);
 	release_resource(etsects->rsrc);
Signature · 1 line
1.7.2.5
maintainer
#2 lore raw

Re: [PATCH 1/1] gianfar: fix phc index build failure

From: Richard Cochran <[email protected]>
Date: Fri, 21 Sep 2012 07:11:12 +0200

Quoted 7 lines

This patch fixes a build failure introduced in commit 66636287. Not only was a global variable inconsistently named, but also it was not exported as it should have been.

This fix is also needed in stable version 3.5.

Applied and queued up for -stable, thanks.

Quoted 1 line

Do not add -stable CC:'s to networking patches, please instead simply ask me to queue it up for -stable as I take care of networking stable submissions myself rather than via the automated procedure.