MAINTAINERS: correct pathname
PATCH v2 1/6 MAINTAINERS: correct pathname
From: Nitin A Kamble <[email protected]>
The commmon directory has more stuff than just recipes-core. All this need to be maintained together as part of the meta-intel layer.
--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
MAINTAINERS +1 -1
@@ -42,7 +42,7 @@ F: meta-chiefriver/ COMMON M: Nitin A Kamble<[email protected]> -F: common/recipes-core/ +F: common/ CROWNBAY M: Nitin A Kamble<[email protected]>
Signature · 1 line
1.7.3.4
PATCH v2 2/6 chiefriver: add WEBTITLE & Compliance information
From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
--- meta-chiefriver/README | 8 +++++++- meta-chiefriver/conf/machine/chiefriver.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)
meta-chiefriver/README +7 -1
@@ -7,6 +7,12 @@ plus the Panther Point PCH. This BSP assumes that the Ivy Bridge integrated graphics are being used. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============
@@ -20,7 +26,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-chiefriver branch: master
meta-chiefriver/conf/machine/chiefriver.conf +2 -0
@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: chiefriver +#@WEBTITLE: Intel 3rd Generations Core Platforms: Core i3, i5, i7 (Ivy Bridge) + #@DESCRIPTION: Machine configuration for Chief River systems # i.e. Ivy Bridge + Panther Point
Signature · 1 line
1.7.3.4
Re: [PATCH v2 2/6] chiefriver: add WEBTITLE & Compliance information
Quoted 17 lines · On Wed, 2012-10-24 at 13:25 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-chiefriver/README | 8 +++++++- meta-chiefriver/conf/machine/chiefriver.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)meta-chiefriver/README +0
-0
meta-chiefriver/README plus the Panther Point PCH. This BSP assumes that the Ivy Bridge · line 14
Quoted 8 lines
meta-chiefriver/README +5
-0@@ -7,6 +7,12 @@ plus the Panther Point PCH. This BSP assumes that the Ivy Bridge integrated graphics are being used. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration +
To be consistent with the rest of the README, there should be a blank line between the ===== and the 'This BSP... ' text.
Also, for readability, it would be nice to have the URL also separated by a blank line from the preceding text, and indented a couple spaces like similar lines in the README.
Also, I think the compliance text reads better as:
This BSP is compliant with the Yocto Project as per the requirements listed here:
meta-chiefriver/README This layer depends on: · line 29
Quoted 10 lines
meta-chiefriver/README +2
-1+ Dependencies ============@@ -20,7 +26,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-chiefriver
If you look at the meta-intel/conf/layer.conf, you see the layer actually is 'intel'.
Also, this is the README for the chiefriver layer, so it can't depend on itself i.e. meta-chiefriver or 'chiefriver' shouldn't be listed in layers
meta-chiefriver/conf/machine/chiefriver.conf line 5
Quoted 13 lines
meta-chiefriver/README +0
-0branch: mastermeta-chiefriver/conf/machine/chiefriver.conf +2
-0@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: chiefriver +#@WEBTITLE: Intel 3rd Generations Core Platforms: Core i3, i5, i7 (Ivy Bridge) +
Since this is text that will appear on the website, we need to be a little picky about grammar: it should read '3rd Generation' rather than '3rd Generations'
These comments apply to the other README files as well, so I won't repeat them there, other than to fix any text that might appear on the website for those as well...
Tom
Quoted 3 lines
meta-chiefriver/conf/machine/chiefriver.conf +0
-0#@DESCRIPTION: Machine configuration for Chief River systems # i.e. Ivy Bridge + Panther Point
Re: [PATCH v2 2/6] chiefriver: add WEBTITLE & Compliance information
Quoted 63 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Wednesday, October 24, 2012 5:15 PM
To: Kamble, Nitin A
Cc: [email protected]; Hart, Darren
Subject: Re: [PATCH v2 2/6] chiefriver: add WEBTITLE & Compliance informationQuoted 20 lines · On Wed, 2012-10-24 at 13:25 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-chiefriver/README | 8 +++++++- meta-chiefriver/conf/machine/chiefriver.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)meta-chiefriver/README index renamed from meta-chiefriver/README +0
-07c47b02..249a389 100644
meta-chiefriver/README +0
-0@@ -7,6 +7,12 @@ plus the Panther Point PCH. This BSP assumes thatthe Ivy Bridge integrated graphics are being used.
meta-chiefriver/README plus the Panther Point PCH. This BSP assumes that the Ivy Bridge · line 14
Quoted 5 lines
meta-chiefriver/README +5
-0+Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration +To be consistent with the rest of the README, there should be a blank line between the ===== and the 'This BSP... ' text.
Also, for readability, it would be nice to have the URL also separated by a blank line from the preceding text, and indented a couple spaces like similar lines in the README.
Also, I think the compliance text reads better as:
This BSP is compliant with the Yocto Project as per the requirements listed here:
meta-chiefriver/README This layer depends on: · line 29
Quoted 10 lines
meta-chiefriver/README +2
-1+ Dependencies ============@@ -20,7 +26,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-chiefriverIf you look at the
meta-intel/conf/layer.conf, you see the layer actually is 'intel'.
Quoted 2 lines
Also, this is the README for the chiefriver layer, so it can't depend on itself i.e. meta-chiefriver or 'chiefriver' shouldn't be listed in layers
Tom,
As part of the compliance we need to list all the components/layers needed to build the BSP. So even though it is README from this layer I think it should be listed as one of dependency for building the BSP.
And I will incorporate the rest of the feedback in the next pull request.
Nitin
Quoted 30 lines
Quoted 10 lines
meta-chiefriver/README +0
-0branch: mastermeta-chiefriver/conf/machine/chiefriver.conf +0
-0meta-chiefriver/conf/machine/chiefriver.conf line 6
Quoted 6 lines
meta-chiefriver/conf/machine/chiefriver.conf +3
-0@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: chiefriver +#@WEBTITLE: Intel 3rd Generations Core Platforms: Core i3, i5, i7 +(Ivy Bridge) +Since this is text that will appear on the website, we need to be a little picky about grammar: it should read '3rd Generation' rather than '3rd Generations'
These comments apply to the other README files as well, so I won't repeat them there, other than to fix any text that might appear on the website for those as well...
Tom
Quoted 3 lines
meta-chiefriver/conf/machine/chiefriver.conf +0
-0#@DESCRIPTION: Machine configuration for Chief River systems # i.e.Ivy Bridge + Panther Point
Re: [PATCH v2 2/6] chiefriver: add WEBTITLE & Compliance information
Quoted 4 lines
Quoted 4 lines
If you look at the
meta-intel/conf/layer.conf, you see the layer actually is 'intel'.
Quoted 8 lines
Quoted 3 lines
Also, this is the README for the chiefriver layer, so it can't depend on itself i.e. meta-chiefriver or 'chiefriver' shouldn't be listed in layers
Tom,
As part of the compliance we need to list all the components/layers needed
to build the BSP. So even though it is README from this layer I think it should be listed as one of dependency for building the BSP.
Tom,
It's ok, there are other places in the README where these layers are mentioned.
So I can take this change out too.
Thanks,
Nitin
PATCH v2 3/6 crownbay: add WEBTITLE & Compliance information
In reply to [email protected]From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
--- meta-crownbay/README | 10 ++++++++-- meta-crownbay/conf/machine/crownbay-noemgd.conf | 2 ++ meta-crownbay/conf/machine/crownbay.conf | 2 ++ 3 files changed, 12 insertions(+), 2 deletions(-)
meta-crownbay/README +8 -2
@@ -2,13 +2,19 @@ This README file contains information on building the meta-crownbay BSP layer, and booting the images contained in the /binary directory. Please see the corresponding sections below for details. -The Crown Bay platform consists of the Intel Atom Z6xx processor, +The Crown Bay platform consists of the Intel Atom E6xx processor, plus the Intel EG20T Platform Controller Hub (Tunnel Creek + Topcliff). It also supports the E6xx embedded on-chip graphics via the Intel Embedded Media and Graphics Driver (EMGD) 1.14 Driver. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============
@@ -22,7 +28,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-crownbay branch: master
meta-crownbay/conf/machine/crownbay-noemgd.conf +2 -0
@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: crownbay-noemgd +#@WEBTITLE: Intel Atom E6xx processor with Intel EG20T Controller Hub development kit (Crown Bay) with open source VESA graphics + #@DESCRIPTION: Machine configuration for Crown Bay systems, without Intel-proprietary graphics bits # i.e. E660 + EG20T
meta-crownbay/conf/machine/crownbay.conf +2 -0
@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: crownbay +#@WEBTITLE: Intel Atom E6xx processor with Intel EG20T Controller Hub development kit (Crown Bay) with proprietary IEMGD accelerated graphics + #@DESCRIPTION: Machine configuration for Crown Bay systems # i.e. E660 + EG20T
Signature · 1 line
1.7.3.4
Re: [PATCH v2 3/6] crownbay: add WEBTITLE & Compliance information
Quoted 52 lines · On Wed, 2012-10-24 at 13:25 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-crownbay/README | 10 ++++++++-- meta-crownbay/conf/machine/crownbay-noemgd.conf | 2 ++ meta-crownbay/conf/machine/crownbay.conf | 2 ++ 3 files changed, 12 insertions(+), 2 deletions(-)meta-crownbay/README +8
-2@@ -2,13 +2,19 @@ This README file contains information on building the meta-crownbay BSP layer, and booting the images contained in the /binary directory. Please see the corresponding sections below for details. -The Crown Bay platform consists of the Intel Atom Z6xx processor, +The Crown Bay platform consists of the Intel Atom E6xx processor, plus the Intel EG20T Platform Controller Hub (Tunnel Creek + Topcliff). It also supports the E6xx embedded on-chip graphics via the Intel Embedded Media and Graphics Driver (EMGD) 1.14 Driver. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============@@ -22,7 +28,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-crownbay branch: mastermeta-crownbay/conf/machine/crownbay-noemgd.conf +0
-0
meta-crownbay/conf/machine/crownbay-noemgd.conf line 5
Quoted 5 lines
meta-crownbay/conf/machine/crownbay-noemgd.conf +2
-0@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: crownbay-noemgd +#@WEBTITLE: Intel Atom E6xx processor with Intel EG20T Controller Hub development kit (Crown Bay) with open source VESA graphics +
This should probably be capitalized as in the manual title:
Intel Atom E6xx Processor with Intel EG20T Controller Hub Development Kit (Crown Bay) with open source VESA graphics
Same for the other one...
Tom
Quoted 16 lines
meta-crownbay/conf/machine/crownbay-noemgd.conf +0
-0#@DESCRIPTION: Machine configuration for Crown Bay systems, without Intel-proprietary graphics bits # i.e. E660 + EG20Tmeta-crownbay/conf/machine/crownbay.conf +2
-0@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: crownbay +#@WEBTITLE: Intel Atom E6xx processor with Intel EG20T Controller Hub development kit (Crown Bay) with proprietary IEMGD accelerated graphics + #@DESCRIPTION: Machine configuration for Crown Bay systems # i.e. E660 + EG20T
PATCH v2 4/6 emenlow: add WEBTITLE & Compliance information
In reply to [email protected]From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
--- meta-emenlow/README | 8 +++++++- meta-emenlow/conf/machine/emenlow.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)
meta-emenlow/README +7 -1
@@ -13,6 +13,12 @@ depending on which BSP tarball you downloaded. Please see the corresponding sections below for details. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============
@@ -26,7 +32,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-emenlow branch: master
meta-emenlow/conf/machine/emenlow.conf +2 -0
@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: emenlow +#@WEBTITLE: Platforms with Intel Atom Z5xx processor with Intel US15W Controller Hub (Emenlow) + #@DESCRIPTION: Machine configuration for eMenlow based systems, like the # Webs-2120 box.
Signature · 1 line
1.7.3.4
Re: [PATCH v2 4/6] emenlow: add WEBTITLE & Compliance information
Quoted 43 lines · On Wed, 2012-10-24 at 13:25 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-emenlow/README | 8 +++++++- meta-emenlow/conf/machine/emenlow.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)meta-emenlow/README +7
-1@@ -13,6 +13,12 @@ depending on which BSP tarball you downloaded. Please see the corresponding sections below for details. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============@@ -26,7 +32,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-emenlow branch: mastermeta-emenlow/conf/machine/emenlow.conf +0
-0
meta-emenlow/conf/machine/emenlow.conf line 5
Quoted 5 lines
meta-emenlow/conf/machine/emenlow.conf +2
-0@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: emenlow +#@WEBTITLE: Platforms with Intel Atom Z5xx processor with Intel US15W Controller Hub (Emenlow) +
To be consistent with the other ones e.g crownbay, remove the 'Platforms with' and also capitalize as:
Intel Atom Z5xx Processor with Intel US15W Platform Controller Hub (Emenlow)
I think Emenlow is actually eMenlow...
Tom
Quoted 3 lines
meta-emenlow/conf/machine/emenlow.conf +0
-0#@DESCRIPTION: Machine configuration for eMenlow based systems, like the # Webs-2120 box.
PATCH v2 5/6 jasperforest: add WEBTITLE & Compliance information
In reply to [email protected]From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
--- meta-jasperforest/README | 8 +++++++- meta-jasperforest/conf/machine/jasperforest.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)
meta-jasperforest/README +7 -1
@@ -8,6 +8,12 @@ combined with the Intel 3420 PCH chipset (Ibex Peak) make up the 'Picket Post' CRB this BSP was developed on. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============
@@ -21,7 +27,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-jasperforest branch: master
meta-jasperforest/conf/machine/jasperforest.conf +2 -0
@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: jasperforest +#@WEBTITLE: Platforms with Intel Xeon C5500/C3500 series processors with Intel 3420 PCH chipset (Jasper Forest) + #@DESCRIPTION: Machine configuration for Jasper Forest Picket Post # systems i.e. Xeon C5500/C3500 + Intel 3420 chipset (Ibex Peak)
Signature · 1 line
1.7.3.4
Re: [PATCH v2 5/6] jasperforest: add WEBTITLE & Compliance information
Quoted 43 lines · On Wed, 2012-10-24 at 13:25 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-jasperforest/README | 8 +++++++- meta-jasperforest/conf/machine/jasperforest.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)meta-jasperforest/README +7
-1@@ -8,6 +8,12 @@ combined with the Intel 3420 PCH chipset (Ibex Peak) make up the 'Picket Post' CRB this BSP was developed on. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============@@ -21,7 +27,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-jasperforest branch: mastermeta-jasperforest/conf/machine/jasperforest.conf +0
-0
meta-jasperforest/conf/machine/jasperforest.conf line 5
Quoted 5 lines
meta-jasperforest/conf/machine/jasperforest.conf +2
-0@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: jasperforest +#@WEBTITLE: Platforms with Intel Xeon C5500/C3500 series processors with Intel 3420 PCH chipset (Jasper Forest) +
Similarly:
Intel Xeon C5500/C3500 Series Processors with Intel 3420 PCH Chipset (Jasper Forest)
Tom
Quoted 3 lines
meta-jasperforest/conf/machine/jasperforest.conf +0
-0#@DESCRIPTION: Machine configuration for Jasper Forest Picket Post # systems i.e. Xeon C5500/C3500 + Intel 3420 chipset (Ibex Peak)
PATCH v2 6/6 sugarbay: add WEBTITLE & Compliance information
In reply to [email protected]From: Nitin A Kamble <[email protected]>
The WEBTITLE will be used to publish the BSP on the Yocto Project Website. And adding the Yocto Project Compliance information for the 1.3 release. Also specifying all the layers used from meta-intel repository.
--- meta-sugarbay/README | 8 +++++++- meta-sugarbay/conf/machine/sugarbay.conf | 2 ++ 2 files changed, 9 insertions(+), 1 deletions(-)
meta-sugarbay/README +7 -1
@@ -7,6 +7,12 @@ plus the Cougar Point PCH (Q67 Express or B65 Express chipsets). This BSP assumes that the Sandy Bridge integrated graphics are being used. +Compliance +========== +This BSP is compliant with Yocto Project as per requirements listed here: +http://www.yoctoproject.org/yocto-project-compatible-registration + + Dependencies ============
@@ -20,7 +26,7 @@ This layer depends on: branch: master URI: git://git.yoctoproject.org/meta-intel - layers: intel + layers: meta-intel, meta-sugarbay branch: master
meta-sugarbay/conf/machine/sugarbay.conf +2 -0
@@ -1,6 +1,8 @@ #@TYPE: Machine #@NAME: sugarbay +#@WEBTITLE: Intel 2nd Generation Core Platforms: Core i3, i5, i7 (Sandy Bridge) + #@DESCRIPTION: Machine configuration for Sugar Bay systems # i.e. Sandy Bridge + Cougar Point
Signature · 1 line
1.7.3.4
v2 cover meta-intel: README updates
From: Nitin A Kamble <[email protected]>
Changed the commits based on the feedback from Tom & Darren. We also need similar changes for other BSPs for 1.3 release.
Thanks,
Nitin
The following changes since commit 62aa4ca25a943c864838b2910c5b506cca0c9323:
fri2: Add grub-efi workaround for USB keyboard initialization (2012-10-24 13:16:00 -0700)
are available in the git repository at:
git://git.yoctoproject.org/meta-intel-contrib nitin/misc
http://git.yoctoproject.org/cgit.cgi/meta-intel-contrib/log/?h=nitin/misc
Nitin A Kamble (6):
MAINTAINERS: correct pathname
chiefriver: add WEBTITLE & Compliance information
crownbay: add WEBTITLE & Compliance information
emenlow: add WEBTITLE & Compliance information
jasperforest: add WEBTITLE & Compliance information
sugarbay: add WEBTITLE & Compliance information
MAINTAINERS | 2 +- meta-chiefriver/README | 8 +++++++- meta-chiefriver/conf/machine/chiefriver.conf | 2 ++ meta-crownbay/README | 10 ++++++++-- meta-crownbay/conf/machine/crownbay-noemgd.conf | 2 ++ meta-crownbay/conf/machine/crownbay.conf | 2 ++ meta-emenlow/README | 8 +++++++- meta-emenlow/conf/machine/emenlow.conf | 2 ++ meta-jasperforest/README | 8 +++++++- meta-jasperforest/conf/machine/jasperforest.conf | 2 ++ meta-sugarbay/README | 8 +++++++- meta-sugarbay/conf/machine/sugarbay.conf | 2 ++ 12 files changed, 49 insertions(+), 7 deletions(-)
Signature · 1 line
1.7.3.4