Skip to contentSkip to conversation

remove unused functions

PATCH In review Blue Swirl 2 participants 6 messages Oct 28, 2012 – Oct 30, 2012

lore
Share & tools
lore

Blue Swirl

author
#0 lore raw

cover remove unused functions

Remove some unused functions.

Blue Swirl (3):
m48t59: remove unused m48t59_set_addr
sun4c: remove unused functions
slirp: remove unused function u_sleep

 hw/m48t59.c       |    7 -------
 hw/nvram.h        |    1 -
 hw/sun4c_intctl.c |   23 -----------------------
 hw/sun4m.h        |    4 ----
 slirp/misc.c      |   14 --------------
 slirp/misc.h      |    1 -
 6 files changed, 0 insertions(+), 50 deletions(-)
Signature · 1 line
1.7.2.5
author
#1 lore raw

PATCH 1/3 m48t59: remove unused m48t59_set_addr

Signed-off-by Blue Swirl <[email protected]>
---
 hw/m48t59.c |    7 -------
 hw/nvram.h  |    1 -
 2 files changed, 0 insertions(+), 8 deletions(-)
hw/m48t59.c +0 -7
index 9eb1a09..058d6e7 100644
@@ -466,13 +466,6 @@ uint32_t m48t59_read (void *opaque, uint32_t addr)
     return retval;
 }
 
-void m48t59_set_addr (void *opaque, uint32_t addr)
-{
-    M48t59State *NVRAM = opaque;
-
-    NVRAM->addr = addr;
-}
-
 void m48t59_toggle_lock (void *opaque, int lock)
 {
     M48t59State *NVRAM = opaque;
hw/nvram.h +0 -1
index 72363ce..59337fa 100644
@@ -30,6 +30,5 @@ M48t59State *m48t59_init_isa(ISABus *bus, uint32_t io_base, uint16_t size,
                              int type);
 M48t59State *m48t59_init(qemu_irq IRQ, hwaddr mem_base,
                          uint32_t io_base, uint16_t size, int type);
-void m48t59_set_addr (void *opaque, uint32_t addr);
 
 #endif /* !NVRAM_H */
Signature · 1 line
1.7.2.5
author
#2 lore raw

PATCH 2/3 sun4c: remove unused functions

In reply to Blue Swirl
Signed-off-by Blue Swirl <[email protected]>
---
 hw/sun4c_intctl.c |   23 -----------------------
 hw/sun4m.h        |    4 ----
 2 files changed, 0 insertions(+), 27 deletions(-)
hw/sun4c_intctl.c +0 -23
index 8cd70ab..702e9f5 100644
@@ -94,29 +94,6 @@ static const MemoryRegionOps sun4c_intctl_mem_ops = {
     },
 };
 
-void sun4c_pic_info(Monitor *mon, void *opaque)
-{
-    Sun4c_INTCTLState *s = opaque;
-
-    monitor_printf(mon, "master: pending 0x%2.2x, enabled 0x%2.2x\n",
-                   s->pending, s->reg);
-}
-
-void sun4c_irq_info(Monitor *mon, void *opaque)
-{
-#ifndef DEBUG_IRQ_COUNT
-    monitor_printf(mon, "irq statistic code not compiled.\n");
-#else
-    Sun4c_INTCTLState *s = opaque;
-    int64_t count;
-
-    monitor_printf(mon, "IRQ statistics:\n");
-    count = s->irq_count;
-    if (count > 0)
-        monitor_printf(mon, " %" PRId64 "\n", count);
-#endif
-}
-
 static const uint32_t intbit_to_level[] = { 0, 1, 4, 6, 8, 10, 0, 14, };
 
 static void sun4c_check_interrupts(void *opaque)
hw/sun4m.h +0 -4
index a8c3133..47eb945 100644
@@ -26,10 +26,6 @@ static inline void sparc_iommu_memory_write(void *opaque,
 void slavio_pic_info(Monitor *mon, DeviceState *dev);
 void slavio_irq_info(Monitor *mon, DeviceState *dev);
 
-/* sun4c_intctl.c */
-void sun4c_pic_info(Monitor *mon, void *opaque);
-void sun4c_irq_info(Monitor *mon, void *opaque);
-
 /* sun4m.c */
 void sun4m_pic_info(Monitor *mon);
 void sun4m_irq_info(Monitor *mon);
Signature · 1 line
1.7.2.5
author
#3 lore raw

PATCH 3/3 slirp: remove unused function u_sleep

In reply to Blue Swirl
Signed-off-by Blue Swirl <[email protected]>
---
 slirp/misc.c |   14 --------------
 slirp/misc.h |    1 -
 2 files changed, 0 insertions(+), 15 deletions(-)
slirp/misc.c +0 -14
index 0bee864..664532a 100644
@@ -253,20 +253,6 @@ void lprint(const char *format, ...)
     va_end(args);
 }
 
-void
-u_sleep(int usec)
-{
-	struct timeval t;
-	fd_set fdset;
-
-	FD_ZERO(&fdset);
-
-	t.tv_sec = 0;
-	t.tv_usec = usec * 1000;
-
-	select(0, &fdset, &fdset, &fdset, &t);
-}
-
 void slirp_connection_info(Slirp *slirp, Monitor *mon)
 {
     const char * const tcpstates[] = {
slirp/misc.h +0 -1
index ed40a10..cc36aeb 100644
@@ -64,7 +64,6 @@ void snooze_hup(int);
 void snooze(void);
 void relay(int);
 void add_emu(char *);
-void u_sleep(int);
 void fd_nonblock(int);
 void fd_block(int);
 int rsh_exec(struct socket *, struct socket *, char *, char *, char *);
Signature · 1 line
1.7.2.5
#4 lore raw

Re: [Qemu-devel] [PATCH 3/3] slirp: remove unused function u_sleep

Quoted 37 lines · Blue Swirl
Signed-off-by Blue Swirl <[email protected]>
---
 slirp/misc.c |   14 --------------
 slirp/misc.h |    1 -
 2 files changed, 0 insertions(+), 15 deletions(-)
slirp/misc.c +0 -14
index 0bee864..664532a 100644
@@ -253,20 +253,6 @@ void lprint(const char *format, ...)
     va_end(args);
 }
 
-void
-u_sleep(int usec)
-{
-	struct timeval t;
-	fd_set fdset;
-
-	FD_ZERO(&fdset);
-
-	t.tv_sec = 0;
-	t.tv_usec = usec * 1000;
-
-	select(0, &fdset, &fdset, &fdset, &t);
-}
-
 void slirp_connection_info(Slirp *slirp, Monitor *mon)
 {
     const char * const tcpstates[] = {
slirp/misc.h +0 -0
index ed40a10..cc36aeb 100644

slirp/misc.h void snooze_hup(int); · line 69

Quoted 7 lines
slirp/misc.h +0 -1
@@ -64,7 +64,6 @@ void snooze_hup(int);
 void snooze(void);
 void relay(int);
 void add_emu(char *);
-void u_sleep(int);
 void fd_nonblock(int);
 void fd_block(int);
 int rsh_exec(struct socket *, struct socket *, char *, char *, char *);

It's obviously fine. But wasn't it already merged or accepted for trivial? Of course, I can take it otherwise.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
author
#5 lore raw

Re: [Qemu-devel] [PATCH 3/3] slirp: remove unused function u_sleep

Quoted 40 lines · Jan Kiszka
Quoted 39 lines · Blue Swirl
Signed-off-by Blue Swirl <[email protected]>
---
 slirp/misc.c |   14 --------------
 slirp/misc.h |    1 -
 2 files changed, 0 insertions(+), 15 deletions(-)
slirp/misc.c +0 -14
index 0bee864..664532a 100644
@@ -253,20 +253,6 @@ void lprint(const char *format, ...)
     va_end(args);
 }
 
-void
-u_sleep(int usec)
-{
-     struct timeval t;
-     fd_set fdset;
-
-     FD_ZERO(&fdset);
-
-     t.tv_sec = 0;
-     t.tv_usec = usec * 1000;
-
-     select(0, &fdset, &fdset, &fdset, &t);
-}
-
 void slirp_connection_info(Slirp *slirp, Monitor *mon)
 {
     const char * const tcpstates[] = {
slirp/misc.h +0 -0
index ed40a10..cc36aeb 100644
@@ -64,7 +64,6 @@ void snooze_hup(int);
 void snooze(void);
 void relay(int);
 void add_emu(char *);
Quoted 8 lines

slirp/misc.h void snooze_hup(int); · line 69

Quoted 5 lines
slirp/misc.h +0 -1
-void u_sleep(int);
 void fd_nonblock(int);
 void fd_block(int);
 int rsh_exec(struct socket *, struct socket *, char *, char *, char *);

It's obviously fine. But wasn't it already merged or accepted for trivial? Of course, I can take it otherwise.

I split the function removals from the rest of the series because of API considerations, these are not entirely trivial.

Quoted 6 lines

Jan

--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux