eglibc: always compile with optimization.
cover eglibc: always compile with optimization.
From: Jackie Huang <[email protected]>
The following changes since commit 5e4714a454f9f742bf8af70dad2aa66ccb87e3fd:
lib/oe/classextend: Ensure we don't extend expressions more than once (2012-11-06 09:29:03 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib jhuang0/d_eglibc_1112_1
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/d_eglibc_1112_1
Jackie Huang (1):
eglibc: always compile with optimization.
meta/recipes-core/eglibc/eglibc_2.16.bb | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4
PATCH 1/1 eglibc: always compile with optimization.
From: Jackie Huang <[email protected]>
eglibc fails to compile if someone tries to compile an entire image as -O0:
error "glibc cannot be compiled without optimization"
so in this case, force to use -O2 and give a note about it.
[YOCTO #3405]
--- meta/recipes-core/eglibc/eglibc_2.16.bb | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
meta/recipes-core/eglibc/eglibc_2.16.bb +11 -0
@@ -87,6 +87,17 @@ EXTRA_OECONF = "--enable-kernel=${OLDEST_KERNEL} \ EXTRA_OECONF += "${@get_libc_fpu_setting(bb, d)}" +# eglibc can't be built without optimization, if someone tries to compile an +# entire image as -O0, we override it with -O2 here and give a note about it. +def get_optimization(d): + if base_contains("SELECTED_OPTIMIZATION", "-O0", "x", "", d) == "x": + bb.note("eglibc can't be built with -O0, -O2 will be used instead.") + selected_optimization = d.getVar("SELECTED_OPTIMIZATION", True) + return selected_optimization.replace("-O0", "-O2") + return selected_optimization + +SELECTED_OPTIMIZATION := "${@get_optimization(d)}" + do_unpack_append() { bb.build.exec_func('do_move_ports', d) }
Signature · 1 line
1.7.4
meta/recipes-core/eglibc/eglibc_2.16.bb EXTRA_OECONF = "--enable-kernel=${OLDEST_KERNEL} \ · line 97
Quoted 8 lines · On Mon, 2012-11-12 at 11:31 +0800, [email protected] wrote:
meta/recipes-core/eglibc/eglibc_2.16.bb +8
-0+# eglibc can't be built without optimization, if someone tries to compile an +# entire image as -O0, we override it with -O2 here and give a note about it. +def get_optimization(d): + if base_contains("SELECTED_OPTIMIZATION", "-O0", "x", "", d) == "x": + bb.note("eglibc can't be built with -O0, -O2 will be used instead.") + selected_optimization = d.getVar("SELECTED_OPTIMIZATION", True) + return selected_optimization.replace("-O0", "-O2") + return selected_optimization
Did you test this patch at all?
p.
Quoted 11 lines · Phil Blundell
meta/recipes-core/eglibc/eglibc_2.16.bb EXTRA_OECONF = "--enable-kernel=${OLDEST_KERNEL} \ · line 97
Quoted 8 lines · On Mon, 2012-11-12 at 11:31 +0800, [email protected] wrote:
meta/recipes-core/eglibc/eglibc_2.16.bb +8
-0+# eglibc can't be built without optimization, if someone tries to compile an +# entire image as -O0, we override it with -O2 here and give a note about it. +def get_optimization(d): + if base_contains("SELECTED_OPTIMIZATION", "-O0", "x", "", d) == "x": + bb.note("eglibc can't be built with -O0, -O2 will be used instead.") + selected_optimization = d.getVar("SELECTED_OPTIMIZATION", True) + return selected_optimization.replace("-O0", "-O2") + return selected_optimizationDid you test this patch at all?
I did test only in the cases that caused the defect but now I realized that it's not well tested and it doesn't work in other cases, sorry about that, I will re-work on it.
Thanks,
Jackie
Quoted 6 lines
p.
Signature · 5 lines
Jackie Huang WIND RIVER | China Development Center MSN:[email protected] Tel: +86 8477 8594 Mobile: +86 138 1027 4745