dropbear: allow configuring blank password option at runtime
cover dropbear: allow configuring blank password option at runtime
The following change since commit 4b63e73422ea25aba1bde0beddb02bc04948e13c:
update-rc.d: check also that symlinks are valid (2013-01-16 12:07:55 +0000)
is available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/ssh-nopw
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/ssh-nopw
Paul Eggleton (1):
dropbear: allow configuring blank password option at runtime
meta/classes/core-image.bbclass | 5 +- meta/classes/image.bbclass | 8 +- meta/recipes-core/dropbear/dropbear.inc | 6 +- .../dropbear/dropbear/allow-nopw.patch | 19 ---- .../dropbear/dropbear/nopw-option.patch | 106 ++++++++++++++++++++ 5 files changed, 116 insertions(+), 28 deletions(-) delete mode 100644 meta/recipes-core/dropbear/dropbear/allow-nopw.patch create mode 100644 meta/recipes-core/dropbear/dropbear/nopw-option.patch
Signature · 1 line
1.7.10.4
PATCH 1/1 dropbear: allow configuring blank password option at runtime
Instead of using IMAGE_FEATURES to control something within a recipe, allow this to be set at runtime and set it during postprocessing. Additionally, use one postprocessing function for both openssh and dropbear and run it regardless of whether ssh-server-* are in IMAGE_FEATURES so that it still takes effect if these are installed by adding dropbear/openssh to IMAGE_INSTALL.
Fixes [YOCTO #2578].
--- meta/classes/core-image.bbclass | 5 +- meta/classes/image.bbclass | 8 +- meta/recipes-core/dropbear/dropbear.inc | 6 +- .../dropbear/dropbear/allow-nopw.patch | 19 ---- .../dropbear/dropbear/nopw-option.patch | 106 ++++++++++++++++++++ 5 files changed, 116 insertions(+), 28 deletions(-) delete mode 100644 meta/recipes-core/dropbear/dropbear/allow-nopw.patch create mode 100644 meta/recipes-core/dropbear/dropbear/nopw-option.patch
meta/classes/core-image.bbclass +2 -3
@@ -76,6 +76,5 @@ ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; " # Zap the root password if debug-tweaks feature is not enabled ROOTFS_POSTPROCESS_COMMAND += '${@base_contains("IMAGE_FEATURES", "debug-tweaks", "", "zap_root_password ; ",d)}' -# Allow openssh accept empty password login if both debug-tweaks and ssh-server-openssh are enabled -ROOTFS_POSTPROCESS_COMMAND += '${@base_contains("IMAGE_FEATURES", "debug-tweaks ssh-server-openssh", "openssh_allow_empty_password; ", "",d)}' - +# Allow dropbear/openssh to accept logins from accounts with an empty password string if debug-tweaks is enabled +ROOTFS_POSTPROCESS_COMMAND += '${@base_contains("IMAGE_FEATURES", "debug-tweaks", "ssh_allow_empty_password; ", "",d)}'
meta/classes/image.bbclass +6 -2
@@ -396,12 +396,16 @@ zap_root_password () { mv ${IMAGE_ROOTFS}/etc/passwd.new ${IMAGE_ROOTFS}/etc/passwd } -# allow openssh accept login with empty password string -openssh_allow_empty_password () { +# allow dropbear/openssh to accept root logins and logins from accounts with an empty password string +ssh_allow_empty_password () { if [ -e ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config ]; then sed -i 's#.*PermitRootLogin.*#PermitRootLogin yes#' ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config sed -i 's#.*PermitEmptyPasswords.*#PermitEmptyPasswords yes#' ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config fi + + if [ -e ${IMAGE_ROOTFS}${sbindir}/dropbear ] ; then + echo 'DROPBEAR_EXTRA_ARGS="-B"' > ${IMAGE_ROOTFS}${sysconfdir}/default/dropbear + fi } # Turn any symbolic /sbin/init link into a file
meta/recipes-core/dropbear/dropbear.inc +2 -4
@@ -2,7 +2,7 @@ DESCRIPTION = "Dropbear is a lightweight SSH and SCP implementation" HOMEPAGE = "http://matt.ucc.asn.au/dropbear/dropbear.html" SECTION = "console/network" -INC_PR = "r0" +INC_PR = "r1" # some files are from other projects and have others license terms: # public domain, OpenSSH 3.5p1, OpenSSH3.6.1p2, PuTTY
@@ -18,7 +18,7 @@ SRC_URI = "http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.gz \ file://dropbear-0.53.1-static_build_fix.patch \ file://configure.patch \ file://fix-2kb-keys.patch \ - ${@base_contains("DISTRO_TYPE", "debug", "file://allow-nopw.patch", "",d)} \ + file://nopw-option.patch \ file://init \ ${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', '', d)} "
@@ -40,8 +40,6 @@ EXTRA_OEMAKE = 'MULTI=1 SCPPROGRESS=1 PROGRAMS="${SBINCOMMANDS} ${BINCOMMANDS}"' EXTRA_OECONF += "\ ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam', '--disable-pam', d)}" -DISTRO_TYPE ?= "${@base_contains("IMAGE_FEATURES", "debug-tweaks", "debug", "",d)}" - do_install() { install -d ${D}${sysconfdir} \ ${D}${sysconfdir}/init.d \
meta/recipes-core/dropbear/dropbear/allow-nopw.patch deleted +0 -19
@@ -1,19 +0,0 @@ -Enable blank password login function for new release dropbear. - -Upstream-Status: Inappropriate [configuration] - -Signed-off-by: Mei Lei <[email protected]> - -diff --git a/options.h b/options.h -index 73689ad..041ddaa 100644 ---- a/options.h -+++ b/options.h -@@ -180,7 +180,7 @@ much traffic. */ - * Public key logins are allowed for blank-password accounts regardless of this - * setting. PAM is not affected by this setting, it uses the normal pam.d - * settings ('nullok' option) */ --/* #define ALLOW_BLANK_PASSWORD */ -+#define ALLOW_BLANK_PASSWORD - - #define ENABLE_CLI_PASSWORD_AUTH - #define ENABLE_CLI_PUBKEY_AUTH
meta/recipes-core/dropbear/dropbear/nopw-option.patch new file +106 -0
106 lines not on this page · raw message
Signature · 1 line
1.7.10.4
Quoted 9 lines · On Wednesday 16 January 2013 14:54:17 Paul Eggleton wrote:
Instead of using
IMAGE_FEATURESto control something within a recipe, allow this to be set at runtime and set it during postprocessing. Additionally, use one postprocessing function for both openssh and dropbear and run it regardless of whether ssh-server-* are inIMAGE_FEATURESso that it still takes effect if these are installed by adding dropbear/openssh toIMAGE_INSTALL.Fixes [YOCTO #2578].
Quoted 7 lines
Signed-off-by Paul Eggleton <[email protected]>--- meta/classes/core-image.bbclass | 5 +- meta/classes/image.bbclass | 8 +- meta/recipes-core/dropbear/dropbear.inc | 6 +- .../dropbear/dropbear/allow-nopw.patch | 19 ---- .../dropbear/dropbear/nopw-option.patch | 106
Upon further consideration, this is not going to work for anyone inheriting from image.bbclass rather than core-image.bbclass, which is quite a lot of people. I'll send a v2.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre