Skip to contentSkip to conversation

rootfs_rpm.bbclass: fix the unexpected postinst error

PATCH In review [email protected] 1 participant 3 messages Jan 22, 2013 – Jan 29, 2013

lore
Share & tools
lore
#0 lore raw

cover rootfs_rpm.bbclass: fix the unexpected postinst error

From: Chen Qi <[email protected]>

The following changes since commit 37e025f6f9c410005e0f1dee0767e38eaec01cbd:

bitbake: hob: Hob should display warnings generated during parsing (2013-01-21 19:05:31 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/postinst-error
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/postinst-error

Chen Qi (1):
rootfs_rpm.bbclass: fix the unexpected postinst error

 meta/classes/rootfs_rpm.bbclass |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 rootfs_rpm.bbclass: fix the unexpected postinst error

From: Chen Qi <[email protected]>

If the /etc/rpm-postinsts/ directory was empty, the following error would occur at system startup.

ERROR: postinst /etc/rpm-postinsts/* failed

This patch fixes this issue.

[YOCTO #3767]

---
 meta/classes/rootfs_rpm.bbclass |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/rootfs_rpm.bbclass +2 -1
index 7d789cc..accd7d9 100644
@@ -108,7 +108,8 @@ fakeroot rootfs_rpm_do_rootfs () {
 	i=\$i
 	cat > ${IMAGE_ROOTFS}${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts << EOF
 #!/bin/sh
-for i in /etc/rpm-postinsts/*; do
+for i in `ls /etc/rpm-postinsts/`; do
+	i=/etc/rpm-postinsts/$i
 	echo "Running postinst $i..."
 	if [ -f $i ] && $i; then
 		rm $i
Signature · 1 line
1.7.9.5
author
#2 lore raw

Really really sorry that this patch introduces a bug :(
(It built and booted correctly, so I thought everything's OK. I didn't check the do_rootfs log.) A follow-up patch has been sent.
Sorry for the inconvenience.

Chen Qi

Quoted 30 lines · On 01/22/2013 04:44 PM, [email protected] wrote:

From: Chen Qi <[email protected]>

If the /etc/rpm-postinsts/ directory was empty, the following error would occur at system startup.

ERROR: postinst /etc/rpm-postinsts/* failed

This patch fixes this issue.

[YOCTO #3767]

---
  meta/classes/rootfs_rpm.bbclass |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/rootfs_rpm.bbclass +2 -1
index 7d789cc..accd7d9 100644
@@ -108,7 +108,8 @@ fakeroot rootfs_rpm_do_rootfs () {
  	i=\$i
  	cat > ${IMAGE_ROOTFS}${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts << EOF
  #!/bin/sh
-for i in /etc/rpm-postinsts/*; do
+for i in `ls /etc/rpm-postinsts/`; do
+	i=/etc/rpm-postinsts/$i
  	echo "Running postinst $i..."
  	if [ -f $i ] && $i; then
  		rm $i