Skip to contentSkip to conversation

installed but unpackaged... foul lies and calumnies

PATCH New Peter Seebach 1 participant 2 messages Jan 25, 2013

lore
Share & tools
lore
#0 lore raw

cover installed but unpackaged... foul lies and calumnies

If a FILES_* variable has an unqualified path in it, this can result in a file being sucessfully packaged, and yet, still showing up as installed-but-unpackaged. Note: I had weird build problems with my oe-core tree, but I tested this in a nearby poky tree and it worked there, anyway.

The following changes since commit 2e2a91025ca9c113365c810ce08b48201fe792b8:
Khem Raj (1):
systemd: Fix build on ppc

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib seebs/unpackaged
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/unpackaged

Peter Seebach (1):
package.bbclass: Consistency between packaging and unpackaged check

 meta/classes/package.bbclass |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
#1 lore raw

PATCH 1/1 package.bbclass: Consistency between packaging and unpackaged check

A path name in FILES_package which has no leading slash can work for the packaging code, causing the file to get installed correctly as part of a package; however, the check for installed but unpackaged files checks against the "./" path, resulting in a spurious diagnostic. Solution: We're already prepending a period to every absolute path. If a path has gotten past that, and doesn't start with "./", it's presumably a relative path, and adding "./" to it will make it match.

The test case is to create a file in the root directory, and include the file's name with no leading slash in a FILES_*. Without this, the file should actually get packaged, but generate an installed-but-unpackaged warning anyway.

---
 meta/classes/package.bbclass |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
meta/classes/package.bbclass +2 -0
index 8e07168..ee18488 100644
@@ -980,6 +980,8 @@ python populate_packages () {
                 file.replace("//", "/")
             if os.path.isabs(file):
                 file = '.' + file
+            if not file.startswith("./")
+                file = './' + file
             if not os.path.islink(file):
                 if os.path.isdir(file):
                     newfiles =  [ os.path.join(file,x) for x in os.listdir(file) ]
Signature · 1 line
1.7.0.4