Skip to contentSkip to conversation

pseudo 1.4.4

PATCH New Peter Seebach 1 participant 2 messages Feb 12, 2013

lore
Share & tools
lore
#0 lore raw

cover pseudo 1.4.4

So, about two days AFTER pseudo 1.4.3 goes in, I finally hit the fairly obvious bug in the link/linkat() changes. Summary: In general, if parameter names end in 'path' pseudo tries to do automatic path fixups for them. This doesn't work well for the *at() functions, because they can need magic done with their corresponding file descriptors. So linkat() doesn't take already-converted names.

link(), however, was using fully-expanded names. And when I converted it to just call linkat(), it preserved this behavior. The obvious failure is that in a chroot() environment, link() would prepend the chroot path twice; once in link(), and once in linkat() which it called.

Fixed in pseudo 1.4.4, retested against the test case. Due to the slightly-too-magical way pseudo works, the only actual changes are to the names of the parameters of link().

The following changes since commit c58e6cf352774e147038e6543ac95ab0060f2327:
Anders Roxell (1):
distro_check: Remove creation of empty Meego filelist.

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib seebs/pseudo144
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/pseudo144

Peter Seebach (1):
pseudo_git.bb: Bump to pseudo 1.4.4.

 .../pseudo/{pseudo_1.4.3.bb => pseudo_1.4.4.bb}    |    4 ++--
 meta/recipes-devtools/pseudo/pseudo_git.bb         |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
 rename meta/recipes-devtools/pseudo/{pseudo_1.4.3.bb => pseudo_1.4.4.bb} (43%)
#1 lore raw

PATCH 1/1 pseudo_git.bb: Bump to pseudo 1.4.4.

The pseudo 1.4.2 linkat() implementation had a broken edge case in which you could end up with chroot paths being doubled when using plain link() calls instead of linkat() calls.

---
 .../pseudo/{pseudo_1.4.3.bb => pseudo_1.4.4.bb}    |    4 ++--
 meta/recipes-devtools/pseudo/pseudo_git.bb         |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
 rename meta/recipes-devtools/pseudo/{pseudo_1.4.3.bb => pseudo_1.4.4.bb} (43%)
meta/recipes-devtools/pseudo/pseudo_1.4.4.bb renamed from meta/recipes-devtools/pseudo/pseudo_1.4.3.bb +2 -2
similarity index 43%
rename from meta/recipes-devtools/pseudo/pseudo_1.4.3.bb
rename to meta/recipes-devtools/pseudo/pseudo_1.4.4.bb
index 8f25bd0..dea607c 100644
@@ -4,5 +4,5 @@ PR = "r0"
 
 SRC_URI = "http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2"
 
-SRC_URI[md5sum] = "ac943153aa78e210e2d0db7c85845db3"
-SRC_URI[sha256sum] = "0ca12a319c0ee87d1c8b2a4310c36a6d68d8d4b8c9c7dba00bace1773baf18e8"
+SRC_URI[md5sum] = "ae18a1388c032ac910adbf8c3111fdc4"
+SRC_URI[sha256sum] = "e72cb188fd8efb9eadfb5ce571a45a99245ae312eb9830cb9a9726bb25e47c17"
meta/recipes-devtools/pseudo/pseudo_git.bb +2 -2
index bbdba43..efffc95 100644
@@ -1,7 +1,7 @@
 require pseudo.inc
 
-SRCREV = "a01d7884e5f3acba1460cf6b500d28390e7af9f8"
-PV = "1.4.3+git${SRCPV}"
+SRCREV = "363a94bb851046f62648d7c96c749e899bd0648e"
+PV = "1.4.4+git${SRCPV}"
 PR = "r0"
 
 DEFAULT_PREFERENCE = "-1"
Signature · 1 line
1.7.0.4