Skip to contentSkip to conversation

update to autotools

PATCH New Yann Droneaud 1 participant 3 messages May 20, 2013 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

cover update to autotools

As part of update to configure.ac, please find two quite simple patches.

It should be applied to bring the build system a bit up to date regarding autotools.

It works on Debian 6.0 (Squeeze) and Fedora 17 (Beefy Miracle), but you might want to test on older systems ... I'm looking at you Red Hat Enterprise Linux ... But ultimately it depends on the release manager's host environment which is probably up to date :)

Yann Droneaud (2):
configure: apply updates proposed by autoupdate
configure: use automake's option "subdir-objects"

 configure.ac | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)
Signature · 6 lines
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): cover.1369089206.git.ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org

#2 lore raw

PATCH 1/2 configure: apply updates proposed by autoupdate

'autoupdate' is a tool to help developer to update configure.ac.

This patch apply a few fixes as suggested by autoupdate.

It was tested on Debian 6.0.7 (Squeeze) and Fedora 17 (Beefy Miracle).

---
 configure.ac | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)
configure.ac +8 -9
index 8f79891..a1d5365 100644
@@ -1,7 +1,7 @@
 dnl Process this file with autoconf to produce a configure script.
 
-AC_PREREQ(2.57)
-AC_INIT(libibverbs, 1.1.6, [email protected])
+AC_PREREQ([2.67])
+AC_INIT([libibverbs],[1.1.6],[[email protected]])
 AC_CONFIG_SRCDIR([src/ibverbs.h])
 AC_CONFIG_AUX_DIR(config)
 AC_CONFIG_MACRO_DIR(config)
@@ -11,14 +11,12 @@ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
 dnl Checks for programs
 AC_PROG_CC
-AC_GNU_SOURCE
+AC_USE_SYSTEM_EXTENSIONS
 AC_PROG_LN_S
-AC_PROG_LIBTOOL
-
 LT_INIT
 
 AC_ARG_WITH([valgrind],
-    AC_HELP_STRING([--with-valgrind],
+    AS_HELP_STRING([--with-valgrind],
         [Enable Valgrind annotations (small runtime overhead, default NO)]))
 if test x$with_valgrind = x || test x$with_valgrind = xno; then
     want_valgrind=no
@@ -84,9 +82,10 @@ fi
 AC_SUBST(LIBIBVERBS_VERSION_SCRIPT)
 
 AC_CACHE_CHECK(for .symver assembler support, ac_cv_asm_symver_support,
-    [AC_TRY_COMPILE(, [asm("symbol:\n.symver symbol, api@ABI\n");],
-        ac_cv_asm_symver_support=yes,
-        ac_cv_asm_symver_support=no)])
+    [AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]],
+        [[asm("symbol:\n.symver symbol, api@ABI\n");]])],
+        [ac_cv_asm_symver_support=yes],
+        [ac_cv_asm_symver_support=no])])
 if test $ac_cv_asm_symver_support = yes; then
     AC_DEFINE([HAVE_SYMVER_SUPPORT], 1, [assembler has .symver support])
 fi
Signature · 6 lines
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

PATCH 2/2 configure: use automake's option "subdir-objects"

In reply to a message not in the archive

Following advice in "Autotool Mythbuster" [1], option subdir-objects can be used to have Makefiles create object files in the same directory than theirs source files.

It reduces clobbering in the build directory.

[1] "Autotool Mythbuster", by Diego Elio "Flameeyes" Petten`o
http://www.flameeyes.eu/autotools-mythbuster/automake/nonrecursive.html

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
index a1d5365..231083c 100644
@@ -6,7 +6,7 @@ AC_CONFIG_SRCDIR([src/ibverbs.h])
 AC_CONFIG_AUX_DIR(config)
 AC_CONFIG_MACRO_DIR(config)
 AC_CONFIG_HEADER(config.h)
-AM_INIT_AUTOMAKE([foreign])
+AM_INIT_AUTOMAKE([foreign subdir-objects])
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
 dnl Checks for programs
Signature · 6 lines
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html