Skip to contentSkip to conversation

RFC: Add recipe of gtk3 version of vte alongside gtk2 one.

PATCH In review Marko Lindqvist 3 participants 5 messages May 26, 2013 – May 29, 2013

lore
Share & tools
lore
#0 lore raw

cover RFC: Add recipe of gtk3 version of vte alongside gtk2 one.

RFC only! Patch is only build-tested.

Last gtk2-compatible version of vte is 0.28.2 currently present on OE core.
Later versions depend on gtk3. Since gtk3 exist in OE core, it would make
sense to be able to build version of vte (and other similar packages)
that does not depend on gtk2. Otherwise we end with systems that must
contain both gtk2 (to be used by some programs) and gtk3 (to be used by
other programs).
This patch just adds new recipe for latest vte version, 0.34.5, alongside
with 0.28.2 version.
How should priorities be set? "1" for gtk2-version, so it gets selected despite gtk3-version being newer?

- ML

The following changes since commit 8f5bc47729edb8cb051d81e9ff1680cb8d2eca25:

dropbear: a fix for hang in dropbearkey, built for x32 (2013-05-24 14:14:30 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib cazfi/rfc
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=cazfi/rfc

Marko Lindqvist (1):
vte: add 0.34.5 recipe

 .../vte/vte-0.34.5/obsolete_automake_macros.patch        |   14 ++++++++++++++
 meta/recipes-support/vte/vte.inc                         |    4 +++-
 meta/recipes-support/vte/vte_0.28.2.bb                   |    6 ++++--
 meta/recipes-support/vte/vte_0.34.5.bb                   |   12 ++++++++++++
 4 files changed, 33 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-support/vte/vte-0.34.5/obsolete_automake_macros.patch
 create mode 100644 meta/recipes-support/vte/vte_0.34.5.bb
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 vte: add 0.34.5 recipe

Add latest vte version for gtk3-based systems. Keep 0.28.2 as it's last gtk2-compatible version.

---
 .../vte/vte-0.34.5/obsolete_automake_macros.patch        |   14 ++++++++++++++
 meta/recipes-support/vte/vte.inc                         |    4 +++-
 meta/recipes-support/vte/vte_0.28.2.bb                   |    6 ++++--
 meta/recipes-support/vte/vte_0.34.5.bb                   |   12 ++++++++++++
 4 files changed, 33 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-support/vte/vte-0.34.5/obsolete_automake_macros.patch
 create mode 100644 meta/recipes-support/vte/vte_0.34.5.bb
meta/recipes-support/vte/vte-0.34.5/obsolete_automake_macros.patch new file +14 -0
new file mode 100644
index 0000000..6763d37
@@ -0,0 +1,14 @@
+Upstream-Status: Submitted [https://bugzilla.gnome.org/show_bug.cgi?id=691545]
+
+Signed-off-by: Marko Lindqvist <[email protected]>
+diff -Nurd vte-0.28.2/gnome-pty-helper/configure.in vte-0.28.2/gnome-pty-helper/configure.in
+--- vte-0.28.2/gnome-pty-helper/configure.in	2010-07-15 20:08:44.000000000 +0300
++++ vte-0.28.2/gnome-pty-helper/configure.in	2013-01-11 14:50:34.971027440 +0200
+@@ -8,7 +8,6 @@
+ AC_ISC_POSIX
+ AC_PROG_CC
+ AC_STDC_HEADERS
+-AM_PROG_CC_STDC
+
+ if test -z "$enable_maintainer_mode"; then
+   enable_maintainer_mode=yes
meta/recipes-support/vte/vte.inc +3 -1
index b653fab..bc9736a 100644
@@ -1,9 +1,11 @@
 DESCRIPTION = "vte is a virtual terminal emulator"
 BUGTRACKER = "https://bugzilla.gnome.org/buglist.cgi?product=vte"
 LICENSE = "LGPLv2.1+"
-DEPENDS = " glib-2.0 gtk+ intltool-native ncurses gobject-introspection-stub"
+DEPENDS = " glib-2.0 intltool-native ncurses gobject-introspection-stub"
 RDEPENDS_libvte = "vte-termcap"
 
+GNOME_COMPRESS_TYPE = "xz"
+
 inherit gnome gtk-doc
 
 EXTRA_OECONF = "--disable-python --disable-introspection"
meta/recipes-support/vte/vte_0.28.2.bb +4 -2
index 485187d..caf7515 100644
@@ -6,5 +6,7 @@ PR = "r6"
 
 SRC_URI += "file://obsolete_automake_macros.patch"
 
-SRC_URI[archive.md5sum] = "f07a4bf943194f94b7f142db8f7f36dc"
-SRC_URI[archive.sha256sum] = "8d04e202b617373dfb47689e5e628febe2c58840b34cccc4af4feb88c48df903"
+SRC_URI[archive.md5sum] = "497f26e457308649e6ece32b3bb142ff"
+SRC_URI[archive.sha256sum] = "86cf0b81aa023fa93ed415653d51c96767f20b2d7334c893caba71e42654b0ae"
+
+DEPENDS += "gtk+"
meta/recipes-support/vte/vte_0.34.5.bb new file +12 -0
new file mode 100644
index 0000000..8707213
@@ -0,0 +1,12 @@
+require vte.inc
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7"
+
+PR = "r0"
+
+SRC_URI += "file://obsolete_automake_macros.patch"
+
+SRC_URI[archive.md5sum] = "ce1f11568992df8e61c9366918fed571"
+SRC_URI[archive.sha256sum] = "8847fb75b620a94ba62c2ffd9e1653396978106f294574ba24a19ced259a7351"
+
+DEPENDS += "gtk+3"
Signature · 1 line
1.7.10.4
#2 lore raw
In reply to Marko Lindqvist
Quoted 2 lines · Marko Lindqvist

Last gtk2-compatible version of vte is 0.28.2 currently present on OE core. Later versions depend on gtk3.

vte supports both gtk2 and gtk3.

Quoted 8 lines

Since gtk3 exist in OE core, it would make
sense to be able to build version of vte (and other similar packages)
that does not depend on gtk2. Otherwise we end with systems that must
contain both gtk2 (to be used by some programs) and gtk3 (to be used by
other programs).
This patch just adds new recipe for latest vte version, 0.34.5, alongside
with 0.28.2 version.
How should priorities be set? "1" for gtk2-version, so it gets selected despite gtk3-version being newer?

Because they are *not* drop-in replacements, how about naming the gtk3 vte vte3_3.34.5.bb?

Ross

#3 lore raw
Quoted 7 lines · Ross
Quoted 1 line · Marko Lindqvist

Last gtk2-compatible version of vte is 0.28.2 currently present on OE

core.

Quoted 1 line

Later versions depend on gtk3.

vte supports both gtk2 and gtk3.

0.30.0 NEWS states that "dropped support for gtk2". While this sounds like
upstream 0.28.2 would work with either gtk2 or gtk3, OE recipe depends on "gtk+", which is always gtk2?

Quoted 8 lines
Quoted 8 lines

Since gtk3 exist in OE core, it would make
sense to be able to build version of vte (and other similar packages) that does not depend on gtk2. Otherwise we end with systems that must contain both gtk2 (to be used by some programs) and gtk3 (to be used by other programs).
This patch just adds new recipe for latest vte version, 0.34.5, alongside with 0.28.2 version.
How should priorities be set? "1" for gtk2-version, so it gets selected

Quoted 5 lines

despite gtk3-version being newer?

Because they are *not* drop-in replacements, how about naming the gtk3 vte vte3_3.34.5.bb?

I think calling it vte3 would be confusing at best, when vte itself is not
version 3.x. How about "vte-gtk3"?

- ML

#4 lore raw
Quoted 24 lines · Marko Lindqvist
Quoted 7 lines · Ross
Quoted 1 line · Marko Lindqvist

Last gtk2-compatible version of vte is 0.28.2 currently present on OE

core.

Quoted 1 line

Later versions depend on gtk3.

vte supports both gtk2 and gtk3.

0.30.0 NEWS states that "dropped support for gtk2". While this sounds
like upstream 0.28.2 would work with either gtk2 or gtk3, OE recipe depends on "gtk+", which is always gtk2?

Quoted 9 lines
Quoted 6 lines

Since gtk3 exist in OE core, it would make
sense to be able to build version of vte (and other similar packages) that does not depend on gtk2. Otherwise we end with systems that must contain both gtk2 (to be used by some programs) and gtk3 (to be used by other programs).
This patch just adds new recipe for latest vte version, 0.34.5,

alongside

Quoted 2 lines

with 0.28.2 version.
How should priorities be set? "1" for gtk2-version, so it gets selected

Quoted 9 lines
Quoted 5 lines

despite gtk3-version being newer?

Because they are *not* drop-in replacements, how about naming the gtk3 vte vte3_3.34.5.bb?

I think calling it vte3 would be confusing at best, when vte itself is
not version 3.x. How about "vte-gtk3"?

So I would say to rename vte to vte-gtk2 at same time and make it provide vte for now.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750