Skip to contentSkip to conversation

kernel.bbclass: Fix link for modules-${MACHINE}.tgz

PATCH In review Yi Zhao 2 participants 3 messages Jun 5, 2013

lore
Share & tools
lore

Yi Zhao

author
#0 lore raw

cover kernel.bbclass: Fix link for modules-${MACHINE}.tgz

When build an image, It will generate a symbolic link file named modules-${MACHINE}.tgz in tmp/deploy/images directory. This file should link to the real modules tarball. But now it links to an invalid file which has an extra ".bin" suffix. This patch fixs this issue.

The following changes since commit a62aed41f2d8f874f7ae24d0e5be5dbc66ea2199:

lrzsz: check locale.h in configure (2013-06-04 15:55:46 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib yizhao/bug4595
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=yizhao/bug4595

Yi Zhao (1):
kernel.bbclass: Fix link for modules-${MACHINE}.tgz

 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 kernel.bbclass: Fix link for modules-${MACHINE}.tgz

The modules-${MACHINE}.tgz should link to ${MODULE_TARBALL_BASE_NAME}. But now it links to an invalid file ${MODULE_TARBALL_BASE_NAME}.bin. Remove the extra .bin suffix.

[YOCTO #4595]

Signed-off-by Yi Zhao <[email protected]>
---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -1
index 6550615..40a6b5b 100644
@@ -375,7 +375,7 @@ kernel_do_deploy() {
 	if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
 		mkdir -p ${D}/lib
 		tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib
-		ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
+		ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
 	fi
 
 	ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#2 lore raw
Quoted 5 lines · Yi Zhao

The modules-${MACHINE}.tgz should link to ${MODULE_TARBALL_BASE_NAME}. But now it links to an invalid file ${MODULE_TARBALL_BASE_NAME}.bin. Remove the extra .bin suffix.

[YOCTO #4595]

Looks good, thanks for fixing it.

Acked-by Martin Jansa <[email protected]>
Quoted 26 lines
Signed-off-by Yi Zhao <[email protected]>
---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -1
index 6550615..40a6b5b 100644
@@ -375,7 +375,7 @@ kernel_do_deploy() {
 	if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
 		mkdir -p ${D}/lib
 		tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib
-		ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
+		ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
 	fi
 
 	ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin
Signature · 6 lines
1.7.9.5

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]