Skip to contentSkip to conversation

yocto bsp tools bugfixes

PATCH New Tom Zanussi 1 participant 3 messages Jul 3, 2013

lore
Share & tools
lore
#0 lore raw

cover yocto bsp tools bugfixes

This patchset fixes a couple bugs in the yocto bsp tools.

The first one [yocto-bsp: filter out 'layer' from arch list] is just an unchanged repost of the patch that was posted a couple weeks ago and never got picked up. It needs to go into both master and the next 1.4 point release. The second one should go into master.

The following changes since commit 8a186a6b3853fc1a7dcf342d421c8926c38949c9:

bitbake: hob: save button from settings called a nonexisting method (2013-07-03 08:13:35 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib.git tzanussi/bug-4735-repost-and-bug-4743
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/bug-4735-repost-and-bug-4743

Tom Zanussi (2):
yocto-bsp: filter out 'layer' from arch list
yocto-kernel: enforce exact match for BBLAYERS

 scripts/lib/bsp/engine.py | 2 +-
 scripts/lib/bsp/kernel.py | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.11.4
#1 lore raw

PATCH 1/2 yocto-bsp: filter out 'layer' from arch list

The yocto-layer tool added a new directory alongside the actual architectures and 'common', which is already screened out as not an actual architecture when displaying the architecures.

The same needs to be done for 'layer' which isn't actually an architecuture and likewise needs to be screened out.

Fixes [YOCTO #4735].

---
 scripts/lib/bsp/engine.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lib/bsp/engine.py +1 -1
index 36bd446..681720d 100644
@@ -1674,7 +1674,7 @@ def yocto_bsp_list(args, scripts_path, properties_file):
         arch_path = bsp_path + '/substrate/target/arch'
         print "Architectures available:"
         for arch in os.listdir(arch_path):
-            if arch == "common":
+            if arch == "common" or arch == "layer":
                 continue
             print "    %s" % arch
         return True
Signature · 1 line
1.7.11.4
#2 lore raw

PATCH 2/2 yocto-kernel: enforce exact match for BBLAYERS

The current code uses .startswith to find BBLAYERS, which causes false positives when other variables such as BBLAYERS_NON_REMOVABLE exist.

This forces an exact match instead of a partial match.

Fixes [YOCTO #4743].

---
 scripts/lib/bsp/kernel.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/lib/bsp/kernel.py +2 -1
index 94ae950..c3592a3 100644
@@ -54,7 +54,8 @@ def find_bblayers(scripts_path):
     in_bblayers = False
     for line in lines:
         line = line.strip()
-        if line.strip().startswith("BBLAYERS"):
+        tokens = line.split()
+        if len(tokens) > 0 and tokens[0] == 'BBLAYERS':
             bblayers_lines.append(line)
             in_bblayers = True
             quotes = line.strip().count('"')
Signature · 1 line
1.7.11.4