Skip to contentSkip to conversation

acl: fix the acl self contained test cases issue

PATCH In review [email protected] 2 participants 3 messages Jul 15, 2013 – Jul 16, 2013

lore
Share & tools
lore
#0 lore raw

cover acl: fix the acl self contained test cases issue

From: Jackie Huang <[email protected]>

We added the acl self contained test cases in our testing layer and found failures, this patch fixed the test scripts that cause the issues.

--
The following changes since commit 4f5009dcbbeb27bdf5dcaebb3b457fecef410ebe:

security_flags: Add addition recipes to the non pie list (2013-07-10 09:40:42 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib jhuang0/d_acl_0715_2
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/d_acl_0715_2

Jackie Huang (1):
acl: fix the acl self contained test cases issue

 meta/recipes-support/attr/acl.inc                  |    4 +-
 .../attr/files/fix-acl-test-cases.patch            |  210 ++++++++++++++++++++
 2 files changed, 213 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-support/attr/files/fix-acl-test-cases.patch
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 acl: fix the acl self contained test cases issue

From: Jackie Huang <[email protected]>

misc.test: fix the order of expected output of getfacl root/permissions.test: this test requires that the daemon user is in groups bin and daemon, so add it into bin group before testing start.

---
 meta/recipes-support/attr/acl.inc                  |    4 +-
 .../attr/files/fix-acl-test-cases.patch            |  210 ++++++++++++++++++++
 2 files changed, 213 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-support/attr/files/fix-acl-test-cases.patch
meta/recipes-support/attr/acl.inc +3 -1
index b504517..6b6ecbf 100644
@@ -9,7 +9,9 @@ LIC_FILES_CHKSUM = "file://doc/COPYING;md5=c781d70ed2b4d48995b790403217a249 \
                     file://doc/COPYING.LGPL;md5=9e9a206917f8af112da634ce3ab41764"
 
 DEPENDS = "attr"
-SRC_URI = "http://download.savannah.gnu.org/releases/acl/${BP}.src.tar.gz"
+SRC_URI = "http://download.savannah.gnu.org/releases/acl/${BP}.src.tar.gz \
+           file://fix-acl-test-cases.patch \
+"
 
 require ea-acl.inc
 
meta/recipes-support/attr/files/fix-acl-test-cases.patch new file +210 -0

210 lines not on this page · raw message

Signature · 1 line
1.7.4.1
#2 lore raw
Quoted 1 line · On 15 July 2013 11:01, <[email protected]> wrote:

+Upstream-Status: Pending

If we're patching the test case because it's wrong then we need to be contacting upstream to get this merged or rejected, there's no point patching the test case to make it work when actually it's a subtle problem in how we're running it.

Ross