Skip to contentSkip to conversation

Improve bb-matrix graphs

PATCH In review Peter Kjellerstedt 2 participants 5 messages Sep 10, 2013 – Sep 11, 2013

lore
Share & tools
lore
#0 lore raw

cover Improve bb-matrix graphs

This improves the look of bb-matrix graphs with sparse data, i.e., where not all combinations of BB_NUMBER_THREADS and PARALLEL_MAKE have been tested.

This adds an implicit dependency on gnuplot v4.4 or later, but since this only is a script in the contrib section I hope that is acceptable.

//Peter

The following changes since commit 0ca5d1fb38157564a2b9452ade32391d18a41b09:

yocto-bsp: remove apm as a default MACHINE_FEATURE (2013-09-09 16:28:47 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib pkj/bb-matrix-plot
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/bb-matrix-plot

Peter Kjellerstedt (1):
bb-matrix-plot: Use interpolation for sparse data

 scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 bb-matrix-plot: Use interpolation for sparse data

If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16" and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by default looks very jagged due to the missing data points. By using splines to interpolate the missing data the graph looks a lot better.

This should not change graphs where all data points are available in any way, only improve sparse graphs.

---
 scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/contrib/bb-perf/bb-matrix-plot.sh +1 -1
index 87e8cb1..136a255 100755
@@ -115,7 +115,7 @@ set xlabel "$XLABEL"
 set ylabel "$YLABEL"
 set style line 100 lt 5 lw 1.5
 $PM3D_FRAGMENT
-set dgrid3d $PM_CNT,$BB_CNT
+set dgrid3d $PM_CNT,$BB_CNT splines
 set ticslevel 0.2
 
 set term png size $SIZE
Signature · 1 line
1.8.2.1
#2 lore raw

Re: [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data

Quoted 19 lines · Peter Kjellerstedt

If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16" and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by default looks very jagged due to the missing data points. By using splines to interpolate the missing data the graph looks a lot better.

This should not change graphs where all data points are available in any way, only improve sparse graphs.

---
 scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/contrib/bb-perf/bb-matrix-plot.sh +0 -0
index 87e8cb1..136a255 100755

scripts/contrib/bb-perf/bb-matrix-plot.sh set xlabel "$XLABEL" · line 118

Quoted 5 lines
scripts/contrib/bb-perf/bb-matrix-plot.sh +1 -1
@@ -115,7 +115,7 @@ set xlabel "$XLABEL"
 set ylabel "$YLABEL"
 set style line 100 lt 5 lw 1.5
 $PM3D_FRAGMENT
-set dgrid3d $PM_CNT,$BB_CNT
+set dgrid3d $PM_CNT,$BB_CNT splines

Saweet! I just couldn't figure that one out for some reason. Thank you, thank you, thank you!

Please note the gnuplot 4.4 dependency in the patch commit message though. Also, what happens if an older gnuplot is used? Does it fail or revert to the old behavior? If it fails, can we check for 4.4 and use splines if available?

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#3 lore raw

Re: [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data

Quoted 38 lines

-----Original Message-----
From: Darren Hart [mailto:[email protected]]
Sent: den 10 september 2013 17:38
To: Peter Kjellerstedt
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data

Quoted 19 lines · Peter Kjellerstedt

If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16" and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by default looks very jagged due to the missing data points. By using splines to interpolate the missing data the graph looks a lot better.

This should not change graphs where all data points are available in any way, only improve sparse graphs.

---
 scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/contrib/bb-perf/bb-matrix-plot.sh +0 -0
index 87e8cb1..136a255 100755

scripts/contrib/bb-perf/bb-matrix-plot.sh set xlabel "$XLABEL" · line 118

Quoted 5 lines
scripts/contrib/bb-perf/bb-matrix-plot.sh +1 -1
@@ -115,7 +115,7 @@ set xlabel "$XLABEL"
 set ylabel "$YLABEL"
 set style line 100 lt 5 lw 1.5
 $PM3D_FRAGMENT
-set dgrid3d $PM_CNT,$BB_CNT
+set dgrid3d $PM_CNT,$BB_CNT splines

Saweet! I just couldn't figure that one out for some reason. Thank you, thank you, thank you!

Quoted 4 lines

Please note the gnuplot 4.4 dependency in the patch commit message though. Also, what happens if an older gnuplot is used? Does it fail or revert to the old behavior? If it fails, can we check for 4.4 and use splines if available?

I actually tried it now using gnuplot 4.2.2, and the script already uses a couple of features that require gnuplot 4.4. The script can be fixed to support gnuplot 4.2 (by adding a test for the gnuplot version and then modifying the input to gnuplot accordingly), but since nobody has complained so far, I would suggest just leaving it as is...

Quoted 4 lines

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

//Peter

Acked-by
#4 lore raw

Re: [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data

Quoted 43 lines · Peter Kjellerstedt
Quoted 38 lines

-----Original Message-----
From: Darren Hart [mailto:[email protected]]
Sent: den 10 september 2013 17:38
To: Peter Kjellerstedt
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data

Quoted 19 lines · Peter Kjellerstedt

If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16" and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by default looks very jagged due to the missing data points. By using splines to interpolate the missing data the graph looks a lot better.

This should not change graphs where all data points are available in any way, only improve sparse graphs.

---
 scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/contrib/bb-perf/bb-matrix-plot.sh +0 -0
index 87e8cb1..136a255 100755

scripts/contrib/bb-perf/bb-matrix-plot.sh set xlabel "$XLABEL" · line 118

Quoted 5 lines
scripts/contrib/bb-perf/bb-matrix-plot.sh +1 -1
@@ -115,7 +115,7 @@ set xlabel "$XLABEL"
 set ylabel "$YLABEL"
 set style line 100 lt 5 lw 1.5
 $PM3D_FRAGMENT
-set dgrid3d $PM_CNT,$BB_CNT
+set dgrid3d $PM_CNT,$BB_CNT splines

Saweet! I just couldn't figure that one out for some reason. Thank you, thank you, thank you!

Quoted 4 lines

Please note the gnuplot 4.4 dependency in the patch commit message though. Also, what happens if an older gnuplot is used? Does it fail or revert to the old behavior? If it fails, can we check for 4.4 and use splines if available?

Quoted 6 lines

I actually tried it now using gnuplot 4.2.2, and the script already uses a couple of features that require gnuplot 4.4. The script can be fixed to support gnuplot 4.2 (by adding a test for the gnuplot version and then modifying the input to gnuplot accordingly), but since nobody has complained so far, I would suggest just leaving it as is...

Agreed. Thank you Peter.

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel