Write-reliability settings support
cover Write-reliability settings support
This series builds on top ofd91d3698c6464a83b7c301eb84da109f9f94b54c
It introduces
* an extracted function for setting the PARTITION_SETTING_COMPLETE bit
* a command for setting the write-reliability bits
* pretty-printing the write-reliability bits from EXTCSD registers
available also https://github.com/BenGardiner/mmc-utils/tree/features/reliable-write
if it helps.
Ben Gardiner (3):
extract PARTITION_SETTING_COMPLETE function pretty print write reliability settings support setting the OTP write reliability settings
mmc.c | 5 +++ mmc.h | 1 + mmc_cmds.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------- mmc_cmds.h | 1 + 4 files changed, 129 insertions(+), 21 deletions(-)
Signature · 1 line
1.8.1.2
PATCH 1/3 extract PARTITION_SETTING_COMPLETE function
Extract a function which sets the OTP PARTITION_SETTING_COMPLETE bit; once this bit is set there are many other parameters in EXT_CSD which can no longer be set.
Multiple OTP partition settings can be achieved by calling 'set' commands with '-n' on all except for the last.
--- mmc_cmds.c | 77 ++++++++++++++++++++++++++++++++++++++------------------------ 1 file changed, 47 insertions(+), 30 deletions(-)
mmc_cmds.c +47 -30
@@ -449,6 +449,51 @@ unsigned int get_hc_erase_grp_size(__u8 *ext_csd)return ext_csd[224 ]; } +int set_partitioning_setting_completed (int dry_run,const char *const device, +int fd) +{ +int ret; + +if (dry_run) { +fprintf (stderr,"NOT setting PARTITION_SETTING_COMPLETED\n" ); +fprintf (stderr,"These changes will not take effect neither " +"now nor after a power cycle\n" ); +return 1 ; + } + +fprintf (stderr,"setting OTP PARTITION_SETTING_COMPLETED!\n" ); + ret =write_extcsd_value (fd,EXT_CSD_PARTITION_SETTING_COMPLETED ,0x1 ); +if (ret) { +fprintf (stderr,"Could not write 0x1 to " +"EXT_CSD[%d] in %s\n" , +EXT_CSD_PARTITION_SETTING_COMPLETED , device); +return 1 ; + } + +__u32 response; + ret =send_status (fd, &response); +if (ret) { +fprintf (stderr,"Could not get response to SEND_STATUS " +"from %s\n" , device); +return 1 ; + } + +if (response &R1_SWITCH_ERROR ) { +fprintf (stderr,"Setting OTP PARTITION_SETTING_COMPLETED " +"failed on %s\n" , device); +return 1 ; + } + +fprintf (stderr,"Setting OTP PARTITION_SETTING_COMPLETED on " +"%s SUCCESS\n" , device); +fprintf (stderr,"Device power cycle needed for settings to " +"take effect.\n" +"Confirm that PARTITION_SETTING_COMPLETED bit is set " +"using 'extcsd read' after power cycle\n" ); + +return 0 ; +} +int do_enh_area_set (int nargs,char **argv) {__u8 value;
@@ -579,38 +624,10 @@ int do_enh_area_set(int nargs, char **argv)exit (1 ); } -if (dry_run) - { -fprintf (stderr,"NOT setting PARTITION_SETTING_COMPLETED\n" ); -exit (1 ); - } +printf ("Done setting ENH_USR area on %s\n" , device); -fprintf (stderr,"setting OTP PARTITION_SETTING_COMPLETED!\n" ); - ret =write_extcsd_value (fd,EXT_CSD_PARTITION_SETTING_COMPLETED ,0x1 ); -if (ret) { -fprintf (stderr,"Could not write 0x1 to " -"EXT_CSD[%d] in %s\n" , -EXT_CSD_PARTITION_SETTING_COMPLETED , device); +if (!set_partitioning_setting_completed (dry_run, device, fd))exit (1 ); - } - -__u32 response; - ret =send_status (fd, &response); -if (ret) { -fprintf (stderr,"Could not get response to SEND_STATUS from %s\n" , device); -exit (1 ); - } - -if (response &R1_SWITCH_ERROR ) - { -fprintf (stderr,"Setting ENH_USR area failed on %s\n" , device); -exit (1 ); - } - -fprintf (stderr,"Setting ENH_USR area on %s SUCCESS\n" , device); -fprintf (stderr,"Device power cycle needed for settings to take effect.\n" -"Confirm that PARTITION_SETTING_COMPLETED bit is set using 'extcsd read'" -"after power cycle\n" );return 0 ; }
Signature · 1 line
1.8.1.2
Re: [PATCH 1/3] extract PARTITION_SETTING_COMPLETE function
Quoted 11 lines · Ben Gardiner <ben.l.gardiner <at> gmail.com> writes:
Extract a function which sets the OTP
PARTITION_SETTING_COMPLETEbit; once this bit is set there are many other parameters inEXT_CSDwhich can no longer be set.Multiple OTP partition settings can be achieved by calling 'set' commands with '-n' on all except for the last.
Signed-off-by Ben Gardiner <ben.l.gardiner <at> gmail.com>--- mmc_cmds.c | 77 ++++++++++++++++++++++++++++++++++++++---------------
---------
mmc_cmds.c
Quoted 7 lines
1 file changed, 47 insertions(+), 30 deletions(-)mmc_cmds.c +0
-0<at> <at> -449,6 +449,51 <at> <at> unsigned int
get_hc_erase_grp_size(__u8 *ext_csd)
mmc_cmds.c
Quoted 4 lines
mmc_cmds.c +1
-0return ext_csd[224 ]; } +int set_partitioning_setting_completed(int dry_run, const char *
const device,
mmc_cmds.c
Quoted 6 lines
mmc_cmds.c +6
-0+ int fd) +{ +int ret; + +if (dry_run) { + fprintf(stderr, "NOT setting
PARTITION_SETTING_COMPLETED\n");
mmc_cmds.c
Quoted 1 line
mmc_cmds.c +1
-0+ fprintf(stderr, "These changes will not take effect
neither "
mmc_cmds.c
Quoted 6 lines
mmc_cmds.c +6
-0+ "now nor after a power cycle\n"); +return 1 ; + } + +fprintf (stderr,"setting OTP PARTITION_SETTING_COMPLETED!\n" ); + ret = write_extcsd_value(fd,
EXT_CSD_PARTITION_SETTING_COMPLETED, 0x1);
Quoted 7 lines
mmc_cmds.c +7
-0+if (ret) { +fprintf (stderr,"Could not write 0x1 to " +"EXT_CSD[%d] in %s\n" , +EXT_CSD_PARTITION_SETTING_COMPLETED , device); +return 1 ; + } +
mmc_cmds.c
Quoted 10 lines
mmc_cmds.c +10
-0+__u32 response; + ret =send_status (fd, &response); +if (ret) { +fprintf (stderr,"Could not get response to SEND_STATUS " +"from %s\n" , device); +return 1 ; + } + +if (response &R1_SWITCH_ERROR ) { + fprintf(stderr, "Setting OTP PARTITION_SETTING_COMPLETED
"
Quoted 8 lines
mmc_cmds.c +8
-0+ "failed on %s\n", device); +return 1 ; + } + +fprintf (stderr,"Setting OTP PARTITION_SETTING_COMPLETED on " +"%s SUCCESS\n" , device); +fprintf (stderr,"Device power cycle needed for settings to " + "take effect.\n"
mmc_cmds.c
Quoted 10 lines
mmc_cmds.c +6
-0+"Confirm that PARTITION_SETTING_COMPLETED bit is set " + "using 'extcsd read' after power cycle\n"); + +return 0 ; +} +int do_enh_area_set (int nargs,char **argv) {__u8 value; <at> <at> -579,38 +624,10 <at> <at> int do_enh_area_set(int
nargs, char **argv)
mmc_cmds.c
Quoted 6 lines
mmc_cmds.c +0
-3exit (1 ); } -if (dry_run) - { - fprintf(stderr, "NOT setting
PARTITION_SETTING_COMPLETED\n");
mmc_cmds.c
Quoted 6 lines
mmc_cmds.c +1
-4-exit (1 ); - } +printf ("Done setting ENH_USR area on %s\n" , device); -fprintf (stderr,"setting OTP PARTITION_SETTING_COMPLETED!\n" ); - ret = write_extcsd_value(fd,
EXT_CSD_PARTITION_SETTING_COMPLETED, 0x1);
mmc_cmds.c
Quoted 12 lines
mmc_cmds.c +1
-10-if (ret) { -fprintf (stderr,"Could not write 0x1 to " -"EXT_CSD[%d] in %s\n" , -EXT_CSD_PARTITION_SETTING_COMPLETED , device); +if (!set_partitioning_setting_completed (dry_run, device, fd))exit (1 ); - } - -__u32 response; - ret =send_status (fd, &response); -if (ret) { - fprintf(stderr, "Could not get response to SEND_STATUS
from %s\n", device);
mmc_cmds.c
Quoted 6 lines
mmc_cmds.c +0
-6-exit (1 ); - } - -if (response &R1_SWITCH_ERROR ) - { - fprintf(stderr, "Setting ENH_USR area failed on %s\n",
device);
mmc_cmds.c
Quoted 5 lines
mmc_cmds.c +0
-5-exit (1 ); - } - -fprintf (stderr,"Setting ENH_USR area on %s SUCCESS\n" , device); - fprintf(stderr, "Device power cycle needed for settings to take
effect.\n"
mmc_cmds.c
Quoted 1 line
mmc_cmds.c +0
-1- "Confirm that PARTITION_SETTING_COMPLETED bit is set
using 'extcsd read'"
mmc_cmds.c
Quoted 4 lines
mmc_cmds.c +0
-1- "after power cycle\n");return 0 ; }
The program return code looks wrong with this patch. If I do mmc write_reliability set -n 0 /dev/mmcblk0; echo $? mmc write_reliability set -y 0 /dev/mmcblk0; echo $?
the first instance returns a 0, the second a 1.
The following change fixes this by changing set_partitioning_setting completed() to only return one on an error and removing the inversions in the if tests.
mmc_cmds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mmc_cmds.c +0 -0
@@ -462,7 +462,7 @@ int set_partitioning_setting_completed(int dry_run,
const char * const device,
fprintf(stderr, "NOT setting
PARTITION_SETTING_COMPLETED\n");
fprintf(stderr, "These changes will not take effect
neither "
"now nor after a power cycle\n");
- return 1;
+ return 0;
}
fprintf(stderr, "setting OTP PARTITION_SETTING_COMPLETED!\n");@@ -630,7 +630,7 @@ int do_enh_area_set(int nargs, char **argv)
printf("Done setting ENH_USR area on %s\n", device);- if (!set_partitioning_setting_completed(dry_run, device, fd))
+ if (set_partitioning_setting_completed(dry_run, device, fd))
exit(1);
return 0;
@@ -692,7 +692,7 @@ int do_write_reliability_set(int nargs, char **argv)
printf("Done setting EXT_CSD_WR_REL_SET to 0x%02x on %s\n",
value, device);- if (!set_partitioning_setting_completed(dry_run, device, fd))
+ if (set_partitioning_setting_completed(dry_run, device, fd))
exit(1);
return 0;Signature · 1 line
1.7.9.5
PATCH 2/3 pretty print write reliability settings
In reply to Ben Gardiner--- mmc.h | 1 + mmc_cmds.c | 26 ++++++++++++++++++++++++-- 2 files changed, 25 insertions(+), 2 deletions(-)
mmc.h +1 -0
@@ -46,6 +46,7 @@#define EXT_CSD_PART_CONFIG 179#define EXT_CSD_ERASE_GROUP_DEF 175#define EXT_CSD_BOOT_WP 173 +#define EXT_CSD_WR_REL_SET 167#define EXT_CSD_WR_REL_PARAM 166#define EXT_CSD_SANITIZE_START 165#define EXT_CSD_BKOPS_EN 163/* R/W */
mmc_cmds.c +24 -2
@@ -917,10 +917,32 @@ int do_read_extcsd(int nargs, char **argv)/* A441]: reserved [170] */ printf ("FW configuration [FW_CONFIG]: 0x%02x\n" , ext_csd[169 ]);printf ("RPMB Size [RPMB_SIZE_MULT]: 0x%02x\n" , ext_csd[168 ]); + + reg = ext_csd[EXT_CSD_WR_REL_SET ]; +const char *const fast ="existing data is at risk if a power " +"failure occurs during a write operation" ; +const char *const reliable ="the device protects existing " +"data if a power failure occurs during a write " +"operation" ;printf ("Write reliability setting register" -" [WR_REL_SET]: 0x%02x\n" , ext_csd[167 ]); +" [WR_REL_SET]: 0x%02x\n" , reg); + +printf (" user area: %s\n" , reg & (1 <<0 ) ? reliable : fast); +int i; +for (i =1 ; i <=4 ; i++) { +printf (" partition %d: %s\n" , i, + reg & (1 <<i) ? reliable : fast); + } + + reg = ext_csd[EXT_CSD_WR_REL_PARAM ];printf ("Write reliability parameter register" -" [WR_REL_PARAM]: 0x%02x\n" , ext_csd[166 ]); +" [WR_REL_PARAM]: 0x%02x\n" , reg); +if (reg &0x01 ) +printf (" Device supports writing EXT_CSD_WR_REL_SET\n" ); +if (reg &0x04 ) +printf (" Device supports the enhanced def. of reliable " +"write\n" ); +/* sanitize_start ext_csd[165]]: not readable * bkops_start ext_csd[164]]: only writable */ printf("Enable background operations handshake"
Signature · 1 line
1.8.1.2
PATCH 3/3 support setting the OTP write reliability settings
In reply to Ben Gardiner--- mmc.c | 5 +++++ mmc_cmds.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ mmc_cmds.h | 1 + 3 files changed, 68 insertions(+)
mmc.c +5 -0
@@ -75,6 +75,11 @@ static struct Command commands[] = {"Enable the enhanced user area for the <device>.\nDry-run only unless -y is passed.\nNOTE! This is a one-time programmable (unreversible) change." ,NULL }, + { do_write_reliability_set, -2, +"write_reliability set" ,"<-y|-n> " "<partition> " "<device>\n" +"Enable write reliability per partition for the <device>.\nDry-run only unless -y is passed.\nNOTE! This is a one-time programmable (unreversible) change." , +NULL + }, { do_status_get, -1,"status get" ,"<device>\n" "Print the response to STATUS_SEND (CMD13).",
mmc_cmds.c +62 -0
68 lines not on this page · raw message
mmc_cmds.h +1 -0
@@ -27,3 +27,4 @@ int do_hwreset_dis(int nargs, char **argv);int do_sanitize (int nargs,char **argv);int do_status_get (int nargs,char **argv);int do_enh_area_set (int nargs,char **argv); +int do_write_reliability_set (int nargs,char **argv);
Signature · 1 line
1.8.1.2
Hi Ben,
Quoted 16 lines · Ben Gardiner
This series builds on top of
d91d3698c6464a83b7c301eb84da109f9f94b54cIt introduces
* an extracted function for setting thePARTITION_SETTING_COMPLETEbit
* a command for setting the write-reliability bits
* pretty-printing the write-reliability bits from EXTCSD registersavailable also https://github.com/BenGardiner/mmc-utils/tree/features/reliable-write
if it helps.Ben Gardiner (3):
extractPARTITION_SETTING_COMPLETEfunction pretty print write reliability settings support setting the OTP write reliability settings
Quoted 5 lines
mmc.c | 5 +++ mmc.h | 1 + mmc_cmds.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------- mmc_cmds.h | 1 + 4 files changed, 129 insertions(+), 21 deletions(-)
I've pushed all three patches to mmc-utils now. Thanks!
- Chris.
Signature · 1 line
Chris Ball <[email protected]> <http://printf.net/>