drivers: net: Next block of Remove extern from function prototypes
Subsystems (9)
The following changes since commit b0983d3c9b132c33b6fb2e28d157a1edc18a173c:
tcp: fix dynamic right sizing (2013-09-24 11:07:32 -0400)
are available in the git repository at:
git://repo.or.cz/linux-2.6/trivial-mods.git 20130924_dn_externs_2
for you to fetch changes up to 294da3abaa73a0b69fd54e442b0b5bd9455b7be6:
irda: Remove extern from function prototypes (2013-09-24 12:54:17 -0700)
----------------------------------------------------------------
Joe Perches (10):
ibm/emac: Remove extern from function prototypes
intel: Remove extern from function prototypes
oki-semi: Remove extern from function prototypes
qlogic: Remove extern from function prototypes
sfc: Remove extern from function prototypes
stmicro: Remove extern from function prototypes
ti: Remove extern from function prototypes
toshiba: Remove extern from function prototypes fddi/skfp: Remove extern from function prototypes
irda: Remove extern from function prototypes
drivers/net/ethernet/ibm/emac/debug.h | 14 +- drivers/net/ethernet/ibm/emac/rgmii.h | 18 +- drivers/net/ethernet/ibm/emac/tah.h | 14 +- drivers/net/ethernet/ibm/emac/zmii.h | 18 +- drivers/net/ethernet/intel/e1000/e1000.h | 32 ++-- drivers/net/ethernet/intel/e1000e/e1000.h | 45 +++-- drivers/net/ethernet/intel/igb/e1000_82575.h | 16 +- drivers/net/ethernet/intel/igb/e1000_hw.h | 6 +- drivers/net/ethernet/intel/igb/e1000_i210.h | 38 ++-- drivers/net/ethernet/intel/igb/e1000_mac.h | 2 +- drivers/net/ethernet/intel/igb/igb.h | 73 ++++---- drivers/net/ethernet/intel/igbvf/igbvf.h | 22 +-- drivers/net/ethernet/intel/ixgb/ixgb.h | 22 +-- drivers/net/ethernet/intel/ixgb/ixgb_hw.h | 25 +-- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 172 +++++++++--------- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 34 ++-- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 56 +++--- drivers/net/ethernet/qlogic/netxen/netxen_nic.h | 5 +- drivers/net/ethernet/qlogic/qlge/qlge.h | 58 +++--- drivers/net/ethernet/sfc/efx.h | 104 ++++++----- drivers/net/ethernet/sfc/mcdi.h | 120 ++++++------- drivers/net/ethernet/sfc/mdio_10g.h | 26 ++- drivers/net/ethernet/sfc/nic.h | 210 +++++++++++----------- drivers/net/ethernet/sfc/phy.h | 8 +- drivers/net/ethernet/sfc/selftest.h | 15 +- drivers/net/ethernet/stmicro/stmmac/common.h | 12 +- drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h | 17 +- drivers/net/ethernet/stmicro/stmmac/mmc.h | 6 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 10 +- drivers/net/ethernet/ti/cpts.h | 9 +- drivers/net/ethernet/toshiba/ps3_gelic_net.h | 29 ++- drivers/net/ethernet/toshiba/ps3_gelic_wireless.h | 6 +- drivers/net/ethernet/toshiba/spider_net.h | 4 +- drivers/net/fddi/skfp/h/smc.h | 28 +-- drivers/net/irda/sir-dev.h | 29 +-- 35 files changed, 631 insertions(+), 672 deletions(-)
Signature · 14 lines
1.8.1.2.459.gbcd45b4.dirty ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
PATCH 1/10 ibm/emac: Remove extern from function prototypes
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/ibm/emac/debug.h | 14 +++++++------- drivers/net/ethernet/ibm/emac/rgmii.h | 18 +++++++++--------- drivers/net/ethernet/ibm/emac/tah.h | 14 +++++++------- drivers/net/ethernet/ibm/emac/zmii.h | 18 +++++++++--------- 4 files changed, 32 insertions(+), 32 deletions(-)
drivers/net/ethernet/ibm/emac/debug.h +7 -7
@@ -29,13 +29,13 @@struct emac_instance ;struct mal_instance ; -extern void emac_dbg_register (struct emac_instance *dev); -extern void emac_dbg_unregister (struct emac_instance *dev); -extern void mal_dbg_register (struct mal_instance *mal); -extern void mal_dbg_unregister (struct mal_instance *mal); -extern int emac_init_debug (void )__init ; -extern void emac_fini_debug(void) __exit; -extern void emac_dbg_dump_all (void ); +void emac_dbg_register (struct emac_instance *dev); +void emac_dbg_unregister (struct emac_instance *dev); +void mal_dbg_register (struct mal_instance *mal); +void mal_dbg_unregister (struct mal_instance *mal); +int emac_init_debug (void )__init ; +void emac_fini_debug(void) __exit; +void emac_dbg_dump_all (void );# define DBG_LEVEL 1
drivers/net/ethernet/ibm/emac/rgmii.h +9 -9
@@ -56,15 +56,15 @@ struct rgmii_instance {#ifdef CONFIG_IBM_EMAC_RGMII -extern int rgmii_init (void ); -extern void rgmii_exit (void ); -extern int rgmii_attach (struct platform_device *ofdev,int input,int mode); -extern void rgmii_detach (struct platform_device *ofdev,int input); -extern void rgmii_get_mdio (struct platform_device *ofdev,int input); -extern void rgmii_put_mdio (struct platform_device *ofdev,int input); -extern void rgmii_set_speed (struct platform_device *ofdev,int input,int speed); -extern int rgmii_get_regs_len (struct platform_device *ofdev); -extern void *rgmii_dump_regs (struct platform_device *ofdev,void *buf); +int rgmii_init (void ); +void rgmii_exit (void ); +int rgmii_attach (struct platform_device *ofdev,int input,int mode); +void rgmii_detach (struct platform_device *ofdev,int input); +void rgmii_get_mdio (struct platform_device *ofdev,int input); +void rgmii_put_mdio (struct platform_device *ofdev,int input); +void rgmii_set_speed (struct platform_device *ofdev,int input,int speed); +int rgmii_get_regs_len (struct platform_device *ofdev); +void *rgmii_dump_regs (struct platform_device *ofdev,void *buf);#else
drivers/net/ethernet/ibm/emac/tah.h +7 -7
@@ -72,13 +72,13 @@ struct tah_instance {#ifdef CONFIG_IBM_EMAC_TAH -extern int tah_init (void ); -extern void tah_exit (void ); -extern int tah_attach (struct platform_device *ofdev,int channel); -extern void tah_detach (struct platform_device *ofdev,int channel); -extern void tah_reset (struct platform_device *ofdev); -extern int tah_get_regs_len (struct platform_device *ofdev); -extern void *tah_dump_regs (struct platform_device *ofdev,void *buf); +int tah_init (void ); +void tah_exit (void ); +int tah_attach (struct platform_device *ofdev,int channel); +void tah_detach (struct platform_device *ofdev,int channel); +void tah_reset (struct platform_device *ofdev); +int tah_get_regs_len (struct platform_device *ofdev); +void *tah_dump_regs (struct platform_device *ofdev,void *buf);#else
drivers/net/ethernet/ibm/emac/zmii.h +9 -9
@@ -53,15 +53,15 @@ struct zmii_instance {#ifdef CONFIG_IBM_EMAC_ZMII -extern int zmii_init (void ); -extern void zmii_exit (void ); -extern int zmii_attach (struct platform_device *ofdev,int input,int *mode); -extern void zmii_detach (struct platform_device *ofdev,int input); -extern void zmii_get_mdio (struct platform_device *ofdev,int input); -extern void zmii_put_mdio (struct platform_device *ofdev,int input); -extern void zmii_set_speed (struct platform_device *ofdev,int input,int speed); -extern int zmii_get_regs_len (struct platform_device *ocpdev); -extern void *zmii_dump_regs (struct platform_device *ofdev,void *buf); +int zmii_init (void ); +void zmii_exit (void ); +int zmii_attach (struct platform_device *ofdev,int input,int *mode); +void zmii_detach (struct platform_device *ofdev,int input); +void zmii_get_mdio (struct platform_device *ofdev,int input); +void zmii_put_mdio (struct platform_device *ofdev,int input); +void zmii_set_speed (struct platform_device *ofdev,int input,int speed); +int zmii_get_regs_len (struct platform_device *ocpdev); +void *zmii_dump_regs (struct platform_device *ofdev,void *buf);#else # define zmii_init () 0
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
PATCH 2/10 intel: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/intel/e1000/e1000.h | 32 ++--- drivers/net/ethernet/intel/e1000e/e1000.h | 45 ++++--- drivers/net/ethernet/intel/igb/e1000_82575.h | 16 +-- drivers/net/ethernet/intel/igb/e1000_hw.h | 6 +- drivers/net/ethernet/intel/igb/e1000_i210.h | 38 +++--- drivers/net/ethernet/intel/igb/e1000_mac.h | 2 +- drivers/net/ethernet/intel/igb/igb.h | 73 ++++++------ drivers/net/ethernet/intel/igbvf/igbvf.h | 22 ++-- drivers/net/ethernet/intel/ixgb/ixgb.h | 22 ++-- drivers/net/ethernet/intel/ixgb/ixgb_hw.h | 25 ++-- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 172 +++++++++++++-------------- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 34 +++--- 12 files changed, 233 insertions(+), 254 deletions(-)
drivers/net/ethernet/intel/e1000/e1000.h +16 -16
@@ -325,7 +325,7 @@ enum e1000_state_t {#undef pr_fmt#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt -extern struct net_device *e1000_get_hw_dev (struct e1000_hw *hw); +struct net_device *e1000_get_hw_dev (struct e1000_hw *hw); #define e_dbg(format, arg...) \ netdev_dbg(e1000_get_hw_dev(hw), format, ## arg) #define e_err(msglvl, format, arg...) \
@@ -346,20 +346,20 @@ extern struct net_device *e1000_get_hw_dev(struct e1000_hw *hw);extern char e1000_driver_name[];extern const char e1000_driver_version[]; -extern int e1000_up (struct e1000_adapter *adapter); -extern void e1000_down (struct e1000_adapter *adapter); -extern void e1000_reinit_locked (struct e1000_adapter *adapter); -extern void e1000_reset (struct e1000_adapter *adapter); -extern int e1000_set_spd_dplx (struct e1000_adapter *adapter,u32 spd,u8 dplx); -extern int e1000_setup_all_rx_resources (struct e1000_adapter *adapter); -extern int e1000_setup_all_tx_resources (struct e1000_adapter *adapter); -extern void e1000_free_all_rx_resources (struct e1000_adapter *adapter); -extern void e1000_free_all_tx_resources (struct e1000_adapter *adapter); -extern void e1000_update_stats (struct e1000_adapter *adapter); -extern bool e1000_has_link (struct e1000_adapter *adapter); -extern void e1000_power_up_phy (struct e1000_adapter *); -extern void e1000_set_ethtool_ops (struct net_device *netdev); -extern void e1000_check_options (struct e1000_adapter *adapter); -extern char *e1000_get_hw_dev_name (struct e1000_hw *hw); +int e1000_up (struct e1000_adapter *adapter); +void e1000_down (struct e1000_adapter *adapter); +void e1000_reinit_locked (struct e1000_adapter *adapter); +void e1000_reset (struct e1000_adapter *adapter); +int e1000_set_spd_dplx (struct e1000_adapter *adapter,u32 spd,u8 dplx); +int e1000_setup_all_rx_resources (struct e1000_adapter *adapter); +int e1000_setup_all_tx_resources (struct e1000_adapter *adapter); +void e1000_free_all_rx_resources (struct e1000_adapter *adapter); +void e1000_free_all_tx_resources (struct e1000_adapter *adapter); +void e1000_update_stats (struct e1000_adapter *adapter); +bool e1000_has_link (struct e1000_adapter *adapter); +void e1000_power_up_phy (struct e1000_adapter *); +void e1000_set_ethtool_ops (struct net_device *netdev); +void e1000_check_options (struct e1000_adapter *adapter); +char *e1000_get_hw_dev_name (struct e1000_hw *hw);#endif /* _E1000_H_ */
drivers/net/ethernet/intel/e1000e/e1000.h +22 -23
63 lines not on this page · raw message
drivers/net/ethernet/intel/igb/e1000_82575.h +8 -8
@@ -28,14 +28,14 @@#ifndef _E1000_82575_H_#define _E1000_82575_H_ -extern void igb_shutdown_serdes_link_82575 (struct e1000_hw *hw); -extern void igb_power_up_serdes_link_82575 (struct e1000_hw *hw); -extern void igb_power_down_phy_copper_82575 (struct e1000_hw *hw); -extern void igb_rx_fifo_flush_82575 (struct e1000_hw *hw); -extern s32 igb_read_i2c_byte (struct e1000_hw *hw,u8 byte_offset, -u8 dev_addr,u8 *data); -extern s32 igb_write_i2c_byte (struct e1000_hw *hw,u8 byte_offset, -u8 dev_addr,u8 data); +void igb_shutdown_serdes_link_82575 (struct e1000_hw *hw); +void igb_power_up_serdes_link_82575 (struct e1000_hw *hw); +void igb_power_down_phy_copper_82575 (struct e1000_hw *hw); +void igb_rx_fifo_flush_82575 (struct e1000_hw *hw); +s32 igb_read_i2c_byte (struct e1000_hw *hw,u8 byte_offset,u8 dev_addr, +u8 *data); +s32 igb_write_i2c_byte (struct e1000_hw *hw,u8 byte_offset,u8 dev_addr, +u8 data);#define ID_LED_DEFAULT_82575_SERDES ((ID_LED_DEF1_DEF2 << 12) | \ (ID_LED_DEF1_DEF2 << 8) | \
drivers/net/ethernet/intel/igb/e1000_hw.h +3 -3
@@ -562,11 +562,11 @@ struct e1000_hw {u8 revision_id; }; -extern struct net_device *igb_get_hw_dev (struct e1000_hw *hw); +struct net_device *igb_get_hw_dev (struct e1000_hw *hw); #define hw_dbg(format, arg...) \ netdev_dbg(igb_get_hw_dev(hw), format, ##arg)/* These functions must be implemented by drivers */ -s32 igb_read_pcie_cap_reg (struct e1000_hw *hw,u32 reg,u16 *value); -s32 igb_write_pcie_cap_reg (struct e1000_hw *hw,u32 reg,u16 *value); +s32 igb_read_pcie_cap_reg (struct e1000_hw *hw,u32 reg,u16 *value); +s32 igb_write_pcie_cap_reg (struct e1000_hw *hw,u32 reg,u16 *value);#endif /* _E1000_HW_H_ */
drivers/net/ethernet/intel/igb/e1000_i210.h +18 -20
@@ -28,26 +28,24 @@#ifndef _E1000_I210_H_#define _E1000_I210_H_ -extern s32 igb_update_flash_i210 (struct e1000_hw *hw); -extern s32 igb_update_nvm_checksum_i210 (struct e1000_hw *hw); -extern s32 igb_validate_nvm_checksum_i210 (struct e1000_hw *hw); -extern s32 igb_write_nvm_srwr_i210 (struct e1000_hw *hw,u16 offset, -u16 words,u16 *data); -extern s32 igb_read_nvm_srrd_i210 (struct e1000_hw *hw,u16 offset, -u16 words,u16 *data); -extern s32 igb_acquire_swfw_sync_i210 (struct e1000_hw *hw,u16 mask); -extern void igb_release_swfw_sync_i210 (struct e1000_hw *hw,u16 mask); -extern s32 igb_acquire_nvm_i210 (struct e1000_hw *hw); -extern void igb_release_nvm_i210 (struct e1000_hw *hw); -extern s32 igb_valid_led_default_i210 (struct e1000_hw *hw,u16 *data); -extern s32 igb_read_invm_version (struct e1000_hw *hw, -struct e1000_fw_version *invm_ver); -extern s32 igb_read_xmdio_reg (struct e1000_hw *hw,u16 addr,u8 dev_addr, -u16 *data); -extern s32 igb_write_xmdio_reg (struct e1000_hw *hw,u16 addr,u8 dev_addr, -u16 data); -extern s32 igb_init_nvm_params_i210 (struct e1000_hw *hw); -extern bool igb_get_flash_presence_i210 (struct e1000_hw *hw); +s32 igb_update_flash_i210 (struct e1000_hw *hw); +s32 igb_update_nvm_checksum_i210 (struct e1000_hw *hw); +s32 igb_validate_nvm_checksum_i210 (struct e1000_hw *hw); +s32 igb_write_nvm_srwr_i210 (struct e1000_hw *hw,u16 offset,u16 words, +u16 *data); +s32 igb_read_nvm_srrd_i210 (struct e1000_hw *hw,u16 offset,u16 words, +u16 *data); +s32 igb_acquire_swfw_sync_i210 (struct e1000_hw *hw,u16 mask); +void igb_release_swfw_sync_i210 (struct e1000_hw *hw,u16 mask); +s32 igb_acquire_nvm_i210 (struct e1000_hw *hw); +void igb_release_nvm_i210 (struct e1000_hw *hw); +s32 igb_valid_led_default_i210 (struct e1000_hw *hw,u16 *data); +s32 igb_read_invm_version (struct e1000_hw *hw, +struct e1000_fw_version *invm_ver); +s32 igb_read_xmdio_reg (struct e1000_hw *hw,u16 addr,u8 dev_addr,u16 *data); +s32 igb_write_xmdio_reg (struct e1000_hw *hw,u16 addr,u8 dev_addr,u16 data); +s32 igb_init_nvm_params_i210 (struct e1000_hw *hw); +bool igb_get_flash_presence_i210 (struct e1000_hw *hw);#define E1000_STM_OPCODE 0xDB00#define E1000_EEPROM_FLASH_SIZE_WORD 0x11
drivers/net/ethernet/intel/igb/e1000_mac.h +1 -1
@@ -86,6 +86,6 @@ enum e1000_mng_mode {#define E1000_MNG_DHCP_COOKIE_STATUS_VLAN 0x2 -extern void e1000_init_function_pointers_82575 (struct e1000_hw *hw); +void e1000_init_function_pointers_82575 (struct e1000_hw *hw);#endif
drivers/net/ethernet/intel/igb/igb.h +35 -38
86 lines not on this page · raw message
drivers/net/ethernet/intel/igbvf/igbvf.h +11 -11
@@ -312,17 +312,17 @@ enum igbvf_state_t {extern char igbvf_driver_name[];extern const char igbvf_driver_version[]; -extern void igbvf_check_options (struct igbvf_adapter *); -extern void igbvf_set_ethtool_ops (struct net_device *); - -extern int igbvf_up (struct igbvf_adapter *); -extern void igbvf_down (struct igbvf_adapter *); -extern void igbvf_reinit_locked (struct igbvf_adapter *); -extern int igbvf_setup_rx_resources (struct igbvf_adapter *,struct igbvf_ring *); -extern int igbvf_setup_tx_resources (struct igbvf_adapter *,struct igbvf_ring *); -extern void igbvf_free_rx_resources (struct igbvf_ring *); -extern void igbvf_free_tx_resources (struct igbvf_ring *); -extern void igbvf_update_stats (struct igbvf_adapter *); +void igbvf_check_options (struct igbvf_adapter *); +void igbvf_set_ethtool_ops (struct net_device *); + +int igbvf_up (struct igbvf_adapter *); +void igbvf_down (struct igbvf_adapter *); +void igbvf_reinit_locked (struct igbvf_adapter *); +int igbvf_setup_rx_resources (struct igbvf_adapter *,struct igbvf_ring *); +int igbvf_setup_tx_resources (struct igbvf_adapter *,struct igbvf_ring *); +void igbvf_free_rx_resources (struct igbvf_ring *); +void igbvf_free_tx_resources (struct igbvf_ring *); +void igbvf_update_stats (struct igbvf_adapter *);extern unsigned int copybreak;
drivers/net/ethernet/intel/ixgb/ixgb.h +11 -11
@@ -187,21 +187,21 @@ enum ixgb_state_t { };/* Exported from other modules */ -extern void ixgb_check_options (struct ixgb_adapter *adapter); -extern void ixgb_set_ethtool_ops (struct net_device *netdev); +void ixgb_check_options (struct ixgb_adapter *adapter); +void ixgb_set_ethtool_ops (struct net_device *netdev);extern char ixgb_driver_name[];extern const char ixgb_driver_version[]; -extern void ixgb_set_speed_duplex (struct net_device *netdev); +void ixgb_set_speed_duplex (struct net_device *netdev); -extern int ixgb_up (struct ixgb_adapter *adapter); -extern void ixgb_down (struct ixgb_adapter *adapter,bool kill_watchdog); -extern void ixgb_reset (struct ixgb_adapter *adapter); -extern int ixgb_setup_rx_resources (struct ixgb_adapter *adapter); -extern int ixgb_setup_tx_resources (struct ixgb_adapter *adapter); -extern void ixgb_free_rx_resources (struct ixgb_adapter *adapter); -extern void ixgb_free_tx_resources (struct ixgb_adapter *adapter); -extern void ixgb_update_stats (struct ixgb_adapter *adapter); +int ixgb_up (struct ixgb_adapter *adapter); +void ixgb_down (struct ixgb_adapter *adapter,bool kill_watchdog); +void ixgb_reset (struct ixgb_adapter *adapter); +int ixgb_setup_rx_resources (struct ixgb_adapter *adapter); +int ixgb_setup_tx_resources (struct ixgb_adapter *adapter); +void ixgb_free_rx_resources (struct ixgb_adapter *adapter); +void ixgb_free_tx_resources (struct ixgb_adapter *adapter); +void ixgb_update_stats (struct ixgb_adapter *adapter);#endif /* _IXGB_H_ */
drivers/net/ethernet/intel/ixgb/ixgb_hw.h +9 -16
@@ -759,27 +759,20 @@ struct ixgb_hw_stats { };/* Function Prototypes */ -extern bool ixgb_adapter_stop (struct ixgb_hw *hw); -extern bool ixgb_init_hw (struct ixgb_hw *hw); -extern bool ixgb_adapter_start (struct ixgb_hw *hw); -extern void ixgb_check_for_link (struct ixgb_hw *hw); -extern bool ixgb_check_for_bad_link (struct ixgb_hw *hw); - -extern void ixgb_rar_set (struct ixgb_hw *hw, -u8 *addr, -u32 index); +bool ixgb_adapter_stop (struct ixgb_hw *hw); +bool ixgb_init_hw (struct ixgb_hw *hw); +bool ixgb_adapter_start (struct ixgb_hw *hw); +void ixgb_check_for_link (struct ixgb_hw *hw); +bool ixgb_check_for_bad_link (struct ixgb_hw *hw); +void ixgb_rar_set (struct ixgb_hw *hw,u8 *addr,u32 index);/* Filters (multicast, vlan, receive) */ -extern void ixgb_mc_addr_list_update (struct ixgb_hw *hw, -u8 *mc_addr_list, -u32 mc_addr_count, -u32 pad); +void ixgb_mc_addr_list_update (struct ixgb_hw *hw,u8 *mc_addr_list, +u32 mc_addr_count,u32 pad);/* Vfta functions */ -extern void ixgb_write_vfta (struct ixgb_hw *hw, -u32 offset, -u32 value); +void ixgb_write_vfta (struct ixgb_hw *hw,u32 offset,u32 value);/* Access functions to eeprom data */ void ixgb_get_ee_mac_addr (struct ixgb_hw *hw,u8 *mac_addr);
drivers/net/ethernet/intel/ixgbe/ixgbe.h +84 -88
200 lines not on this page · raw message
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +15 -19
@@ -281,27 +281,23 @@ extern const struct ixgbe_mbx_operations ixgbevf_mbx_ops;extern const char ixgbevf_driver_name[];extern const char ixgbevf_driver_version[]; -extern void ixgbevf_up (struct ixgbevf_adapter *adapter); -extern void ixgbevf_down (struct ixgbevf_adapter *adapter); -extern void ixgbevf_reinit_locked (struct ixgbevf_adapter *adapter); -extern void ixgbevf_reset (struct ixgbevf_adapter *adapter); -extern void ixgbevf_set_ethtool_ops (struct net_device *netdev); -extern int ixgbevf_setup_rx_resources (struct ixgbevf_adapter *, -struct ixgbevf_ring *); -extern int ixgbevf_setup_tx_resources (struct ixgbevf_adapter *, -struct ixgbevf_ring *); -extern void ixgbevf_free_rx_resources (struct ixgbevf_adapter *, -struct ixgbevf_ring *); -extern void ixgbevf_free_tx_resources (struct ixgbevf_adapter *, -struct ixgbevf_ring *); -extern void ixgbevf_update_stats (struct ixgbevf_adapter *adapter); -extern int ethtool_ioctl (struct ifreq *ifr); - -extern void ixgbe_napi_add_all (struct ixgbevf_adapter *adapter); -extern void ixgbe_napi_del_all (struct ixgbevf_adapter *adapter); +void ixgbevf_up (struct ixgbevf_adapter *adapter); +void ixgbevf_down (struct ixgbevf_adapter *adapter); +void ixgbevf_reinit_locked (struct ixgbevf_adapter *adapter); +void ixgbevf_reset (struct ixgbevf_adapter *adapter); +void ixgbevf_set_ethtool_ops (struct net_device *netdev); +int ixgbevf_setup_rx_resources (struct ixgbevf_adapter *,struct ixgbevf_ring *); +int ixgbevf_setup_tx_resources (struct ixgbevf_adapter *,struct ixgbevf_ring *); +void ixgbevf_free_rx_resources (struct ixgbevf_adapter *,struct ixgbevf_ring *); +void ixgbevf_free_tx_resources (struct ixgbevf_adapter *,struct ixgbevf_ring *); +void ixgbevf_update_stats (struct ixgbevf_adapter *adapter); +int ethtool_ioctl (struct ifreq *ifr); + +void ixgbe_napi_add_all (struct ixgbevf_adapter *adapter); +void ixgbe_napi_del_all (struct ixgbevf_adapter *adapter);#ifdef DEBUG -extern char *ixgbevf_get_hw_dev_name (struct ixgbe_hw *hw); +char *ixgbevf_get_hw_dev_name (struct ixgbe_hw *hw); #define hw_dbg(hw, format, arg...) \ printk(KERN_DEBUG "%s: " format, ixgbevf_get_hw_dev_name(hw), ##arg)#else
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
Re: [PATCH 02/10] intel: Remove extern from function prototypes
Quoted 7 lines · Joe Perches
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
So you are able to confirm that all compilers make this assumption correctly? The initial reason for using extern was because not all compilers made the assumption or made it correctly.
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Re: [PATCH 02/10] intel: Remove extern from function prototypes
Quoted 5 lines · Jeff Kirsher
Quoted 4 lines · Joe Perches
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Quoted 7 lines
Quoted 3 lines
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
So you are able to confirm that all compilers make this assumption correctly? The initial reason for using extern was because not all compilers made the assumption or made it correctly.
You are probably thinking of global variables, where declarations without either 'extern' or an initialiser might or might not be treated as 'common'. On function declarations, 'extern' really is redundant.
Ben.
Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
David Miller
maintainerRe: [PATCH 02/10] intel: Remove extern from function prototypes
From: Ben Hutchings <[email protected]>
Date: Tue, 24 Sep 2013 23:16:52 +0100
Quoted 10 lines · Jeff Kirsher
Quoted 9 lines · Joe Perches
Quoted 7 lines
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Quoted 7 lines
Quoted 3 lines
So you are able to confirm that all compilers make this assumption correctly? The initial reason for using extern was because not all compilers made the assumption or made it correctly.
You are probably thinking of global variables, where declarations without either 'extern' or an initialiser might or might not be treated as 'common'. On function declarations, 'extern' really is redundant.
Furthermore, these networking headers include existing generic kernel headers which already have removed the 'extern' from function declarations in certain cases.
So I don't think there isn't an issue, and if there is it has existed already for some time. :-)
Re: [PATCH 02/10] intel: Remove extern from function prototypes
In reply to Jeff KirsherQuoted 5 lines · Jeff Kirsher
Quoted 4 lines · Joe Perches
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Quoted 7 lines
Quoted 3 lines
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
So you are able to confirm that all compilers make this assumption correctly? The initial reason for using extern was because not all compilers made the assumption or made it correctly.
No, I didn't bother.
Any current compilers already do make this assumption valid as it's been part of the c spec since 1989 and prototypes without extern already are the predominate form in .h files for linux kernel sources.
Even in drivers/net/ethernet/intel/... there are more prototypes without extern than with extern.
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
PATCH 3/10 oki-semi: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 56 ++++++++++++------------- 1 file changed, 28 insertions(+), 28 deletions(-)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h +28 -28
@@ -653,38 +653,38 @@ struct pch_gbe_adapter {extern const char pch_driver_version[];/* pch_gbe_main.c */ -extern int pch_gbe_up (struct pch_gbe_adapter *adapter); -extern void pch_gbe_down (struct pch_gbe_adapter *adapter); -extern void pch_gbe_reinit_locked (struct pch_gbe_adapter *adapter); -extern void pch_gbe_reset (struct pch_gbe_adapter *adapter); -extern int pch_gbe_setup_tx_resources (struct pch_gbe_adapter *adapter, -struct pch_gbe_tx_ring *txdr); -extern int pch_gbe_setup_rx_resources (struct pch_gbe_adapter *adapter, -struct pch_gbe_rx_ring *rxdr); -extern void pch_gbe_free_tx_resources (struct pch_gbe_adapter *adapter, -struct pch_gbe_tx_ring *tx_ring); -extern void pch_gbe_free_rx_resources (struct pch_gbe_adapter *adapter, -struct pch_gbe_rx_ring *rx_ring); -extern void pch_gbe_update_stats (struct pch_gbe_adapter *adapter); -extern u32 pch_ch_control_read (struct pci_dev *pdev); -extern void pch_ch_control_write (struct pci_dev *pdev,u32 val); -extern u32 pch_ch_event_read (struct pci_dev *pdev); -extern void pch_ch_event_write (struct pci_dev *pdev,u32 val); -extern u32 pch_src_uuid_lo_read (struct pci_dev *pdev); -extern u32 pch_src_uuid_hi_read (struct pci_dev *pdev); -extern u64 pch_rx_snap_read (struct pci_dev *pdev); -extern u64 pch_tx_snap_read (struct pci_dev *pdev); -extern int pch_set_station_address (u8 *addr,struct pci_dev *pdev); +int pch_gbe_up (struct pch_gbe_adapter *adapter); +void pch_gbe_down (struct pch_gbe_adapter *adapter); +void pch_gbe_reinit_locked (struct pch_gbe_adapter *adapter); +void pch_gbe_reset (struct pch_gbe_adapter *adapter); +int pch_gbe_setup_tx_resources (struct pch_gbe_adapter *adapter, +struct pch_gbe_tx_ring *txdr); +int pch_gbe_setup_rx_resources (struct pch_gbe_adapter *adapter, +struct pch_gbe_rx_ring *rxdr); +void pch_gbe_free_tx_resources (struct pch_gbe_adapter *adapter, +struct pch_gbe_tx_ring *tx_ring); +void pch_gbe_free_rx_resources (struct pch_gbe_adapter *adapter, +struct pch_gbe_rx_ring *rx_ring); +void pch_gbe_update_stats (struct pch_gbe_adapter *adapter); +u32 pch_ch_control_read (struct pci_dev *pdev); +void pch_ch_control_write (struct pci_dev *pdev,u32 val); +u32 pch_ch_event_read (struct pci_dev *pdev); +void pch_ch_event_write (struct pci_dev *pdev,u32 val); +u32 pch_src_uuid_lo_read (struct pci_dev *pdev); +u32 pch_src_uuid_hi_read (struct pci_dev *pdev); +u64 pch_rx_snap_read (struct pci_dev *pdev); +u64 pch_tx_snap_read (struct pci_dev *pdev); +int pch_set_station_address (u8 *addr,struct pci_dev *pdev);/* pch_gbe_param.c */ -extern void pch_gbe_check_options (struct pch_gbe_adapter *adapter); +void pch_gbe_check_options (struct pch_gbe_adapter *adapter);/* pch_gbe_ethtool.c */ -extern void pch_gbe_set_ethtool_ops (struct net_device *netdev); +void pch_gbe_set_ethtool_ops (struct net_device *netdev);/* pch_gbe_mac.c */ -extern s32 pch_gbe_mac_force_mac_fc (struct pch_gbe_hw *hw); -extern s32 pch_gbe_mac_read_mac_addr (struct pch_gbe_hw *hw); -extern u16 pch_gbe_mac_ctrl_miim (struct pch_gbe_hw *hw, -u32 addr,u32 dir,u32 reg,u16 data); +s32 pch_gbe_mac_force_mac_fc (struct pch_gbe_hw *hw); +s32 pch_gbe_mac_read_mac_addr (struct pch_gbe_hw *hw); +u16 pch_gbe_mac_ctrl_miim (struct pch_gbe_hw *hw,u32 addr,u32 dir,u32 reg, +u16 data);#endif /* _PCH_GBE_H_ */
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
PATCH 4/10 qlogic: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/qlogic/netxen/netxen_nic.h | 5 +-- drivers/net/ethernet/qlogic/qlge/qlge.h | 58 ++++++++++++------------- 2 files changed, 30 insertions(+), 33 deletions(-)
drivers/net/ethernet/qlogic/netxen/netxen_nic.h +2 -3
@@ -1883,9 +1883,8 @@ static inline u32 netxen_tx_avail(struct nx_host_tx_ring *tx_ring)int netxen_get_flash_mac_addr (struct netxen_adapter *adapter,u64 *mac);int netxen_p3_get_mac_addr (struct netxen_adapter *adapter,u64 *mac); -extern void netxen_change_ringparam (struct netxen_adapter *adapter); -extern int netxen_rom_fast_read (struct netxen_adapter *adapter,int addr, -int *valp); +void netxen_change_ringparam (struct netxen_adapter *adapter); +int netxen_rom_fast_read (struct netxen_adapter *adapter,int addr,int *valp);extern const struct ethtool_ops netxen_nic_ethtool_ops;
drivers/net/ethernet/qlogic/qlge/qlge.h +28 -30
118 lines not on this page · raw message
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
PATCH 5/10 sfc: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/sfc/efx.h | 104 +++++++++--------- drivers/net/ethernet/sfc/mcdi.h | 120 ++++++++++----------- drivers/net/ethernet/sfc/mdio_10g.h | 26 +++-- drivers/net/ethernet/sfc/nic.h | 210 ++++++++++++++++++------------------ drivers/net/ethernet/sfc/phy.h | 8 +- drivers/net/ethernet/sfc/selftest.h | 15 ++- 6 files changed, 234 insertions(+), 249 deletions(-)
drivers/net/ethernet/sfc/efx.h +50 -54
@@ -18,38 +18,36 @@#define EFX_MEM_BAR 2/* TX */ -extern int efx_probe_tx_queue (struct efx_tx_queue *tx_queue); -extern void efx_remove_tx_queue (struct efx_tx_queue *tx_queue); -extern void efx_init_tx_queue (struct efx_tx_queue *tx_queue); -extern void efx_init_tx_queue_core_txq (struct efx_tx_queue *tx_queue); -extern void efx_fini_tx_queue (struct efx_tx_queue *tx_queue); -extern netdev_tx_t -efx_hard_start_xmit (struct sk_buff *skb,struct net_device *net_dev); -extern netdev_tx_t -efx_enqueue_skb (struct efx_tx_queue *tx_queue,struct sk_buff *skb); -extern void efx_xmit_done (struct efx_tx_queue *tx_queue,unsigned int index); -extern int efx_setup_tc (struct net_device *net_dev,u8 num_tc); -extern unsigned int efx_tx_max_skb_descs (struct efx_nic *efx); +int efx_probe_tx_queue (struct efx_tx_queue *tx_queue); +void efx_remove_tx_queue (struct efx_tx_queue *tx_queue); +void efx_init_tx_queue (struct efx_tx_queue *tx_queue); +void efx_init_tx_queue_core_txq (struct efx_tx_queue *tx_queue); +void efx_fini_tx_queue (struct efx_tx_queue *tx_queue); +netdev_tx_t efx_hard_start_xmit (struct sk_buff *skb, +struct net_device *net_dev); +netdev_tx_t efx_enqueue_skb (struct efx_tx_queue *tx_queue,struct sk_buff *skb); +void efx_xmit_done (struct efx_tx_queue *tx_queue,unsigned int index); +int efx_setup_tc (struct net_device *net_dev,u8 num_tc); +unsigned int efx_tx_max_skb_descs (struct efx_nic *efx);extern unsigned int efx_piobuf_size;/* RX */ -extern void efx_rx_config_page_split (struct efx_nic *efx); -extern int efx_probe_rx_queue (struct efx_rx_queue *rx_queue); -extern void efx_remove_rx_queue (struct efx_rx_queue *rx_queue); -extern void efx_init_rx_queue (struct efx_rx_queue *rx_queue); -extern void efx_fini_rx_queue (struct efx_rx_queue *rx_queue); -extern void efx_fast_push_rx_descriptors (struct efx_rx_queue *rx_queue); -extern void efx_rx_slow_fill (unsigned long context); -extern void __efx_rx_packet (struct efx_channel *channel); -extern void efx_rx_packet (struct efx_rx_queue *rx_queue, -unsigned int index,unsigned int n_frags, -unsigned int len,u16 flags); +void efx_rx_config_page_split (struct efx_nic *efx); +int efx_probe_rx_queue (struct efx_rx_queue *rx_queue); +void efx_remove_rx_queue (struct efx_rx_queue *rx_queue); +void efx_init_rx_queue (struct efx_rx_queue *rx_queue); +void efx_fini_rx_queue (struct efx_rx_queue *rx_queue); +void efx_fast_push_rx_descriptors (struct efx_rx_queue *rx_queue); +void efx_rx_slow_fill (unsigned long context); +void __efx_rx_packet (struct efx_channel *channel); +void efx_rx_packet (struct efx_rx_queue *rx_queue,unsigned int index, +unsigned int n_frags,unsigned int len,u16 flags);static inline void efx_rx_flush_packet (struct efx_channel *channel) {if (channel->rx_pkt_n_frags)__efx_rx_packet (channel); } -extern void efx_schedule_slow_fill (struct efx_rx_queue *rx_queue); +void efx_schedule_slow_fill (struct efx_rx_queue *rx_queue);#define EFX_MAX_DMAQ_SIZE 4096UL#define EFX_DEFAULT_DMAQ_SIZE 1024UL
@@ -163,9 +161,9 @@ static inline s32 efx_filter_get_rx_ids(struct efx_nic *efx,return efx->type->filter_get_rx_ids (efx, priority, buf, size); }#ifdef CONFIG_RFS_ACCEL -extern int efx_filter_rfs (struct net_device *net_dev,const struct sk_buff *skb, -u16 rxq_index,u32 flow_id); -extern bool __efx_filter_rfs_expire (struct efx_nic *efx,unsigned quota); +int efx_filter_rfs (struct net_device *net_dev,const struct sk_buff *skb, +u16 rxq_index,u32 flow_id); +bool __efx_filter_rfs_expire (struct efx_nic *efx,unsigned quota);static inline void efx_filter_rfs_expire (struct efx_channel *channel) { if (channel->rfs_filters_added >= 60 &&
@@ -177,50 +175,48 @@ static inline void efx_filter_rfs_expire(struct efx_channel *channel)static inline void efx_filter_rfs_expire (struct efx_channel *channel) {}#define efx_filter_rfs_enabled () 0#endif -extern bool efx_filter_is_mc_recipient (const struct efx_filter_spec *spec); +bool efx_filter_is_mc_recipient (const struct efx_filter_spec *spec);/* Channels */ -extern int efx_channel_dummy_op_int (struct efx_channel *channel); -extern void efx_channel_dummy_op_void (struct efx_channel *channel); -extern int -efx_realloc_channels (struct efx_nic *efx,u32 rxq_entries,u32 txq_entries); +int efx_channel_dummy_op_int (struct efx_channel *channel); +void efx_channel_dummy_op_void (struct efx_channel *channel); +int efx_realloc_channels (struct efx_nic *efx,u32 rxq_entries,u32 txq_entries);/* Ports */ -extern int efx_reconfigure_port (struct efx_nic *efx); -extern int __efx_reconfigure_port (struct efx_nic *efx); +int efx_reconfigure_port (struct efx_nic *efx); +int __efx_reconfigure_port (struct efx_nic *efx);/* Ethtool support */ extern const struct ethtool_ops efx_ethtool_ops;/* Reset handling */ -extern int efx_reset (struct efx_nic *efx,enum reset_type method); -extern void efx_reset_down (struct efx_nic *efx,enum reset_type method); -extern int efx_reset_up (struct efx_nic *efx,enum reset_type method,bool ok); -extern int efx_try_recovery (struct efx_nic *efx); +int efx_reset (struct efx_nic *efx,enum reset_type method); +void efx_reset_down (struct efx_nic *efx,enum reset_type method); +int efx_reset_up (struct efx_nic *efx,enum reset_type method,bool ok); +int efx_try_recovery (struct efx_nic *efx);/* Global */ -extern void efx_schedule_reset (struct efx_nic *efx,enum reset_type type); -extern int efx_init_irq_moderation (struct efx_nic *efx,unsigned int tx_usecs, -unsigned int rx_usecs,bool rx_adaptive, -bool rx_may_override_tx); -extern void efx_get_irq_moderation (struct efx_nic *efx,unsigned int *tx_usecs, -unsigned int *rx_usecs,bool *rx_adaptive); +void efx_schedule_reset (struct efx_nic *efx,enum reset_type type); +int efx_init_irq_moderation (struct efx_nic *efx,unsigned int tx_usecs, +unsigned int rx_usecs,bool rx_adaptive, +bool rx_may_override_tx); +void efx_get_irq_moderation (struct efx_nic *efx,unsigned int *tx_usecs, +unsigned int *rx_usecs,bool *rx_adaptive);/* Dummy PHY ops for PHY drivers */ -extern int efx_port_dummy_op_int (struct efx_nic *efx); -extern void efx_port_dummy_op_void (struct efx_nic *efx); - +int efx_port_dummy_op_int (struct efx_nic *efx); +void efx_port_dummy_op_void (struct efx_nic *efx);/* MTD */ #ifdef CONFIG_SFC_MTD -extern int efx_mtd_add (struct efx_nic *efx,struct efx_mtd_partition *parts, -size_t n_parts,size_t sizeof_part); +int efx_mtd_add (struct efx_nic *efx,struct efx_mtd_partition *parts, +size_t n_parts,size_t sizeof_part);static inline int efx_mtd_probe (struct efx_nic *efx) {return efx->type->mtd_probe (efx); } -extern void efx_mtd_rename (struct efx_nic *efx); -extern void efx_mtd_remove (struct efx_nic *efx); +void efx_mtd_rename (struct efx_nic *efx); +void efx_mtd_remove (struct efx_nic *efx);#else static inline int efx_mtd_probe (struct efx_nic *efx) {return 0 ; }static inline void efx_mtd_rename (struct efx_nic *efx) {}
@@ -242,9 +238,9 @@ static inline void efx_schedule_channel_irq(struct efx_channel *channel)efx_schedule_channel (channel); } -extern void efx_link_status_changed (struct efx_nic *efx); -extern void efx_link_set_advertising (struct efx_nic *efx,u32 ); -extern void efx_link_set_wanted_fc (struct efx_nic *efx,u8 ); +void efx_link_status_changed (struct efx_nic *efx); +void efx_link_set_advertising (struct efx_nic *efx,u32 ); +void efx_link_set_wanted_fc (struct efx_nic *efx,u8 );static inline void efx_device_detach_sync (struct efx_nic *efx) {
drivers/net/ethernet/sfc/mcdi.h +58 -62
151 lines not on this page · raw message
drivers/net/ethernet/sfc/mdio_10g.h +12 -14
@@ -20,7 +20,7 @@static inline unsigned efx_mdio_id_rev (u32 id) {return id &0xf ; }static inline unsigned efx_mdio_id_model (u32 id) {return (id >>4 ) &0x3f ; } -extern unsigned efx_mdio_id_oui (u32 id); +unsigned efx_mdio_id_oui (u32 id);static inline int efx_mdio_read (struct efx_nic *efx,int devad,int addr) {
@@ -56,7 +56,7 @@ static inline bool efx_mdio_phyxgxs_lane_sync(struct efx_nic *efx)return sync; } -extern const char *efx_mdio_mmd_name (int mmd); +const char *efx_mdio_mmd_name (int mmd);/* * Reset a specific MMD and wait for reset to clear.
@@ -64,30 +64,29 @@ extern const char *efx_mdio_mmd_name(int mmd);* * This function will sleep */ -extern int efx_mdio_reset_mmd (struct efx_nic *efx,int mmd, -int spins,int spintime); +int efx_mdio_reset_mmd (struct efx_nic *efx,int mmd,int spins,int spintime);/* As efx_mdio_check_mmd but for multiple MMDs */ int efx_mdio_check_mmds (struct efx_nic *efx,unsigned int mmd_mask);/* Check the link status of specified mmds in bit mask */ -extern bool efx_mdio_links_ok (struct efx_nic *efx,unsigned int mmd_mask); +bool efx_mdio_links_ok (struct efx_nic *efx,unsigned int mmd_mask);/* Generic transmit disable support though PMAPMD */ -extern void efx_mdio_transmit_disable (struct efx_nic *efx); +void efx_mdio_transmit_disable (struct efx_nic *efx);/* Generic part of reconfigure: set/clear loopback bits */ -extern void efx_mdio_phy_reconfigure (struct efx_nic *efx); +void efx_mdio_phy_reconfigure (struct efx_nic *efx);/* Set the power state of the specified MMDs */ -extern void efx_mdio_set_mmds_lpower (struct efx_nic *efx, -int low_power,unsigned int mmd_mask); +void efx_mdio_set_mmds_lpower (struct efx_nic *efx,int low_power, +unsigned int mmd_mask);/* Set (some of) the PHY settings over MDIO */ -extern int efx_mdio_set_settings (struct efx_nic *efx,struct ethtool_cmd *ecmd); +int efx_mdio_set_settings (struct efx_nic *efx,struct ethtool_cmd *ecmd);/* Push advertising flags and restart autonegotiation */ -extern void efx_mdio_an_reconfigure (struct efx_nic *efx); +void efx_mdio_an_reconfigure (struct efx_nic *efx);/* Get pause parameters from AN if available (otherwise return * requested pause parameters)
@@ -95,8 +94,7 @@ extern void efx_mdio_an_reconfigure(struct efx_nic *efx);u8 efx_mdio_get_pause (struct efx_nic *efx);/* Wait for specified MMDs to exit reset within a timeout */ -extern int efx_mdio_wait_reset_mmds (struct efx_nic *efx, -unsigned int mmd_mask); +int efx_mdio_wait_reset_mmds (struct efx_nic *efx,unsigned int mmd_mask);/* Set or clear flag, debouncing */ static inline void
@@ -107,6 +105,6 @@ efx_mdio_set_flag(struct efx_nic *efx, int devad, int addr, }/* Liveness self-test for MDIO PHYs */ -extern int efx_mdio_test_alive (struct efx_nic *efx); +int efx_mdio_test_alive (struct efx_nic *efx);#endif /* EFX_MDIO_10G_H */
drivers/net/ethernet/sfc/nic.h +103 -107
277 lines not on this page · raw message
drivers/net/ethernet/sfc/phy.h +4 -4
@@ -15,7 +15,7 @@*/ extern const struct efx_phy_operations falcon_sfx7101_phy_ops; -extern void tenxpress_set_id_led (struct efx_nic *efx,enum efx_led_mode mode); +void tenxpress_set_id_led (struct efx_nic *efx,enum efx_led_mode mode);/**************************************************************************** * AMCC/Quake QT202x PHYs
@@ -34,7 +34,7 @@ extern const struct efx_phy_operations falcon_qt202x_phy_ops;#define QUAKE_LED_TXLINK (0)#define QUAKE_LED_RXLINK (8) -extern void falcon_qt202x_set_led (struct efx_nic *p,int led,int state); +void falcon_qt202x_set_led (struct efx_nic *p,int led,int state);/**************************************************************************** * Transwitch CX4 retimer
@@ -44,7 +44,7 @@ extern const struct efx_phy_operations falcon_txc_phy_ops;#define TXC_GPIO_DIR_INPUT 0#define TXC_GPIO_DIR_OUTPUT 1 -extern void falcon_txc_set_gpio_dir (struct efx_nic *efx,int pin,int dir); -extern void falcon_txc_set_gpio_val (struct efx_nic *efx,int pin,int val); +void falcon_txc_set_gpio_dir (struct efx_nic *efx,int pin,int dir); +void falcon_txc_set_gpio_val (struct efx_nic *efx,int pin,int val);#endif
drivers/net/ethernet/sfc/selftest.h +7 -8
@@ -43,13 +43,12 @@ struct efx_self_tests { struct efx_loopback_self_tests loopback[LOOPBACK_TEST_MAX + 1]; }; -extern void efx_loopback_rx_packet (struct efx_nic *efx, -const char *buf_ptr,int pkt_len); -extern int efx_selftest (struct efx_nic *efx, -struct efx_self_tests *tests, -unsigned flags); -extern void efx_selftest_async_start (struct efx_nic *efx); -extern void efx_selftest_async_cancel (struct efx_nic *efx); -extern void efx_selftest_async_work (struct work_struct *data); +void efx_loopback_rx_packet (struct efx_nic *efx,const char *buf_ptr, +int pkt_len); +int efx_selftest (struct efx_nic *efx,struct efx_self_tests *tests, +unsigned flags); +void efx_selftest_async_start (struct efx_nic *efx); +void efx_selftest_async_cancel (struct efx_nic *efx); +void efx_selftest_async_work (struct work_struct *data);#endif /* EFX_SELFTEST_H */
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
PATCH 6/10 stmicro: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/stmicro/stmmac/common.h | 12 ++++++------ drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h | 17 ++++++++--------- drivers/net/ethernet/stmicro/stmmac/mmc.h | 6 +++--- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 10 +++++----- 4 files changed, 22 insertions(+), 23 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +6 -6
@@ -451,14 +451,14 @@ struct mac_device_info {struct mac_device_info *dwmac1000_setup (void __iomem *ioaddr);struct mac_device_info *dwmac100_setup (void __iomem *ioaddr); -extern void stmmac_set_mac_addr (void __iomem *ioaddr,u8 addr[6 ], -unsigned int high,unsigned int low); -extern void stmmac_get_mac_addr (void __iomem *ioaddr,unsigned char *addr, -unsigned int high,unsigned int low); +void stmmac_set_mac_addr (void __iomem *ioaddr,u8 addr[6 ], +unsigned int high,unsigned int low); +void stmmac_get_mac_addr (void __iomem *ioaddr,unsigned char *addr, +unsigned int high,unsigned int low); -extern void stmmac_set_mac (void __iomem *ioaddr,bool enable); +void stmmac_set_mac (void __iomem *ioaddr,bool enable); -extern void dwmac_dma_flush_tx_fifo (void __iomem *ioaddr); +void dwmac_dma_flush_tx_fifo (void __iomem *ioaddr);extern const struct stmmac_ring_mode_ops ring_mode_ops;extern const struct stmmac_chain_mode_ops chain_mode_ops;
drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h +8 -9
@@ -104,14 +104,13 @@#define DMA_STATUS_TI 0x00000001/* Transmit Interrupt */ #define DMA_CONTROL_FTF 0x00100000/* Flush transmit FIFO */ -extern void dwmac_enable_dma_transmission (void __iomem *ioaddr); -extern void dwmac_enable_dma_irq (void __iomem *ioaddr); -extern void dwmac_disable_dma_irq (void __iomem *ioaddr); -extern void dwmac_dma_start_tx (void __iomem *ioaddr); -extern void dwmac_dma_stop_tx (void __iomem *ioaddr); -extern void dwmac_dma_start_rx (void __iomem *ioaddr); -extern void dwmac_dma_stop_rx (void __iomem *ioaddr); -extern int dwmac_dma_interrupt (void __iomem *ioaddr, -struct stmmac_extra_stats *x); +void dwmac_enable_dma_transmission (void __iomem *ioaddr); +void dwmac_enable_dma_irq (void __iomem *ioaddr); +void dwmac_disable_dma_irq (void __iomem *ioaddr); +void dwmac_dma_start_tx (void __iomem *ioaddr); +void dwmac_dma_stop_tx (void __iomem *ioaddr); +void dwmac_dma_start_rx (void __iomem *ioaddr); +void dwmac_dma_stop_rx (void __iomem *ioaddr); +int dwmac_dma_interrupt (void __iomem *ioaddr,struct stmmac_extra_stats *x);#endif /* __DWMAC_DMA_H__ */
drivers/net/ethernet/stmicro/stmmac/mmc.h +3 -3
@@ -128,8 +128,8 @@ struct stmmac_counters { unsigned int mmc_rx_icmp_err_octets; }; -extern void dwmac_mmc_ctrl (void __iomem *ioaddr,unsigned int mode); -extern void dwmac_mmc_intr_all_mask (void __iomem *ioaddr); -extern void dwmac_mmc_read (void __iomem *ioaddr,struct stmmac_counters *mmc); +void dwmac_mmc_ctrl (void __iomem *ioaddr,unsigned int mode); +void dwmac_mmc_intr_all_mask (void __iomem *ioaddr); +void dwmac_mmc_read (void __iomem *ioaddr,struct stmmac_counters *mmc);#endif /* __MMC_H__ */
drivers/net/ethernet/stmicro/stmmac/stmmac.h +5 -5
@@ -110,14 +110,14 @@ struct stmmac_priv {extern int phyaddr; -extern int stmmac_mdio_unregister (struct net_device *ndev); -extern int stmmac_mdio_register (struct net_device *ndev); -extern void stmmac_set_ethtool_ops (struct net_device *netdev); +int stmmac_mdio_unregister (struct net_device *ndev); +int stmmac_mdio_register (struct net_device *ndev); +void stmmac_set_ethtool_ops (struct net_device *netdev);extern const struct stmmac_desc_ops enh_desc_ops;extern const struct stmmac_desc_ops ndesc_ops;extern const struct stmmac_hwtimestamp stmmac_ptp; -extern int stmmac_ptp_register (struct stmmac_priv *priv); -extern void stmmac_ptp_unregister (struct stmmac_priv *priv); +int stmmac_ptp_register (struct stmmac_priv *priv); +void stmmac_ptp_unregister (struct stmmac_priv *priv);int stmmac_freeze (struct net_device *ndev);int stmmac_restore (struct net_device *ndev);int stmmac_resume (struct net_device *ndev);
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
PATCH 7/10 ti: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/ti/cpts.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/net/ethernet/ti/cpts.h +4 -5
@@ -127,8 +127,8 @@ struct cpts { };#ifdef CONFIG_TI_CPTS -extern void cpts_rx_timestamp (struct cpts *cpts,struct sk_buff *skb); -extern void cpts_tx_timestamp (struct cpts *cpts,struct sk_buff *skb); +void cpts_rx_timestamp (struct cpts *cpts,struct sk_buff *skb); +void cpts_tx_timestamp (struct cpts *cpts,struct sk_buff *skb);#else static inline void cpts_rx_timestamp (struct cpts *cpts,struct sk_buff *skb) {
@@ -138,8 +138,7 @@ static inline void cpts_tx_timestamp(struct cpts *cpts, struct sk_buff *skb) }#endif -extern int cpts_register (struct device *dev,struct cpts *cpts, -u32 mult,u32 shift); -extern void cpts_unregister (struct cpts *cpts); +int cpts_register (struct device *dev,struct cpts *cpts,u32 mult,u32 shift); +void cpts_unregister (struct cpts *cpts);#endif
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
PATCH 8/10 toshiba: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/toshiba/ps3_gelic_net.h | 29 +++++++++++------------ drivers/net/ethernet/toshiba/ps3_gelic_wireless.h | 6 ++--- drivers/net/ethernet/toshiba/spider_net.h | 4 ++-- 3 files changed, 19 insertions(+), 20 deletions(-)
drivers/net/ethernet/toshiba/ps3_gelic_net.h +14 -15
@@ -359,27 +359,26 @@ static inline void *port_priv(struct gelic_port *port) }#ifdef CONFIG_PPC_EARLY_DEBUG_PS3GELIC -extern void udbg_shutdown_ps3gelic (void ); +void udbg_shutdown_ps3gelic (void );#else static inline void udbg_shutdown_ps3gelic (void ) {}#endif -extern int gelic_card_set_irq_mask (struct gelic_card *card,u64 mask); +int gelic_card_set_irq_mask (struct gelic_card *card,u64 mask);/* shared netdev ops */ -extern void gelic_card_up (struct gelic_card *card); -extern void gelic_card_down (struct gelic_card *card); -extern int gelic_net_open (struct net_device *netdev); -extern int gelic_net_stop (struct net_device *netdev); -extern int gelic_net_xmit (struct sk_buff *skb,struct net_device *netdev); -extern void gelic_net_set_multi (struct net_device *netdev); -extern void gelic_net_tx_timeout (struct net_device *netdev); -extern int gelic_net_change_mtu (struct net_device *netdev,int new_mtu); -extern int gelic_net_setup_netdev (struct net_device *netdev, -struct gelic_card *card); +void gelic_card_up (struct gelic_card *card); +void gelic_card_down (struct gelic_card *card); +int gelic_net_open (struct net_device *netdev); +int gelic_net_stop (struct net_device *netdev); +int gelic_net_xmit (struct sk_buff *skb,struct net_device *netdev); +void gelic_net_set_multi (struct net_device *netdev); +void gelic_net_tx_timeout (struct net_device *netdev); +int gelic_net_change_mtu (struct net_device *netdev,int new_mtu); +int gelic_net_setup_netdev (struct net_device *netdev,struct gelic_card *card);/* shared ethtool ops */ -extern void gelic_net_get_drvinfo (struct net_device *netdev, -struct ethtool_drvinfo *info); -extern void gelic_net_poll_controller (struct net_device *netdev); +void gelic_net_get_drvinfo (struct net_device *netdev, +struct ethtool_drvinfo *info); +void gelic_net_poll_controller (struct net_device *netdev);#endif /* _GELIC_NET_H */
drivers/net/ethernet/toshiba/ps3_gelic_wireless.h +3 -3
@@ -320,7 +320,7 @@ struct gelic_eurus_cmd {#define GELIC_WL_PRIV_SET_PSK (SIOCIWFIRSTPRIV + 0)#define GELIC_WL_PRIV_GET_PSK (SIOCIWFIRSTPRIV + 1) -extern int gelic_wl_driver_probe (struct gelic_card *card); -extern int gelic_wl_driver_remove (struct gelic_card *card); -extern void gelic_wl_interrupt (struct net_device *netdev,u64 status); +int gelic_wl_driver_probe (struct gelic_card *card); +int gelic_wl_driver_remove (struct gelic_card *card); +void gelic_wl_interrupt (struct net_device *netdev,u64 status);#endif /* _GELIC_WIRELESS_H */
drivers/net/ethernet/toshiba/spider_net.h +2 -2
@@ -29,8 +29,8 @@#include <linux/sungem_phy.h> -extern int spider_net_stop (struct net_device *netdev); -extern int spider_net_open (struct net_device *netdev); +int spider_net_stop (struct net_device *netdev); +int spider_net_open (struct net_device *netdev);extern const struct ethtool_ops spider_net_ethtool_ops;
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
Re: [PATCH 08/10] toshiba: Remove extern from function prototypes
Quoted 8 lines · Joe Perches
There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Quoted 6 lines
Signed-off-by Joe Perches <[email protected]>--- drivers/net/ethernet/toshiba/ps3_gelic_net.h | 29 +++++++++++------------ drivers/net/ethernet/toshiba/ps3_gelic_wireless.h | 6 ++--- drivers/net/ethernet/toshiba/spider_net.h | 4 ++-- 3 files changed, 19 insertions(+), 20 deletions(-)
Looks good. Thanks.
Acked-by Geoff Levand <[email protected]>
PATCH 9/10 fddi/skfp: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/fddi/skfp/h/smc.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-)
drivers/net/fddi/skfp/h/smc.h +14 -14
@@ -469,20 +469,20 @@ struct s_smc {extern const struct fddi_addr fddi_broadcast; -extern void all_selection_criteria (struct s_smc *smc); -extern void card_stop (struct s_smc *smc); -extern void init_board (struct s_smc *smc,u_char *mac_addr); -extern int init_fplus (struct s_smc *smc); -extern void init_plc (struct s_smc *smc); -extern int init_smt (struct s_smc *smc,u_char * mac_addr); -extern void mac1_irq (struct s_smc *smc,u_short stu,u_short stl); -extern void mac2_irq (struct s_smc *smc,u_short code_s2u,u_short code_s2l); -extern void mac3_irq (struct s_smc *smc,u_short code_s3u,u_short code_s3l); -extern int pcm_status_twisted (struct s_smc *smc); -extern void plc1_irq (struct s_smc *smc); -extern void plc2_irq (struct s_smc *smc); -extern void read_address (struct s_smc *smc,u_char * mac_addr); -extern void timer_irq (struct s_smc *smc); +void all_selection_criteria (struct s_smc *smc); +void card_stop (struct s_smc *smc); +void init_board (struct s_smc *smc,u_char *mac_addr); +int init_fplus (struct s_smc *smc); +void init_plc (struct s_smc *smc); +int init_smt (struct s_smc *smc,u_char *mac_addr); +void mac1_irq (struct s_smc *smc,u_short stu,u_short stl); +void mac2_irq (struct s_smc *smc,u_short code_s2u,u_short code_s2l); +void mac3_irq (struct s_smc *smc,u_short code_s3u,u_short code_s3l); +int pcm_status_twisted (struct s_smc *smc); +void plc1_irq (struct s_smc *smc); +void plc2_irq (struct s_smc *smc); +void read_address (struct s_smc *smc,u_char *mac_addr); +void timer_irq (struct s_smc *smc);#endif /* _SCMECM_ */
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
PATCH 10/10 irda: Remove extern from function prototypes
In reply to Joe PerchesThere are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes.
Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/irda/sir-dev.h | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)
drivers/net/irda/sir-dev.h +15 -14
@@ -102,28 +102,29 @@ struct sir_driver {/* exported */ -extern int irda_register_dongle (struct dongle_driver *new); -extern int irda_unregister_dongle (struct dongle_driver *drv); +int irda_register_dongle (struct dongle_driver *new); +int irda_unregister_dongle (struct dongle_driver *drv); -extern struct sir_dev *sirdev_get_instance (const struct sir_driver *drv,const char *name); -extern int sirdev_put_instance (struct sir_dev *self); +struct sir_dev *sirdev_get_instance (const struct sir_driver *drv, +const char *name); +int sirdev_put_instance (struct sir_dev *self); -extern int sirdev_set_dongle (struct sir_dev *dev,IRDA_DONGLE type); -extern void sirdev_write_complete (struct sir_dev *dev); -extern int sirdev_receive (struct sir_dev *dev,const unsigned char *cp,size_t count); +int sirdev_set_dongle (struct sir_dev *dev,IRDA_DONGLE type); +void sirdev_write_complete (struct sir_dev *dev); +int sirdev_receive (struct sir_dev *dev,const unsigned char *cp,size_t count);/* low level helpers for SIR device/dongle setup */ -extern int sirdev_raw_write (struct sir_dev *dev,const char *buf,int len); -extern int sirdev_raw_read (struct sir_dev *dev,char *buf,int len); -extern int sirdev_set_dtr_rts (struct sir_dev *dev,int dtr,int rts); +int sirdev_raw_write (struct sir_dev *dev,const char *buf,int len); +int sirdev_raw_read (struct sir_dev *dev,char *buf,int len); +int sirdev_set_dtr_rts (struct sir_dev *dev,int dtr,int rts);/* not exported */ -extern int sirdev_get_dongle (struct sir_dev *self,IRDA_DONGLE type); -extern int sirdev_put_dongle (struct sir_dev *self); +int sirdev_get_dongle (struct sir_dev *self,IRDA_DONGLE type); +int sirdev_put_dongle (struct sir_dev *self); -extern void sirdev_enable_rx (struct sir_dev *dev); -extern int sirdev_schedule_request (struct sir_dev *dev,int state,unsigned param); +void sirdev_enable_rx (struct sir_dev *dev); +int sirdev_schedule_request (struct sir_dev *dev,int state,unsigned param);/* inline helpers */
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
A message that is not in the archive (sent off-list or not yet received): OF686C5618.58B3CEF3-ONC1257BF0.0074538C-C1257BF0.00745392@de.ibm.com
RFC PATCH 1/1 Update Jens Osterkamp email address
The old address isn't working.
Signed-off-by Joe Perches <[email protected]>
---
Maybe if you're still interested in receiving emails on this old driver...
Quoted 6 lines · On Tue, 2013-09-24 at 14:10 -0700, [email protected] wrote:
Your message
Subject: [PATCH 08/10] toshiba: Remove extern from function prototypes
was not delivered to:
[email protected]
because:
User jens ([email protected]) not listed in Domino Directory
.mailmap | 2 +- MAINTAINERS | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.h | 2 +- drivers/net/ethernet/toshiba/spider_net.c | 4 ++-- drivers/net/ethernet/toshiba/spider_net.h | 2 +- drivers/net/ethernet/toshiba/spider_net_ethtool.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-)
.mailmap +1 -1
@@ -60,7 +60,7 @@ James Ketrenos <jketreno@io.(none)> Jean Tourrilhes <[email protected]> Jeff Garzik <[email protected]> Jens Axboe <[email protected]> -Jens Osterkamp <[email protected]> +Jens Osterkamp <[email protected]> John Stultz <[email protected]> Juha Yrjola <at solidboot.com> Juha Yrjola <[email protected]>
MAINTAINERS +1 -1
@@ -7854,7 +7854,7 @@ F: include/uapi/linux/spi/ SPIDERNET NETWORK DRIVER for CELL M: Ishizaki Kou <[email protected]> -M: Jens Osterkamp <[email protected]> +M: Jens Osterkamp <[email protected]> L: [email protected] S: Supported F: Documentation/networking/spider_net.txt
drivers/net/ethernet/toshiba/ps3_gelic_net.c +1 -1
@@ -9,7 +9,7 @@* (C) Copyright IBM Corp. 2005 * * Authors : Utz Bacher <[email protected]> -* Jens Osterkamp <[email protected]> +* Jens Osterkamp <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/net/ethernet/toshiba/ps3_gelic_net.h +1 -1
@@ -9,7 +9,7 @@* (C) Copyright IBM Corp. 2005 * * Authors : Utz Bacher <[email protected]> -* Jens Osterkamp <[email protected]> +* Jens Osterkamp <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/net/ethernet/toshiba/spider_net.c +2 -2
@@ -5,7 +5,7 @@* (C) Copyright 2006 TOSHIBA CORPORATION * * Authors : Utz Bacher <[email protected]> -* Jens Osterkamp <[email protected]> +* Jens Osterkamp <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
@@ -54,7 +54,7 @@#include "spider_net.h" MODULE_AUTHOR ("Utz Bacher <[email protected]> and Jens Osterkamp " \ -"<[email protected]>" ); +"<[email protected]>" );MODULE_DESCRIPTION ("Spider Southbridge Gigabit Ethernet driver" );MODULE_LICENSE ("GPL" );MODULE_VERSION (VERSION );
drivers/net/ethernet/toshiba/spider_net.h +1 -1
@@ -5,7 +5,7 @@* (C) Copyright 2006 TOSHIBA CORPORATION * * Authors : Utz Bacher <[email protected]> -* Jens Osterkamp <[email protected]> +* Jens Osterkamp <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/net/ethernet/toshiba/spider_net_ethtool.c +1 -1
@@ -4,7 +4,7 @@* (C) Copyright IBM Corp. 2005 * * Authors : Utz Bacher <[email protected]> -* Jens Osterkamp <[email protected]> +* Jens Osterkamp <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
Re: [RFC patch] Update Jens Osterkamp email address
Quoted 15 lines · Joe Perches
The old address isn't working.
Signed-off-by Joe Perches <[email protected]>---
Maybe if you're still interested in receiving emails on this old driver...
Quoted 6 lines · On Tue, 2013-09-24 at 14:10 -0700, [email protected] wrote:
Your message
Subject: [PATCH 08/10] toshiba: Remove extern from function prototypes
was not delivered to:
[email protected]
because:
User jens ([email protected]) not listed in Domino Directory
Nevermind. The newer address isn't working either.
------
VMSDVM9.POK.IBM.COM unable to deliver following mail to recipient(s):
<[email protected]>
VMSDVM9.POK.IBM.COM received negative reply:
550 5.1.1 <[email protected]>: Recipient address rejected: User unknown in local recipient table
-------
Ishizaki?
Maybe you know of a more current address or maybe you could delete Jens' email address from MAINTAINERS.
David Miller
maintainerFrom: Joe Perches <[email protected]>
Date: Tue, 24 Sep 2013 14:09:54 -0700
Quoted 7 lines
The following changes since commit
b0983d3c9b132c33b6fb2e28d157a1edc18a173c:tcp: fix dynamic right sizing (2013-09-24 11:07:32 -0400)
are available in the git repository at:
git://repo.or.cz/linux-2.6/trivial-mods.git20130924_dn_externs_2
Pulled, thanks Joe.