Skip to contentSkip to conversation

A couple of ptest.bbclass fixes

PATCH New Paul Eggleton 1 participant 3 messages Oct 30, 2013

lore
Share & tools
lore
#0 lore raw

cover A couple of ptest.bbclass fixes

The following changes since commit 58ae94f1b06d0e6234413dbf9869bde85f154c85:

recipes: Remove PR = r0 from all recipes (2013-10-30 14:51:34 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib paule/ptest
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/ptest

Paul Eggleton (2):
classes/ptest: do not set EXCLUDE_FROM_WORLD
classes/ptest: fix quoting

 meta/classes/ptest.bbclass | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/2 classes/ptest: do not set EXCLUDE_FROM_WORLD

Various normal recipes that we expect to build during a world build now inherit this class; it cannot therefore set EXCLUDE_FROM_WORLD.

---
 meta/classes/ptest.bbclass | 4 ----
 1 file changed, 4 deletions(-)
meta/classes/ptest.bbclass +0 -4
index d67b4e6..347a681 100644
@@ -1,7 +1,3 @@
-# Ptest packages are built indirectly by a distro_feature,
-# no need for them to be a direct target of 'world'
-EXCLUDE_FROM_WORLD = "1"
-
 SUMMARY_${PN}-ptest ?= "${SUMMARY} - Package test files"
 DESCRIPTION_${PN}-ptest ?= "${DESCRIPTION}  \
 This package contains a test directory ${PTEST_PATH} for package test purposes."
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 2/2 classes/ptest: fix quoting

In reply to Paul Eggleton

BitBake currently allows using the same quotes outside and inside the value, but it isn't really right, looks odd and might stop working in future.

---
 meta/classes/ptest.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/ptest.bbclass +1 -1
index 347a681..508ea9a 100644
@@ -6,7 +6,7 @@ PTEST_PATH ?= "${libdir}/${PN}/ptest"
 FILES_${PN}-ptest = "${PTEST_PATH}"
 SECTION_${PN}-ptest = "devel"
 ALLOW_EMPTY_${PN}-ptest = "1"
-PTEST_ENABLED = "${@base_contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
+PTEST_ENABLED = "${@base_contains('DISTRO_FEATURES', 'ptest', '1', '0', d)}"
 RDEPENDS_${PN}-ptest_virtclass-native = ""
 RDEPENDS_${PN}-ptest_virtclass-nativesdk = ""
 
Signature · 1 line
1.8.1.2