Skip to contentSkip to conversation

lib32-qt4-examples: fix QA warnings and INSANE_SKIP not work

PATCH New Hongxu Jia 1 participant 2 messages Nov 13, 2013

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

cover lib32-qt4-examples: fix QA warnings and INSANE_SKIP not work

The following changes since commit ea92671d9823e3667d6ced7ac2af20f991da404d:

bitbake: cooker: replace "w" file opening mode with "a" mode (2013-11-12 17:01:37 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-qt4-warning
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-qt4-warning

Hongxu Jia (1):
lib32-qt4-examples: fix QA warnings and INSANE_SKIP not work

 meta/recipes-qt/qt4/qt4.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 1/1 lib32-qt4-examples: fix QA warnings and INSANE_SKIP not work

Fix the following warnings:
...
lib32-qt4-examples: found library in wrong location: /usr/bin/qt4/examples/tools/echoplugin/plugin/libechoplugin.so
lib32-qt4-examples: found library in wrong location: /usr/bin/qt4/examples/tools/plugandpaint/plugins/libpnp_extrafilters.so
...

In oe-core f119566477243ce43b727492dc78b9cb3dd76de4, it added INSANE_SKIP libdir for examples packages as it includes plugin shared libraries outside of libdir.

But it hardcoded ${QT_BASE_NAME} as INSANE_SKIP's package name and it didn't work while multilib enabled.

Add ${MLPREFIX} as package name's prefix in INSANE_SKIP

[YOCTO #5516]

---
 meta/recipes-qt/qt4/qt4.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-qt/qt4/qt4.inc +2 -2
index 6adc404..293eb87 100644
@@ -185,8 +185,8 @@ FILES_${QT_BASE_NAME}-xmlpatterns          = "${bindir}/xmlpatterns*"
 FILES_${QT_BASE_NAME}-xmlpatterns-dbg      = "${bindir}/.debug/xmlpatterns*"
 FILES_${QT_BASE_NAME}-qml-plugins          = "${libdir}/${QT_DIR_NAME}/imports/* ${libdir}/${QT_DIR_NAME}/plugins/qmltooling/*"
 FILES_${QT_BASE_NAME}-qml-plugins-dbg      = "${libdir}/${QT_DIR_NAME}/imports/*/*/*/.debug/* ${libdir}/${QT_DIR_NAME}/imports/*/.debug ${libdir}/${QT_DIR_NAME}/plugins/qmltooling/.debug"
-INSANE_SKIP_${QT_BASE_NAME}-examples      += "libdir"
-INSANE_SKIP_${QT_BASE_NAME}-examples-dbg  += "libdir"
+INSANE_SKIP_${MLPREFIX}${QT_BASE_NAME}-examples      += "libdir"
+INSANE_SKIP_${MLPREFIX}${QT_BASE_NAME}-examples-dbg  += "libdir"
 
 # License options, to be set by the recipe if different values are needed
 QT_LICENSE_FILE ?= ""
Signature · 1 line
1.8.1.2