Skip to contentSkip to conversation

Hob: check if warnings are related to package build

PATCH New Valentin Popa 1 participant 2 messages Dec 3, 2013

lore
Share & tools
lore
#0 lore raw

cover Hob: check if warnings are related to package build

The following changes since commit a6450a951fd52d1330c577139dd492f0c8abb1f8:

ref-manual: Added the multilib* class. (2013-12-03 12:53:40 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib vpopa/YOCTO_5621
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=vpopa/YOCTO_5621

Valentin Popa (1):
Hob: check if warnings are related to package build

 bitbake/lib/bb/ui/crumbs/runningbuild.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 Hob: check if warnings are related to package build

If warnings come from recipes parsing
and not from package build, 'parent' object
will be None; so don't update the color for it.

[YOCTO #5621]

---
 bitbake/lib/bb/ui/crumbs/runningbuild.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
bitbake/lib/bb/ui/crumbs/runningbuild.py +4 -4
index 0a48a6b..16a955d 100644
@@ -174,13 +174,13 @@ class RunningBuild (gobject.GObject):
                       color,
                       0))
 
-            # if there are warnings, mark the task with warning
-            # color;
+            # if there are warnings while processing a package
+            #  (parent), mark the task with warning color;
             # in case there are errors, the updates will be
             #  handled on TaskFailed.
-            if color == HobColors.WARNING:
+            if color == HobColors.WARNING and parent:
                 self.model.set(parent, self.model.COL_COLOR, color)
-                if task: #then we have a parent, and update it's color
+                if task: #then we have a parent (package), and update it's color
                     self.model.set(self.tasks_to_iter[(package, None)], self.model.COL_COLOR, color)
 
         elif isinstance(event, bb.build.TaskStarted):
Signature · 1 line
1.8.3.2