Add dependency on kernel headers
cover Add dependency on kernel headers
From: "Yann E. MORIN" <[email protected]>
Hello All!
This series introduces infrastructure for packages to depend on the required version of kernel headers.
It follows the proposal made on the list:
http://lists.busybox.net/pipermail/buildroot/2014-February/088924.html
The basic idea is to add a symbol for each kernel header version, and have toolchains select the appropriate symbol, and packages depend on the appropriate symbol.
In this series:
- such symbols are added for all kernel headers >= 3.0;
- the internal toochain backend selects the appropriate symbol
without user-visible changes;
- the predefined external toolchains select the appropriate symbols without user-visible changes; those using kernel headers older than 3.0, select nothing, and a comment is added to state so;
- for the custom external toolchain, a new choice is shown to the
user, to select the appropriate kernel headers version;
- five packages are converted to take advantage of this.
For example:
- BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1 selects
BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3
- dvb-apps depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3
Regards,
Yann E. MORIN.
----------------------------------------------------------------
Yann E. MORIN (10):
toolchain/common: add minimum kernel headers options
manual: document minimal kernel headers dependency package/linux-headers: select appropriate 'AT_LEAST_XXX' header version toolchain/external: add choice to select 'AT_LEAST_XXX' header version toolchain/external: add choice to select 'AT_LEAST_XXX' header version package/dvb-apps: requires kernel headers >= 3.3 package/w_scan: requires kernel headers >= 3.0 package/weston: requires kernel headers >= 3.0 package/tvheadend: requires kernel headers >= 3.2 package/mmc-utils: requires kernel headers >= 3.0
docs/manual/adding-packages-directory.txt | 6 +++ package/dvb-apps/Config.in | 5 +- package/linux-headers/Config.in.host | 11 +++++ package/mmc-utils/Config.in | 5 +- package/tvheadend/Config.in | 5 +- package/w_scan/Config.in | 4 ++ package/weston/Config.in | 5 +- toolchain/toolchain-common.in | 59 +++++++++++++++++++++++ toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++ toolchain/toolchain-external/Config.in | 34 ++++++++++++++ 10 files changed, 191 insertions(+), 8 deletions(-) create mode 100644 toolchain/toolchain-external/Config-headers.in
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/10 toolchain/common: add minimum kernel headers options
From: "Yann E. MORIN" <[email protected]>
We now have quite a few packages that depend on the kernel headers to be at least a certain version. For example, dvb-apps requires at least the 3.3 kernel headers.
Add a set of options that packages can depend on, to check that the kernel headers match their required version.
---
Notes:
1. We only add those versions already in the internal backend choice, on the assumption that we won't have a package that depends on headers older than the ones we provide ourselves in our internal backend.
This may pose a problem if the user selects (eg.) 2.6.39 as a custom version, and a package would work with those headers. But since we only start with 3.0, the package would not be selectable.
2. This does not address the format of the comment for when a package depends on a specific kernel headers, to come in a following patch.
3. This is not used for now, but will be in the following patches.
--- toolchain/toolchain-common.in | 59 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+)
toolchain/toolchain-common.in +59 -0
@@ -107,3 +107,62 @@ config BR2_ECLIPSE_REGISTER This options tells Buildroot to generate the necessary configuration files to make your toolchain appear within Eclipse, through the Eclipse Buildroot plugin. + +# Options for packages to depend on, if they require at least a +# specific version of the kernel headers. +# Toolchains should choose the adequate option (ie. the highest +# version, not all of them). +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 + bool + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_6 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_6 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11 + +config BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_13 + bool + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
Signature · 1 line
1.8.1.2
PATCH 1/10 toolchain/common: add minimum kernel headers options
Quoted 6 lines · Yann E. MORIN
From: "Yann E. MORIN" <[email protected]>
We now have quite a few packages that depend on the kernel headers to be at least a certain version. For example, dvb-apps requires at least the 3.3 kernel headers.
Quoted 7 lines
Add a set of options that packages can depend on, to check that the kernel headers match their required version.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 2/10 manual: document minimal kernel headers dependency
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
--- docs/manual/adding-packages-directory.txt | 6 ++++++ 1 file changed, 6 insertions(+)
docs/manual/adding-packages-directory.txt +6 -0
@@ -218,6 +218,12 @@ use in the comment. ** Dependency symbol: +BR2_USE_MMU+ ** Comment string: no comment to be added +* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace + +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) +** Comment string: `headers >= X.Y` (replace +X.Y+ with the + proper version) + * C library ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+, +BR2_TOOLCHAIN_USES_UCLIBC+
Signature · 1 line
1.8.1.2
PATCH 2/10 manual: document minimal kernel headers dependency
Hi Yann,
Quoted 16 lines · Yann E. MORIN
From: "Yann E. MORIN" <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Samuel Martin <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>--- docs/manual/adding-packages-directory.txt | 6 ++++++ 1 file changed, 6 insertions(+)docs/manual/adding-packages-directory.txt +0
-0
docs/manual/adding-packages-directory.txt use in the comment. · line 222
Quoted 5 lines
docs/manual/adding-packages-directory.txt +2
-0@@ -218,6 +218,12 @@ use in the comment. ** Dependency symbol: +BR2_USE_MMU+ ** Comment string: no comment to be added +* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace
s/synbol/symbol/
Quoted 10 lines
docs/manual/adding-packages-directory.txt +4
-1+ +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) +** Comment string: `headers >= X.Y` (replace +X.Y+ with the + proper version) + * C library ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+, +BR2_TOOLCHAIN_USES_UCLIBC+ --1.8.1.2
Regards,
Signature · 1 line
Samuel
PATCH 2/10 manual: document minimal kernel headers dependency
Samuel, All,
On 2014-02-16 18:41 +0100, Samuel Martin spake thusly:
Quoted 20 lines · Yann E. MORIN
Quoted 19 lines
From: "Yann E. MORIN" <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Samuel Martin <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>--- docs/manual/adding-packages-directory.txt | 6 ++++++ 1 file changed, 6 insertions(+)docs/manual/adding-packages-directory.txt +0
-0@@ -218,6 +218,12 @@ use in the comment. ** Dependency symbol: +BR2_USE_MMU+ ** Comment string: no comment to be added
Quoted 4 lines
docs/manual/adding-packages-directory.txt use in the comment. · line 222
Quoted 2 lines
docs/manual/adding-packages-directory.txt +2
-0+* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replaces/synbol/symbol/
Fixed! Thank you!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 2/10 manual: document minimal kernel headers dependency
In reply to Yann E. MORIN"Yann E. MORIN" <[email protected]> schreef:
Quoted 16 lines
From: "Yann E. MORIN" <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Samuel Martin <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
docs/manual/adding-packages-directory.txt| 6 ++++++1 file changed, 6 insertions(+)docs/manual/adding-packages-directory.txt +0
-0
docs/manual/adding-packages-directory.txt use in the comment. · line 225
Quoted 8 lines
docs/manual/adding-packages-directory.txt +5
-0@@ -218,6 +218,12 @@ use in the comment. ** Dependency symbol: +BR2_USE_MMU+ ** Comment string: no comment to be added +* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace + +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) +** Comment string: `headers >= X.Y` (replace +X.Y+ with the + proper version)
Are these backticks?
Is there a specific reason you use this instead of single or double quotes?
Best regards,
Thomas
PATCH 2/10 manual: document minimal kernel headers dependency
Thomas, All,
On 2014-02-16 21:03 +0100, Thomas De Schampheleire spake thusly:
Quoted 20 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 19 lines
From: "Yann E. MORIN" <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Samuel Martin <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
docs/manual/adding-packages-directory.txt| 6 ++++++1 file changed, 6 insertions(+)docs/manual/adding-packages-directory.txt +0
-0@@ -218,6 +218,12 @@ use in the comment. ** Dependency symbol: +BR2_USE_MMU+ ** Comment string: no comment to be added
Quoted 8 lines
docs/manual/adding-packages-directory.txt use in the comment. · line 225
Quoted 5 lines
docs/manual/adding-packages-directory.txt +5
-0+* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace + +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) +** Comment string: `headers >= X.Y` (replace +X.Y+ with the + proper version)Are these backticks?
Is there a specific reason you use this instead of single or double quotes?
I just duplicated what wah done for C++, a few lines below.
Lookign at the other comments, it looks like C++ is the only one using backticks, the others use the +blabla+ format.
Will fix bot before submitting again.
Thanks for the review!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 2/10 manual: document minimal kernel headers dependency
"Yann E. MORIN" <[email protected]> schreef:
Quoted 32 lines
Thomas, All,
On 2014-02-16 21:03 +0100, Thomas De Schampheleire spake thusly:
Quoted 20 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 19 lines
From: "Yann E. MORIN" <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Samuel Martin <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
docs/manual/adding-packages-directory.txt| 6 ++++++1 file changed, 6 insertions(+)docs/manual/adding-packages-directory.txt +0
-0@@ -218,6 +218,12 @@ use in the comment. ** Dependency symbol: +BR2_USE_MMU+ ** Comment string: no comment to be addedQuoted 8 lines
docs/manual/adding-packages-directory.txt use in the comment. · line 225
Quoted 5 lines
docs/manual/adding-packages-directory.txt +5
-0+* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace + +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) +** Comment string: `headers >= X.Y` (replace +X.Y+ with the + proper version)Are these backticks?
Is there a specific reason you use this instead of single or double quotes?
Quoted 6 lines
I just duplicated what wah done for C++, a few lines below.
Lookign at the other comments, it looks like C++ is the only one using backticks, the others use the +blabla+ format.
Will fix bot before submitting again.
Ah now I understand again: the pluses in c++ required me to use backticks.
While giving the feedback to you I forgot this was asciidoc syntax, sorry. Then it doesn't really matter...
PATCH 2/10 manual: document minimal kernel headers dependency
Thomas, All,
On 2014-02-16 21:45 +0100, Thomas De Schampheleire spake thusly:
Quoted 3 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 2 lines
On 2014-02-16 21:03 +0100, Thomas De Schampheleire spake thusly:
Quoted 1 line
"Yann E. MORIN" <[email protected]> schreef:
[--SNIP--]
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
docs/manual/adding-packages-directory.txt use in the comment. · line 225
Quoted 5 lines
docs/manual/adding-packages-directory.txt +5
-0+* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace + +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) +** Comment string: `headers >= X.Y` (replace +X.Y+ with the + proper version)Are these backticks?
Is there a specific reason you use this instead of single or double quotes?I just duplicated what wah done for C++, a few lines below.
Quoted 8 lines
Quoted 4 lines
Lookign at the other comments, it looks like C++ is the only one using backticks, the others use the +blabla+ format.
Will fix bot before submitting again.
Ah now I understand again: the pluses in c++ required me to use backticks. While giving the feedback to you I forgot this was asciidoc syntax, sorry. Then it doesn't really matter...
Well, I can just use +foo+ for the headers version, it makes it more in-line with the other comments, C++ is an exception.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 3/10 package/linux-headers: select appropriate 'AT_LEAST_XXX' header version
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
Select the appropriate BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXX options for the internal toolchain backend.
The custom and snapshot options do not select anything:
- snapshot is for a 2.6 kernel (BR2_DEFAULT_KERNEL_HEADERS="2.6" in this case)
- we provide most of post-3.x kernel versions
- custom and snapshot are thus to select a version before 3.0
--- package/linux-headers/Config.in.host | 11 +++++++++++ 1 file changed, 11 insertions(+)
package/linux-headers/Config.in.host +11 -0
@@ -17,42 +17,53 @@ choice config BR2_KERNEL_HEADERS_3_0 bool "Linux 3.0.x kernel headers" depends on !BR2_arc + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 config BR2_KERNEL_HEADERS_3_2 bool "Linux 3.2.x kernel headers" depends on !BR2_arc + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 config BR2_KERNEL_HEADERS_3_4 bool "Linux 3.4.x kernel headers" depends on !BR2_arc + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 config BR2_KERNEL_HEADERS_3_6 bool "Linux 3.6.x kernel headers" depends on BR2_DEPRECATED_SINCE_2013_05 && !BR2_arc + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_6 config BR2_KERNEL_HEADERS_3_7 bool "Linux 3.7.x kernel headers" depends on BR2_DEPRECATED_SINCE_2013_05 && !BR2_arc + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 config BR2_KERNEL_HEADERS_3_8 bool "Linux 3.8.x kernel headers" depends on BR2_DEPRECATED_SINCE_2013_08 && !BR2_arc + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8 config BR2_KERNEL_HEADERS_3_9 bool "Linux 3.9.x kernel headers" depends on BR2_DEPRECATED_SINCE_2013_11 + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9 config BR2_KERNEL_HEADERS_3_10 bool "Linux 3.10.x kernel headers" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10 config BR2_KERNEL_HEADERS_3_11 bool "Linux 3.11.x kernel headers" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11 config BR2_KERNEL_HEADERS_3_12 bool "Linux 3.12.x kernel headers" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 config BR2_KERNEL_HEADERS_3_13 bool "Linux 3.13.x kernel headers" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_13 config BR2_KERNEL_HEADERS_VERSION bool "Manually specified Linux version"
Signature · 1 line
1.8.1.2
PATCH 3/10 package/linux-headers: select appropriate 'AT_LEAST_XXX' header version
Quoted 10 lines · Yann E. MORIN
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the internal toolchain backend.The custom and snapshot options do not select anything:
- snapshot is for a 2.6 kernel (BR2_DEFAULT_KERNEL_HEADERS="2.6" in this case)
- we provide most of post-3.x kernel versions
- custom and snapshot are thus to select a version before 3.0
I'm afraid that the custom and snapshot can also be used in other
situations. I've used it for instance with a 3.4 kernel where there were some vendor-specific additions to the headers.
So to be complete, there should be another choice to select the actual
kernel version just like for the external toolchain...
Regards,
Arnout
Quoted 5 lines
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 3/10 package/linux-headers: select appropriate 'AT_LEAST_XXX' header version
Arnout, All,
On 2014-02-17 23:41 +0100, Arnout Vandecappelle spake thusly:
Quoted 12 lines · Yann E. MORIN
Quoted 10 lines
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the internal toolchain backend.The custom and snapshot options do not select anything:
- snapshot is for a 2.6 kernel (BR2_DEFAULT_KERNEL_HEADERS="2.6" in this case)
- we provide most of post-3.x kernel versions
- custom and snapshot are thus to select a version before 3.0
Quoted 6 lines
I'm afraid that the custom and snapshot can also be used in other
situations. I've used it for instance with a 3.4 kernel where there were some vendor-specific additions to the headers.So to be complete, there should be another choice to select the actual
kernel version just like for the external toolchain...
OK for the "Manually specified Linux version", but the "Local Linux snapshot" is expressly marked as a 2.6 snapshot:
config BR2_KERNEL_HEADERS_SNAP
bool "Local Linux snapshot (linux-2.6.tar.bz2)"
[...]
config BR2_DEFAULT_KERNEL_HEADERS
string
[...]
default "2.6" if BR2_KERNEL_HEADERS_SNAP
So, I'm not a fan of adding this for the snapshot.
I'll respin the series with jsut the manual version change. If we deem it necessary to add it for snapshot too, this can be done in a follow-up patch.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 3/10 package/linux-headers: select appropriate 'AT_LEAST_XXX' header version
Dear Yann E. MORIN,
Quoted 2 lines · Yann E. MORIN
config
BR2_KERNEL_HEADERS_SNAP
bool "Local Linux snapshot (linux-2.6.tar.bz2)"
Don't worry about BR2_KERNEL_HEADERS_SNAP. It should be removed entirely. It is completely weird to ask the tarball to be named exactly linux-2.6.tar.bz2. IMO, we should simply get rid of this feature.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 3/10 package/linux-headers: select appropriate 'AT_LEAST_XXX' header version
Thomas Petazzoni <[email protected]> schreef:
Quoted 10 lines
Dear Yann E. MORIN,
Quoted 2 lines · Yann E. MORIN
config
BR2_KERNEL_HEADERS_SNAP
bool "Local Linux snapshot (linux-2.6.tar.bz2)"Don't worry about
BR2_KERNEL_HEADERS_SNAP. It should be removed entirely. It is completely weird to ask the tarball to be named exactly linux-2.6.tar.bz2. IMO, we should simply get rid of this feature.
Let's do it at once!
PATCH 3/10 package/linux-headers: select appropriate 'AT_LEAST_XXX' header version
Thomas?, All,
On 2014-02-20 22:06 +0100, Thomas De Schampheleire spake thusly:
Quoted 5 lines
Thomas Petazzoni <[email protected]> schreef:
Quoted 4 lines
Dear Yann E. MORIN,
On Thu, 20 Feb 2014 19:16:47 +0100, Yann E. MORIN wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
config
BR2_KERNEL_HEADERS_SNAP
bool "Local Linux snapshot (linux-2.6.tar.bz2)"Don't worry about
BR2_KERNEL_HEADERS_SNAP. It should be removed entirely. It is completely weird to ask the tarball to be named exactly linux-2.6.tar.bz2. IMO, we should simply get rid of this feature.Let's do it at once!
I already have a patch for it in my local tree! ;-)
You can count on me when it comes to removing stuff! :-]
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
Select the appropriate BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXX options for the external, custom toolchain backend.
We try to be conservative here, and default to kernel headers 2.6.x.
--- toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++ toolchain/toolchain-external/Config.in | 2 + 2 files changed, 67 insertions(+) create mode 100644 toolchain/toolchain-external/Config-headers.in
toolchain/toolchain-external/Config-headers.in new file +65 -0
@@ -0,0 +1,65 @@ +choice + bool "External toolchain kernel headers" + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_13 + bool "3.13" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_13 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_12 + bool "3.12" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_11 + bool "3.11" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10 + bool "3.10" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_9 + bool "3.9" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_8 + bool "3.8" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_7 + bool "3.7" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_6 + bool "3.6" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_6 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_5 + bool "3.5" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_4 + bool "3.4" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_3 + bool "3.3" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_2 + bool "3.2" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_1 + bool "3.1" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_0 + bool "3.0" + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 + +config BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD + bool "2.6.x" + +endchoice
toolchain/toolchain-external/Config.in +2 -0
@@ -912,6 +912,8 @@ config BR2_TOOLCHAIN_EXTERNAL_MUSL if BR2_TOOLCHAIN_EXTERNAL_CUSTOM +source "toolchain/toolchain-external/Config-headers.in" + choice prompt "External toolchain C library" default BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
Signature · 1 line
1.8.1.2
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
"Yann E. MORIN" <[email protected]> schreef:
Quoted 23 lines
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the external, custom toolchain backend.We try to be conservative here, and default to kernel headers 2.6.x.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
toolchain/toolchain-external/Config.in | 2 +2 files changed, 67 insertions(+)create mode 100644 toolchain/toolchain-external/Config-headers.in
toolchain/toolchain-external/Config-headers.in new file +0
-0
toolchain/toolchain-external/Config-headers.in line 5
Quoted 5 lines
toolchain/toolchain-external/Config-headers.in new file +5
-0@@ -0,0 +1,65 @@ +choice + bool "External toolchain kernel headers" + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD +
Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
Best regards,
Thomas
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Thomas, All,
On 2014-02-16 21:08 +0100, Thomas De Schampheleire spake thusly:
Quoted 18 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 17 lines
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the external, custom toolchain backend.We try to be conservative here, and default to kernel headers 2.6.x.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
toolchain/toolchain-external/Config.in | 2 +2 files changed, 67 insertions(+)create mode 100644 toolchain/toolchain-external/Config-headers.in
Quoted 15 lines
toolchain/toolchain-external/Config-headers.in line 5
Quoted 11 lines
toolchain/toolchain-external/Config-headers.in new file +5
-0@@ -0,0 +1,65 @@ +choice + bool "External toolchain kernel headers" + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD +Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
I'm not sure I entirely grok your comment. This choice is only visible for external toolchains, not for the internal backend, so there is not two choices to set the kernel headers version.
However, I can indeed add a help entry like that one:
help
Set to the kernel headers version that were used to build the external toolchain.
This is used to hide/show some packages that have strict requirements on the version of kernel headers.
What do you think about that? Does it answers your concerns?
Thanks for the review! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Quoted 37 lines · Yann E. MORIN
Thomas, All,
On 2014-02-16 21:08 +0100, Thomas De Schampheleire spake thusly:
Quoted 18 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 17 lines
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the external, custom toolchain backend.We try to be conservative here, and default to kernel headers 2.6.x.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
toolchain/toolchain-external/Config.in | 2 +2 files changed, 67 insertions(+)create mode 100644 toolchain/toolchain-external/Config-headers.in
Quoted 15 lines
toolchain/toolchain-external/Config-headers.in line 5
Quoted 11 lines
toolchain/toolchain-external/Config-headers.in new file +5
-0@@ -0,0 +1,65 @@ +choice + bool "External toolchain kernel headers" + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD +Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
Quoted 3 lines
I'm not sure I entirely grok your comment. This choice is only visible for external toolchains, not for the internal backend, so there is not two choices to set the kernel headers version.
True, but suppose the user did make the externel toolchain himself, for example with crosstool-ng. While creating the toolchain, he did get the question of which headers to use already, so he/she may think 'Huh? Why do I have to choose it again, and what will happen if I select a newer version here?"
Quoted 11 lines
However, I can indeed add a help entry like that one:
help
Set to the kernel headers version that were used to build the external toolchain.This is used to hide/show some packages that have strict requirements on the version of kernel headers.
What do you think about that? Does it answers your concerns?
Yes, thanks.
Maybe you could also add that if the user is unsure about the exact version, it's 'safer' to specify an older version than a newer one. And maybe a way of determining the header version used in a toolchain, in case the user does not know it.
Best regards,
Thomas
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Dear Thomas De Schampheleire,
Quoted 9 lines · Thomas De Schampheleire
Quoted 3 lines
I'm not sure I entirely grok your comment. This choice is only visible for external toolchains, not for the internal backend, so there is not two choices to set the kernel headers version.
True, but suppose the user did make the externel toolchain himself, for example with crosstool-ng. While creating the toolchain, he did get the question of which headers to use already, so he/she may think 'Huh? Why do I have to choose it again, and what will happen if I select a newer version here?"
This is something we already have for C++, large file, RPC, IPv6 and so on. We have a typical help text for this:
Select this option if your external toolchain has thread support. If you don't know, leave the default value, Buildroot will tell you if it's correct or not.
Quoted 4 lines
Maybe you could also add that if the user is unsure about the exact version, it's 'safer' to specify an older version than a newer one. And maybe a way of determining the header version used in a toolchain, in case the user does not know it.
We should simply have a check that ensures the selection is correct.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Quoted 21 lines · Thomas Petazzoni
Dear Thomas De Schampheleire,
Quoted 9 lines · Thomas De Schampheleire
Quoted 3 lines
I'm not sure I entirely grok your comment. This choice is only visible for external toolchains, not for the internal backend, so there is not two choices to set the kernel headers version.
True, but suppose the user did make the externel toolchain himself, for example with crosstool-ng. While creating the toolchain, he did get the question of which headers to use already, so he/she may think 'Huh? Why do I have to choose it again, and what will happen if I select a newer version here?"
This is something we already have for C++, large file, RPC, IPv6 and so on. We have a typical help text for this:
Select this option if your external toolchain has thread support. If you don't know, leave the default value, Buildroot will tell you if it's correct or not.
Quoted 7 lines
Quoted 4 lines
Maybe you could also add that if the user is unsure about the exact version, it's 'safer' to specify an older version than a newer one. And maybe a way of determining the header version used in a toolchain, in case the user does not know it.
We should simply have a check that ensures the selection is correct.
This was probably answered before, but if we can detect that the selection is incorrect, why don't we set the right value automatically?
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Dear Thomas De Schampheleire,
Quoted 10 lines · Thomas De Schampheleire
Quoted 6 lines
Quoted 4 lines
Maybe you could also add that if the user is unsure about the exact version, it's 'safer' to specify an older version than a newer one. And maybe a way of determining the header version used in a toolchain, in case the user does not know it.
We should simply have a check that ensures the selection is correct.
This was probably answered before, but if we can detect that the selection is incorrect, why don't we set the right value automatically?
Because we need the values within Kconfig, to show/not show the different packages. And while we are in Kconfig, we cannot run commands to test the toolchain that has just been selected by the user. So we need to ask the user what his toolchain looks like, in order to have the correct dependencies for packages. And then at build time, we can check that the configuration selected for the toolchain actually matches the provided toolchain.
This has already been discussed a million times I guess :-)
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
In reply to Thomas PetazzoniThomas P, All,
On 2014-02-17 11:30 +0100, Thomas Petazzoni spake thusly:
Quoted 11 lines · Thomas De Schampheleire
Quoted 10 lines
Quoted 4 lines
I'm not sure I entirely grok your comment. This choice is only visible for external toolchains, not for the internal backend, so there is not two choices to set the kernel headers version.
True, but suppose the user did make the externel toolchain himself, for example with crosstool-ng. While creating the toolchain, he did get the question of which headers to use already, so he/she may think 'Huh? Why do I have to choose it again, and what will happen if I select a newer version here?"
[--SNIP--]
Quoted 6 lines
Quoted 4 lines
Maybe you could also add that if the user is unsure about the exact version, it's 'safer' to specify an older version than a newer one. And maybe a way of determining the header version used in a toolchain, in case the user does not know it.
We should simply have a check that ensures the selection is correct.
Yes, I already added such a check later after sending the series. It will be part of the next submission.
Basically, I check that the specified headers version is no more recent than the one actually used in the toolchain.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Dear Yann E. MORIN,
Quoted 5 lines · Yann E. MORIN
Yes, I already added such a check later after sending the series. It will be part of the next submission.
Basically, I check that the specified headers version is no more recent than the one actually used in the toolchain.
I think the specified headers version should match the one actually used in the toolchain. Otherwise, the user may have messages such as "package foo needs headers >= 3.3" even if he is using a toolchain with kernel headers of kernel 3.6.
This behavior would also match what we currently do: if a toolchain has thread support, but the user forgets to indicate in menuconfig that the toolchain has thread support, then we abort with an error. Even if technically speaking, we could simply continue, since building a configuration with no thread support would work entirely fine with a toolchain that has thread support.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Quoted 15 lines · Thomas Petazzoni
Dear Yann E. MORIN,
Quoted 5 lines · Yann E. MORIN
Yes, I already added such a check later after sending the series. It will be part of the next submission.
Basically, I check that the specified headers version is no more recent than the one actually used in the toolchain.
I think the specified headers version should match the one actually used in the toolchain. Otherwise, the user may have messages such as "package foo needs headers >= 3.3" even if he is using a toolchain with kernel headers of kernel 3.6.
Quoted 6 lines
This behavior would also match what we currently do: if a toolchain has thread support, but the user forgets to indicate in menuconfig that the toolchain has thread support, then we abort with an error. Even if technically speaking, we could simply continue, since building a configuration with no thread support would work entirely fine with a toolchain that has thread support.
+1
Regards,
Arnout
Quoted 5 lines
Best regards,
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
In reply to Thomas De SchampheleireThomas DS, All,
On 2014-02-17 09:07 +0100, Thomas De Schampheleire spake thusly:
Quoted 2 lines · Yann E. MORIN
Quoted 1 line
On 2014-02-16 21:08 +0100, Thomas De Schampheleire spake thusly:
[--SNIP--]
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
I'm not sure I entirely grok your comment. This choice is only visible for external toolchains, not for the internal backend, so there is not two choices to set the kernel headers version.
Quoted 5 lines
True, but suppose the user did make the externel toolchain himself, for example with crosstool-ng. While creating the toolchain, he did get the question of which headers to use already, so he/she may think 'Huh? Why do I have to choose it again, and what will happen if I select a newer version here?"
OK, I was not sure that was what you meant. Agreed.
Quoted 6 lines
Quoted 6 lines
However, I can indeed add a help entry like that one:
help
Set to the kernel headers version that were used to build the external toolchain.
Quoted 8 lines
Quoted 4 lines
This is used to hide/show some packages that have strict requirements on the version of kernel headers.
What do you think about that? Does it answers your concerns?
Yes, thanks.
Maybe you could also add that if the user is unsure about the exact version, it's 'safer' to specify an older version than a newer one.
OK.
Quoted 2 lines
And maybe a way of determining the header version used in a toolchain, in case the user does not know it.
OK.
Thank you!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
In reply to Thomas De SchampheleireQuoted 18 lines · Thomas De Schampheleire
"Yann E. MORIN" <[email protected]> schreef:
Quoted 17 lines
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the external, custom toolchain backend.We try to be conservative here, and default to kernel headers 2.6.x.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
toolchain/toolchain-external/Config.in | 2 +2 files changed, 67 insertions(+)create mode 100644 toolchain/toolchain-external/Config-headers.in
Quoted 13 lines
toolchain/toolchain-external/Config-headers.in line 5
Quoted 11 lines
toolchain/toolchain-external/Config-headers.in new file +5
-0@@ -0,0 +1,65 @@ +choice + bool "External toolchain kernel headers" + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD +Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
Note, however, that you can't add help text to a choice. So the only
option is to add the text to every choice option.
Ah, the limitations of Kconfig...
Regards,
Arnout
Quoted 5 lines
Best regards,
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Arnout, All,
On 2014-02-17 23:45 +0100, Arnout Vandecappelle spake thusly:
Quoted 33 lines · Thomas De Schampheleire
Quoted 18 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 17 lines
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the external, custom toolchain backend.We try to be conservative here, and default to kernel headers 2.6.x.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
toolchain/toolchain-external/Config.in | 2 +2 files changed, 67 insertions(+)create mode 100644 toolchain/toolchain-external/Config-headers.in
Quoted 13 lines
toolchain/toolchain-external/Config-headers.in line 5
Quoted 11 lines
toolchain/toolchain-external/Config-headers.in new file +5
-0@@ -0,0 +1,65 @@ +choice + bool "External toolchain kernel headers" + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD +Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
Quoted 2 lines
Note, however, that you can't add help text to a choice. So the only
option is to add the text to every choice option.
Wrong. Just try... ;-)
Quoted 1 line
Ah, the limitations of
Kconfig...
You talking to me? You talking to me? :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 4/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Quoted 36 lines · Yann E. MORIN
Arnout, All,
On 2014-02-17 23:45 +0100, Arnout Vandecappelle spake thusly:
Quoted 33 lines · Thomas De Schampheleire
Quoted 31 lines
"Yann E. MORIN" <[email protected]> schreef:
Quoted 23 lines
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the external, custom toolchain backend.We try to be conservative here, and default to kernel headers 2.6.x.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>---
toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
toolchain/toolchain-external/Config.in | 2 +2 files changed, 67 insertions(+)create mode 100644 toolchain/toolchain-external/Config-headers.in
toolchain/toolchain-external/Config-headers.in new file +0
-0toolchain/toolchain-external/Config-headers.in line 5
Quoted 5 lines
toolchain/toolchain-external/Config-headers.in new file +5
-0@@ -0,0 +1,65 @@ +choice + bool "External toolchain kernel headers" + depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM + default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD +Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?
Quoted 4 lines
Quoted 2 lines
Note, however, that you can't add help text to a choice. So the only
option is to add the text to every choice option.Wrong. Just try... ;-)
Duh, I was so convinced of that... I think I've given that feedback in
other reviews as well...
Regards,
Arnout
Quoted 8 lines
Quoted 2 lines
Ah, the limitations of
Kconfig...You talking to me? You talking to me? :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 5/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
Select the appropriate BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXX options for the external, pre-defined toolchains.
Also annotate those toolchain with older-than-3.0 headers.
--- toolchain/toolchain-external/Config.in | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
toolchain/toolchain-external/Config.in +32 -0
@@ -17,6 +17,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_2013_11 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1 help Linaro toolchain for the ARM architecture. It uses Linaro GCC 2013.11 (based on gcc 4.8), Linaro GDB 2013.10 (based on
@@ -39,6 +40,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_2013_10 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1 help Linaro toolchain for the ARM architecture. It uses Linaro GCC 2013.10 (based on gcc 4.8), Linaro GDB 2013.10 (based on
@@ -61,6 +63,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_2013_09 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1 help Linaro toolchain for the ARM architecture. It uses Linaro GCC 2013.09 (based on gcc 4.8), Linaro GDB 2013.05 (based on
@@ -87,6 +90,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201311 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11 help Sourcery CodeBench toolchain for the ARM architecture, from Mentor Graphics. It uses gcc 4.8.1, binutils 2.23.52, glibc
@@ -113,6 +117,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201305 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8 help Sourcery CodeBench toolchain for the ARM architecture, from Mentor Graphics. It uses gcc 4.7.3, binutils 2.23.52, glibc
@@ -139,6 +144,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201203 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 help Sourcery CodeBench toolchain for the ARM architecture, from Mentor Graphics. It uses gcc 4.6.3, binutils 2.21.53, glibc
@@ -172,6 +178,7 @@ config BR2_TOOLCHAIN_EXTERNAL_ARAGO_ARMV7A_201109 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + # kernel headers: 2.6.31 help Texas Instruments Arago 2011.09 toolchain, with gcc 4.5.3, binutils 2.20.1, glibc 2.12, gdb 7.2.
@@ -195,6 +202,7 @@ config BR2_TOOLCHAIN_EXTERNAL_ARAGO_ARMV5TE_201109 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + # kernel headers: 2.6.31 help Texas Instruments Arago ARMv5 2011.09 toolchain, with gcc 4.5.3, binutils 2.20.1, glibc 2.12, gdb 7.2.
@@ -211,6 +219,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS201311 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11 help Sourcery CodeBench toolchain for the MIPS architecture, from Mentor Graphics. It uses gcc 4.8.1, binutils 2.23.52, glibc
@@ -279,6 +288,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS201305 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8 help Sourcery CodeBench toolchain for the MIPS architecture, from Mentor Graphics. It uses gcc 4.7.3, binutils 2.23.52, glibc
@@ -347,6 +357,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS201209 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5 help Sourcery CodeBench toolchain for the MIPS architecture, from Mentor Graphics. It uses gcc 4.7.2, binutils 2.23.51, glibc
@@ -418,6 +429,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 help Sourcery CodeBench toolchain for the Nios-II architecture, from Mentor Graphics. It uses gcc 4.7.3, binutils 2.23.52,
@@ -432,6 +444,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + # kernel headers: 2.6.38 help Sourcery CodeBench toolchain for the PowerPC architecture, from Mentor Graphics. It uses gcc 4.5.2, binutils 2.20.51,
@@ -463,6 +476,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + # kernel headers: 2.6.35 help Sourcery CodeBench toolchain for the PowerPC architecture, from Mentor Graphics. It uses gcc 4.5.1, binutils 2.20,
@@ -494,6 +508,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201209 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5 help Sourcery CodeBench toolchain for the SuperH architecture, from Mentor Graphics. It uses gcc 4.7.2, binutils 2.23.51,
@@ -516,6 +531,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201203 select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 help Sourcery CodeBench toolchain for the SuperH architecture, from Mentor Graphics. It uses gcc 4.6.3, binutils 2.21.53,
@@ -539,6 +555,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH201103 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + # kernel headers: 2.6.38 help Sourcery CodeBench toolchain for the SuperH architecture, from Mentor Graphics. It uses gcc 4.5.2, binutils 2.20,
@@ -565,6 +582,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103 select BR2_TOOLCHAIN_HAS_THREADS_DEBUG select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + # kernel headers: 2.6.38 help Sourcery CodeBench toolchain for the SuperH architecture, from Mentor Graphics. It uses gcc 4.5.2, binutils 2.20,
@@ -584,6 +602,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009 select BR2_TOOLCHAIN_HAS_THREADS_DEBUG select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + # kernel headers: 2.6.35 help Sourcery CodeBench toolchain for the SuperH architecture, from Mentor Graphics. It uses gcc 4.5.1, binutils 2.20,
@@ -601,6 +620,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201209 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5 help Sourcery CodeBench toolchain for the x86/x86_64 architectures, from Mentor Graphics. It uses gcc 4.7.2,
@@ -626,6 +646,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201203 select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 help Sourcery CodeBench toolchain for the x86/x86_64 architectures, from Mentor Graphics. It uses gcc 4.6.3,
@@ -652,6 +673,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201109 select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 help Sourcery CodeBench toolchain for the x86/x86_64 architectures, from Mentor Graphics. It uses gcc 4.6.1,
@@ -681,6 +703,7 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 select BR2_TOOLCHAIN_HAS_THREADS select BR2_TOOLCHAIN_HAS_THREADS_DEBUG select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10 help Toolchain for the Blackfin architecture, from http://blackfin.uclinux.org.
@@ -698,6 +721,7 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 select BR2_TOOLCHAIN_HAS_THREADS select BR2_TOOLCHAIN_HAS_THREADS_DEBUG select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5 help Toolchain for the Blackfin architecture, from http://blackfin.uclinux.org.
@@ -715,6 +739,7 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1 select BR2_TOOLCHAIN_HAS_THREADS select BR2_TOOLCHAIN_HAS_THREADS_DEBUG select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 help Toolchain for the Blackfin architecture, from http://blackfin.uclinux.org.
@@ -728,6 +753,7 @@ config BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEEL_14_3 select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 help Toolchain for the Microblaze architecture, from http://git.xilinx.com/?p=microblaze-gnu.git;a=tree;f=binaries. It
@@ -741,6 +767,7 @@ config BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEEL_V2 depends on BR2_DEPRECATED_SINCE_2014_02 select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_TOOLCHAIN_HAS_NATIVE_RPC + # kernel headers: 2.6.37 help Toolchain for the Microblaze architecture, from http://wiki.xilinx.com/mb-gnu-tools
@@ -754,6 +781,7 @@ config BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEBE_14_3 select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_HOSTARCH_NEEDS_IA32_LIBS + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 help Toolchain for the Microblaze architecture, from http://git.xilinx.com/?p=microblaze-gnu.git;a=tree;f=binaries. It
@@ -767,6 +795,7 @@ config BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEBE_V2 depends on BR2_DEPRECATED_SINCE_2014_02 select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_TOOLCHAIN_HAS_NATIVE_RPC + # kernel headers: 2.6.37 help Toolchain for the Microblaze architecture, from http://wiki.xilinx.com/mb-gnu-tools
@@ -780,6 +809,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_11 select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS select BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 help Toolchain for the AArch64 architecture, from http://www.linaro.org/engineering/armv8/
@@ -793,6 +823,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_10 select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS select BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 help Toolchain for the AArch64 architecture, from http://www.linaro.org/engineering/armv8/
@@ -806,6 +837,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_09 select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS select BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 help Toolchain for the AArch64 architecture, from http://www.linaro.org/engineering/armv8/
Signature · 1 line
1.8.1.2
PATCH 5/10 toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Quoted 11 lines · Yann E. MORIN
From: "Yann E. MORIN" <[email protected]>
Select the appropriate
BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXXoptions for the external, pre-defined toolchains.Also annotate those toolchain with older-than-3.0 headers.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Arnout Vandecappelle <[email protected]>Cc Thomas De Schampheleire <[email protected]>
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 6/10 package/dvb-apps: requires kernel headers >= 3.3
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
dvb-apps requires linux kernel headers >= 3.3, for:
SYS_TURBO, SYS_DVBC_ANNEX_A : introduced in 3.2
SYS_DVBC_ANNEX_C, DTV_ENUM_DELSYS: introduced in 3.3
Fixes:
http://autobuild.buildroot.net/results/a77/a7786dffa28e5472fbc9c8fe4ab302c84d7a3cb9
--- package/dvb-apps/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
package/dvb-apps/Config.in +3 -2
@@ -8,13 +8,14 @@ config BR2_PACKAGE_DVB_APPS if BR2_PACKAGE_DVB_APPS -comment "dvb-apps utils needs a toolchain w/ largefile, threads" - depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS +comment "dvb-apps utils needs a toolchain w/ largefile, threads, headers >= 3.3" + depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 config BR2_PACKAGE_DVB_APPS_UTILS bool "dvb-apps utilities" depends on BR2_LARGEFILE depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help A small number of DVB test and utility programs,
Signature · 1 line
1.8.1.2
PATCH 6/10 package/dvb-apps: requires kernel headers >= 3.3
Quoted 19 lines · Yann E. MORIN
From: "Yann E. MORIN" <[email protected]>
dvb-apps requires linux kernel headers >= 3.3, for:
SYS_TURBO,SYS_DVBC_ANNEX_A: introduced in 3.2
SYS_DVBC_ANNEX_C,DTV_ENUM_DELSYS: introduced in 3.3Fixes:
http://autobuild.buildroot.net/results/a77/a7786dffa28e5472fbc9c8fe4ab302c84d7a3cb9Signed-off-by "Yann E. MORIN" <[email protected]>--- package/dvb-apps/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)package/dvb-apps/Config.in +0
-0
package/dvb-apps/Config.in config BR2_PACKAGE_DVB_APPS · line 11
Quoted 6 lines
package/dvb-apps/Config.in +1
-2@@ -8,13 +8,14 @@ config BR2_PACKAGE_DVB_APPS if BR2_PACKAGE_DVB_APPS -comment "dvb-apps utils needs a toolchain w/ largefile, threads" - depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS +comment "dvb-apps utils needs a toolchain w/ largefile, threads, headers >= 3.3"
Note that on a 80-column display it already breaks off after threads.
How do we deal with that in general? Split over two comments, or ignore?
Regards,
Arnout
Quoted 11 lines
package/dvb-apps/Config.in +2
-0+ depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 config BR2_PACKAGE_DVB_APPS_UTILS bool "dvb-apps utilities" depends on BR2_LARGEFILE depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3 select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help A small number of DVB test and utility programs,
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 6/10 package/dvb-apps: requires kernel headers >= 3.3
Arnout, All,
On 2014-02-17 23:51 +0100, Arnout Vandecappelle spake thusly:
Quoted 21 lines · Yann E. MORIN
Quoted 20 lines
From: "Yann E. MORIN" <[email protected]>
dvb-apps requires linux kernel headers >= 3.3, for:
SYS_TURBO,SYS_DVBC_ANNEX_A: introduced in 3.2
SYS_DVBC_ANNEX_C,DTV_ENUM_DELSYS: introduced in 3.3Fixes:
http://autobuild.buildroot.net/results/a77/a7786dffa28e5472fbc9c8fe4ab302c84d7a3cb9Signed-off-by "Yann E. MORIN" <[email protected]>--- package/dvb-apps/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)package/dvb-apps/Config.in +0
-0@@ -8,13 +8,14 @@ config BR2_PACKAGE_DVB_APPS
Quoted 8 lines
package/dvb-apps/Config.in config BR2_PACKAGE_DVB_APPS · line 11
Quoted 5 lines
package/dvb-apps/Config.in +1
-2if BR2_PACKAGE_DVB_APPS -comment "dvb-apps utils needs a toolchain w/ largefile, threads" - depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS +comment "dvb-apps utils needs a toolchain w/ largefile, threads, headers >= 3.3"Note that on a 80-column display it already breaks off after threads.
How do we deal with that in general? Split over two comments, or ignore?
I would not like to see multi-line comments.
I am of the opinion that we do our best to work with small terminals, but do not be over-zealous on enforcing this.
After all, we're in the third millenium, now. 80-char-wide terminals are so second millenium! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 7/10 package/w_scan: requires kernel headers >= 3.0
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
It needs DVB API version 5.3 or later, introduced in linux 3.0.
Fixes:
http://autobuild.buildroot.net/results/6e7/6e7c691099a8f3eef4fc84860ceb1a94f25873eb
--- package/w_scan/Config.in | 4 ++++ 1 file changed, 4 insertions(+)
package/w_scan/Config.in +4 -0
@@ -1,5 +1,9 @@ +comment "w_scan needs a toolchain w/ headers >= 3.0" + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 + config BR2_PACKAGE_W_SCAN bool "w_scan" + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help w_scan is a small command line utility used to perform frequency
Signature · 1 line
1.8.1.2
PATCH 8/10 package/weston: requires kernel headers >= 3.0
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
It needs K_OFF, introduced in 2.6.39.
Since we do not have dependencies on kernel headers before 3.0, just depend on kernel headers 3.0.
Fixes:
http://autobuild.buildroot.net/results/aa5/aa54b1aaf0ac89531d7a1e7dd3900b35605ae3f5
--- package/weston/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
package/weston/Config.in +3 -2
@@ -1,6 +1,6 @@ -comment "weston needs udev and a toolchain w/ threads" +comment "weston needs udev and a toolchain w/ threads, headers >= 3.0" depends on !BR2_avr32 - depends on !BR2_PACKAGE_UDEV || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_PACKAGE_UDEV || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 config BR2_PACKAGE_WESTON bool "weston"
@@ -14,6 +14,7 @@ config BR2_PACKAGE_WESTON depends on BR2_PACKAGE_UDEV depends on !BR2_avr32 # wayland depends on BR2_TOOLCHAIN_HAS_THREADS # wayland + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # Runtime dependency select BR2_PACKAGE_XKEYBOARD_CONFIG # Make sure at least one compositor is selected.
Signature · 1 line
1.8.1.2
PATCH 9/10 package/tvheadend: requires kernel headers >= 3.2
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
tvheadend requires SYS_TURBO, introduced in linux 3.2.
Fixes:
http://autobuild.buildroot.net/results/4df/4df8cd85e0287910567df81c0394b2914570e98a
--- package/tvheadend/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
package/tvheadend/Config.in +3 -2
@@ -1,7 +1,7 @@ -comment "tvheadend needs a toolchain w/ largefile, IPv6, threads" +comment "tvheadend needs a toolchain w/ largefile, IPv6, threads, headers >= 3.2" depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD - depends on !BR2_LARGEFILE || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_LARGEFILE || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 config BR2_PACKAGE_TVHEADEND bool "tvheadend"
@@ -17,6 +17,7 @@ config BR2_PACKAGE_TVHEADEND depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD # no NPTL for these archs depends on !BR2_xtensa && !BR2_arc + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 select BR2_PACKAGE_DVB_APPS select BR2_PACKAGE_OPENSSL help
Signature · 1 line
1.8.1.2
PATCH 10/10 package/mmc-utils: requires kernel headers >= 3.0
In reply to Yann E. MORINFrom: "Yann E. MORIN" <[email protected]>
mmc-utils needs the mmc ioctls, introduced in linux 3.0.
Fixes:
http://autobuild.buildroot.net/results/0c1/0c15e2b193418c6f0edbc98a6ea3957bdf71a98b
--- package/mmc-utils/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
package/mmc-utils/Config.in +3 -2
@@ -1,10 +1,11 @@ config BR2_PACKAGE_MMC_UTILS bool "mmc-utils" depends on BR2_LARGEFILE + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 help MMC utils https://git.kernel.org/cgit/linux/kernel/git/cjb/mmc-utils.git -comment "mmc-utils needs a toolchain w/ largefile" - depends on !BR2_LARGEFILE +comment "mmc-utils needs a toolchain w/ largefile, headers >= 3.0" + depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
Signature · 1 line
1.8.1.2
cover Add dependency on kernel headers
In reply to Yann E. MORINHello All!
On 2014-02-16 18:27 +0100, Yann E. MORIN spake thusly:
Quoted 17 lines
This series introduces infrastructure for packages to depend on the required version of kernel headers.
It follows the proposal made on the list:
http://lists.busybox.net/pipermail/buildroot/2014-February/088924.htmlThe basic idea is to add a symbol for each kernel header version, and have toolchains select the appropriate symbol, and packages depend on the appropriate symbol.
In this series:
- such symbols are added for all kernel headers >= 3.0;
- the internal toochain backend selects the appropriate symbol
without user-visible changes;
Quoted 8 lines
- the predefined external toolchains select the appropriate symbols without user-visible changes; those using kernel headers older than 3.0, select nothing, and a comment is added to state so;
- for the custom external toolchain, a new choice is shown to the
user, to select the appropriate kernel headers version;- five packages are converted to take advantage of this.
There is one thing this series does not do: ensure the selection is correct, by way of a new 'check_headers_version' herlper in toolchain/helpers.mk.
This can be added later, or in a second iteration of the series, if need be.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'