dbus: fix a hard dependency about dbus-ptest

PATCH Superseded Chong Lu 4 participants 7 messages Mar 19, 2014 – Apr 4, 2014

lore

Share & tools

lore

Chong Lu

author

2014-03-19 02:00 UTC #0 lore raw

v3 cover dbus: fix a hard dependency about dbus-ptest

Changes since V2:

PACKAGES is conditional on DISTRO_FEATURES containing ptest. Modify ${PN}-ptest to dbus-ptest.
Remove RPROVIDES_dbus-ptest.

The following changes since commit 0150bc30d3674301631c2e9b6c64e01058fd1070:

bitbake: runqueue: Really fix sigchld handling (2014-03-18 23:05:53 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib chonglu/dbus
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/dbus

Chong Lu (1):
dbus: fix a hard dependency about dbus-ptest

 meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
 meta/recipes-core/dbus/dbus.inc                                      | 4 +++-
 2 files changed, 3 insertions(+), 1 deletion(-)
 rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)

Signature · 1 line

1.8.1.2

Chong Lu

author

2014-03-19 02:00 UTC #1 lore raw

PATCH v3 1/1 dbus: fix a hard dependency about dbus-ptest

If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This issue will increase size for most small images.
This patch fixes this problem.

[YOCTO #5702]

Signed-off-by Chong Lu <[email protected]>

---
 meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
 meta/recipes-core/dbus/dbus.inc                                      | 4 +++-
 2 files changed, 3 insertions(+), 1 deletion(-)
 rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)

meta/recipes-core/dbus/dbus-test_1.6.18.bb renamed from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb +0 -0

similarity index 100%
rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb

meta/recipes-core/dbus/dbus.inc +3 -1

index 677ff78..6059e7c 100644
@@ -6,9 +6,11 @@ LICENSE = "AFL-2 | GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
                     file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
 DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}"
 RDEPENDS_dbus_class-native = ""
 RDEPENDS_dbus_class-nativesdk = ""
+PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
+ALLOW_EMPTY_dbus-ptest = "1"
+RDEPENDS_dbus-ptest = "dbus-test-ptest"
 
 SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
            file://tmpdir.patch \

Signature · 1 line

1.8.1.2

Burton, Ross

Reviewed-by on v3 1/1

2014-03-19 11:59 UTC #2 lore raw

Quoted 4 lines · Chong Lu

If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This issue will increase size for most small images.
This patch fixes this problem.

Reviewed-by Ross Burton <[email protected]>

Ross

Chong Lu

author

2014-04-01 01:20 UTC #3 lore raw

Ping

Quoted 9 lines · Ross

Quoted 4 lines · Chong Lu
If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This issue will increase size for most small images.
This patch fixes this problem.
Reviewed-by Ross Burton <[email protected]>
Ross

Saul Wold

2014-04-03 20:32 UTC #4 lore raw

In reply to Chong Lu

Quoted 23 lines · Chong Lu

If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This issue will increase size for most small images.
This patch fixes this problem.
[YOCTO #5702]
Signed-off-by Chong Lu <[email protected]>
---
  meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
  meta/recipes-core/dbus/dbus.inc                                      | 4 +++-
  2 files changed, 3 insertions(+), 1 deletion(-)
rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)
meta/recipes-core/dbus/dbus-test_1.6.18.bb renamed from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb +0 -0
similarity index 100%
rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
meta/recipes-core/dbus/dbus.inc +0 -0
index 677ff78..6059e7c 100644

meta/recipes-core/dbus/dbus.inc LICENSE = "AFL-2 | GPLv2+" · line 13

Quoted 9 lines

meta/recipes-core/dbus/dbus.inc +3 -1

@@ -6,9 +6,11 @@ LICENSE = "AFL-2 | GPLv2+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
                      file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
  DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}"
  RDEPENDS_dbus_class-native = ""
  RDEPENDS_dbus_class-nativesdk = ""
+PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
+ALLOW_EMPTY_dbus-ptest = "1"
+RDEPENDS_dbus-ptest = "dbus-test-ptest"

Seems like this is still causing some issues

Quoted 5 lines

meta/recipes-core/dbus/dbus.inc +0 -0
 ERROR: Nothing RPROVIDES 'nativesdk-dbus-test-ptest' (but virtual:nativesdk:/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-intel-gpl/build/meta/recipes-core/dbus/dbus_1.6.18.bb RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'nativesdk-dbus-test-ptest' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['nativesdk-dbus-test-ptest']
ERROR: Required build target 'nativesdk-qt4-tools' has no buildable providers.
Missing or unbuildable dependency chain was: ['nativesdk-qt4-tools', 'nativesdk-dbus', 'nativesdk-dbus-test-ptest']

As seen in this AB Failure: http://autobuilder.yoctoproject.org/main/builders/nightly-intel-gpl/builds/30/steps/BuildImages/logs/stdio

Sau!

Quoted 4 lines

  SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
             file://tmpdir.patch \

Chong Lu

author

2014-04-04 06:09 UTC #5 lore raw

Quoted 48 lines · Saul Wold

Quoted 35 lines · Chong Lu
If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This issue will increase size for most small images.
This patch fixes this problem.
[YOCTO #5702]
Signed-off-by Chong Lu <[email protected]>
---
meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb =>
dbus-test_1.6.18.bb} | 0
meta/recipes-core/dbus/dbus.inc | 4 +++-
  2 files changed, 3 insertions(+), 1 deletion(-)
rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb =>
dbus-test_1.6.18.bb} (100%)
meta/recipes-core/dbus/dbus-test_1.6.18.bb renamed from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb +0 -0
similarity index 100%
rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
meta/recipes-core/dbus/dbus.inc +0 -0
index 677ff78..6059e7c 100644
@@ -6,9 +6,11 @@ LICENSE = "AFL-2 | GPLv2+"
  LIC_FILES_CHKSUM = 
 "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}"
RDEPENDS_dbus_class-native = ""
RDEPENDS_dbus_class-nativesdk = ""
+PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
meta/recipes-core/dbus/dbus.inc LICENSE = "AFL-2 | GPLv2+" · line 13
Quoted 2 lines
meta/recipes-core/dbus/dbus.inc +2 -0
+ALLOW_EMPTY_dbus-ptest = "1"
+RDEPENDS_dbus-ptest = "dbus-test-ptest"
Seems like this is still causing some issues
Quoted 5 lines
ERROR: Nothing RPROVIDES 'nativesdk-dbus-test-ptest' (but virtual:nativesdk:/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-intel-gpl/build/meta/recipes-core/dbus/dbus_1.6.18.bb RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'nativesdk-dbus-test-ptest' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['nativesdk-dbus-test-ptest']
ERROR: Required build target 'nativesdk-qt4-tools' has no buildable providers.
Missing or unbuildable dependency chain was: ['nativesdk-qt4-tools', 'nativesdk-dbus', 'nativesdk-dbus-test-ptest']

Quoted 5 lines

As seen in this AB Failure: http://autobuilder.yoctoproject.org/main/builders/nightly-intel-gpl/builds/30/steps/BuildImages/logs/stdio
Sau!

Hi Saul,

I built core-image-sato-sdk after applied my patch. I didn't see error. Can you tell me how to reproduce your building errors?

Best Regards
Chong

Quoted 10 lines

Quoted 8 lines

SRC_URI =

"http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
             file://tmpdir.patch \

Paul Eggleton

2014-04-04 10:43 UTC #6 lore raw

Quoted 69 lines · On Friday 04 April 2014 14:09:09 Chong Lu wrote:

Quoted 68 lines · Saul Wold
Quoted 49 lines · Chong Lu
If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package
is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This
issue will increase size for most small images.
This patch fixes this problem.
[YOCTO #5702]
Signed-off-by Chong Lu <[email protected]>
---
meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb =>
dbus-test_1.6.18.bb} | 0
meta/recipes-core/dbus/dbus.inc | 4 +++-
  2 files changed, 3 insertions(+), 1 deletion(-)
rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb =>
dbus-test_1.6.18.bb} (100%)
meta/recipes-core/dbus/dbus-test_1.6.18.bb renamed from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb +0 -0
similarity index 100%
rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
meta/recipes-core/dbus/dbus.inc +0 -0
index 677ff78..6059e7c 100644
@@ -6,9 +6,11 @@ LICENSE = "AFL-2 | GPLv2+"
 
  LIC_FILES_CHKSUM =
 
 "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a97453 8bb3c">>
DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}"
RDEPENDS_dbus_class-native = ""
RDEPENDS_dbus_class-nativesdk = ""
+PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
meta/recipes-core/dbus/dbus.inc LICENSE = "AFL-2 | GPLv2+" · line 13
Quoted 2 lines
meta/recipes-core/dbus/dbus.inc +2 -0
+ALLOW_EMPTY_dbus-ptest = "1"
+RDEPENDS_dbus-ptest = "dbus-test-ptest"
Seems like this is still causing some issues
Quoted 12 lines
ERROR: Nothing RPROVIDES 'nativesdk-dbus-test-ptest' (but virtual:nativesdk:/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-i ntel-gpl/build/meta/recipes-core/dbus/dbus_1.6.18.bb RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'nativesdk-dbus-test-ptest' is unbuildable, removing...
Missing or unbuildable dependency chain was:
['nativesdk-dbus-test-ptest']
ERROR: Required build target 'nativesdk-qt4-tools' has no buildable providers.
Missing or unbuildable dependency chain was: ['nativesdk-qt4-tools', 'nativesdk-dbus', 'nativesdk-dbus-test-ptest']

Quoted 6 lines

Quoted 3 lines
As seen in this AB Failure:
http://autobuilder.yoctoproject.org/main/builders/nightly-intel-gpl/builds
/30/steps/BuildImages/logs/stdio
I built core-image-sato-sdk after applied my patch. I didn't see error. Can you tell me how to reproduce your building errors?

You'd need to try to build nativesdk-dbus - "bitbake nativesdk-dbus" should be able to reproduce this.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre