Skip to contentSkip to conversation

Toaster web fixes

PATCH New Paul Eggleton 1 participant 3 messages Apr 11, 2014

lore
Share & tools
lore

Paul Eggleton

author
#0 lore raw

cover Toaster web fixes

The following changes since commit bb4980c63db386ce7d30d9a6b86e9f3861b3bc3a:

bitbake: Update to version 1.23.0 for master (2014-04-10 17:55:41 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib paule/toasterfixes4
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/toasterfixes4

Belen Barros Pena (2):
bitbake: toaster: Fix total number of tasks in build dashboard
bitbake: toaster: Fix Empty tasks filter

 lib/toaster/toastergui/templates/builddashboard.html | 2 +-
 lib/toaster/toastergui/views.py                      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.0
author
#1 lore raw

PATCH 1/2 bitbake: toaster: Fix total number of tasks in build dashboard

From: Belen Barros Pena <[email protected]>

The total number of tasks in the build dashboard was counting _setscene tasks, which are not exposed by Toaster as separate tasks. This patch makes sure that _setscene tasks are not counted when calculating that number.

[YOCTO #6145]

Signed-off-by Belen Barros Pena <[email protected]>
---
 lib/toaster/toastergui/templates/builddashboard.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/toaster/toastergui/templates/builddashboard.html +1 -1
index fa4b194..a01ef3d 100644
@@ -125,7 +125,7 @@
     <div class="well span4 dashboard-section">
         <h4><a href="{%url 'tasks' build.pk%}">Tasks</a></h4>
             <dl>
-        <dt>Total number of tasks</dt><dd><a href="{% url 'tasks' build.pk %}">{{build.task_build.all.count}}</a></dd>
+        <dt>Total number of tasks</dt><dd><a href="{% url 'tasks' build.pk %}">{% query build.task_build order__gt=0 as alltasks %}{{alltasks.count}}</a></dd>
         <dt>
             Tasks executed
             <i class="icon-question-sign get-help" title="'Executed' tasks are those that need to be run in order to generate the task output"></i>
Signature · 1 line
1.9.0
author
#2 lore raw

PATCH 2/2 bitbake: toaster: Fix Empty tasks filter

In reply to Paul Eggleton

From: Belen Barros Pena <[email protected]>

Somehow the counter was set to count tasks with outcome 'not available', instead of outcome 'empty'. This patch fixes the problem.

[YOCTO #6146]

Signed-off-by Belen Barros Pena <[email protected]>
---
 lib/toaster/toastergui/views.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/toaster/toastergui/views.py +1 -1
index e4ada14..53be967 100644
@@ -928,7 +928,7 @@ def tasks_common(request, build_id, variant, task_anchor):
                                ('Cached Tasks', 'outcome:%d'%Task.OUTCOME_CACHED, queryset_with_search.filter(outcome=Task.OUTCOME_CACHED).count(), 'Cached tasks restore output from the <code>sstate-cache</code> directory or mirrors'),
                                ('Prebuilt Tasks', 'outcome:%d'%Task.OUTCOME_PREBUILT, queryset_with_search.filter(outcome=Task.OUTCOME_PREBUILT).count(),'Prebuilt tasks didn\'t need to run because their output was reused from a previous build'),
                                ('Covered Tasks', 'outcome:%d'%Task.OUTCOME_COVERED, queryset_with_search.filter(outcome=Task.OUTCOME_COVERED).count(), 'Covered tasks didn\'t need to run because their output is provided by another task in this build'),
-                               ('Empty Tasks', 'outcome:%d'%Task.OUTCOME_EMPTY, queryset_with_search.filter(outcome=Task.OUTCOME_NA).count(), 'Empty tasks have no executable content'),
+                               ('Empty Tasks', 'outcome:%d'%Task.OUTCOME_EMPTY, queryset_with_search.filter(outcome=Task.OUTCOME_EMPTY).count(), 'Empty tasks have no executable content'),
                                ]
                    }
Signature · 1 line
1.9.0