Skip to contentSkip to conversation

Breakpad fix and upgrade

PATCH New Anders Darander 1 participant 3 messages Apr 23, 2014

lore
Share & tools
lore

Anders Darander

author
#0 lore raw

cover Breakpad fix and upgrade

Fixing a build issue with an internal Qt based application.

Using qt4e, CFLAGS were used and thus the include files were found. However, when porting to Qt5, CFLAGS seems to no longer be used, and thus we need to also set CXXFLAGS.

While looking at the recipe in question, I thought it was just as good to update it to the latest svn.

The following changes since commit 0f56bc4e2818a051a511ceb48596cbfa2f51ff3d:

dejagnu: recipe taken from openembedded (2014-04-21 13:31:48 +0200)

are available in the git repository at:

git://github.com/darander/meta-oe HEAD
https://github.com/darander/meta-oe/tree/breakpad-cflags

Anders Darander (2):
breakpad.bbclass: set includedir in CXXFLAGS
breakpad: update to latest svn

 meta-oe/classes/breakpad.bbclass                  | 1 +
 meta-oe/recipes-devtools/breakpad/breakpad_svn.bb | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.0.0.rc0
author
#1 lore raw

PATCH 1/2 breakpad.bbclass: set includedir in CXXFLAGS

Previously this was only set in CFLAGS.
An build issue was discovered while convering in internal application from Qt4 to Qt5. As a result of this, the required header files were no longer found, until we also set CXXFLAGS.

Signed-off-by Anders Darander <[email protected]>
---
 meta-oe/classes/breakpad.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta-oe/classes/breakpad.bbclass +1 -0
index 8c49ca7..e4d6808 100644
@@ -5,6 +5,7 @@
 DEPENDS += "breakpad breakpad-native"
 
 CFLAGS += "-I${STAGING_DIR_TARGET}${includedir}/breakpad "
+CXXFLAGS += "-I${STAGING_DIR_TARGET}${includedir}/breakpad "
 
 BREAKPAD_BIN ?= ""
Signature · 1 line
2.0.0.rc0
author
#2 lore raw

PATCH 2/2 breakpad: update to latest svn

In reply to Anders Darander

The old license file, COPYING has been renamed to LICENSE. It has also been appended with the the disclaimer from src/common/convert_UTF.h (see r1285).

Signed-off-by Anders Darander <[email protected]>
---
 meta-oe/recipes-devtools/breakpad/breakpad_svn.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-oe/recipes-devtools/breakpad/breakpad_svn.bb +3 -2
index 7c7024a..2c5941d 100644
@@ -6,14 +6,14 @@ SUMMARY = "An open-source multi-platform crash reporting system"
 DESCRIPTION = "Breakpad is a library and tool suite that allows you to distribute an application to users with compiler-provided debugging information removed, record crashes in compact \"minidump\" files, send them back to your server, and produce C and C++ stack traces from these minidumps. "
 HOMEPAGE = "https://code.google.com/p/google-breakpad/"
 LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=c80d1a3b623f72bb85a4c75b556551df"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=56c24a43c81c3af6fcf590851931489e"
 SECTION = "libs"
 
 inherit autotools
 
 BBCLASSEXTEND = "native"
 
-SRCREV = "r1218"
+SRCREV = "r1318"
 SRC_URI = "svn://google-breakpad.googlecode.com/svn;module=trunk;protocol=http"
 S = "${WORKDIR}/trunk"
 

@@ -42,6 +42,7 @@ do_install_append() {
         install -m 0644 ${S}/src/google_breakpad/common/minidump_format.h ${D}${includedir}/breakpad/google_breakpad/common/minidump_format.h
         install -m 0644 ${S}/src/google_breakpad/common/minidump_cpu_amd64.h ${D}${includedir}/breakpad/google_breakpad/common/minidump_cpu_amd64.h
         install -m 0644 ${S}/src/google_breakpad/common/minidump_cpu_arm.h ${D}${includedir}/breakpad/google_breakpad/common/minidump_cpu_arm.h
+        install -m 0644 ${S}/src/google_breakpad/common/minidump_cpu_arm.h ${D}${includedir}/breakpad/google_breakpad/common/minidump_cpu_arm64.h
         install -m 0644 ${S}/src/google_breakpad/common/minidump_cpu_mips.h ${D}${includedir}/breakpad/google_breakpad/common/minidump_cpu_mips.h
         install -m 0644 ${S}/src/google_breakpad/common/minidump_cpu_ppc64.h ${D}${includedir}/breakpad/google_breakpad/common/minidump_cpu_ppc64.h
         install -m 0644 ${S}/src/google_breakpad/common/minidump_cpu_ppc.h ${D}${includedir}/breakpad/google_breakpad/common/minidump_cpu_ppc.h
Signature · 1 line
2.0.0.rc0