Skip to contentSkip to conversation

treewide: Convert logging message misuses of /n to \n

PATCH Applied Joe Perches 5 participants 11 messages Apr 25, 2014 – May 20, 2014

Subsystems (8)
Networking Network drivers USB Sound +4 more subsystems
lore
Share & tools
lore

Joe Perches

author
#0 lore raw

cover treewide: Convert logging message misuses of /n to \n

Joe Perches (5):
qlge: Convert /n to \n
iwlegacy: Convert /n to \n
staging: rtl<foo>: Convert /n to \n
appledisplay: Convert /n to \n
sound: tlv320aic31xx: Convert /n to \n

 drivers/net/ethernet/qlogic/qlge/qlge_main.c  | 2 +-
 drivers/net/wireless/iwlegacy/3945.c          | 2 +-
 drivers/net/wireless/iwlegacy/4965-mac.c      | 2 +-
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
 drivers/staging/rtl8188eu/os_dep/usb_intf.c   | 2 +-
 drivers/staging/rtl8723au/hal/usb_ops_linux.c | 4 ++--
 drivers/staging/rtl8723au/os_dep/usb_intf.c   | 2 +-
 drivers/usb/misc/appledisplay.c               | 2 +-
 sound/soc/codecs/tlv320aic31xx.c              | 2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
author
#1 lore raw

PATCH 1/5 qlge: Convert /n to \n

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/qlogic/qlge/qlge_main.c +1 -1
index 0a1d76a..6e36fe1 100644
@@ -3595,7 +3595,7 @@ static int ql_request_irq(struct ql_adapter *qdev)
 	}
 	return status;
 err_irq:
-	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!/n");
+	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!\n");
 	ql_free_irq(qdev);
 	return status;
 }
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
Acked-by on v1 1/5
#2 lore raw

Re: [PATCH 1/5] qlge: Convert /n to \n

Quoted 18 lines · Joe Perches

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>

---
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/qlogic/qlge/qlge_main.c +0 -0
index 0a1d76a..6e36fe1 100644
@@ -3595,7 +3595,7 @@ static int ql_request_irq(struct ql_adapter *qdev)
 	}
 	return status;

err_irq:

drivers/net/ethernet/qlogic/qlge/qlge_main.c +1 -1
-	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!/n");
+	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!\n");
Quoted 5 lines
	ql_free_irq(qdev);
	return status;
}
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
Acked-by Jitendra Kalsaria <[email protected]>
author
#4 lore raw

PATCH 2/5 iwlegacy: Convert /n to \n

In reply to Joe Perches

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/net/wireless/iwlegacy/3945.c     | 2 +-
 drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/iwlegacy/3945.c +1 -1
index d37a6fd..b598e28 100644
@@ -573,7 +573,7 @@ il3945_hdl_rx(struct il_priv *il, struct il_rx_buf *rxb)
 		rx_status.flag |= RX_FLAG_SHORTPRE;
 
 	if ((unlikely(rx_stats->phy_count > 20))) {
-		D_DROP("dsp size out of range [0,20]: %d/n",
+		D_DROP("dsp size out of range [0,20]: %d\n",
 		       rx_stats->phy_count);
 		return;
 	}
drivers/net/wireless/iwlegacy/4965-mac.c +1 -1
index 888ad5c..c159c05 100644
@@ -670,7 +670,7 @@ il4965_hdl_rx(struct il_priv *il, struct il_rx_buf *rxb)
 	}
 
 	if ((unlikely(phy_res->cfg_phy_cnt > 20))) {
-		D_DROP("dsp size out of range [0,20]: %d/n",
+		D_DROP("dsp size out of range [0,20]: %d\n",
 		       phy_res->cfg_phy_cnt);
 		return;
 	}
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
author
#5 lore raw

PATCH 3/5 staging: rtl<foo>: Convert /n to \n

In reply to Joe Perches

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
 drivers/staging/rtl8188eu/os_dep/usb_intf.c   | 2 +-
 drivers/staging/rtl8723au/hal/usb_ops_linux.c | 4 ++--
 drivers/staging/rtl8723au/os_dep/usb_intf.c   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8188eu/hal/usb_ops_linux.c +1 -1
index 1fa5370..e94c689 100644
@@ -559,7 +559,7 @@ static void usb_read_port_complete(struct urb *purb, struct pt_regs *regs)
 			rtw_read_port(adapt, precvpriv->ff_hwaddr, 0, (unsigned char *)precvbuf);
 			break;
 		case -EINPROGRESS:
-			DBG_88E("ERROR: URB IS IN PROGRESS!/n");
+			DBG_88E("ERROR: URB IS IN PROGRESS!\n");
 			break;
 		default:
 			break;
drivers/staging/rtl8188eu/os_dep/usb_intf.c +1 -1
index 49a4ce4..b899191 100644
@@ -128,7 +128,7 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
 
 	dvobj->usb_alloc_vendor_req_buf = rtw_zmalloc(MAX_USB_IO_CTL_SIZE);
 	if (dvobj->usb_alloc_vendor_req_buf == NULL) {
-		DBG_88E("alloc usb_vendor_req_buf failed... /n");
+		DBG_88E("alloc usb_vendor_req_buf failed...\n");
 		rst = _FAIL;
 		goto exit;
 	}
drivers/staging/rtl8723au/hal/usb_ops_linux.c +2 -2
index 0311cdf..f5a6e61 100644
@@ -415,7 +415,7 @@ urb_submit:
 		case -EPROTO:
 			break;
 		case -EINPROGRESS:
-			DBG_8723A("ERROR: URB IS IN PROGRESS!/n");
+			DBG_8723A("ERROR: URB IS IN PROGRESS!\n");
 			break;
 		default:
 			break;

@@ -711,7 +711,7 @@ static void usb_read_port_complete(struct urb *purb, struct pt_regs *regs)
 				      0, precvbuf);
 			break;
 		case -EINPROGRESS:
-			DBG_8723A("ERROR: URB IS IN PROGRESS!/n");
+			DBG_8723A("ERROR: URB IS IN PROGRESS!\n");
 			break;
 		default:
 			break;
drivers/staging/rtl8723au/os_dep/usb_intf.c +1 -1
index 31ab346..287439a 100644
@@ -109,7 +109,7 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
 	dvobj->usb_alloc_vendor_req_buf = kzalloc(MAX_USB_IO_CTL_SIZE,
 						  GFP_KERNEL);
 	if (dvobj->usb_alloc_vendor_req_buf == NULL) {
-		DBG_8723A("alloc usb_vendor_req_buf failed... /n");
+		DBG_8723A("alloc usb_vendor_req_buf failed...\n");
 		rst = _FAIL;
 		goto exit;
 	}
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
author
#6 lore raw

PATCH 4/5 appledisplay: Convert /n to \n

In reply to Joe Perches

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/usb/misc/appledisplay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/misc/appledisplay.c +1 -1
index ba6a5d6..f37c78d 100644
@@ -110,7 +110,7 @@ static void appledisplay_complete(struct urb *urb)
 			__func__, status);
 		return;
 	default:
-		dev_dbg(dev, "%s - nonzero urb status received: %d/n",
+		dev_dbg(dev, "%s - nonzero urb status received: %d\n",
 			__func__, status);
 		goto exit;
 	}
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
author
#7 lore raw

Re: [PATCH 4/5] appledisplay: Convert /n to \n

Quoted 4 lines · Joe Perches

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>

---

Greg? Ping?

You inadvertently added this "/n" use in
commit 0a3fd536e685e0ceb646de1a43821bd11c0be75c

Author: Greg Kroah-Hartman <[email protected]>
Date:   Tue May 1 21:33:54 2012 -0700

USB: appledisplay.c: remove dbg() usage

dbg() was a very old USB-specific macro that should no longer be used. This patch removes it from being used in the driver and uses dev_dbg() instead.

Quoted 16 lines
 drivers/usb/misc/appledisplay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/misc/appledisplay.c +1 -1
index ba6a5d6..f37c78d 100644
@@ -110,7 +110,7 @@ static void appledisplay_complete(struct urb *urb)
 			__func__, status);
 		return;
 	default:
-		dev_dbg(dev, "%s - nonzero urb status received: %d/n",
+		dev_dbg(dev, "%s - nonzero urb status received: %d\n",
 			__func__, status);
 		goto exit;
 	}
maintainer
#8 lore raw

Re: [PATCH 4/5] appledisplay: Convert /n to \n

Quoted 10 lines · Joe Perches
Quoted 4 lines · Joe Perches

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>

---

Greg? Ping?

You inadvertently added this "/n" use in
commit 0a3fd536e685e0ceb646de1a43821bd11c0be75c

Quoted 8 lines
Author: Greg Kroah-Hartman <[email protected]>
Date:   Tue May 1 21:33:54 2012 -0700

USB: appledisplay.c: remove dbg() usage

dbg() was a very old USB-specific macro that should no longer be used. This patch removes it from being used in the driver and uses dev_dbg() instead.

Sorry, it's in my queue, just stalled due to traveling. It's not lost, don't worry.

greg k-h

author
#9 lore raw

PATCH 5/5 sound: tlv320aic31xx: Convert /n to \n

In reply to Joe Perches

Use a newline character appropriately.

Signed-off-by Joe Perches <[email protected]>
---
 sound/soc/codecs/tlv320aic31xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tlv320aic31xx.c +1 -1
index b93d500..2341910 100644
@@ -377,7 +377,7 @@ static int aic31xx_dapm_power_event(struct snd_soc_dapm_widget *w,
 		reg = AIC31XX_ADCFLAG;
 		break;
 	default:
-		dev_err(w->codec->dev, "Unknown widget '%s' calling %s/n",
+		dev_err(w->codec->dev, "Unknown widget '%s' calling %s\n",
 			w->name, __func__);
 		return -EINVAL;
 	}
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty
maintainer Applied
#10 lore raw

Re: [PATCH 5/5] sound: tlv320aic31xx: Convert /n to \n

Quoted 1 line · Joe Perches

Use a newline character appropriately.

Applied. As ever please do try to use subject lines appropriate to the subsystem.