Skip to contentSkip to conversation

eglibc: check for required distro features

PATCH New Chen Qi 1 participant 2 messages Jul 3, 2014

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover eglibc: check for required distro features

The following changes since commit c36d459f0d40bdbd3ba809835e0475e8992bc778:

python3: fix builtins imports (2014-06-30 16:35:03 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib ChenQi/distro_features_libc
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/distro_features_libc

Chen Qi (1):
eglibc: check for required distro features

 meta/recipes-core/eglibc/eglibc.inc |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 eglibc: check for required distro features

If users accidently override the DISTRO_FEATURES in local.conf, then build failures occur for lack of libc functions.

All features in DISTRO_FEATURES_LIBC should be in DISTRO_FEATURES. That's why this patch let the recipe inherit distro_features_check class and set REQUIRED_DISTRO_FEATURES to "${DISTRO_FEATURES_LIBC}".

[YOCTO #6381]

---
 meta/recipes-core/eglibc/eglibc.inc |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
meta/recipes-core/eglibc/eglibc.inc +6 -1
index 68128e9..af7f6ad 100644
@@ -38,9 +38,14 @@ DEPENDS = "virtual/${TARGET_PREFIX}gcc-initial libgcc-initial linux-libc-headers
 #RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
 PROVIDES = "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc"
 PROVIDES += "virtual/libintl virtual/libiconv"
-inherit autotools texinfo
+inherit autotools texinfo distro_features_check
 require eglibc-options.inc
 
+# The main purpose of setting this variable is to prevent users from accidently
+# overriding DISTRO_FEATRUES, causing obscure build failures because of lack
+# of libc functions.
+REQUIRED_DISTRO_FEATURES = "${DISTRO_FEATURES_LIBC}"
+
 LEAD_SONAME = "libc.so"
 
 CACHED_CONFIGUREVARS += " \
Signature · 1 line
1.7.9.5