support xmlto
cover support xmlto
The xmlto was shipped from meta-oe, and fixed the defects that 'xmlto/xsltproc stylesheets cannot be found even when they are installed in sysroot'
The xmlto required docbook-xml-dtd and docbook-xsl-stylesheets, we refered debian's docbook-xml-dtd and ubuntu config.
We also enable xmlto for alsa-utils, xorg-proto-common.inc, xorg-lib-common.inc, xserver-xorg.inc.
The test is easy, just build alsa-utils.
BTW: after this merged, I will clean up the duplicate one in meta-oe.
[YOCTO #2416]
//Hongxu
The following changes since commit a5531a2b8983318b99c119a87b78a92cf84160b8:
bitbake: fetch2/svn: Add transportuser parameter (2014-07-04 09:28:36 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib hongxu/support-xmlto
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/support-xmlto
Hongxu Jia (8):
libxml2: enable Catalog support
docbook-xml: add docbook-xsl-stylesheets 1.78.1
docbook-xml: add docbook-xml-dtd4
xmlto: add version 0.0.25
alsa-utils: enable xmlto
xorg-proto-common.inc: enable xmlto
xorg-lib-common.inc: enable xmlto
xserver-xorg.inc: enable xmlto
meta/conf/licenses.conf | 2 +- meta/files/common-licenses/XSL | 48 ++ meta/recipes-core/libxml/libxml2.inc | 2 + .../docbook-xml/docbook-xml-dtd4/LICENSE-OASIS | 16 + .../docbook-xml-update-catalog.xml.patch | 515 +++++++++++++++++++++ .../docbook-xml/docbook-xml-dtd4/docbook-xml.xml | 68 +++ .../docbook-xml/docbook-xml-dtd4_4.5.bb | 75 +++ .../docbook-xsl-stylesheets/docbook-xsl.xml | 6 + .../docbook-xml/docbook-xsl-stylesheets_1.78.1.bb | 67 +++ meta/recipes-devtools/xmlto/files/catalog.xml | 19 + ....in-drop-the-test-of-xmllint-and-xsltproc.patch | 30 ++ .../xmlto-0.0.25/obsolete_automake_macros.patch | 12 + meta/recipes-devtools/xmlto/xmlto_0.0.25.bb | 42 ++ meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 6 +- .../xorg-proto/xorg-proto-common.inc | 6 +- .../recipes-graphics/xorg-xserver/xserver-xorg.inc | 4 +- .../recipes-multimedia/alsa/alsa-utils_1.0.27.2.bb | 4 +- 17 files changed, 911 insertions(+), 11 deletions(-) create mode 100644 meta/files/common-licenses/XSL create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/LICENSE-OASIS create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/docbook-xml-update-catalog.xml.patch create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/docbook-xml.xml create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets/docbook-xsl.xml create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets_1.78.1.bb create mode 100644 meta/recipes-devtools/xmlto/files/catalog.xml create mode 100644 meta/recipes-devtools/xmlto/xmlto-0.0.25/configure.in-drop-the-test-of-xmllint-and-xsltproc.patch create mode 100644 meta/recipes-devtools/xmlto/xmlto-0.0.25/obsolete_automake_macros.patch create mode 100644 meta/recipes-devtools/xmlto/xmlto_0.0.25.bb
Signature · 1 line
1.8.1.2
PATCH 1/8 libxml2: enable Catalog support
The environment variable XML_CATALOG_FILES could work which was required by xmlto.
[YOCTO #2416]
--- meta/recipes-core/libxml/libxml2.inc | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-core/libxml/libxml2.inc +2 -0
@@ -28,6 +28,8 @@ inherit autotools pkgconfig binconfig-disabled pythonnative ptest RDEPENDS_${PN}-ptest_append_libc-glibc += "eglibc-gconv-ebcdic-us eglibc-gconv-ibm1141" +CFLAGS_append = " -DLIBXML_CATALOG_ENABLED" + # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header do_configure_prepend () { sed -i -e '/.*ansidecl.h.*/d' ${S}/configure.in
Signature · 1 line
1.8.1.2
Re: [PATCH 1/8] libxml2: enable Catalog support
Quoted 1 line · Hongxu Jia
+CFLAGS_append = " -DLIBXML_CATALOG_ENABLED"
EXTRA_OECONF has --without-catalog, so you should change that instead of passing CFLAGS directly.
Ross
PATCH 2/8 docbook-xml: add docbook-xsl-stylesheets 1.78.1
In reply to Hongxu JiaAbout the config files (docbook-xsl.xml), we refered what Ubuntu 13.04 did, so the xmlto could correctly search the xsl stylesheets.
[YOCTO #2416]
--- meta/conf/licenses.conf | 2 +- meta/files/common-licenses/XSL | 48 ++++++++++++++++ .../docbook-xsl-stylesheets/docbook-xsl.xml | 6 ++ .../docbook-xml/docbook-xsl-stylesheets_1.78.1.bb | 67 ++++++++++++++++++++++ 4 files changed, 122 insertions(+), 1 deletion(-) create mode 100644 meta/files/common-licenses/XSL create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets/docbook-xsl.xml create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets_1.78.1.bb
meta/conf/licenses.conf +1 -1
@@ -36,7 +36,7 @@ SRC_DISTRIBUTE_LICENSES += "OSL-3.0 PD PHP-3.0 PostgreSQL Proprietary" SRC_DISTRIBUTE_LICENSES += "Python-2.0 QPL-1.0 RHeCos-1 RHeCos-1.1 RPL-1.5" SRC_DISTRIBUTE_LICENSES += "RPSL-1.0 RSCPL Ruby SAX-PD SGI-1 Simple-2.0 Sleepycat" SRC_DISTRIBUTE_LICENSES += "SPL-1.0 SugarCRM-1 SugarCRM-1.1.3 UCB VSL-1.0 W3C" -SRC_DISTRIBUTE_LICENSES += "Watcom-1.0 WXwindows XFree86-1.1 Xnet YPL-1.1" +SRC_DISTRIBUTE_LICENSES += "Watcom-1.0 WXwindows XFree86-1.1 Xnet XSL YPL-1.1" SRC_DISTRIBUTE_LICENSES += "Zimbra-1.3 Zlib ZPL-1.1 ZPL-2.0 ZPL-2.1" # Standards are great! Everyone has their own. In an effort to standardize licensing
meta/files/common-licenses/XSL new file +48 -0
48 lines not on this page · raw message
meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets/docbook-xsl.xml new file +6 -0
@@ -0,0 +1,6 @@ +<?xml version="1.0"?> +<!DOCTYPE catalog PUBLIC "-//OASIS//DTD Entity Resolution XML Catalog V1.0//EN" "http://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd"> +<catalog xmlns="urn:oasis:names:tc:entity:xmlns:xml:catalog"> +<delegateURI uriStartString="http://docbook.sourceforge.net/release/xsl/" catalog="file:///usr/share/xml/docbook/xsl-stylesheets-1.78.1/catalog.xml"/> +<delegateSystem systemIdStartString="http://docbook.sourceforge.net/release/xsl/" catalog="file:///usr/share/xml/docbook/xsl-stylesheets-1.78.1/catalog.xml"/> +</catalog>
meta/recipes-devtools/docbook-xml/docbook-xsl-stylesheets_1.78.1.bb new file +67 -0
67 lines not on this page · raw message
Signature · 1 line
1.8.1.2
PATCH 3/8 docbook-xml: add docbook-xml-dtd4
In reply to Hongxu JiaRefer debian, it shipped the latest DocBook 4.5 XML DTD, as well as a selected set of legacy DTDs for use with older documents, including 4.0, 4.1.2, 4.2, 4.3 and 4.4.
About the config files (docbook-xml.xml and the update patch), we refered what Ubuntu 13.04 did, so the xmlto could correctly search among multible DTDs.
[YOCTO #2416]
--- .../docbook-xml/docbook-xml-dtd4/LICENSE-OASIS | 16 + .../docbook-xml-update-catalog.xml.patch | 515 +++++++++++++++++++++ .../docbook-xml/docbook-xml-dtd4/docbook-xml.xml | 68 +++ .../docbook-xml/docbook-xml-dtd4_4.5.bb | 75 +++ 4 files changed, 674 insertions(+) create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/LICENSE-OASIS create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/docbook-xml-update-catalog.xml.patch create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/docbook-xml.xml create mode 100644 meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/LICENSE-OASIS new file +16 -0
@@ -0,0 +1,16 @@ +Permission to use, copy, modify and distribute the DocBook XML DTD +and its accompanying documentation for any purpose and without fee +is hereby granted in perpetuity, provided that the above copyright +notice and this paragraph appear in all copies. The copyright +holders make no representation about the suitability of the DTD for +any purpose. It is provided "as is" without expressed or implied +warranty. + +If you modify the DocBook DTD in any way, except for declaring and +referencing additional sets of general entities and declaring +additional notations, label your DTD as a variant of DocBook. See +the maintenance documentation for more information. + +Please direct all questions, bug reports, or suggestions for +changes to the [email protected] mailing list. For more +information, see http://www.oasis-open.org/docbook/.
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/docbook-xml-update-catalog.xml.patch new file +515 -0
515 lines not on this page · raw message
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4/docbook-xml.xml new file +68 -0
68 lines not on this page · raw message
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb new file +75 -0
75 lines not on this page · raw message
Signature · 1 line
1.8.1.2
Re: [PATCH 3/8] docbook-xml: add docbook-xml-dtd4
Quoted 55 lines · Hongxu Jia
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb new file +49
-0@@ -0,0 +1,75 @@ +# The DTDs of the various versions have to be installed in parallel and +# should not replace each other. The installation step is common for +# all versions and just differs in ${DTD_VERSION} which is set in each +# version recipe. +# +# The DTDs do have some quirks (see LFS documentation). +SUMMARY = "Document type definitions for verification of XML data files" +DESCRIPTION = "Document type definitions for verification of XML data \ +files against the DocBook rule set, it ships with the latest DocBook 4.5 \ +XML DTD, as well as a selected set of legacy DTDs for use with older \ +documents, including 4.0, 4.1.2, 4.2, 4.3 and 4.4" +HOMEPAGE = "http://www.docbook.org/xml/" + +LICENSE = "OASIS" +LIC_FILES_CHKSUM = "file://${WORKDIR}/LICENSE-OASIS;md5=c608985dd5f7f215e669e7639a0b1d2e" + +# Note: the upstream sources are not distributed with a license file. +# LICENSE-OASIS is included as a "patch" to workaround this. When +# upgrading this recipe, please verify whether this is still needed. +SRC_URI = "${DEBIAN_MIRROR}/main/d/docbook-xml/docbook-xml_${PV}.orig.tar.gz \ + file://LICENSE-OASIS \ + file://docbook-xml-update-catalog.xml.patch \ + file://docbook-xml.xml \ +" + +SRC_URI[md5sum] = "487b4d44e15cffb1f4048af23f98208e" +SRC_URI[sha256sum] = "b0f8edcf697f5318e63dd98c9a931f3fee167af0805ba441db372e0f17b2a44f" + +S="${WORKDIR}/docbook-xml-4.5.c31424" + +inherit allarch +BBCLASSEXTEND = "native" + +SSTATEPOSTINSTFUNCS_append_class-native = " docbook_xml_dtd_sstate_postinst" +SYSROOT_PREPROCESS_FUNCS_append_class-native = " docbook_xml_dtd_sysroot_preprocess" + +do_configre (){ + : +} + +do_compile (){ + : +} + +do_install () { + # Refer debian https://packages.debian.org/sid/all/docbook-xml/filelist + for DTDVERSION in 4.0 4.1.2 4.2 4.3 4.4 4.5; do + install -d -m 755 ${D}${datadir}/xml/docbook/schema/dtd/${DTDVERSION} + cp -v -R docbook-${DTDVERSION}/* ${D}${datadir}/xml/docbook/schema/dtd/${DTDVERSION}
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb line 59
Quoted 10 lines
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb new file +10
-0+ done + + install -d ${D}${sysconfdir}/xml/ + install -m 755 ${WORKDIR}/docbook-xml.xml ${D}${sysconfdir}/xml/docbook-xml.xml +} + +do_install_append_class-nativesdk () { + # Update the hardcode dir in docbook-xml.xml + sed -i -e "s|file:///usr/share/xml|file://${datadir}/xml|g" ${D}${sysconfdir}/xml/docbook-xml.xml +}
Remove the nativesdk do_install_append_class-nativesd, we don't support nativesdk.
I update the git tree directly, no v2 will be sent.
//Hongxu
Quoted 16 lines
meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb new file +16
-0+ +docbook_xml_dtd_sstate_postinst () { + if [ "${BB_CURRENTTASK}" = "populate_sysroot" -o "${BB_CURRENTTASK}" = "populate_sysroot_setscene" ] + then + # Ensure that the catalog file sgml-docbook.cat is properly + # updated when the package is installed from sstate cache. + sed -i -e "s|file://.*/usr/share/xml|file://${datadir}/xml|g" ${SYSROOT_DESTDIR}${sysconfdir}/xml/docbook-xml.xml + fi +} + +docbook_xml_dtd_sysroot_preprocess () { + # Update the hardcode dir in docbook-xml.xml + sed -i -e "s|file:///usr/share/xml|file://${datadir}/xml|g" ${SYSROOT_DESTDIR}${sysconfdir}/xml/docbook-xml.xml +} + +FILES_${PN} = "${datadir}/* ${sysconfdir}/xml/docbook-xml.xml"
PATCH 4/8 xmlto: add version 0.0.25
In reply to Hongxu JiaIt moved from meta-oe and fixed the defect that xmlto/xsltproc stylesheets cannot be found even when they are installed in sysroot.
About the config files (catalog.xml), we refered what Ubuntu 13.04 did, so it could correctly search the xsl stylesheets and xml dtds.
Assigned the environment variable XML_CATALOG_FILES, so the xmlto will use oe-core's config as priority to avoid the the search from build system.
[YOCTO #2416]
--- meta/recipes-devtools/xmlto/files/catalog.xml | 19 ++++++++++ ....in-drop-the-test-of-xmllint-and-xsltproc.patch | 30 ++++++++++++++++ .../xmlto-0.0.25/obsolete_automake_macros.patch | 12 +++++++ meta/recipes-devtools/xmlto/xmlto_0.0.25.bb | 42 ++++++++++++++++++++++ 4 files changed, 103 insertions(+) create mode 100644 meta/recipes-devtools/xmlto/files/catalog.xml create mode 100644 meta/recipes-devtools/xmlto/xmlto-0.0.25/configure.in-drop-the-test-of-xmllint-and-xsltproc.patch create mode 100644 meta/recipes-devtools/xmlto/xmlto-0.0.25/obsolete_automake_macros.patch create mode 100644 meta/recipes-devtools/xmlto/xmlto_0.0.25.bb
meta/recipes-devtools/xmlto/files/catalog.xml new file +19 -0
@@ -0,0 +1,19 @@ +<?xml version="1.0"?> +<!DOCTYPE catalog PUBLIC "-//OASIS//DTD Entity Resolution XML Catalog V1.0//EN" "http://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd"> +<catalog xmlns="urn:oasis:names:tc:entity:xmlns:xml:catalog"> +<delegateSystem systemIdStartString="http://docbook.org/xml/" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//OASIS//ELEMENTS DocBook" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//OASIS//DTD DocBook XML" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//OASIS//DTD XML Exchange Table Model 19990315" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//Norman Walsh//DTD CALS Table Model XML" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//Norman Walsh//ELEMENTS DocBk XML" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//Norman Walsh//DTD DocBook XML" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//OASIS//ENTITIES DocBook" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//Norman Walsh//ENTITIES DocBk XML" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//Norman Walsh//DTD DocBk XML" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//Normal Walsh//Exchange Table Model 19960430" catalog="./docbook-xml.xml"/> +<delegateSystem systemIdStartString="http://www.oasis-open.org/docbook/xml/" catalog="./docbook-xml.xml"/> +<delegatePublic publicIdStartString="-//OASIS//DTD DocBook CALS Table Model" catalog="./docbook-xml.xml"/> +<delegateURI uriStartString="http://docbook.sourceforge.net/release/xsl/" catalog="./docbook-xsl.xml"/> +<delegateSystem systemIdStartString="http://docbook.sourceforge.net/release/xsl/" catalog="./docbook-xsl.xml"/> +</catalog>
meta/recipes-devtools/xmlto/xmlto-0.0.25/configure.in-drop-the-test-of-xmllint-and-xsltproc.patch new file +30 -0
@@ -0,0 +1,30 @@ +configure.in: drop the test of xmllint and xsltproc + +The test is unnecessary, the xmllint and xsltproc were explicitly +added to RDEPENDS. + +Upstream-Status: oe-specific +Signed-off-by: Hongxu Jia <[email protected]> +--- + configure.in | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/configure.in b/configure.in +--- a/configure.in ++++ b/configure.in +@@ -42,10 +42,10 @@ AC_ARG_VAR([LOCALE], [Name and path of the `locale' program.]) + AC_PATH_PROG([LOCALE], [locale], [locale]) + + AC_ARG_VAR([XMLLINT], [Name and path of the `xmllint' program.]) +-AC_PATH_PROG([XMLLINT], [xmllint], [xmllint]) ++dnl AC_PATH_PROG([XMLLINT], [xmllint], [xmllint]) + + AC_ARG_VAR([XSLTPROC], [Name and path of the `xsltproc' program.]) +-AC_PATH_PROG([XSLTPROC], [xsltproc], [xsltproc]) ++dnl AC_PATH_PROG([XSLTPROC], [xsltproc], [xsltproc]) + + dnl + dnl toolchains +-- +1.8.1.2 +
meta/recipes-devtools/xmlto/xmlto-0.0.25/obsolete_automake_macros.patch new file +12 -0
@@ -0,0 +1,12 @@ +diff -Nurd xmlto-0.0.25/configure.in xmlto-0.0.25/configure.in +--- xmlto-0.0.25/configure.in 2011-12-01 17:49:00.000000000 +0200 ++++ xmlto-0.0.25/configure.in 2013-01-07 05:24:16.169953519 +0200 +@@ -1,7 +1,7 @@ + AC_INIT(xmlto, 0.0.25) + AC_CONFIG_SRCDIR(xmlto.spec.in) + AM_INIT_AUTOMAKE([dist-bzip2 subdir-objects 1.6]) +-AM_CONFIG_HEADER(config.h) ++AC_CONFIG_HEADERS(config.h) + + AC_PROG_CC + AM_PROG_CC_C_O
meta/recipes-devtools/xmlto/xmlto_0.0.25.bb new file +42 -0
42 lines not on this page · raw message
Signature · 1 line
1.8.1.2
PATCH 5/8 alsa-utils: enable xmlto
In reply to Hongxu Jia[YOCTO #2416]
--- meta/recipes-multimedia/alsa/alsa-utils_1.0.27.2.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-multimedia/alsa/alsa-utils_1.0.27.2.bb +2 -2
@@ -5,7 +5,7 @@ SECTION = "console/utils" LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ file://alsactl/utils.c;beginline=1;endline=20;md5=fe9526b055e246b5558809a5ae25c0b9" -DEPENDS = "alsa-lib ncurses libsamplerate0 udev" +DEPENDS = "alsa-lib ncurses libsamplerate0 udev xmlto-native" PACKAGECONFIG ??= "udev" PACKAGECONFIG[udev] = "--with-udev-rules-dir=`pkg-config --variable=udevdir udev`/rules.d,,udev"
@@ -21,7 +21,7 @@ SRC_URI[sha256sum] = "02bfac39092f3b68d743c23ad3d688d6c5aa8df69f2ccd692c5b8282ed # http://bugs.openembedded.org/show_bug.cgi?id=2348 # please close bug and remove this comment when properly fixed # -EXTRA_OECONF = "--disable-xmlto" +EXTRA_OECONF = "--enable-xmlto" EXTRA_OECONF_append_libc-uclibc = " --disable-nls" inherit autotools-brokensep gettext pkgconfig
Signature · 1 line
1.8.1.2
PATCH 6/8 xorg-proto-common.inc: enable xmlto
In reply to Hongxu Jia[YOCTO #2416]
--- meta/recipes-graphics/xorg-proto/xorg-proto-common.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-graphics/xorg-proto/xorg-proto-common.inc +3 -3
@@ -11,12 +11,12 @@ SRC_URI = "${XORG_MIRROR}/individual/proto/${XORG_PN}-${PV}.tar.bz2" S = "${WORKDIR}/${XORG_PN}-${PV}" -DEPENDS = "util-macros" +DEPENDS = "util-macros xmlto-native" inherit autotools pkgconfig -EXTRA_OECONF = "--without-fop --without-xmlto" +EXTRA_OECONF = "--without-fop --with-xmlto" -UNKNOWN_CONFIGURE_WHITELIST += "--without-fop --without-xmlto" +UNKNOWN_CONFIGURE_WHITELIST += "--without-fop --with-xmlto" # ${PN} is empty so we need to tweak -dev and -dbg package dependencies RDEPENDS_${PN}-dev = ""
Signature · 1 line
1.8.1.2
PATCH 7/8 xorg-lib-common.inc: enable xmlto
In reply to Hongxu Jia[YOCTO #2416]
--- meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-graphics/xorg-lib/xorg-lib-common.inc +3 -3
@@ -3,7 +3,7 @@ BUGTRACKER = "https://bugs.freedesktop.org/enter_bug.cgi?product=xorg" SECTION = "x11/libs" LICENSE = "MIT-X" -DEPENDS = "util-macros" +DEPENDS = "util-macros xmlto-native" XORG_PN = "${BPN}"
@@ -13,9 +13,9 @@ S = "${WORKDIR}/${XORG_PN}-${PV}" inherit autotools distro_features_check pkgconfig -EXTRA_OECONF = "--disable-specs --without-groff --without-ps2pdf --without-fop --without-xmlto" +EXTRA_OECONF = "--disable-specs --without-groff --without-ps2pdf --without-fop --with-xmlto" UNKNOWN_CONFIGURE_WHITELIST += "--enable-malloc0returnsnull --disable-malloc0returnsnull \ - --disable-specs --without-groff --without-ps2pdf --without-fop --without-xmlto" + --disable-specs --without-groff --without-ps2pdf --without-fop --with-xmlto" REQUIRED_DISTRO_FEATURES ?= "x11"
Signature · 1 line
1.8.1.2
PATCH 8/8 xserver-xorg.inc: enable xmlto
In reply to Hongxu Jia[YOCTO #2416]
--- meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +2 -2
@@ -25,7 +25,7 @@ inherit autotools pkgconfig PROTO_DEPS = "randrproto renderproto fixesproto damageproto xextproto xproto xf86dgaproto xf86miscproto xf86vidmodeproto compositeproto recordproto resourceproto videoproto scrnsaverproto xineramaproto fontsproto kbproto inputproto bigreqsproto xcmiscproto presentproto" LIB_DEPS = "pixman libxfont xtrans libxau libxext libxdmcp libdrm libxkbfile libpciaccess openssl libgcrypt" -DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util" +DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util xmlto-native" # Split out some modules and extensions from the main package # These aren't needed for basic operations and only take up space:
@@ -99,7 +99,7 @@ FILES_${PN}-module-libxf1bpp = "${libdir}/xorg/modules/libxf1bpp.so" FILES_${PN}-module-libxf4bpp = "${libdir}/xorg/modules/libxf4bpp.so" EXTRA_OECONF += "--with-fop=no \ - --without-xmlto \ + --with-xmlto \ --with-pic \ --disable-static \ --disable-xinerama \
Signature · 1 line
1.8.1.2
Re: [PATCH 8/8] xserver-xorg.inc: enable xmlto
Hello,
The commit log needs to be way more detailed. Without a reasoning this just increases build time so for now, NAK!
Quoted 37 lines · Hongxu Jia
[YOCTO #2416]
Signed-off-by Hongxu Jia <[email protected]>--- meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +2
-3@@ -25,7 +25,7 @@ inherit autotools pkgconfig PROTO_DEPS = "randrproto renderproto fixesproto damageproto xextproto xproto xf86dgaproto xf86miscproto xf86vidmodeproto compositeproto recordproto resourceproto videoproto scrnsaverproto xineramaproto fontsproto kbproto inputproto bigreqsproto xcmiscproto presentproto" LIB_DEPS = "pixman libxfont xtrans libxau libxext libxdmcp libdrm libxkbfile libpciaccess openssl libgcrypt" -DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util" +DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util xmlto-native" # Split out some modules and extensions from the main package # These aren't needed for basic operations and only take up space:@@ -99,7 +99,7 @@ FILES_${PN}-module-libxf1bpp = "${libdir}/xorg/modules/libxf1bpp.so" FILES_${PN}-module-libxf4bpp = "${libdir}/xorg/modules/libxf4bpp.so" EXTRA_OECONF += "--with-fop=no \ - --without-xmlto \ + --with-xmlto \ --with-pic \ --disable-static \ --disable-xinerama \ --1.8.1.2
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Hello,
Quoted 11 lines · Hongxu Jia
The xmlto was shipped from meta-oe, and fixed the defects that 'xmlto/xsltproc stylesheets cannot be found even when they are installed in sysroot'
The xmlto required docbook-xml-dtd and docbook-xsl-stylesheets, we refered debian's docbook-xml-dtd and ubuntu config.
We also enable xmlto for alsa-utils, xorg-proto-common.inc, xorg-lib-common.inc, xserver-xorg.inc.
The test is easy, just build alsa-utils.
The commit logs in the patches need to be extended. Please bear on mind that people does not have the cover letter when reading the 'git log' and thus all important information needs to be added in each commit.
I also don't see /why/ this is being done. Please clarify.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 9 lines · Hongxu Jia
The xmlto was shipped from meta-oe, and fixed the defects that 'xmlto/xsltproc stylesheets cannot be found even when they are installed in sysroot'
The xmlto required docbook-xml-dtd and docbook-xsl-stylesheets, we refered debian's docbook-xml-dtd and ubuntu config.
We also enable xmlto for alsa-utils, xorg-proto-common.inc, xorg-lib-common.inc, xserver-xorg.inc.
Presumably the goal here is to enable documentation generation? I'd say what we want is more complicated than a blanket "--with-xmlto" and comes back to the same points I raised when the doxygen patch was submitted.
Native packages never need to build documentation, as nobody is going to read it. We've made steps in this direction with the texinfo class that stubs makeinfo for native recipes.
Target packages may want documentation, but may not. A powerul board such as a Minnow or Beagle can support development on the target and having e.g. the X11 protocol documentation available might be convenient. A board with no UI and 64MB of RAM isn't going to support development on the target and every built piece of documentation is wasted time.
SDK packages do want documentation. The ability to ship a SDK with a toolchain, libraries, and exactly the correct documentation for the libraries is valuable and currently something we can't do.
I'd suggest that we need a global BUILD_DOCUMENTATION variable that can be overridden per-class so that e.g. native and target recipes don't build documentation but SDK packages do. Then along with xmlto we can add gtk-doc and doxygen, adding the ability to build full API documentation for the SDKs.
As such this is definitely a two-part series. Adding xmlto is useful and I'm genuinely happy that someone who wasn't me managed to get docbook-xsl working ;) as that's the blocker for gtk-doc support too. However rnabling xmlto in some recipes globally isn't the right thing to do and will introduce noticeable regressions in build time for many classes of users for no reason.
Ross
Quoted 37 lines · Ross
Quoted 9 lines · Hongxu Jia
The xmlto was shipped from meta-oe, and fixed the defects that 'xmlto/xsltproc stylesheets cannot be found even when they are installed in sysroot'
The xmlto required docbook-xml-dtd and docbook-xsl-stylesheets, we refered debian's docbook-xml-dtd and ubuntu config.
We also enable xmlto for alsa-utils, xorg-proto-common.inc, xorg-lib-common.inc, xserver-xorg.inc.
Presumably the goal here is to enable documentation generation? I'd say what we want is more complicated than a blanket "--with-xmlto" and comes back to the same points I raised when the doxygen patch was submitted.
Native packages never need to build documentation, as nobody is going to read it. We've made steps in this direction with the texinfo class that stubs makeinfo for native recipes.
Target packages may want documentation, but may not. A powerul board such as a Minnow or Beagle can support development on the target and having e.g. the X11 protocol documentation available might be convenient. A board with no UI and 64MB of RAM isn't going to support development on the target and every built piece of documentation is wasted time.
SDK packages do want documentation. The ability to ship a SDK with a toolchain, libraries, and exactly the correct documentation for the libraries is valuable and currently something we can't do.
I'd suggest that we need a global
BUILD_DOCUMENTATIONvariable that can be overridden per-class so that e.g. native and target recipes don't build documentation but SDK packages do. Then along with xmlto we can add gtk-doc and doxygen, adding the ability to build full API documentation for the SDKs.
Quoted 6 lines
As such this is definitely a two-part series. Adding xmlto is useful and I'm genuinely happy that someone who wasn't me managed to get docbook-xsl working ;) as that's the blocker for gtk-doc support too. However rnabling xmlto in some recipes globally isn't the right thing to do and will introduce noticeable regressions in build time for many classes of users for no reason.
I second all your concerns and also I add that the commit logs were too pour.
I am really not sure about a global setting is the way to go. I'd be more included to a PACKAGECONFIG like system.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 6 lines · Ross
As such this is definitely a two-part series. Adding xmlto is useful and I'm genuinely happy that someone who wasn't me managed to get docbook-xsl working;) as that's the blocker for gtk-doc support too. However rnabling xmlto in some recipes globally isn't the right thing to do and will introduce noticeable regressions in build time for many classes of users for no reason.
Got it, I will send V2 without enable xmlto in some recipes.
//Hongxu