Skip to contentSkip to conversation

Two fixes about systemd

PATCH New Chen Qi 1 participant 3 messages Aug 7, 2014

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover Two fixes about systemd

The following changes since commit 1fafe7ccc563d5ac9e41f5c1de93d2736745b512:

ghostscript: Remove bogus gsfonts reference from DESCRIPTION (2014-08-06 11:14:21 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib ChenQi/systemd_alsa-state_v86d
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/systemd_alsa-state_v86d

Chen Qi (2):
alsa-state: install init script only when 'sysvinit' is in
DISTRO_FEATURES
v86d: fix for systemd to load uvesafb module correctly

 meta/recipes-bsp/alsa-state/alsa-state.bb |   10 +++++++---
 meta/recipes-bsp/v86d/v86d/uvesafb.conf   |    2 ++
 meta/recipes-bsp/v86d/v86d_0.1.10.bb      |   14 ++++++++++++--
 3 files changed, 21 insertions(+), 5 deletions(-)
 create mode 100644 meta/recipes-bsp/v86d/v86d/uvesafb.conf
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/2 alsa-state: install init script only when 'sysvinit' is in DISTRO_FEATURES

The /etc/init.d/alsa-state is totally useless for a systemd image. Its functionality has been replaced by alsa-state.service files.

So if 'sysvinit' is not in DISTRO_FEATURES, installing this script doesn't make any sense.

[YOCTO #4420]

Signed-off-by Chen Qi <[email protected]>
---
 meta/recipes-bsp/alsa-state/alsa-state.bb |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
meta/recipes-bsp/alsa-state/alsa-state.bb +7 -3
index 874d6bb..d2f8ea2 100644
@@ -24,11 +24,15 @@ INITSCRIPT_NAME = "alsa-state"
 INITSCRIPT_PARAMS = "start 39 S . stop 31 0 6 ."
 
 do_install() {
-    sed -i -e "s:#STATEDIR#:${localstatedir}/lib/alsa:g" ${WORKDIR}/alsa-state-init
-    install -d ${D}${sysconfdir}/init.d
-    install -m 0755 ${WORKDIR}/alsa-state-init ${D}${sysconfdir}/init.d/alsa-state
+    # Only install the init script when 'sysvinit' is in DISTRO_FEATURES.
+    if ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
+	sed -i -e "s:#STATEDIR#:${localstatedir}/lib/alsa:g" ${WORKDIR}/alsa-state-init
+	install -d ${D}${sysconfdir}/init.d
+	install -m 0755 ${WORKDIR}/alsa-state-init ${D}${sysconfdir}/init.d/alsa-state
+    fi
 
     install -d ${D}/${localstatedir}/lib/alsa
+    install -d ${D}${sysconfdir}
     install -m 0644 ${WORKDIR}/asound.conf ${D}${sysconfdir}
     install -m 0644 ${WORKDIR}/*.state ${D}${localstatedir}/lib/alsa
 }
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 2/2 v86d: fix for systemd to load uvesafb module correctly

In reply to Chen Qi

The /etc/init.d/fbsetup script doesn't have any effect in a systemd image. Its purpose is to load the uvesafb kernel module at boot. This functionality could be achieved by adding a configuration file under /etc/modules-load.d/ directory which would be parsed by the systemd-modules-load.service.

[YOCTO #4420]

Signed-off-by Chen Qi <[email protected]>
---
 meta/recipes-bsp/v86d/v86d/uvesafb.conf |    2 ++
 meta/recipes-bsp/v86d/v86d_0.1.10.bb    |   14 ++++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-bsp/v86d/v86d/uvesafb.conf
meta/recipes-bsp/v86d/v86d/uvesafb.conf new file +2 -0
new file mode 100644
index 0000000..4378975
@@ -0,0 +1,2 @@
+# Load uvesafb.ko at boot
+uvesafb
meta/recipes-bsp/v86d/v86d_0.1.10.bb +12 -2
index b980331..08438be 100644
@@ -12,6 +12,7 @@ PR = "r2"
 SRC_URI = "http://distfiles.gentoo.org/distfiles/${BP}.tar.bz2 \
            file://Update-x86emu-from-X.org.patch \
            file://fbsetup \
+           file://uvesafb.conf \
            file://ar-from-env.patch"
 
 SRC_URI[md5sum] = "51c792ba7b874ad8c43f0d3da4cfabe0"

@@ -35,8 +36,17 @@ do_install () {
 	install -d ${D}${base_sbindir}
 	install v86d ${D}${base_sbindir}/
 
-        install -d ${D}${sysconfdir}/init.d/
-        install -m 0755 ${WORKDIR}/fbsetup ${D}${sysconfdir}/init.d/fbsetup
+        # Only install fbsetup script if 'sysvinit' is in DISTRO_FEATURES
+        if ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
+            install -d ${D}${sysconfdir}/init.d/
+            install -m 0755 ${WORKDIR}/fbsetup ${D}${sysconfdir}/init.d/fbsetup
+        fi
+
+        # Install systemd related configuration file
+        if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
+            install -d ${D}${sysconfdir}/modules-load.d
+            install -m 0644 ${WORKDIR}/uvesafb.conf ${D}${sysconfdir}/modules-load.d
+        fi
 }
 
 inherit update-rc.d
Signature · 1 line
1.7.9.5