Skip to contentSkip to conversation

Set CONFIG_SHELL for xz and gzip

PATCH In review Robert Yang 1 participant 4 messages Aug 13, 2014 – Aug 14, 2014

lore
Share & tools
lore
#0 lore raw

cover Set CONFIG_SHELL for xz and gzip

The following changes since commit 4321c553d5ae816e566234e981a0815bba046d39:

SIGGEN_EXCLUDERECIPES_ABISAFE: add initscripts (2014-08-11 17:44:09 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/bash
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/bash

Robert Yang (2):
xz: set CONFIG_SHELL to /bin/sh
gzip: set CONFIG_SHELL to /bin/sh

 meta/recipes-extended/gzip/gzip.inc       |    2 ++
 meta/recipes-extended/xz/xz_5.1.3alpha.bb |    2 ++
 2 files changed, 4 insertions(+)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/2 xz: set CONFIG_SHELL to /bin/sh

It would be bash, sh, ksh or sh5 according to the host if we don't set this, and its scripts don't have bashism as the checkbashisms shows.

---
 meta/recipes-extended/xz/xz_5.1.3alpha.bb |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-extended/xz/xz_5.1.3alpha.bb +2 -0
index b8501a5..168e383 100644
@@ -38,3 +38,5 @@ FILES_liblzma-staticdev = "${libdir}/liblzma.a"
 FILES_liblzma-dbg = "${libdir}/.debug/liblzma*"
 
 BBCLASSEXTEND = "native nativesdk"
+
+export CONFIG_SHELL="/bin/sh"
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/2 gzip: set CONFIG_SHELL to /bin/sh

In reply to Robert Yang

It would be bash, sh, ksh or sh5 according to the host if we don't set this, and its scripts don't have bashism as the checkbashisms shows.

---
 meta/recipes-extended/gzip/gzip.inc |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-extended/gzip/gzip.inc +2 -0
index eeeafe0..671b1eb 100644
@@ -30,3 +30,5 @@ ALTERNATIVE_${PN} = "gunzip gzip zcat"
 ALTERNATIVE_LINK_NAME[gunzip] = "${base_bindir}/gunzip"
 ALTERNATIVE_LINK_NAME[gzip] = "${base_bindir}/gzip"
 ALTERNATIVE_LINK_NAME[zcat] = "${base_bindir}/zcat"
+
+export CONFIG_SHELL="/bin/sh"
Signature · 1 line
1.7.9.5
#3 lore raw
In reply to Robert Yang

I added grep's patch which is similar to xz and gzip to the repo, so there should be 3 patches:

git://git.openembedded.org/openembedded-core-contrib rbt/bash

====== patch ======

grep: set CONFIG_SHELL to /bin/sh

It would be bash, sh, ksh or sh5 according to the host if we don't set this, and its scripts don't have bashism as the checkbashisms shows.

---
 meta/recipes-extended/grep/grep_2.19.bb   |    1 +
 meta/recipes-extended/grep/grep_2.5.1a.bb |    2 ++
 2 files changed, 3 insertions(+)
meta/recipes-extended/grep/grep_2.19.bb +1 -0
index f38a9a6..9c162cc 100644
@@ -36,3 +36,4 @@ ALTERNATIVE_LINK_NAME[grep] = "${base_bindir}/grep"
 ALTERNATIVE_LINK_NAME[egrep] = "${base_bindir}/egrep"
 ALTERNATIVE_LINK_NAME[fgrep] = "${base_bindir}/fgrep"
 
+export CONFIG_SHELL="/bin/sh"
meta/recipes-extended/grep/grep_2.5.1a.bb +2 -0
index 79842ba..1ce112e 100644
@@ -47,3 +47,5 @@ ALTERNATIVE_${PN} = "grep egrep fgrep"
 ALTERNATIVE_LINK_NAME[grep] = "${base_bindir}/grep"
 ALTERNATIVE_LINK_NAME[egrep] = "${base_bindir}/egrep"
 ALTERNATIVE_LINK_NAME[fgrep] = "${base_bindir}/fgrep"
+
+export CONFIG_SHELL="/bin/sh"
Signature · 3 lines
1.7.9.5

// Robert
Quoted 17 lines · Robert Yang

The following changes since commit 4321c553d5ae816e566234e981a0815bba046d39:

   SIGGEN_EXCLUDERECIPES_ABISAFE: add initscripts (2014-08-11 17:44:09 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/bash
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/bash

Robert Yang (2):
xz: set CONFIG_SHELL to /bin/sh
gzip: set CONFIG_SHELL to /bin/sh

  meta/recipes-extended/gzip/gzip.inc       |    2 ++
  meta/recipes-extended/xz/xz_5.1.3alpha.bb |    2 ++
  2 files changed, 4 insertions(+)