Skip to contentSkip to conversation

Avoid build-deps QA warnings

PATCH In review Peter Kjellerstedt 3 participants 6 messages Aug 13, 2014 – Aug 14, 2014

lore
Share & tools
lore
#0 lore raw

cover Avoid build-deps QA warnings

These changes avoids build-deps QA warnings for two recipes.

//Peter

The following changes since commit 6882d2d9993c8655a292c93e84ea01b4738a700d:

yocto-project-qs, ref-manual: Added 'socat' package to essentials. (2014-08-12 13:50:32 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib pkj/build-deps
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/build-deps

Peter Kjellerstedt (2):
gdb: Add a dependency on zlib gstreamer1.0-plugins-good: Add a PACKAGECONFIG for udev

 meta/recipes-devtools/gdb/gdb-common.inc                        | 2 +-
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.0
#1 lore raw

PATCH 1/2 gdb: Add a dependency on zlib

This solves the following warning:

WARNING: QA Issue: gdb rdepends on zlib, but it isn't a build dependency? [build-deps]

---
 meta/recipes-devtools/gdb/gdb-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-common.inc +1 -1
index b4d4880..599b405 100644
@@ -2,7 +2,7 @@ SUMMARY = "GNU debugger"
 HOMEPAGE = "http://www.gnu.org/software/gdb/"
 LICENSE = "GPLv3+"
 SECTION = "devel"
-DEPENDS = "expat ncurses readline ${LTTNGUST}"
+DEPENDS = "expat zlib ncurses readline ${LTTNGUST}"
 
 LTTNGUST = "lttng-ust"
 LTTNGUST_aarch64 = ""
Signature · 1 line
1.9.0
#2 lore raw

PATCH 2/2 gstreamer1.0-plugins-good: Add a PACKAGECONFIG for udev

In reply to Peter Kjellerstedt

This solves these floating dependencies:

WARNING: QA Issue: gstreamer1.0-plugins-good-video4linux2 rdepends on libudev, but it isn't a build dependency? [build-deps]
WARNING: QA Issue: gstreamer1.0-plugins-good-video4linux2 rdepends on libgudev-1.0, but it isn't a build dependency? [build-deps]

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc +2 -1
index 223e790..b33ab2b 100644
@@ -11,7 +11,7 @@ inherit gettext
 PACKAGECONFIG ??= " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
-    orc cairo flac gdk-pixbuf jpeg libpng soup speex taglib \
+    orc cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib \
     "
 
 X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
@@ -22,6 +22,7 @@ PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
 PACKAGECONFIG[cairo]      = "--enable-cairo,--disable-cairo,cairo"
 PACKAGECONFIG[flac]       = "--enable-flac,--disable-flac,flac"
 PACKAGECONFIG[gdk-pixbuf] = "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
+PACKAGECONFIG[gudev]      = "--with-gudev,--without-gudev,udev"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[jpeg]       = "--enable-jpeg,--disable-jpeg,jpeg"
 PACKAGECONFIG[libpng]     = "--enable-libpng,--disable-libpng,libpng"
Signature · 1 line
1.9.0
#3 lore raw

Re: [PATCH 2/2] gstreamer1.0-plugins-good: Add a PACKAGECONFIG for udev

Quoted 1 line · Peter Kjellerstedt

+PACKAGECONFIG[gudev] = "--with-gudev,--without-gudev,udev"

Don't you need to depend on gudev here aswell?

Ross

#4 lore raw

Re: [PATCH 2/2] gstreamer1.0-plugins-good: Add a PACKAGECONFIG for udev

Op 14 aug. 2014, om 13:21 heeft Burton, Ross <[email protected]> het volgende geschreven:

Quoted 4 lines · Peter Kjellerstedt
Quoted 1 line

+PACKAGECONFIG[gudev] = "--with-gudev,--without-gudev,udev"

Don't you need to depend on gudev here aswell?

gudev is part of udev, right? And as a shlib it will get picked up as RDEPEND automatically[1].

regards,

Koen

[1] Unless gst is stupid and dlopen()s it.

#5 lore raw

Re: [PATCH 2/2] gstreamer1.0-plugins-good: Add a PACKAGECONFIG for udev

Quoted 1 line · Koen Kooi

gudev is part of udev, right? And as a shlib it will get picked up as RDEPEND automatically[1].

Yep, brainfart my end - confused it with another library.

Ross