Skip to contentSkip to conversation

sanity.bbclass/kernel.bbclass: minor fixes

PATCH New Robert Yang 1 participant 2 messages Aug 22, 2014

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover sanity.bbclass/kernel.bbclass: minor fixes

The following changes since commit 47d1fc9f5c38f3d092937c47bd4c2f45adaa7fe6:

qemu: fix Darwin cross-compilation (2014-08-18 20:43:24 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/typo
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/typo

Robert Yang (1):
sanity.bbclass/kernel.bbclass: minor fixes

 meta/classes/kernel.bbclass |    2 +-
 meta/classes/sanity.bbclass |    7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 sanity.bbclass/kernel.bbclass: minor fixes

Fixed:
- Remove an unused line
- Remove unneeded code after d.getVar(), we don't need the "or ''" after d.getVar() unless we need a string.
- typo: PREMIRROS -> PREMIRRORS.

Signed-off-by Robert Yang <[email protected]>
---
 meta/classes/kernel.bbclass |    2 +-
 meta/classes/sanity.bbclass |    7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)
meta/classes/kernel.bbclass +1 -1
index 1289873..76d04a7 100644
@@ -12,7 +12,7 @@ INITRAMFS_TASK ?= ""
 INITRAMFS_IMAGE_BUNDLE ?= ""
 
 python __anonymous () {
-    kerneltype = d.getVar('KERNEL_IMAGETYPE', True) or ''
+    kerneltype = d.getVar('KERNEL_IMAGETYPE', True)
     if kerneltype == 'uImage':
         depends = d.getVar("DEPENDS", True)
         depends = "%s u-boot-mkimage-native" % depends
meta/classes/sanity.bbclass +3 -4
index b5fab6a..3b40ebe 100644
@@ -150,10 +150,9 @@ def check_toolchain_tune(data, tune, multilib):
             bb.debug(2, "  %s: %s" % (feature, valid_tunes[feature]))
         else:
             tune_errors.append("Feature '%s' is not defined." % feature)
-    whitelist = localdata.getVar("TUNEABI_WHITELIST", True) or ''
-    override = localdata.getVar("TUNEABI_OVERRIDE", True) or ''
+    whitelist = localdata.getVar("TUNEABI_WHITELIST", True)
     if whitelist:
-        tuneabi = localdata.getVar("TUNEABI_tune-%s" % tune, True) or ''
+        tuneabi = localdata.getVar("TUNEABI_tune-%s" % tune, True)
         if not tuneabi:
             tuneabi = tune
         if True not in [x in whitelist.split() for x in tuneabi.split()]:

@@ -265,7 +264,7 @@ def check_connectivity(d):
     # CONNECTIVITY_CHECK_URIS are set
     network_enabled = not d.getVar('BB_NO_NETWORK', True)
     check_enabled = len(test_uris)
-    # Take a copy of the data store and unset MIRRORS and PREMIRROS
+    # Take a copy of the data store and unset MIRRORS and PREMIRRORS
     data = bb.data.createCopy(d)
     data.delVar('PREMIRRORS')
     data.delVar('MIRRORS')
Signature · 1 line
1.7.9.5