Skip to contentSkip to conversation

package_manager.py: use RPM_PREFER_ELF_ARCH to instead of RPM_PREFER_COLOR

PATCH New Robert Yang 1 participant 3 messages Aug 29, 2014

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover package_manager.py: use RPM_PREFER_ELF_ARCH to instead of RPM_PREFER_COLOR

The following changes since commit d2fbc55d6863a767e69092bac686c02c3ec34650:

populate_sdk_base: Remap TOOLCHAIN_HOST_TASK variable (2014-08-28 15:12:31 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/rpm
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/rpm

Robert Yang (2):
local.conf.sample.extended: update for RPM_PREFER_ELF_ARCH package_manager.py: use RPM_PREFER_ELF_ARCH

 meta/conf/local.conf.sample.extended |    6 +++---
 meta/lib/oe/package_manager.py       |   12 ++++++------
 meta/lib/oe/rootfs.py                |    2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/2 local.conf.sample.extended: update for RPM_PREFER_ELF_ARCH

Updated as the rpm upstream suggested:
- RPM_PREFER_COLOR -> RPM_PREFER_ELF_ARCH
- 3 -> 4

Signed-off-by Robert Yang <[email protected]>
---
 meta/conf/local.conf.sample.extended |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/conf/local.conf.sample.extended +3 -3
index f7d8798..3211997 100644
@@ -145,12 +145,12 @@
 #MULTILIBS = "multilib:lib32"
 #DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
 
-# Set RPM_PREFER_COLOR to configure preferred ABI when using rpm packaging
+# Set RPM_PREFER_ELF_ARCH to configure preferred ABI when using rpm packaging
 # backend to generate a rootfs, choices are:
 # 1: ELF32 wins
 # 2: ELF64 wins
-# 3: ELF64 N32 wins (for mips64 or mips64el only)
-#RPM_PREFER_COLOR ?= "2"
+# 4: ELF64 N32 wins (for mips64 or mips64el only)
+#RPM_PREFER_ELF_ARCH ?= "2"
 
 # The network based PR service host and port
 # Uncomment the following lines to enable PRservice.
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 2/2 package_manager.py: use RPM_PREFER_ELF_ARCH

In reply to Robert Yang

Use RPM_PREFER_ELF_ARCH to instead of RPM_PREFER_COLOR as rpm upstream suggested, and use "4" to instead of "3" since it is a bit mask (not enumeration), so we need "4" here.

Signed-off-by Robert Yang <[email protected]>
---
 meta/lib/oe/package_manager.py |   12 ++++++------
 meta/lib/oe/rootfs.py          |    2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)
meta/lib/oe/package_manager.py +6 -6
index f8fc3c2..2df2d86 100644
@@ -798,17 +798,17 @@ class RpmPM(PackageManager):
                            self.d.getVar('localstatedir', True))
         cmd = 'config --set rpm-extra-macros._tmppath=/install/tmp'
 
-        prefer_color = self.d.getVar('RPM_PREFER_COLOR', True)
+        prefer_color = self.d.getVar('RPM_PREFER_ELF_ARCH', True)
         if prefer_color:
-            if prefer_color not in ['0', '1', '2', '3']:
-                bb.fatal("Invalid RPM_PREFER_COLOR: %s, it should be one of:\n"
+            if prefer_color not in ['0', '1', '2', '4']:
+                bb.fatal("Invalid RPM_PREFER_ELF_ARCH: %s, it should be one of:\n"
                         "\t1: ELF32 wins\n"
                         "\t2: ELF64 wins\n"
-                        "\t3: ELF64 N32 wins (mips64 or mips64el only)" %
+                        "\t4: ELF64 N32 wins (mips64 or mips64el only)" %
                         prefer_color)
-            if prefer_color == "3" and self.d.getVar("TUNE_ARCH", True) not in \
+            if prefer_color == "4" and self.d.getVar("TUNE_ARCH", True) not in \
                                     ['mips64', 'mips64el']:
-                bb.fatal("RPM_PREFER_COLOR = \"3\" is for mips64 or mips64el "
+                bb.fatal("RPM_PREFER_ELF_ARCH = \"4\" is for mips64 or mips64el "
                          "only.")
             self._invoke_smart('config --set rpm-extra-macros._prefer_color=%s'
                         % prefer_color)
meta/lib/oe/rootfs.py +1 -1
index 0424a01..3d8ae81 100644
@@ -330,7 +330,7 @@ class RpmRootfs(Rootfs):
     @staticmethod
     def _depends_list():
         return ['DEPLOY_DIR_RPM', 'INC_RPM_IMAGE_GEN', 'RPM_PREPROCESS_COMMANDS',
-                'RPM_POSTPROCESS_COMMANDS', 'RPM_PREFER_COLOR']
+                'RPM_POSTPROCESS_COMMANDS', 'RPM_PREFER_ELF_ARCH']
 
     def _get_delayed_postinsts(self):
         postinst_dir = self.d.expand("${IMAGE_ROOTFS}${sysconfdir}/rpm-postinsts")
Signature · 1 line
1.7.9.5