Skip to contentSkip to conversation

Fix buildhistory regression

PATCH Superseded Paul Eggleton 1 participant 3 messages Sep 9, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Fix buildhistory regression

The following change since commit e72aac2ae9e5fce1715fa04b7e94034fd06892d9:

alsa-lib: libasound should runtime depends on alsa-conf (2014-09-03 11:30:11 +0100)

is available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib paule/sstate-buildhistory
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/sstate-buildhistory

Paul Eggleton (1):
classes/sstate: fix regression affecting buildhistory

 meta/classes/sstate.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 classes/sstate: fix regression affecting buildhistory

SSTATEPOSTINSTFUNCS needs to be set with ?= here - if it's = it'll wipe out what is set in that variable in buildhistory, which ends up being parsed earlier than the statement in sstate.bbclass. This fixes buildhistory no longer recording package information since OE-Core revision 9d659c6f20fa4a141b491c62a3ef0dfb1f896d9c.

---
 meta/classes/sstate.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/sstate.bbclass +1 -1
index ead829e..6a77d18 100644
@@ -35,7 +35,7 @@ SSTATE_MANMACH ?= "${SSTATE_PKGARCH}"
 SSTATECREATEFUNCS = "sstate_hardcode_path"
 SSTATEPREINSTFUNCS = ""
 SSTATEPOSTUNPACKFUNCS = "sstate_hardcode_path_unpack"
-SSTATEPOSTINSTFUNCS = ""
+SSTATEPOSTINSTFUNCS ?= ""
 EXTRA_STAGING_FIXMES ?= ""
 
 # Specify dirs in which the shell function is executed and don't use ${B}
Signature · 1 line
1.9.3
#2 lore raw

Re: [PATCH 1/1] classes/sstate: fix regression affecting buildhistory

Quoted 16 lines · On Tuesday 09 September 2014 11:05:56 Paul Eggleton wrote:

SSTATEPOSTINSTFUNCS needs to be set with ?= here - if it's = it'll wipe out what is set in that variable in buildhistory, which ends up being parsed earlier than the statement in sstate.bbclass. This fixes buildhistory no longer recording package information since OE-Core revision 9d659c6f20fa4a141b491c62a3ef0dfb1f896d9c.

---
 meta/classes/sstate.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/sstate.bbclass +0 -0
index ead829e..6a77d18 100644

meta/classes/sstate.bbclass SSTATE_MANMACH ?= "${SSTATE_PKGARCH}" · line 41

Quoted 8 lines
meta/classes/sstate.bbclass +1 -1
@@ -35,7 +35,7 @@ SSTATE_MANMACH ?= "${SSTATE_PKGARCH}"
 SSTATECREATEFUNCS = "sstate_hardcode_path"
 SSTATEPREINSTFUNCS = ""
 SSTATEPOSTUNPACKFUNCS = "sstate_hardcode_path_unpack"
-SSTATEPOSTINSTFUNCS = ""
+SSTATEPOSTINSTFUNCS ?= ""
 EXTRA_STAGING_FIXMES ?= ""
 
 # Specify dirs in which the shell function is executed and don't use ${B}

OK, so Richard informs me that there was a good reason for making this change. v2 incoming.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre