Skip to contentSkip to conversation

A few autobuilder fixes (branch yem/autobuild)

PATCH New Yann E. MORIN 4 participants 12 messages Sep 28, 2014 – Oct 1, 2014

lore
Share & tools
lore
#0 lore raw

cover A few autobuilder fixes (branch yem/autobuild)

Hello All!

TRhis series brings in a few fixes for autobuilder failures, mostly related to static builds.

Regards,
Yann E. MORIN.

The following changes since commit 6f5bffc426f7418c555291450d482a0ceede0865:

qemu-ppc: update kernel to latest for g3beige emulation (2014-09-27 09:53:12 +0200)

are available in the git repository at:

git://gitorious.org/buildroot/buildroot.git yem/autobuild

for you to fetch changes up to 6d21f6468575ab79a003b9f8542f23251b459123:

package/vde2: does not build on static only, needs dlopen() (2014-09-28 18:24:18 +0200)

----------------------------------------------------------------
Yann E. MORIN (4):
docs/manual: add musl to toolchain dependency options package/freerdp: can not build on uClibc package/trace-cmd: does not build on static onl;y, needs dlopen() package/vde2: does not build on static only, needs dlopen()

 docs/manual/adding-packages-directory.txt | 2 +-
 package/freerdp/Config.in                 | 5 +++++
 package/trace-cmd/Config.in               | 6 ++++--
 package/vde2/Config.in                    | 5 +++++
 4 files changed, 15 insertions(+), 3 deletions(-)
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#1 lore raw

PATCH 1/4 docs/manual: add musl to toolchain dependency options

Currently, we only document (e)glibc and uClibc as C libraries on which we can depend. However, we've supported musl for quite some time now.

So, also refference it in the manual, when dealing with toolchain options a pa ckage may have to depend on.

Cc Thomas Petazzoni <[email protected]>
---
 docs/manual/adding-packages-directory.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/manual/adding-packages-directory.txt +1 -1
index fd9460c..2e259ba 100644
@@ -232,7 +232,7 @@ use in the comment.
 
 * C library
 ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+,
-   +BR2_TOOLCHAIN_USES_UCLIBC+
+   +BR2_TOOLCHAIN_USES_UCLIBC+, +BR2_TOOLCHAIN_USES_MUSL+
 ** Comment string: for the C library, a slightly different comment text
    is used: +foo needs an (e)glibc toolchain+, or `foo needs an (e)glibc
    toolchain w/ C++`
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/4 docs/manual: add musl to toolchain dependency options

Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Currently, we only document (e)glibc and uClibc as C libraries on which we can depend. However, we've supported musl for quite some time now.

So, also refference it in the manual, when dealing with toolchain options a pa ckage may have to depend on.

Cc Thomas Petazzoni <[email protected]>
---
 docs/manual/adding-packages-directory.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/manual/adding-packages-directory.txt +0 -0
index fd9460c..2e259ba 100644

docs/manual/adding-packages-directory.txt use in the comment. · line 235

Quoted 5 lines
docs/manual/adding-packages-directory.txt +1 -1
@@ -232,7 +232,7 @@ use in the comment.
 
 * C library
 ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+,
-   +BR2_TOOLCHAIN_USES_UCLIBC+
+   +BR2_TOOLCHAIN_USES_UCLIBC+, +BR2_TOOLCHAIN_USES_MUSL+

Lets keep it sorted (so musl before uclibc).

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/4 package/freerdp: can not build on uClibc

In reply to Yann E. MORIN

FreeRDP uses eventfd_{read,write}, which is not supported in uClibc.

Fixes:

    http://autobuild.buildroot.net/results/ad7/ad7ade4c436d21cba930f40c613870fbadec840e/
    http://autobuild.buildroot.net/results/5a3/5a30aecbb426f76a22e8285931a0a8cd59b5e70b/
    http://autobuild.buildroot.net/results/6e0/6e0de0538e95ae156f7d2ad6eede46e44be81c8e/
    [...]

---
Note: although we depend on !uClibc, we still comment about glibc or musl, because we currently do not have a documented way for negative dependencies.

---
 package/freerdp/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/freerdp/Config.in +5 -0
index c5ff769..2a876b2 100644
@@ -7,8 +7,13 @@ config BR2_PACKAGE_FREERDP
 	select BR2_PACKAGE_XLIB_LIBXCURSOR
 	select BR2_PACKAGE_ZLIB
 	depends on BR2_PACKAGE_XORG7
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC # evenft_{read,write}
 	help
 	  FreeRDP is a free implementation of the Remote Desktop
 	  Protocol (RDP), released under the Apache license
 
 	  http://www.freerdp.com/
+
+comment "freerdp needs an (e)glibc or musl toolchain"
+	depends on BR2_PACKAGE_XORG7
+	depends on BR2_TOOLCHAIN_USES_UCLIBC
Signature · 1 line
1.9.1
#4 lore raw

PATCH 2/4 package/freerdp: can not build on uClibc

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

FreeRDP uses eventfd_{read,write}, which is not supported in uClibc. Fixes:

    http://autobuild.buildroot.net/results/ad7/ad7ade4c436d21cba930f40c613870fbadec840e/
    http://autobuild.buildroot.net/results/5a3/5a30aecbb426f76a22e8285931a0a8cd59b5e70b/
    http://autobuild.buildroot.net/results/6e0/6e0de0538e95ae156f7d2ad6eede46e44be81c8e/
    [...]
Quoted 6 lines

---
Note: although we depend on !uClibc, we still comment about glibc or musl, because we currently do not have a documented way for negative dependencies.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 2/4 package/freerdp: can not build on uClibc

Quoted 9 lines · Peter Korsgaard
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

FreeRDP uses eventfd_{read,write}, which is not supported in uClibc. Fixes:

    http://autobuild.buildroot.net/results/ad7/ad7ade4c436d21cba930f40c613870fbadec840e/
    http://autobuild.buildroot.net/results/5a3/5a30aecbb426f76a22e8285931a0a8cd59b5e70b/
    http://autobuild.buildroot.net/results/6e0/6e0de0538e95ae156f7d2ad6eede46e44be81c8e/
    [...]
Quoted 9 lines
Quoted 6 lines

---
Note: although we depend on !uClibc, we still comment about glibc or musl, because we currently do not have a documented way for negative dependencies.

Committed, thanks.

Dear Peter,

I sent this patch 5 days ago to add support for uClibc for this package by applying an upstream patch:

http://patchwork.ozlabs.org/patch/392966/

Please, take it into consideration. I think it's better to fix the package instead of disabling it.

Thanks,

Signature · 1 line
Vincent
#6 lore raw

PATCH 2/4 package/freerdp: can not build on uClibc

Dear Vicente Olivert Riera,

Quoted 7 lines · Vicente Olivert Riera

I sent this patch 5 days ago to add support for uClibc for this package by applying an upstream patch:

http://patchwork.ozlabs.org/patch/392966/

Please, take it into consideration. I think it's better to fix the package instead of disabling it.

Agreed.

Can you resend your patch, after taking into account the comments made by Yann, and also making sure to re-enable freerdp with uClibc as part of this patch (effectively reverting Yann's patch) ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#7 lore raw

PATCH 2/4 package/freerdp: can not build on uClibc

Dear Thomas Petazzoni,

Quoted 14 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 7 lines · Vicente Olivert Riera

I sent this patch 5 days ago to add support for uClibc for this package by applying an upstream patch:

http://patchwork.ozlabs.org/patch/392966/

Please, take it into consideration. I think it's better to fix the package instead of disabling it.

Agreed.

Quoted 7 lines

Can you resend your patch, after taking into account the comments made by Yann, and also making sure to re-enable freerdp with uClibc as part of this patch (effectively reverting Yann's patch) ?

Thanks,

Thomas

Done: http://patchwork.ozlabs.org/patch/395466/

Signature · 1 line
Vincent
#8 lore raw

PATCH 3/4 package/trace-cmd: does not build on static onl; y, needs dlopen()

In reply to Yann E. MORIN

Fixes:

    http://autobuild.buildroot.net/results/4d773e0738c1d5adada8c0a4bca312068132fd9b/
---
 package/trace-cmd/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/trace-cmd/Config.in +4 -2
index baa4868..8b3bc5f 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_TRACE_CMD
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_avr32 # AVR32 does not have TLS support
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB # dlopen()
 	help
 	  Command line reader for ftrace.
 
@@ -14,6 +15,7 @@ config BR2_PACKAGE_TRACE_CMD
 
 	  http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
 
-comment "trace-cmd needs a toolchain w/ largefile, threads"
-	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+comment "trace-cmd needs a toolchain w/ largefile, threads, dynamic library"
 	depends on BR2_USE_MMU
+	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS \
+		|| BR2_PREFER_STATIC_LIB
Signature · 1 line
1.9.1
#9 lore raw

PATCH 3/4 package/trace-cmd: does not build on static onl; y, needs dlopen()

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Committed after fixing the typo in $SUBJECT, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH 4/4 package/vde2: does not build on static only, needs dlopen()

In reply to Yann E. MORIN

Fixes:

    http://autobuild.buildroot.net/results/f9d/f9d23455a138e2214546922486c03c9d3c35b04a/
---
 package/vde2/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/vde2/Config.in +5 -0
index 2bbd822..18ff2e4 100644
@@ -1,9 +1,14 @@
 config BR2_PACKAGE_VDE2
 	bool "vde2"
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_PREFER_STATIC_LIB # dlopen()
 	help
 	  VDE is an ethernet compliant virtual network that can be
 	  spawned over a set of physical computers over the Internet.
 	  VDE is part of the virtualsquare project.
 
 	  http://vde.sourceforge.net/
+
+comment "vde2 needs a toolchain w/ dynamic library"
+	depends on BR2_USE_MMU
+	depends on BR2_PREFER_STATIC_LIB
Signature · 1 line
1.9.1