fix for guile and neard
cover fix for guile and neard
The following changes since commit 6541799c2e9a5a1586676c207d62f885c70e24dc:
lib/oe/rootfs.py: Fix reference to abiversion file location (2015-01-16 23:14:26 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/neard_guile
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/neard_guile
Robert Yang (4):
Revert "guile: fixed installed-vs-shipped error"
guile: fix installed-vs-shipped error
neard: fix B != S
neard: fix parallel issue
meta/recipes-connectivity/neard/neard.inc | 4 +--
.../neard/Makefile.am-fix-parallel-issue.patch | 33 ++++++++++++++++++++
meta/recipes-connectivity/neard/neard_0.14.bb | 2 ++
...pends.patch => libguile-Makefile.am-hook.patch} | 23 ++++++++------
meta/recipes-devtools/guile/guile_2.0.11.bb | 2 +-
5 files changed, 51 insertions(+), 13 deletions(-)
create mode 100644 meta/recipes-connectivity/neard/neard/Makefile.am-fix-parallel-issue.patch
rename meta/recipes-devtools/guile/files/{libguile-Makefile.am-depends.patch => libguile-Makefile.am-hook.patch} (56%)Signature · 1 line
1.7.9.5
PATCH 1/4 Revert "guile: fixed installed-vs-shipped error"
This reverts commit 397f27cdceaa4874d8d06aad10cd37a5817d90b8.
The fix isn't correct, caused:
install: cannot create regular file `/path/to/sysroots/x86_64-linux/usr/lib/libguile-2.0.so.22.7.2': File exists
will add a new fix.
--- .../guile/files/libguile-Makefile.am-depends.patch | 39 -------------------- meta/recipes-devtools/guile/guile_2.0.11.bb | 1 - 2 files changed, 40 deletions(-) delete mode 100644 meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch
meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch deleted +0 -39
@@ -1,39 +0,0 @@ -From 9c4e120a7a87db34d22a50883a5a525170b480d7 Mon Sep 17 00:00:00 2001 -From: Robert Yang <[email protected]> -Date: Tue, 6 Jan 2015 23:10:51 -0800 -Subject: [PATCH] libguile/Makefile.am: install-data-hook: depends on - install-libLTLIBRARIES - -It may install such a file: -/usr/lib64/libguile-2.0*-gdb.scm - -This is because when there is no file in the directory: -for f in libguile-2.0*; do - [snip] -done - -The f would be libguile-2.0* itself. - -Upstream-Status: Pending - -Signed-off-by: Robert Yang <[email protected]> ---- - libguile/Makefile.am | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/libguile/Makefile.am b/libguile/Makefile.am -index 281faac..fe0a3ba 100644 ---- a/libguile/Makefile.am -+++ b/libguile/Makefile.am -@@ -449,7 +449,7 @@ EXTRA_libguile_@GUILE_EFFECTIVE_VERSION@_la_SOURCES = _scm.h \ - install-exec-hook: - rm -f $(DESTDIR)$(bindir)/guile-snarf.awk - --install-data-hook: libguile-2.0-gdb.scm -+install-data-hook: libguile-2.0-gdb.scm install-libLTLIBRARIES - @$(MKDIR_P) $(DESTDIR)$(libdir) - ## We want to install libguile-2.0-gdb.scm as SOMETHING-gdb.scm. - ## SOMETHING is the full name of the final library. We want to ignore --- -1.7.9.5 -
meta/recipes-devtools/guile/guile_2.0.11.bb +0 -1
@@ -21,7 +21,6 @@ SRC_URI = "${GNU_MIRROR}/guile/guile-${PV}.tar.xz \ file://arm_endianness.patch \ file://arm_aarch64.patch \ file://workaround-ice-ssa-corruption.patch \ - file://libguile-Makefile.am-depends.patch \ " # file://debian/0001-Change-guile-to-guile-X.Y-for-info-pages.patch
Signature · 1 line
1.7.9.5
PATCH 2/4 guile: fix installed-vs-shipped error
In reply to Robert YangFixed:
guile-2.0.11: guile: Files/directories were installed but not shipped
/usr/lib64/libguile-2.0*-gdb.scm [installed-vs-shipped]
This is because when there is no file in the directory:
for f in libguile-2.0*; do
[snip]
done
The f would be libguile-2.0* itself, use install-exec-hook will fix the problem since it depends on install-libLTLIBRARIES.
--- .../guile/files/libguile-Makefile.am-hook.patch | 42 ++++++++++++++++++++ meta/recipes-devtools/guile/guile_2.0.11.bb | 1 + 2 files changed, 43 insertions(+) create mode 100644 meta/recipes-devtools/guile/files/libguile-Makefile.am-hook.patch
meta/recipes-devtools/guile/files/libguile-Makefile.am-hook.patch new file +42 -0
@@ -0,0 +1,42 @@ +From 9c4e120a7a87db34d22a50883a5a525170b480d7 Mon Sep 17 00:00:00 2001 +From: Robert Yang <[email protected]> +Date: Tue, 6 Jan 2015 23:10:51 -0800 +Subject: [PATCH] libguile/Makefile.am: install-data-hook -> install-exec-hook + +It may install such a file: +/usr/lib64/libguile-2.0*-gdb.scm + +This is because when there is no file in the directory: +for f in libguile-2.0*; do + [snip] +done + +The f would be libguile-2.0* itself, use install-exec-hook will fix the +problem since it depends on install-libLTLIBRARIES. + +Upstream-Status: Pending + +Signed-off-by: Robert Yang <[email protected]> +--- + libguile/Makefile.am | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/libguile/Makefile.am b/libguile/Makefile.am +index 5decd99..52645b7 100644 +--- a/libguile/Makefile.am ++++ b/libguile/Makefile.am +@@ -446,10 +446,8 @@ EXTRA_libguile_@GUILE_EFFECTIVE_VERSION@_la_SOURCES = _scm.h \ + ## delete guile-snarf.awk from the installation bindir, in case it's + ## lingering there due to an earlier guile version not having been + ## wiped out. +-install-exec-hook: ++install-exec-hook: libguile-2.0-gdb.scm + rm -f $(DESTDIR)$(bindir)/guile-snarf.awk +- +-install-data-hook: libguile-2.0-gdb.scm + @$(MKDIR_P) $(DESTDIR)$(libdir) + ## We want to install libguile-2.0-gdb.scm as SOMETHING-gdb.scm. + ## SOMETHING is the full name of the final library. We want to ignore +-- +1.7.9.5 +
meta/recipes-devtools/guile/guile_2.0.11.bb +1 -0
@@ -21,6 +21,7 @@ SRC_URI = "${GNU_MIRROR}/guile/guile-${PV}.tar.xz \ file://arm_endianness.patch \ file://arm_aarch64.patch \ file://workaround-ice-ssa-corruption.patch \ + file://libguile-Makefile.am-hook.patch \ " # file://debian/0001-Change-guile-to-guile-X.Y-for-info-pages.patch
Signature · 1 line
1.7.9.5
PATCH 3/4 neard: fix B != S
In reply to Robert YangAnd bump PR to avoid:
configure: error: source directory already configured; run "make distclean" there first
--- meta/recipes-connectivity/neard/neard.inc | 4 ++-- meta/recipes-connectivity/neard/neard_0.14.bb | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
meta/recipes-connectivity/neard/neard.inc +2 -2
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ file://src/near.h;beginline=1;endline=20;md5=358e4deefef251a4761e1ffacc965d13 \ " -inherit autotools-brokensep pkgconfig systemd update-rc.d +inherit autotools pkgconfig systemd update-rc.d EXTRA_OECONF += "--enable-tools"
@@ -35,7 +35,7 @@ do_install_append() { # Install the tests for neard-tests install -d ${D}${libdir}/neard install -m 0755 ${S}/test/* ${D}${libdir}/${BPN}/ - install -m 0755 ${S}/tools/nfctool/nfctool ${D}${libdir}/${BPN}/ + install -m 0755 ${B}/tools/nfctool/nfctool ${D}${libdir}/${BPN}/ } PACKAGES =+ "${PN}-tests"
meta/recipes-connectivity/neard/neard_0.14.bb +1 -0
@@ -8,3 +8,4 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/network/nfc/${BPN}-${PV}.tar.xz \ SRC_URI[md5sum] = "692ba2653d60155255244c87396c486b" SRC_URI[sha256sum] = "6ea724b443d39d679168fc7776a965d1f64727c3735391df2c01469ee7cd8cca" +PR = "r1"
Signature · 1 line
1.7.9.5
PATCH 4/4 neard: fix parallel issue
In reply to Robert YangThere might be no src dir if the src/builtin.h runs earlier, create it to fix the race issue:
src/genbuiltin nfctype1 nfctype2 nfctype3 nfctype4 p2p > src/builtin.h /bin/sh: src/builtin.h: No such file or directory
--- .../neard/Makefile.am-fix-parallel-issue.patch | 33 ++++++++++++++++++++ meta/recipes-connectivity/neard/neard_0.14.bb | 1 + 2 files changed, 34 insertions(+) create mode 100644 meta/recipes-connectivity/neard/neard/Makefile.am-fix-parallel-issue.patch
meta/recipes-connectivity/neard/neard/Makefile.am-fix-parallel-issue.patch new file +33 -0
@@ -0,0 +1,33 @@ +From 43acc56d5506c7e318f717fb3634bc16e3438913 Mon Sep 17 00:00:00 2001 +From: Robert Yang <[email protected]> +Date: Thu, 15 Jan 2015 18:12:07 -0800 +Subject: [PATCH] Makefile.am: fix parallel issue + +There might be no src dir if src/builtin.h runs earlier, create it to +fix the race issue: + +src/genbuiltin nfctype1 nfctype2 nfctype3 nfctype4 p2p > src/builtin.h +/bin/sh: src/builtin.h: No such file or directory + +Upstream-Status: Pending + +Signed-off-by: Robert Yang <[email protected]> +--- + Makefile.am | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/Makefile.am b/Makefile.am +index 3241311..a43eaa2 100644 +--- a/Makefile.am ++++ b/Makefile.am +@@ -164,6 +164,7 @@ MAINTAINERCLEANFILES = Makefile.in \ + src/plugin.$(OBJEXT): src/builtin.h + + src/builtin.h: src/genbuiltin $(builtin_sources) ++ $(AM_V_at)$(MKDIR_P) src + $(AM_V_GEN)$(srcdir)/src/genbuiltin $(builtin_modules) > $@ + + $(src_neard_OBJECTS) \ +-- +1.7.9.5 +
meta/recipes-connectivity/neard/neard_0.14.bb +1 -0
@@ -4,6 +4,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/network/nfc/${BPN}-${PV}.tar.xz \ file://parallel-build.patch \ file://neard.in \ file://neard.service.in \ + file://Makefile.am-fix-parallel-issue.patch \ " SRC_URI[md5sum] = "692ba2653d60155255244c87396c486b" SRC_URI[sha256sum] = "6ea724b443d39d679168fc7776a965d1f64727c3735391df2c01469ee7cd8cca"
Signature · 1 line
1.7.9.5