Skip to contentSkip to conversation

Rbd: add listwatchers command

PATCH In review Li Wang 2 participants 3 messages Jan 21, 2015 – Jan 22, 2015

lore
Share & tools
lore

Li Wang

author
#0 lore raw

PATCH 1/1 Rbd: add listwatchers command

Currently, RBD does not provide an easy way to consult who opened a specied image, this complicates the cloud maintenance, sometimes the administrator found that a RBD image could not be deleted with an error 'image has watchers', but no further information available. The RADOS has a command to show the watchers of an object, but the commands at RADOS level are not supposed to be exposed to a cloud administrator, and it is not clear for a non-expert administrator to how to associate an opened RBD with a corresponding watched object. This motivates us to add an RBD command to list the information of the clients who opened a RBD image to facilitate the cloud maintenance.

The patches are at:
https://github.com/ceph/ceph/pull/3435

Yunchuan Wen (3):
rbd: add listwatchers command to list the watchers of an image
test: add rbd listwatchers to src/test/cli/rbd/help.t
man: add rbd listwatchers to doc/man/8/rbd.rst

 doc/man/8/rbd.rst       |  3 +++
 src/rbd.cc              | 63 +++++++++++++++++++++++++++++++++++++++++++++++--
 src/test/cli/rbd/help.t |  1 +
 3 files changed, 65 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · Li Wang

Currently, RBD does not provide an easy way to consult who opened a specied image, this complicates the cloud maintenance, sometimes the administrator found that a RBD image could not be deleted with an error 'image has watchers', but no further information available. The RADOS has a command to

Quoted 8 lines

show the watchers of an object, but the commands at RADOS level are not supposed to be exposed to a cloud administrator, and it is not clear for a non-expert administrator to how to associate an opened RBD with a corresponding watched object. This motivates us to add an RBD command to list the information of the clients who opened a RBD image to facilitate the cloud maintenance.

Perhaps this should just be rolled into the existing 'rbd info' command. More people will see it and there's no additional cost over what info is already doing...

sage

Quoted 18 lines

The patches are at:
https://github.com/ceph/ceph/pull/3435

Yunchuan Wen (3):
rbd: add listwatchers command to list the watchers of an image
test: add rbd listwatchers to src/test/cli/rbd/help.t
man: add rbd listwatchers to doc/man/8/rbd.rst

 doc/man/8/rbd.rst       |  3 +++
 src/rbd.cc              | 63 +++++++++++++++++++++++++++++++++++++++++++++++--
 src/test/cli/rbd/help.t |  1 +
 3 files changed, 65 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.1
author
#2 lore raw

My thoughts, 'rbd info' is intended to describe the STATIC, intrinsic properties of an image, while the watchers information are dynamic, something like 'rbd showmapped', what is your opinion?

Cheers,
Li Wang

Quoted 49 lines · Sage Weil
Quoted 6 lines · Li Wang

Currently, RBD does not provide an easy way to consult who opened a specied image, this complicates the cloud maintenance, sometimes the administrator found that a RBD image could not be deleted with an error 'image has watchers', but no further information available. The RADOS has a command to

Quoted 8 lines

show the watchers of an object, but the commands at RADOS level are not supposed to be exposed to a cloud administrator, and it is not clear for a non-expert administrator to how to associate an opened RBD with a corresponding watched object. This motivates us to add an RBD command to list the information of the clients who opened a RBD image to facilitate the cloud maintenance.

Perhaps this should just be rolled into the existing 'rbd info' command. More people will see it and there's no additional cost over what info is already doing...

sage

Quoted 9 lines

The patches are at:
https://github.com/ceph/ceph/pull/3435

Yunchuan Wen (3):
rbd: add listwatchers command to list the watchers of an image
test: add rbd listwatchers to src/test/cli/rbd/help.t
man: add rbd listwatchers to doc/man/8/rbd.rst

Quoted 9 lines
  doc/man/8/rbd.rst       |  3 +++
  src/rbd.cc              | 63 +++++++++++++++++++++++++++++++++++++++++++++++--
  src/test/cli/rbd/help.t |  1 +
  3 files changed, 65 insertions(+), 2 deletions(-)

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html