Skip to contentSkip to conversation

Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

PATCH In review Aya Mahfouz 3 participants 6 messages Feb 20, 2015 – Feb 21, 2015 Staging

lore
Share & tools
lore
#0 lore raw

cover Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The replacements is safe since the header file <linux/uaccess.h> includes <asm/uaccess.h>

Aya Mahfouz (2):
staging: i2o: Use #include <linux/uaccess.h> instead of

    <asm/uaccess.h>
  staging: i2o: Use #include <linux/uaccess.h> instead of
    <asm/uaccess.h>
 drivers/staging/i2o/i2o_config.c | 3 +--
 drivers/staging/i2o/i2o_proc.c   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/2 staging: i2o: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

This patch fixes the following checkpatch.pl warning:
Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

---
 drivers/staging/i2o/i2o_config.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/i2o/i2o_config.c +1 -2
index 04bd3b6..5748663 100644
@@ -34,8 +34,7 @@
 #include <linux/mutex.h>
 #include <linux/compat.h>
 #include <linux/slab.h>
-
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 
 #include "core.h"
 
Signature · 1 line
1.9.3
#2 lore raw

PATCH 2/2 staging: i2o: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

In reply to Aya Mahfouz

This patch fixes the following checkpatch.pl warning:
Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

---
 drivers/staging/i2o/i2o_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/i2o/i2o_proc.c +1 -1
index ad84f33..cea536a 100644
@@ -48,9 +48,9 @@
 #include <linux/errno.h>
 #include <linux/spinlock.h>
 #include <linux/workqueue.h>
+#include <linux/uaccess.h>
 
 #include <asm/io.h>
-#include <asm/uaccess.h>
 #include <asm/byteorder.h>
 
 /* Structure used to define /proc entries */
Signature · 1 line
1.9.3
#3 lore raw
In reply to Aya Mahfouz
Quoted 3 lines · Aya Mahfouz

This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The replacements is safe since the header file <linux/uaccess.h> includes <asm/uaccess.h>

Thoughtful comment. Thanks.

julia

Quoted 20 lines

Aya Mahfouz (2):
staging: i2o: Use #include <linux/uaccess.h> instead of

    <asm/uaccess.h>
  staging: i2o: Use #include <linux/uaccess.h> instead of
    <asm/uaccess.h>
 drivers/staging/i2o/i2o_config.c | 3 +--
 drivers/staging/i2o/i2o_proc.c   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
Signature · 8 lines
1.9.3

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1424395309.git.mahfouz.saif.elyazal%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
#4 lore raw
In reply to Aya Mahfouz

Hi Aya,

Quoted 3 lines · Aya Mahfouz

This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The replacements is safe since the header file <linux/uaccess.h> includes <asm/uaccess.h>

Like Julia mentioned its a thoughtful comment. Such explanations are encouraged. However, it will be more valuable to include the above explanation in the changelogs of the patches also since those go into the git log of the kernel. The cover letter contains an overview of the patchset to help the reviewers. They do not get documented in the history of changes to the kernel. Would you therefore be able to resend this as a fresh version including the above lines in the changelog of the individual patches?

Regards
Preeti U Murthy

Quoted 11 lines

Aya Mahfouz (2):
staging: i2o: Use #include <linux/uaccess.h> instead of

    <asm/uaccess.h>
  staging: i2o: Use #include <linux/uaccess.h> instead of
    <asm/uaccess.h>
 drivers/staging/i2o/i2o_config.c | 3 +--
 drivers/staging/i2o/i2o_proc.c   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
#5 lore raw
Quoted 16 lines · Preeti U Murthy

Hi Aya,

Quoted 3 lines · Aya Mahfouz

This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The replacements is safe since the header file <linux/uaccess.h> includes <asm/uaccess.h>

Like Julia mentioned its a thoughtful comment. Such explanations are encouraged. However, it will be more valuable to include the above explanation in the changelogs of the patches also since those go into the git log of the kernel. The cover letter contains an overview of the patchset to help the reviewers. They do not get documented in the history of changes to the kernel. Would you therefore be able to resend this as a fresh version including the above lines in the changelog of the individual patches?

Quoted 2 lines

Regards
Preeti U Murthy

Thank you Julia and Preeti for your comments. I will not send a new version of this patch since the driver will be out of staging as Julia stated in another thread. However, I will keep your advice in mind for future patches.

Kind Regards,
Aya Saif El-yazal Mahfouz

Quoted 12 lines
Quoted 11 lines

Aya Mahfouz (2):
staging: i2o: Use #include <linux/uaccess.h> instead of

    <asm/uaccess.h>
  staging: i2o: Use #include <linux/uaccess.h> instead of
    <asm/uaccess.h>
 drivers/staging/i2o/i2o_config.c | 3 +--
 drivers/staging/i2o/i2o_proc.c   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)