Skip to contentSkip to conversation

sanity.bbclass: vmdk and live can't be built together

PATCH New Robert Yang 1 participant 2 messages Mar 19, 2015

lore
Share & tools
lore
#0 lore raw

cover sanity.bbclass: vmdk and live can't be built together

The following changes since commit 0752c79282b1cc9699743e719518e6c341d50a3a:

systemd: fix /var/log/journal ownership (2015-03-16 17:38:51 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/vmdk
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/vmdk

Robert Yang (1):
sanity.bbclass: vmdk and live can't be built together

 meta/classes/sanity.bbclass |    4 ++++
 1 file changed, 4 insertions(+)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 sanity.bbclass: vmdk and live can't be built together

Both vmdk and live use syslinux, but they have different/conflicted configurations, the main conflictions are:

                    vmdk                live
SYSLINUX_ROOT       root=/dev/sda2      root=/dev/ram0
SYSLINUX_LABELS     boot                boot install
INITRD              No                  yes

So it would make the boot menu strange and vmdk can't be boot, we need add a few extra vars to fix the problem such as SYSLINUX_ROOT_VMDK SYSLINUX_ROOT_LIVE, but that needs a lot of changes in the code, so just add a sanity checking for it.

[YOCTO #6889]

---
 meta/classes/sanity.bbclass |    4 ++++
 1 file changed, 4 insertions(+)
meta/classes/sanity.bbclass +4 -0
index 31b99d4..cca39c9 100644
@@ -819,6 +819,10 @@ def check_sanity_everybuild(status, d):
         with open(checkfile, "w") as f:
             f.write(tmpdir)
 
+    # Check vmdk and live can't be built together.
+    if 'vmdk' in d.getVar('IMAGE_FSTYPES', True) and 'live' in d.getVar('IMAGE_FSTYPES', True):
+        status.addresult("Error, IMAGE_FSTYPES vmdk and live can't be built together\n")
+
 def check_sanity(sanity_data):
     import subprocess
 
Signature · 1 line
1.7.9.5