Skip to contentSkip to conversation

insane.bbclass: add missing QA to WARN_QA

PATCH In review Robert Yang 2 participants 4 messages Mar 19, 2015

lore
Share & tools
lore
#0 lore raw

cover insane.bbclass: add missing QA to WARN_QA

The following changes since commit 0752c79282b1cc9699743e719518e6c341d50a3a:

systemd: fix /var/log/journal ownership (2015-03-16 17:38:51 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/qa
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/qa

Robert Yang (1):
insane.bbclass: add missing QA to WARN_QA

 meta/classes/insane.bbclass |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 insane.bbclass: add missing QA to WARN_QA

The following QA were not in WARN_QA or ERROR_QA, so they are not in ALL_QA:
buildpaths
desktop
libexec
pkgname
symlink-to-sysroot
unsafe-references-in-binaries unsafe-references-in-scripts

---
 meta/classes/insane.bbclass |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/classes/insane.bbclass +3 -1
index 061ce5b..c201c9b 100644
@@ -30,7 +30,9 @@ WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \
             textrel already-stripped incompatible-license files-invalid \
             installed-vs-shipped compile-host-path install-host-path \
             pn-overrides infodir build-deps file-rdeps \
-            unknown-configure-option \
+            unknown-configure-option buildpaths desktop libexec pkgname \
+            symlink-to-sysroot unsafe-references-in-binaries \
+            unsafe-references-in-scripts \
             "
 ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
             perms dep-cmp pkgvarcheck perm-config perm-line perm-link \
Signature · 1 line
1.7.9.5
#2 lore raw

Hi Robert,

Quoted 4 lines · On Thursday 19 March 2015 02:17:43 Robert Yang wrote:

The following QA were not in WARN_QA or ERROR_QA, so they are not in ALL_QA:

buildpaths

Last I checked enabling this throws up quite a few issues, some of which aren't a problem. Has that been fixed? If not, we can't enable it.

Quoted 1 line

desktop

I'm pretty sure we kept this one off deliberately as well, there are too many bad desktop files out there and for most people it doesn't matter.

Quoted 1 line

libexec

Does this test work?

Quoted 1 line

pkgname

Only certain package managers care about the rules this test enforces.

Quoted 1 line

symlink-to-sysroot

I agree this one should probably be enabled.

Quoted 2 lines

unsafe-references-in-binaries
unsafe-references-in-scripts

We haven't enabled these because there isn't general agreement that this is a problem for everyone.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#3 lore raw

Hi Paul,

Thanks for the reply, I just wanted to add them to ALL_QA, but you are right, I need do more checking and fix, please ignore this patch atm.

// Robert

Quoted 37 lines · Paul Eggleton

Hi Robert,

Quoted 4 lines · On Thursday 19 March 2015 02:17:43 Robert Yang wrote:

The following QA were not in WARN_QA or ERROR_QA, so they are not in ALL_QA:

buildpaths

Last I checked enabling this throws up quite a few issues, some of which aren't a problem. Has that been fixed? If not, we can't enable it.

Quoted 1 line

desktop

I'm pretty sure we kept this one off deliberately as well, there are too many bad desktop files out there and for most people it doesn't matter.

Quoted 1 line

libexec

Does this test work?

Quoted 1 line

pkgname

Only certain package managers care about the rules this test enforces.

Quoted 1 line

symlink-to-sysroot

I agree this one should probably be enabled.

Quoted 2 lines

unsafe-references-in-binaries
unsafe-references-in-scripts

We haven't enabled these because there isn't general agreement that this is a problem for everyone.

Cheers,
Paul