Skip to contentSkip to conversation

package/linux-firmware: install AMD Radeon firmware (branch yem/lnx-fw)

PATCH New Yann E. MORIN 2 participants 4 messages Apr 1, 2015 – Apr 2, 2015

lore
Share & tools
lore
#0 lore raw

v3 cover package/linux-firmware: install AMD Radeon firmware (branch yem/lnx-fw)

Hello All!

This quick series is a cleanup and respin of David's initial patch to install AMD Radeon firmware files from the linux-firmware package.

Changes v2 -> v3:
- add support for copying complete directories,
- use that to copy the Radeon FW files, instead of an awfully-long list of files.

Regards,
Yann E. MORIN.

The following changes since commit 7ed9815830bbd6551fd502ddfa5073892883bbeb:

gnuradio: depends on shared libs (2015-04-01 23:45:45 +0200)

are available in the git repository at:

git://git.busybox.net/~ymorin/git/buildroot yem/lnx-fw

for you to fetch changes up to 249b813439492f82e8fd47af7a5f9b778535f7b8:

package/linux-firmware: install AMD Radeon firmware (2015-04-01 23:48:18 +0200)

----------------------------------------------------------------
Yann E. MORIN (1):
package/linux-firmware: add support to copy entire directories

david.barbion at ext.leroymerlin.fr (1):
package/linux-firmware: install AMD Radeon firmware

 package/linux-firmware/Config.in         |  9 +++++++++
 package/linux-firmware/linux-firmware.mk | 30 ++++++++++++++++++++++++++----
 2 files changed, 35 insertions(+), 4 deletions(-)
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#1 lore raw

PATCH v3 1/2 package/linux-firmware: add support to copy entire directories

Cc David BARBION <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 package/linux-firmware/linux-firmware.mk | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)
package/linux-firmware/linux-firmware.mk +21 -4
index 71c8611..5a68138 100644
@@ -293,6 +293,23 @@ LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
 endif
 
 ifneq ($(LINUX_FIRMWARE_FILES),)
+define LINUX_FIRMWARE_INSTALL_FILES
+	$(TAR) c -C $(@D) $(sort $(LINUX_FIRMWARE_FILES)) | \
+		$(TAR) x -C $(TARGET_DIR)/lib/firmware
+endef
+endif
+
+ifneq ($(LINUX_FIRMWARE_DIRS),)
+# We need to rm-rf the destination directory to avoid copying
+# into it in itself, should we re-install the package.
+define LINUX_FIRMWARE_INSTALL_DIRS
+	$(foreach d,$(LINUX_FIRMWARE_DIRS), \
+		rm -rf $(TARGET_DIR)/lib/firmware/$(d); \
+		cp -a $(@D)/$(d) $(TARGET_DIR)/lib/firmware/$(d)$(sep))
+endef
+endif
+
+ifneq ($(LINUX_FIRMWARE_FILES)$(LINUX_FIRMWARE_DIRS),)
 
 # Most firmware files are under a proprietary license, so no need to
 # repeat it for every selections above. Those firmwares that have more
@@ -308,12 +325,12 @@ LINUX_FIRMWARE_ALL_LICENSE_FILES += WHENCE
 # duplicates
 LINUX_FIRMWARE_LICENSE_FILES = $(sort $(LINUX_FIRMWARE_ALL_LICENSE_FILES))
 
+endif
+
 define LINUX_FIRMWARE_INSTALL_TARGET_CMDS
 	mkdir -p $(TARGET_DIR)/lib/firmware
-	$(TAR) c -C $(@D) $(sort $(LINUX_FIRMWARE_FILES)) | \
-		$(TAR) x -C $(TARGET_DIR)/lib/firmware
+	$(LINUX_FIRMWARE_INSTALL_FILES)
+	$(LINUX_FIRMWARE_INSTALL_DIRS)
 endef
 
-endif
-
 $(eval $(generic-package))
Signature · 1 line
1.9.1
#2 lore raw

PATCH v3 2/2 package/linux-firmware: install AMD Radeon firmware

In reply to Yann E. MORIN

From: "[email protected]" <[email protected]>

[yann.morin.1998 at free.fr:
- simplify by copying the full directory
- fix title
]

---
 package/linux-firmware/Config.in         | 9 +++++++++
 package/linux-firmware/linux-firmware.mk | 5 +++++
 2 files changed, 14 insertions(+)
package/linux-firmware/Config.in +9 -0
index 9e1eb91..7265990 100644
@@ -17,6 +17,15 @@ config BR2_PACKAGE_LINUX_FIRMWARE_INTEL_SST_DSP
 
 endmenu # Audio
 
+menu "Video firmware"
+
+config BR2_PACKAGE_LINUX_FIRMWARE_RADEON
+	bool "AMD Radeon video card firmware"
+	help
+	  Firmware files for AMD Radeon video cards.
+
+endmenu # Video
+
 menu "WiFi firmware"
 
 config BR2_PACKAGE_LINUX_FIRMWARE_ATHEROS_6002
package/linux-firmware/linux-firmware.mk +5 -0
index 5a68138..0919b16 100644
@@ -14,6 +14,11 @@ LINUX_FIRMWARE_FILES += intel/fw_sst_0f28.bin-48kHz_i2s_master
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.fw_sst_0f28
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RADEON),y)
+LINUX_FIRMWARE_DIRS += radeon
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.radeon
+endif
+
 # rt2501/rt61
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RALINK_RT61),y)
 LINUX_FIRMWARE_FILES += rt2561.bin rt2561s.bin rt2661.bin
Signature · 1 line
1.9.1
#3 lore raw

v3 cover package/linux-firmware: install AMD Radeon firmware (branch yem/lnx-fw)

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 5 lines · Yann E. MORIN

Yann E. MORIN (1):
package/linux-firmware: add support to copy entire directories

david.barbion at ext.leroymerlin.fr (1):
package/linux-firmware: install AMD Radeon firmware

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com