Added LTR501 Interrupt support

Add ABI info for iio event persistence filter.

Setting <n> to persistence filter would need atleast <n> data values outside the upper/lower threshold limits before generating an interrupt.

Signed-off-by Kuppuswamy Sathyanarayanan <[email protected]>

---
 Documentation/ABI/testing/sysfs-bus-iio | 82 +++++++++++++++++++++++++++++++++
 1 file changed, 82 insertions(+)

Documentation/ABI/testing/sysfs-bus-iio +0 -0

index 9a70c31..590b1d4 100644

Documentation/ABI/testing/sysfs-bus-iio +71 -0

+What:		/sys/.../events/in_accel_x_thresh_rising_persistence
+What:		/sys/.../events/in_accel_x_thresh_falling_persistence
+hat:		/sys/.../events/in_accel_x_roc_rising_persistence
+What:		/sys/.../events/in_accel_x_roc_falling_persistence
+What:		/sys/.../events/in_accel_y_thresh_rising_persistence
+What:		/sys/.../events/in_accel_y_thresh_falling_persistence
+What:		/sys/.../events/in_accel_y_roc_rising_persistence
+What:		/sys/.../events/in_accel_y_roc_falling_persistence
+What:		/sys/.../events/in_accel_z_thresh_rising_persistence
+What:		/sys/.../events/in_accel_z_thresh_falling_persistence
+What:		/sys/.../events/in_accel_z_roc_rising_persistence
+What:		/sys/.../events/in_accel_z_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_x_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_x_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_y_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_y_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_z_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_z_roc_falling_persistence
+What:		/sys/.../events/in_magn_x_thresh_rising_persistence
+What:		/sys/.../events/in_magn_x_thresh_falling_persistence
+What:		/sys/.../events/in_magn_x_roc_rising_persistence
+What:		/sys/.../events/in_magn_x_roc_falling_persistence
+What:		/sys/.../events/in_magn_y_thresh_rising_persistence
+What:		/sys/.../events/in_magn_y_thresh_falling_persistence
+What:		/sys/.../events/in_magn_y_roc_rising_persistence
+What:		/sys/.../events/in_magn_y_roc_falling_persistence
+What:		/sys/.../events/in_magn_z_thresh_rising_persistence
+What:		/sys/.../events/in_magn_z_thresh_falling_persistence
+What:		/sys/.../events/in_magn_z_roc_rising_persistence
+What:		/sys/.../events/in_magn_z_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_roc_falling_persistence
+What:		/sys/.../events/in_voltageY_supply_thresh_rising_persistence
+What:		/sys/.../events/in_voltageY_supply_thresh_falling_persistence
+What:		/sys/.../events/in_voltageY_supply_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_supply_roc_falling_persistence
+What:		/sys/.../events/in_voltageY_thresh_rising_persistence
+What:		/sys/.../events/in_voltageY_thresh_falling_persistence
+What:		/sys/.../events/in_voltageY_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_roc_falling_persistence
+What:		/sys/.../events/in_tempY_thresh_rising_persistence
+What:		/sys/.../events/in_tempY_thresh_falling_persistence
+What:		/sys/.../events/in_tempY_roc_rising_persistence
+What:		/sys/.../events/in_tempY_roc_falling_persistence
+What:		/sys/.../events/in_accel_x&y&z_mag_falling_persistence
+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence
+What:		/sys/.../events/in_activity_still_thresh_rising_persistence
+What:		/sys/.../events/in_activity_still_thresh_falling_persistence
+What:		/sys/.../events/in_activity_walking_thresh_rising_persistence
+What:		/sys/.../events/in_activity_walking_thresh_falling_persistence

Documentation/ABI/testing/sysfs-bus-iio +1 -0

+
 What:		/sys/.../events/in_activity_still_thresh_rising_en
 What:		/sys/.../events/in_activity_still_thresh_falling_en
 What:		/sys/.../events/in_activity_walking_thresh_rising_en

Quoted 11 lines · Kuppuswamy Sathyanarayanan

Add ABI info for iio event persistence filter.

Setting <n> to persistence filter would need atleast <n> data values outside the upper/lower threshold limits before generating an interrupt.

Signed-off-by Kuppuswamy Sathyanarayanan <[email protected]>

---
  Documentation/ABI/testing/sysfs-bus-iio | 82 +++++++++++++++++++++++++++++++++
  1 file changed, 82 insertions(+)

Documentation/ABI/testing/sysfs-bus-iio Description: · line 858

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio +0 -0

index 9a70c31..590b1d4 100644
@@ -856,6 +856,88 @@ Description:
  		met before an event is generated. If direction is not
  		specified then this period applies to both directions.
 

Please don't mass document cases unless they are actually in use. These should get added as and when they become so. Often a particular type of event characteristic is actually only implemented on a small subset of channel types (where it makes sense).

Quoted 75 lines

Documentation/ABI/testing/sysfs-bus-iio +75 -0

+What:		/sys/.../events/in_accel_x_thresh_rising_persistence
+What:		/sys/.../events/in_accel_x_thresh_falling_persistence
+hat:		/sys/.../events/in_accel_x_roc_rising_persistence
+What:		/sys/.../events/in_accel_x_roc_falling_persistence
+What:		/sys/.../events/in_accel_y_thresh_rising_persistence
+What:		/sys/.../events/in_accel_y_thresh_falling_persistence
+What:		/sys/.../events/in_accel_y_roc_rising_persistence
+What:		/sys/.../events/in_accel_y_roc_falling_persistence
+What:		/sys/.../events/in_accel_z_thresh_rising_persistence
+What:		/sys/.../events/in_accel_z_thresh_falling_persistence
+What:		/sys/.../events/in_accel_z_roc_rising_persistence
+What:		/sys/.../events/in_accel_z_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_x_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_x_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_y_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_y_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_z_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_z_roc_falling_persistence
+What:		/sys/.../events/in_magn_x_thresh_rising_persistence
+What:		/sys/.../events/in_magn_x_thresh_falling_persistence
+What:		/sys/.../events/in_magn_x_roc_rising_persistence
+What:		/sys/.../events/in_magn_x_roc_falling_persistence
+What:		/sys/.../events/in_magn_y_thresh_rising_persistence
+What:		/sys/.../events/in_magn_y_thresh_falling_persistence
+What:		/sys/.../events/in_magn_y_roc_rising_persistence
+What:		/sys/.../events/in_magn_y_roc_falling_persistence
+What:		/sys/.../events/in_magn_z_thresh_rising_persistence
+What:		/sys/.../events/in_magn_z_thresh_falling_persistence
+What:		/sys/.../events/in_magn_z_roc_rising_persistence
+What:		/sys/.../events/in_magn_z_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_roc_falling_persistence
+What:		/sys/.../events/in_voltageY_supply_thresh_rising_persistence
+What:		/sys/.../events/in_voltageY_supply_thresh_falling_persistence
+What:		/sys/.../events/in_voltageY_supply_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_supply_roc_falling_persistence
+What:		/sys/.../events/in_voltageY_thresh_rising_persistence
+What:		/sys/.../events/in_voltageY_thresh_falling_persistence
+What:		/sys/.../events/in_voltageY_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_roc_falling_persistence
+What:		/sys/.../events/in_tempY_thresh_rising_persistence
+What:		/sys/.../events/in_tempY_thresh_falling_persistence
+What:		/sys/.../events/in_tempY_roc_rising_persistence
+What:		/sys/.../events/in_tempY_roc_falling_persistence
+What:		/sys/.../events/in_accel_x&y&z_mag_falling_persistence
+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence
+What:		/sys/.../events/in_activity_still_thresh_rising_persistence
+What:		/sys/.../events/in_activity_still_thresh_falling_persistence
+What:		/sys/.../events/in_activity_walking_thresh_rising_persistence
+What:		/sys/.../events/in_activity_walking_thresh_falling_persistence
+What:		/sys/.../events/in_activity_jogging_thresh_rising_persistence
+What:		/sys/.../events/in_activity_jogging_thresh_falling_persistence
+What:		/sys/.../events/in_activity_running_thresh_rising_persistence
+What:		/sys/.../events/in_activity_running_thresh_falling_persistence

Documentation/ABI/testing/sysfs-bus-iio Description: · line 939

Quoted 6 lines

Documentation/ABI/testing/sysfs-bus-iio +6 -0

+KernelVersion:	4.0
+Contact:	[email protected]
+Description:
+		Number of times an event should occur before generating an
+		interrupt. Persistence filter value can be applied for both
+		rising/falling threshold based interrupts.

This still needs clarification as reading the discussion I'm still a little unsure what the condition is. I don't think Lars' original query ever got cleanly answered

Taking just the upper threshold...
The interpretations I can think of are:

1) tsl2591 use case (maps directly to period with the sampling frequency taken into account).
- Too much light for N ALS cycling samples. If it drops below the threshold the count is reset.
the tcs part that Daniel referenced is also this use case.

2) A new option which doesn't take account of the signal dropping below the threshold. So a count of number of times above the threshold.
i.e. On each cycle, if over threshold, increment N.
Evaluate if N is greater than 'persistence' then trigger an event.
Why this would ever make sense on a light sensor is beyond me ;) but there we are. We have a related abi for in_steps_change_value, which fires an event, only every N steps. It doesn't really adapt to this case though.

The name persistence is definitely misleading if this is what the liteon parts do as that definitely implies case 1).

Welcome to my life, bludgeoning what appears to new ABI into what we already have! (not a lot of point in standardized ABI otherwise!)

Jonathan

Quoted 5 lines

Documentation/ABI/testing/sysfs-bus-iio +1 -0

+
  What:		/sys/.../events/in_activity_still_thresh_rising_en
  What:		/sys/.../events/in_activity_still_thresh_falling_en
  What:		/sys/.../events/in_activity_walking_thresh_rising_en

Quoted 8 lines · Jonathan Cameron

Quoted 7 lines · Kuppuswamy Sathyanarayanan

Add ABI info for iio event persistence filter.

Setting <n> to persistence filter would need atleast <n> data values outside the upper/lower threshold limits before generating an interrupt.

Signed-off-by Kuppuswamy Sathyanarayanan

<[email protected]>

Quoted 2 lines

Quoted 2 lines

---
  Documentation/ABI/testing/sysfs-bus-iio | 82

+++++++++++++++++++++++++++++++++

Quoted 3 lines

Review

Quoted 3 lines

  1 file changed, 82 insertions(+)

(quoted diff) +0 -0

b/Documentation/ABI/testing/sysfs-bus-iio

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 858

Quoted 7 lines

index 9a70c31..590b1d4 100644

Documentation/ABI/testing/sysfs-bus-iio +0 -0

@@ -856,6 +856,88 @@ Description:
  		met before an event is generated. If direction is not
  		specified then this period applies to both directions.
 

Please don't mass document cases unless they are actually in use.

These should

Quoted 1 line

get added as and when they become so. Often a particular type of

event

Quoted 1 line

characteristic is actually only implemented on a small subset of

channel types

Quoted 1 line

(where it makes sense).

IMO, persistence filter can be applied for all these cases. But if you think its better to
add ABI for what we currently use then I will leave only ALS/proxmity related ABI's here.

Documentation/ABI/testing/sysfs-bus-iio +2 -0

+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence

Quoted 30 lines

Quoted 30 lines

Documentation/ABI/testing/sysfs-bus-iio +29 -0

+What:		/sys/.../events/in_accel_x_thresh_rising_persistence
+What:		/sys/.../events/in_accel_x_thresh_falling_persistence
+hat:		/sys/.../events/in_accel_x_roc_rising_persistence
+What:		/sys/.../events/in_accel_x_roc_falling_persistence
+What:		/sys/.../events/in_accel_y_thresh_rising_persistence
+What:		/sys/.../events/in_accel_y_thresh_falling_persistence
+What:		/sys/.../events/in_accel_y_roc_rising_persistence
+What:		/sys/.../events/in_accel_y_roc_falling_persistence
+What:		/sys/.../events/in_accel_z_thresh_rising_persistence
+What:		/sys/.../events/in_accel_z_thresh_falling_persistence
+What:		/sys/.../events/in_accel_z_roc_rising_persistence
+What:		/sys/.../events/in_accel_z_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_x_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_x_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_y_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_y_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_z_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_z_roc_falling_persistence
+What:		/sys/.../events/in_magn_x_thresh_rising_persistence
+What:		/sys/.../events/in_magn_x_thresh_falling_persistence
+What:		/sys/.../events/in_magn_x_roc_rising_persistence
+What:		/sys/.../events/in_magn_x_roc_falling_persistence
+What:		/sys/.../events/in_magn_y_thresh_rising_persistence

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description:

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio +7 -0

+What:		/sys/.../events/in_magn_y_thresh_falling_persistence
+What:		/sys/.../events/in_magn_y_roc_rising_persistence
+What:		/sys/.../events/in_magn_y_roc_falling_persistence
+What:		/sys/.../events/in_magn_z_thresh_rising_persistence
+What:		/sys/.../events/in_magn_z_thresh_falling_persistence
+What:		/sys/.../events/in_magn_z_roc_rising_persistence
+What:		/sys/.../events/in_magn_z_roc_falling_persistence
 

+What: /sys/.../events/in_rot_from_north_magnetic_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_roc_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_roc_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_roc_falling_persistence

Quoted 2 lines

Quoted 2 lines

+What: /sys/.../events/in_voltageY_supply_thresh_rising_persistence

+What: /sys/.../events/in_voltageY_supply_thresh_falling_persistence

Quoted 8 lines

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio +8 -0

+What:		/sys/.../events/in_voltageY_supply_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_supply_roc_falling_persistence
+What:		/sys/.../events/in_voltageY_thresh_rising_persistence
+What:		/sys/.../events/in_voltageY_thresh_falling_persistence
+What:		/sys/.../events/in_voltageY_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_roc_falling_persistence
+What:		/sys/.../events/in_tempY_thresh_rising_persistence
+What:		/sys/.../events/in_tempY_thresh_falling_persistence

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 927

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio +7 -0

+What:		/sys/.../events/in_tempY_roc_rising_persistence
+What:		/sys/.../events/in_tempY_roc_falling_persistence
+What:		/sys/.../events/in_accel_x&y&z_mag_falling_persistence
+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence
+What:		/sys/.../events/in_activity_still_thresh_rising_persistence
+What:		/sys/.../events/in_activity_still_thresh_falling_persistence

+What: /sys/.../events/in_activity_walking_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_walking_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_jogging_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_jogging_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_running_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_running_thresh_falling_persistence

Quoted 7 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 939

Quoted 6 lines

Documentation/ABI/testing/sysfs-bus-iio +6 -0

+KernelVersion:	4.0
+Contact:	[email protected]
+Description:
+		Number of times an event should occur before generating an
+		interrupt. Persistence filter value can be applied for both
+		rising/falling threshold based interrupts.

This still needs clarification as reading the discussion I'm still a

little unsure

Quoted 1 line

what the condition is. I don't think Lars' original query ever got

cleanly answered
Sorry for being unclear. Even in this case, the use case is "number of consecutive" measurement data
outside the range.

Quoted 5 lines

Taking just the upper threshold...
The interpretations I can think of are:

1) tsl2591 use case (maps directly to period with the sampling

frequency taken into

Quoted 2 lines

account).
- Too much light for N ALS cycling samples. If it drops below the

threshold

Quoted 2 lines

the count is reset.
the tcs part that Daniel referenced is also this use case.

I agree that it can be mapped to _period if you take the sampling frequency into account. But if you do that then it becomes dependent on

integration time ( for ALS case). Since _period is calculated based on frequency, each time you change _integration_time then internally you need to change the _period value to keep the ratio constant. Also you need to consider what happens if your frequency > period. I think this makes is bit complicated.

Don't you think its better to add another representation instead of trying to fit it in existing ABI's ?

Following are the persistence filter descriptions from data sheets of tsl2591 and ltr501.

LTR501: " The INTERRUPT PERSIST register controls the N number of times

the measurement data is outside the range defined by the upper and lower
threshold limits before asserting the INT".
TSL2591: " The Interrupt persistence filter sets the number of consecutive out-of-range ALS cycles necessary to generate an interrupt"

Quoted 2 lines

2) A new option which doesn't take account of the signal dropping

below the threshold.

Quoted 3 lines

So a count of number of times above the threshold.
i.e. On each cycle, if over threshold, increment N.
Evaluate if N is greater than 'persistence' then trigger an

event.

Quoted 1 line

Why this would ever make sense on a light sensor is beyond me ;)

but there

Quoted 1 line

we are. We have a related abi for in_steps_change_value, which

fires

Quoted 1 line

an event, only every N steps. It doesn't really adapt to this

case though.

Quoted 2 lines

The name persistence is definitely misleading if this is what the

liteon parts

Quoted 3 lines

do as that definitely implies case 1).

Welcome to my life, bludgeoning what appears to new ABI into what we

already have!

Quoted 11 lines

(not a lot of point in standardized ABI otherwise!)

Jonathan

Quoted 5 lines

+
What: /sys/.../events/in_activity_still_thresh_rising_en
What: /sys/.../events/in_activity_still_thresh_falling_en
What: /sys/.../events/in_activity_walking_thresh_rising_en

Quoted 144 lines · sathyanarayanan kuppuswamy

Quoted 8 lines · Jonathan Cameron

Quoted 7 lines · Kuppuswamy Sathyanarayanan

Add ABI info for iio event persistence filter.

Setting <n> to persistence filter would need atleast <n> data values outside the upper/lower threshold limits before generating an interrupt.

Signed-off-by Kuppuswamy Sathyanarayanan

<[email protected]>

Quoted 2 lines

Quoted 2 lines

---
   Documentation/ABI/testing/sysfs-bus-iio | 82

+++++++++++++++++++++++++++++++++

Quoted 3 lines

Review

Quoted 3 lines

   1 file changed, 82 insertions(+)

(quoted diff) +0 -0

b/Documentation/ABI/testing/sysfs-bus-iio

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 858

Quoted 7 lines

index 9a70c31..590b1d4 100644

Documentation/ABI/testing/sysfs-bus-iio +0 -0

@@ -856,6 +856,88 @@ Description:
   		met before an event is generated. If direction is not
   		specified then this period applies to both directions.
 

Please don't mass document cases unless they are actually in use.

These should

Quoted 1 line

get added as and when they become so. Often a particular type of

event

Quoted 1 line

characteristic is actually only implemented on a small subset of

channel types

Quoted 1 line

(where it makes sense).

IMO, persistence filter can be applied for all these cases. But if you think its better to
add ABI for what we currently use then I will leave only ALS/proxmity related ABI's here.

Documentation/ABI/testing/sysfs-bus-iio +2 -0

+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence

Quoted 38 lines

Quoted 38 lines

Documentation/ABI/testing/sysfs-bus-iio +36 -0

+What:		/sys/.../events/in_accel_x_thresh_rising_persistence
+What:		/sys/.../events/in_accel_x_thresh_falling_persistence
+hat:		/sys/.../events/in_accel_x_roc_rising_persistence
+What:		/sys/.../events/in_accel_x_roc_falling_persistence
+What:		/sys/.../events/in_accel_y_thresh_rising_persistence
+What:		/sys/.../events/in_accel_y_thresh_falling_persistence
+What:		/sys/.../events/in_accel_y_roc_rising_persistence
+What:		/sys/.../events/in_accel_y_roc_falling_persistence
+What:		/sys/.../events/in_accel_z_thresh_rising_persistence
+What:		/sys/.../events/in_accel_z_thresh_falling_persistence
+What:		/sys/.../events/in_accel_z_roc_rising_persistence
+What:		/sys/.../events/in_accel_z_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_x_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_x_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_y_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_y_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_z_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_z_roc_falling_persistence
+What:		/sys/.../events/in_magn_x_thresh_rising_persistence
+What:		/sys/.../events/in_magn_x_thresh_falling_persistence
+What:		/sys/.../events/in_magn_x_roc_rising_persistence
+What:		/sys/.../events/in_magn_x_roc_falling_persistence
+What:		/sys/.../events/in_magn_y_thresh_rising_persistence
+What:		/sys/.../events/in_magn_y_thresh_falling_persistence
+What:		/sys/.../events/in_magn_y_roc_rising_persistence
+What:		/sys/.../events/in_magn_y_roc_falling_persistence
+What:		/sys/.../events/in_magn_z_thresh_rising_persistence
+What:		/sys/.../events/in_magn_z_thresh_falling_persistence
+What:		/sys/.../events/in_magn_z_roc_rising_persistence
+What:		/sys/.../events/in_magn_z_roc_falling_persistence
 

Documentation/ABI/testing/sysfs-bus-iio +16 -0

+What:		/sys/.../events/in_rot_from_north_magnetic_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_thresh_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_thresh_falling_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_roc_rising_persistence
+What:		/sys/.../events/in_rot_from_north_true_tilt_comp_roc_falling_persistence

Quoted 2 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 897

Quoted 2 lines

Documentation/ABI/testing/sysfs-bus-iio +1 -0

+What:		/sys/.../events/in_voltageY_supply_thresh_rising_persistence
 

+What: /sys/.../events/in_voltageY_supply_thresh_falling_persistence

Quoted 16 lines

Quoted 16 lines

Documentation/ABI/testing/sysfs-bus-iio +15 -0

+What:		/sys/.../events/in_voltageY_supply_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_supply_roc_falling_persistence
+What:		/sys/.../events/in_voltageY_thresh_rising_persistence
+What:		/sys/.../events/in_voltageY_thresh_falling_persistence
+What:		/sys/.../events/in_voltageY_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_roc_falling_persistence
+What:		/sys/.../events/in_tempY_thresh_rising_persistence
+What:		/sys/.../events/in_tempY_thresh_falling_persistence
+What:		/sys/.../events/in_tempY_roc_rising_persistence
+What:		/sys/.../events/in_tempY_roc_falling_persistence
+What:		/sys/.../events/in_accel_x&y&z_mag_falling_persistence
+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence
+What:		/sys/.../events/in_activity_still_thresh_rising_persistence
+What:		/sys/.../events/in_activity_still_thresh_falling_persistence
 

Documentation/ABI/testing/sysfs-bus-iio +6 -0

+What:		/sys/.../events/in_activity_walking_thresh_rising_persistence
+What:		/sys/.../events/in_activity_walking_thresh_falling_persistence
+What:		/sys/.../events/in_activity_jogging_thresh_rising_persistence
+What:		/sys/.../events/in_activity_jogging_thresh_falling_persistence
+What:		/sys/.../events/in_activity_running_thresh_rising_persistence
+What:		/sys/.../events/in_activity_running_thresh_falling_persistence

Quoted 7 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 939

Quoted 6 lines

Documentation/ABI/testing/sysfs-bus-iio +6 -0

+KernelVersion:	4.0
+Contact:	[email protected]
+Description:
+		Number of times an event should occur before generating an
+		interrupt. Persistence filter value can be applied for both
+		rising/falling threshold based interrupts.

This still needs clarification as reading the discussion I'm still a

little unsure

Quoted 1 line

what the condition is. I don't think Lars' original query ever got

cleanly answered
Sorry for being unclear. Even in this case, the use case is "number of consecutive" measurement data
outside the range.

Quoted 4 lines

Taking just the upper threshold...
The interpretations I can think of are:

1) tsl2591 use case (maps directly to period with the sampling

frequency taken into

Quoted 2 lines

account).
- Too much light for N ALS cycling samples. If it drops below the

threshold

Quoted 2 lines

the count is reset.
the tcs part that Daniel referenced is also this use case.

I agree that it can be mapped to _period if you take the sampling frequency into account. But if you do that then it becomes dependent on

Quoted 5 lines

integration time ( for ALS case). Since _period is calculated based on frequency, each time you change _integration_time then internally you need to change the _period value to keep the ratio constant. Also you need to consider what happens if your frequency > period. I think this makes is bit complicated.

Indeed. Such is life. This isn't the first such case and it won't be the last where
the driver becomes more complex to conform to the existing ABI.

Quoted 3 lines

Don't you think its better to add another representation instead of trying to fit it in existing ABI's ?

No
This is a common situation. All over the place we have cases where changing one
abi element effects the value of another.
We cope with it to provide a consistent
and minimal interface to userspace.
Where the sampling frequency is directly
controlled it is perfectly acceptable to not automatically adjust the period.
We frequently rely on the rule that userspce must check all attrs if it changes any.

Quoted 39 lines

Following are the persistence filter descriptions from data sheets of tsl2591 and ltr501.

LTR501: " The INTERRUPT PERSIST register controls the N number of times

the measurement data is outside the range defined by the upper and lower
threshold limits before asserting the INT".
TSL2591: " The Interrupt persistence filter sets the number of consecutive out-of-range ALS cycles necessary to generate an interrupt"

Quoted 1 line

2) A new option which doesn't take account of the signal dropping

below the threshold.

Quoted 3 lines

So a count of number of times above the threshold.
i.e. On each cycle, if over threshold, increment N.
Evaluate if N is greater than 'persistence' then trigger an

event.

Quoted 1 line

Why this would ever make sense on a light sensor is beyond me ;)

but there

Quoted 1 line

we are. We have a related abi for in_steps_change_value, which

fires

Quoted 1 line

an event, only every N steps. It doesn't really adapt to this

case though.

Quoted 1 line

The name persistence is definitely misleading if this is what the

liteon parts

Quoted 3 lines

do as that definitely implies case 1).

Welcome to my life, bludgeoning what appears to new ABI into what we

already have!

Quoted 10 lines

(not a lot of point in standardized ABI otherwise!)

Jonathan

Quoted 5 lines

Documentation/ABI/testing/sysfs-bus-iio +1 -0

+
   What:		/sys/.../events/in_activity_still_thresh_rising_en
   What:		/sys/.../events/in_activity_still_thresh_falling_en
   What:		/sys/.../events/in_activity_walking_thresh_rising_en

Hi Jonathan,

Thanks for the comments. Comments inline.

Quoted 151 lines · sathyanarayanan kuppuswamy

Quoted 149 lines · Jonathan Cameron

Quoted 8 lines · Kuppuswamy Sathyanarayanan

Quoted 7 lines

Add ABI info for iio event persistence filter.

Setting <n> to persistence filter would need atleast <n> data values outside the upper/lower threshold limits before generating an interrupt.

Signed-off-by Kuppuswamy Sathyanarayanan

<[email protected]>

Quoted 2 lines

Quoted 2 lines

---
   Documentation/ABI/testing/sysfs-bus-iio | 82

+++++++++++++++++++++++++++++++++

Quoted 3 lines

Review

Quoted 3 lines

   1 file changed, 82 insertions(+)

(quoted diff) +0 -0

b/Documentation/ABI/testing/sysfs-bus-iio

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 858

Quoted 7 lines

index 9a70c31..590b1d4 100644

Documentation/ABI/testing/sysfs-bus-iio +0 -0

@@ -856,6 +856,88 @@ Description:
           met before an event is generated. If direction is not
           specified then this period applies to both directions.
 

Please don't mass document cases unless they are actually in use.

These should

Quoted 1 line

get added as and when they become so. Often a particular type of

event

Quoted 1 line

characteristic is actually only implemented on a small subset of

channel types

Quoted 1 line

(where it makes sense).

IMO, persistence filter can be applied for all these cases. But if you think its better to
add ABI for what we currently use then I will leave only ALS/proxmity related ABI's here.

Documentation/ABI/testing/sysfs-bus-iio +2 -0

+What:        /sys/.../events/in_intensity0_thresh_persistence
+What:        /sys/.../events/in_proximity0_thresh_persistence

Quoted 38 lines

Quoted 38 lines

Documentation/ABI/testing/sysfs-bus-iio +36 -0

+What:        /sys/.../events/in_accel_x_thresh_rising_persistence
+What:        /sys/.../events/in_accel_x_thresh_falling_persistence
+hat:        /sys/.../events/in_accel_x_roc_rising_persistence
+What:        /sys/.../events/in_accel_x_roc_falling_persistence
+What:        /sys/.../events/in_accel_y_thresh_rising_persistence
+What:        /sys/.../events/in_accel_y_thresh_falling_persistence
+What:        /sys/.../events/in_accel_y_roc_rising_persistence
+What:        /sys/.../events/in_accel_y_roc_falling_persistence
+What:        /sys/.../events/in_accel_z_thresh_rising_persistence
+What:        /sys/.../events/in_accel_z_thresh_falling_persistence
+What:        /sys/.../events/in_accel_z_roc_rising_persistence
+What:        /sys/.../events/in_accel_z_roc_falling_persistence
+What:        /sys/.../events/in_anglvel_x_thresh_rising_persistence
+What:        /sys/.../events/in_anglvel_x_thresh_falling_persistence
+What:        /sys/.../events/in_anglvel_x_roc_rising_persistence
+What:        /sys/.../events/in_anglvel_x_roc_falling_persistence
+What:        /sys/.../events/in_anglvel_y_thresh_rising_persistence
+What:        /sys/.../events/in_anglvel_y_thresh_falling_persistence
+What:        /sys/.../events/in_anglvel_y_roc_rising_persistence
+What:        /sys/.../events/in_anglvel_y_roc_falling_persistence
+What:        /sys/.../events/in_anglvel_z_thresh_rising_persistence
+What:        /sys/.../events/in_anglvel_z_thresh_falling_persistence
+What:        /sys/.../events/in_anglvel_z_roc_rising_persistence
+What:        /sys/.../events/in_anglvel_z_roc_falling_persistence
+What:        /sys/.../events/in_magn_x_thresh_rising_persistence
+What:        /sys/.../events/in_magn_x_thresh_falling_persistence
+What:        /sys/.../events/in_magn_x_roc_rising_persistence
+What:        /sys/.../events/in_magn_x_roc_falling_persistence
+What:        /sys/.../events/in_magn_y_thresh_rising_persistence
+What:        /sys/.../events/in_magn_y_thresh_falling_persistence
+What:        /sys/.../events/in_magn_y_roc_rising_persistence
+What:        /sys/.../events/in_magn_y_roc_falling_persistence
+What:        /sys/.../events/in_magn_z_thresh_rising_persistence
+What:        /sys/.../events/in_magn_z_thresh_falling_persistence
+What:        /sys/.../events/in_magn_z_roc_rising_persistence
+What:        /sys/.../events/in_magn_z_roc_falling_persistence
 

Documentation/ABI/testing/sysfs-bus-iio +16 -0

+What:        /sys/.../events/in_rot_from_north_magnetic_thresh_rising_persistence
+What:        /sys/.../events/in_rot_from_north_magnetic_thresh_falling_persistence
+What:        /sys/.../events/in_rot_from_north_magnetic_roc_rising_persistence
+What:        /sys/.../events/in_rot_from_north_magnetic_roc_falling_persistence
+What:        /sys/.../events/in_rot_from_north_true_thresh_rising_persistence
+What:        /sys/.../events/in_rot_from_north_true_thresh_falling_persistence
+What:        /sys/.../events/in_rot_from_north_true_roc_rising_persistence
+What:        /sys/.../events/in_rot_from_north_true_roc_falling_persistence
+What:        /sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_rising_persistence
+What:        /sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_falling_persistence
+What:        /sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_rising_persistence
+What:        /sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_falling_persistence
+What:        /sys/.../events/in_rot_from_north_true_tilt_comp_thresh_rising_persistence
+What:        /sys/.../events/in_rot_from_north_true_tilt_comp_thresh_falling_persistence
+What:        /sys/.../events/in_rot_from_north_true_tilt_comp_roc_rising_persistence
+What:        /sys/.../events/in_rot_from_north_true_tilt_comp_roc_falling_persistence

Quoted 2 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 897

Quoted 2 lines

Documentation/ABI/testing/sysfs-bus-iio +1 -0

+What:        /sys/.../events/in_voltageY_supply_thresh_rising_persistence
 

+What: /sys/.../events/in_voltageY_supply_thresh_falling_persistence

Quoted 16 lines

Quoted 16 lines

Documentation/ABI/testing/sysfs-bus-iio +15 -0

+What:        /sys/.../events/in_voltageY_supply_roc_rising_persistence
+What:        /sys/.../events/in_voltageY_supply_roc_falling_persistence
+What:        /sys/.../events/in_voltageY_thresh_rising_persistence
+What:        /sys/.../events/in_voltageY_thresh_falling_persistence
+What:        /sys/.../events/in_voltageY_roc_rising_persistence
+What:        /sys/.../events/in_voltageY_roc_falling_persistence
+What:        /sys/.../events/in_tempY_thresh_rising_persistence
+What:        /sys/.../events/in_tempY_thresh_falling_persistence
+What:        /sys/.../events/in_tempY_roc_rising_persistence
+What:        /sys/.../events/in_tempY_roc_falling_persistence
+What:        /sys/.../events/in_accel_x&y&z_mag_falling_persistence
+What:        /sys/.../events/in_intensity0_thresh_persistence
+What:        /sys/.../events/in_proximity0_thresh_persistence
+What:        /sys/.../events/in_activity_still_thresh_rising_persistence
+What:        /sys/.../events/in_activity_still_thresh_falling_persistence
 

Documentation/ABI/testing/sysfs-bus-iio +6 -0

+What:        /sys/.../events/in_activity_walking_thresh_rising_persistence
+What:        /sys/.../events/in_activity_walking_thresh_falling_persistence
+What:        /sys/.../events/in_activity_jogging_thresh_rising_persistence
+What:        /sys/.../events/in_activity_jogging_thresh_falling_persistence
+What:        /sys/.../events/in_activity_running_thresh_rising_persistence
+What:        /sys/.../events/in_activity_running_thresh_falling_persistence

Quoted 7 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 939

Quoted 6 lines

Documentation/ABI/testing/sysfs-bus-iio +6 -0

+KernelVersion:    4.0
+Contact:    [email protected]
+Description:
+        Number of times an event should occur before generating an
+        interrupt. Persistence filter value can be applied for both
+        rising/falling threshold based interrupts.

This still needs clarification as reading the discussion I'm still a

little unsure

Quoted 1 line

what the condition is. I don't think Lars' original query ever got

cleanly answered
Sorry for being unclear. Even in this case, the use case is "number of consecutive" measurement data
outside the range.

Quoted 4 lines

Taking just the upper threshold...
The interpretations I can think of are:

1) tsl2591 use case (maps directly to period with the sampling

frequency taken into

Quoted 2 lines

account).
- Too much light for N ALS cycling samples. If it drops below the

threshold

Quoted 2 lines

the count is reset.
the tcs part that Daniel referenced is also this use case.

I agree that it can be mapped to _period if you take the sampling frequency into account. But if you do that then it becomes dependent on

integration time ( for ALS case). Since _period is calculated based on frequency, each time you change _integration_time then internally you need to change the _period value to keep the ratio constant. Also you need to consider what happens if your frequency > period. I think this makes is bit complicated.

Quoted 2 lines

Indeed. Such is life. This isn't the first such case and it won't be the last where
the driver becomes more complex to conform to the existing ABI.

If its just the driver complexity then I would completely agree with you. My concern is, we are expecting the user to consider these factors before changing the value on either frequency/period.

If this dependency is due to the hardware then it would make sense for expecting the user to follow them. But here we are creating a logical dependency between persistence and sampling frequency to avoid the software complexity.

If you read the data sheet, there is no relation between persistence and sampling frequency. But when using the interfaces, the user should understand the ABI dependency created in software.

From an ABI point of view, we couldn't care less what the underlying

Quoted 50 lines

Quoted 3 lines

Don't you think its better to add another representation instead of trying to fit it in existing ABI's ?

No
This is a common situation. All over the place we have cases where changing one
abi element effects the value of another.
We cope with it to provide a consistent
and minimal interface to userspace.
Where the sampling frequency is directly
controlled it is perfectly acceptable to not automatically adjust the period.
We frequently rely on the rule that userspce must check all attrs if it changes any.

Quoted 39 lines

Following are the persistence filter descriptions from data sheets of tsl2591 and ltr501.

LTR501: " The INTERRUPT PERSIST register controls the N number of times

the measurement data is outside the range defined by the upper and lower
threshold limits before asserting the INT".
TSL2591: " The Interrupt persistence filter sets the number of consecutive out-of-range ALS cycles necessary to generate an interrupt"

Quoted 1 line

2) A new option which doesn't take account of the signal dropping

below the threshold.

Quoted 3 lines

So a count of number of times above the threshold.
i.e. On each cycle, if over threshold, increment N.
Evaluate if N is greater than 'persistence' then trigger an

event.

Quoted 1 line

Why this would ever make sense on a light sensor is beyond me ;)

but there

Quoted 1 line

we are. We have a related abi for in_steps_change_value, which

fires

Quoted 1 line

an event, only every N steps. It doesn't really adapt to this

case though.

Quoted 1 line

The name persistence is definitely misleading if this is what the

liteon parts

Quoted 3 lines

do as that definitely implies case 1).

Welcome to my life, bludgeoning what appears to new ABI into what we

already have!

Quoted 10 lines

(not a lot of point in standardized ABI otherwise!)

Jonathan

Quoted 5 lines

Documentation/ABI/testing/sysfs-bus-iio +1 -0

+
   What:        /sys/.../events/in_activity_still_thresh_rising_en
   What:        /sys/.../events/in_activity_still_thresh_falling_en
   What:        /sys/.../events/in_activity_walking_thresh_rising_en

Quoted 8 lines · Jonathan Cameron

Quoted 7 lines · Kuppuswamy Sathyanarayanan

Add ABI info for iio event persistence filter.

Setting <n> to persistence filter would need atleast <n> data values outside the upper/lower threshold limits before generating an interrupt.

Signed-off-by Kuppuswamy Sathyanarayanan

<[email protected]>

Quoted 2 lines

Quoted 2 lines

---
  Documentation/ABI/testing/sysfs-bus-iio | 82

+++++++++++++++++++++++++++++++++

Quoted 3 lines

Review

Quoted 3 lines

  1 file changed, 82 insertions(+)

(quoted diff) +0 -0

b/Documentation/ABI/testing/sysfs-bus-iio

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 858

Quoted 7 lines

index 9a70c31..590b1d4 100644

Documentation/ABI/testing/sysfs-bus-iio +0 -0

@@ -856,6 +856,88 @@ Description:
  		met before an event is generated. If direction is not
  		specified then this period applies to both directions.
 

Please don't mass document cases unless they are actually in use.

These should

Quoted 1 line

get added as and when they become so. Often a particular type of

event

Quoted 1 line

characteristic is actually only implemented on a small subset of

channel types

Quoted 1 line

(where it makes sense).

IMO, persistence filter can be applied for all these cases.

But if you
think its better to
add ABI for what we currently use then I will leave only ALS/proxmity related ABI's here.

Documentation/ABI/testing/sysfs-bus-iio +2 -0

+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence

Quoted 30 lines

Quoted 30 lines

Documentation/ABI/testing/sysfs-bus-iio +29 -0

+What:		/sys/.../events/in_accel_x_thresh_rising_persistence
+What:		/sys/.../events/in_accel_x_thresh_falling_persistence
+hat:		/sys/.../events/in_accel_x_roc_rising_persistence
+What:		/sys/.../events/in_accel_x_roc_falling_persistence
+What:		/sys/.../events/in_accel_y_thresh_rising_persistence
+What:		/sys/.../events/in_accel_y_thresh_falling_persistence
+What:		/sys/.../events/in_accel_y_roc_rising_persistence
+What:		/sys/.../events/in_accel_y_roc_falling_persistence
+What:		/sys/.../events/in_accel_z_thresh_rising_persistence
+What:		/sys/.../events/in_accel_z_thresh_falling_persistence
+What:		/sys/.../events/in_accel_z_roc_rising_persistence
+What:		/sys/.../events/in_accel_z_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_x_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_x_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_x_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_y_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_y_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_y_roc_falling_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_rising_persistence
+What:		/sys/.../events/in_anglvel_z_thresh_falling_persistence
+What:		/sys/.../events/in_anglvel_z_roc_rising_persistence
+What:		/sys/.../events/in_anglvel_z_roc_falling_persistence
+What:		/sys/.../events/in_magn_x_thresh_rising_persistence
+What:		/sys/.../events/in_magn_x_thresh_falling_persistence
+What:		/sys/.../events/in_magn_x_roc_rising_persistence
+What:		/sys/.../events/in_magn_x_roc_falling_persistence
+What:		/sys/.../events/in_magn_y_thresh_rising_persistence

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description:

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio +7 -0

+What:		/sys/.../events/in_magn_y_thresh_falling_persistence
+What:		/sys/.../events/in_magn_y_roc_rising_persistence
+What:		/sys/.../events/in_magn_y_roc_falling_persistence
+What:		/sys/.../events/in_magn_z_thresh_rising_persistence
+What:		/sys/.../events/in_magn_z_thresh_falling_persistence
+What:		/sys/.../events/in_magn_z_roc_rising_persistence
+What:		/sys/.../events/in_magn_z_roc_falling_persistence
 

+What: /sys/.../events/in_rot_from_north_magnetic_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_roc_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_roc_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_magnetic_tilt_comp_roc_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_roc_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_rot_from_north_true_tilt_comp_roc_falling_persistence

Quoted 2 lines

Quoted 2 lines

+What: /sys/.../events/in_voltageY_supply_thresh_rising_persistence

+What: /sys/.../events/in_voltageY_supply_thresh_falling_persistence

Quoted 8 lines

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio +8 -0

+What:		/sys/.../events/in_voltageY_supply_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_supply_roc_falling_persistence
+What:		/sys/.../events/in_voltageY_thresh_rising_persistence
+What:		/sys/.../events/in_voltageY_thresh_falling_persistence
+What:		/sys/.../events/in_voltageY_roc_rising_persistence
+What:		/sys/.../events/in_voltageY_roc_falling_persistence
+What:		/sys/.../events/in_tempY_thresh_rising_persistence
+What:		/sys/.../events/in_tempY_thresh_falling_persistence

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 927

Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio +7 -0

+What:		/sys/.../events/in_tempY_roc_rising_persistence
+What:		/sys/.../events/in_tempY_roc_falling_persistence
+What:		/sys/.../events/in_accel_x&y&z_mag_falling_persistence
+What:		/sys/.../events/in_intensity0_thresh_persistence
+What:		/sys/.../events/in_proximity0_thresh_persistence
+What:		/sys/.../events/in_activity_still_thresh_rising_persistence
+What:		/sys/.../events/in_activity_still_thresh_falling_persistence

+What: /sys/.../events/in_activity_walking_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_walking_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_jogging_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_jogging_thresh_falling_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_running_thresh_rising_persistence

Quoted 1 line

Quoted 1 line

+What: /sys/.../events/in_activity_running_thresh_falling_persistence

Quoted 7 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 939

Quoted 6 lines

Documentation/ABI/testing/sysfs-bus-iio +6 -0

+KernelVersion:	4.0
+Contact:	[email protected]
+Description:
+		Number of times an event should occur before generating an
+		interrupt. Persistence filter value can be applied for both
+		rising/falling threshold based interrupts.

This still needs clarification as reading the discussion I'm still a

little unsure

Quoted 1 line

what the condition is. I don't think Lars' original query ever got

cleanly answered
Sorry for being unclear. Even in this case, the use case is "number of consecutive" measurement data
outside the range.

Quoted 5 lines

Taking just the upper threshold...
The interpretations I can think of are:

1) tsl2591 use case (maps directly to period with the sampling

frequency taken into

Quoted 2 lines

account).
- Too much light for N ALS cycling samples. If it drops below the

threshold

Quoted 2 lines

the count is reset.
the tcs part that Daniel referenced is also this use case.

I agree that it can be mapped to _period if you take the sampling frequency into account. But if you do that then it becomes dependent on

integration time ( for ALS case). Since _period is calculated based on frequency, each time you change _integration_time then internally you need to change the _period value to keep the ratio constant. Also you need to consider what happens if your frequency > period. I think this makes is bit complicated.

Don't you think its better to add another representation instead of trying to fit it in existing ABI's ?

Following are the persistence filter descriptions from data sheets of tsl2591 and ltr501.

LTR501: " The INTERRUPT PERSIST register controls the N number of times

the measurement data is outside the range defined by the upper and lower
threshold limits before asserting the INT".
TSL2591: " The Interrupt persistence filter sets the number of consecutive out-of-range ALS cycles necessary to generate an interrupt"

Quoted 2 lines

2) A new option which doesn't take account of the signal dropping

below the threshold.

Quoted 3 lines

So a count of number of times above the threshold.
i.e. On each cycle, if over threshold, increment N.
Evaluate if N is greater than 'persistence' then trigger an

event.

Quoted 1 line

Why this would ever make sense on a light sensor is beyond me ;)

but there

Quoted 1 line

we are. We have a related abi for in_steps_change_value, which

fires

Quoted 1 line

an event, only every N steps. It doesn't really adapt to this

case though.

Quoted 2 lines

The name persistence is definitely misleading if this is what the

liteon parts

Quoted 3 lines

do as that definitely implies case 1).

Welcome to my life, bludgeoning what appears to new ABI into what we

already have!

Quoted 11 lines

(not a lot of point in standardized ABI otherwise!)

Jonathan

Quoted 5 lines

+
What: /sys/.../events/in_activity_still_thresh_rising_en
What: /sys/.../events/in_activity_still_thresh_falling_en
What: /sys/.../events/in_activity_walking_thresh_rising_en

This patch adds interrupt support for Liteon 501 chip.

Interrupt will be generated whenever ALS or proximity data exceeds values given in upper and lower threshold register settings.

Signed-off-by Kuppuswamy Sathyanarayanan <[email protected]>

---
 drivers/iio/light/ltr501.c | 302 ++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 299 insertions(+), 3 deletions(-)

drivers/iio/light/ltr501.c +7 -1

index 883855a..8672962 100644
@@ -9,7 +9,7 @@
  *
  * 7-bit I2C slave address 0x23
  *
- * TODO: interrupt, threshold, measurement rate, IR LED characteristics
+ * TODO: measurement rate, IR LED characteristics
  */
 
 #include <linux/module.h>

@@ -18,6 +18,7 @@
 #include <linux/delay.h>
 
 #include <linux/iio/iio.h>
+#include <linux/iio/events.h>
 #include <linux/iio/sysfs.h>
 #include <linux/iio/trigger_consumer.h>
 #include <linux/iio/buffer.h>

@@ -33,6 +34,11 @@
 #define LTR501_ALS_DATA0 0x8a /* 16-bit, little endian */
 #define LTR501_ALS_PS_STATUS 0x8c
 #define LTR501_PS_DATA 0x8d /* 16-bit, little endian */
+#define LTR501_INTR 0x8f /* output mode, polarity, mode */
+#define LTR501_PS_THRESH_UP 0x90 /* 11 bit, ps upper threshold */
+#define LTR501_PS_THRESH_LOW 0x92 /* 11 bit, ps lower threshold */
+#define LTR501_ALS_THRESH_UP 0x97 /* 16 bit, ALS upper threshold */
+#define LTR501_ALS_THRESH_LOW 0x99 /* 16 bit, ALS lower threshold */
 
 #define LTR501_ALS_CONTR_SW_RESET BIT(2)
 #define LTR501_CONTR_PS_GAIN_MASK (BIT(3) | BIT(2))

drivers/iio/light/ltr501.c +11 -0

+	ret = i2c_smbus_read_byte_data(data->client, LTR501_INTR);
+	if (ret < 0)
+		return ret;
+
+	new_val = (ret & ~mask) | (val & mask);
+
+	return i2c_smbus_write_byte_data(data->client, LTR501_INTR, new_val);
+}
+
 static int ltr501_read_als(struct ltr501_data *data, __le16 buf[2])
 {
 	int ret = ltr501_drdy(data, LTR501_STATUS_ALS_RDY);

@@ -89,6 +127,43 @@ static int ltr501_read_ps(struct ltr501_data *data)
 	return i2c_smbus_read_word_data(data->client, LTR501_PS_DATA);
 }
 
+static const struct iio_event_spec ltr501_als_event_spec[] = {
+	{

drivers/iio/light/ltr501.c +25 -0

+		.type = IIO_EV_TYPE_THRESH,
+		.dir = IIO_EV_DIR_EITHER,
+		.mask_separate = BIT(IIO_EV_INFO_ENABLE),
+	},
+
+};
+
+static const struct iio_event_spec ltr501_pxs_event_spec[] = {
+	{
+		.type = IIO_EV_TYPE_THRESH,
+		.dir = IIO_EV_DIR_RISING,
+		.mask_separate = BIT(IIO_EV_INFO_VALUE),
+	},
+	{
+		.type = IIO_EV_TYPE_THRESH,
+		.dir = IIO_EV_DIR_FALLING,
+		.mask_separate = BIT(IIO_EV_INFO_VALUE),
+	},
+	{
+		.type = IIO_EV_TYPE_THRESH,
+		.dir = IIO_EV_DIR_EITHER,
+		.mask_separate = BIT(IIO_EV_INFO_ENABLE),
+	},
+};
+
 #define LTR501_INTENSITY_CHANNEL(_idx, _addr, _mod, _shared) { \
 	.type = IIO_INTENSITY, \
 	.modified = 1, \

drivers/iio/light/ltr501.c +3 -0

 }
 
 static const struct iio_chan_spec ltr501_channels[] = {

@@ -121,6 +198,8 @@ static const struct iio_chan_spec ltr501_channels[] = {
 			.storagebits = 16,
 			.endianness = IIO_CPU,
 		},
+		.event_spec = ltr501_pxs_event_spec,
+		.num_event_specs = ARRAY_SIZE(ltr501_pxs_event_spec),
 	},
 	IIO_CHAN_SOFT_TIMESTAMP(3),
 };

@@ -238,6 +317,167 @@ static int ltr501_write_raw(struct iio_dev *indio_dev,
 	return -EINVAL;
 }
 
+static int ltr501_read_thresh(struct iio_dev *indio_dev,

drivers/iio/light/ltr501.c +30 -0

+		*val = ret & LTR501_ALS_THRESH_MASK;
+		break;
+	case IIO_PROXIMITY:
+		mutex_lock(&data->lock_ps);
+		switch (dir) {
+		case IIO_EV_DIR_RISING:
+			ret = i2c_smbus_read_word_data(data->client,
+						       LTR501_PS_THRESH_UP);
+			break;
+		case IIO_EV_DIR_FALLING:
+			ret = i2c_smbus_read_word_data(data->client,
+						       LTR501_PS_THRESH_LOW);
+			break;
+		default:
+			break;
+		}
+		mutex_unlock(&data->lock_ps);
+		*val = ret & LTR501_PS_THRESH_MASK;
+		break;
+	default:
+		break;
+	}
+
+	return ret < 0 ? ret : IIO_VAL_INT;
+}
+
+static int ltr501_write_thresh(struct iio_dev *indio_dev,
+		const struct iio_chan_spec *chan, enum iio_event_type type,
+		enum iio_event_direction dir, enum iio_event_info info, int val,
+		int val2)

drivers/iio/light/ltr501.c +30 -0

+		case IIO_EV_DIR_RISING:
+			ret = i2c_smbus_write_word_data(data->client,
+							LTR501_ALS_THRESH_UP,
+							new_val);
+			break;
+		case IIO_EV_DIR_FALLING:
+			ret = i2c_smbus_write_word_data(data->client,
+							LTR501_ALS_THRESH_LOW,
+							new_val);
+			break;
+		default:
+			break;
+		}
+		mutex_unlock(&data->lock_als);
+		break;
+	case IIO_PROXIMITY:
+		switch (dir) {
+		mutex_lock(&data->lock_ps);
+		new_val = val & LTR501_PS_THRESH_MASK;
+		case IIO_EV_DIR_RISING:
+			ret = i2c_smbus_write_word_data(data->client,
+							LTR501_PS_THRESH_UP,
+							new_val);
+			break;
+		case IIO_EV_DIR_FALLING:
+			ret = i2c_smbus_write_word_data(data->client,
+							LTR501_PS_THRESH_LOW,
+							new_val);
+			break;
+		default:

drivers/iio/light/ltr501.c +9 -0

+		break;
+	}
+
+	return ret;
+}
+
+static int ltr501_write_event_config(struct iio_dev *indio_dev,
+		const struct iio_chan_spec *chan, enum iio_event_type type,
+		enum iio_event_direction dir, int state)

drivers/iio/light/ltr501.c +27 -0

+		mutex_unlock(&data->lock_als);
+		break;
+	case IIO_PROXIMITY:
+		mutex_lock(&data->lock_ps);
+		ret = ltr501_set_intr_reg(data, LTR501_INTR_MODE_PS_MASK,
+					  (state ? LTR501_INTR_MODE_PS :
+					  LTR501_INTR_MODE_NONE));
+		mutex_unlock(&data->lock_ps);
+		break;
+	default:
+		break;
+	}
+
+	return ret < 0 ? ret : IIO_VAL_INT;
+}
+
 static IIO_CONST_ATTR(in_proximity_scale_available, "1 0.25 0.125 0.0625");
 static IIO_CONST_ATTR(in_intensity_scale_available, "1 0.005");
 

@@ -251,10 +491,21 @@ static const struct attribute_group ltr501_attribute_group = {
 	.attrs = ltr501_attributes,
 };
 
+static const struct iio_info ltr501_info_no_irq = {
+	.read_raw = ltr501_read_raw,
+	.write_raw = ltr501_write_raw,
+	.attrs = &ltr501_attribute_group,
+	.driver_module = THIS_MODULE,
+};
+
 static const struct iio_info ltr501_info = {
 	.read_raw = ltr501_read_raw,
 	.write_raw = ltr501_write_raw,
 	.attrs = &ltr501_attribute_group,
+	.read_event_value	= &ltr501_read_thresh,
+	.write_event_value	= &ltr501_write_thresh,
+	.read_event_config	= &ltr501_read_event_config,
+	.write_event_config	= &ltr501_write_event_config,
 	.driver_module = THIS_MODULE,
 };
 

drivers/iio/light/ltr501.c +31 -1

+			       IIO_UNMOD_EVENT_CODE(IIO_INTENSITY, 0,
+			       IIO_EV_TYPE_THRESH,
+			       IIO_EV_DIR_EITHER),
+			       iio_get_time_ns());
+
+	if (ret & LTR501_STATUS_PS_INTR)
+		iio_push_event(dev_info,
+			       IIO_UNMOD_EVENT_CODE(IIO_PROXIMITY, 0,
+			       IIO_EV_TYPE_THRESH,
+			       IIO_EV_DIR_EITHER),
+			       iio_get_time_ns());
+
+	return IRQ_HANDLED;
+}
+
 static int ltr501_init(struct ltr501_data *data)
 {
 	int ret;

@@ -361,7 +642,6 @@ static int ltr501_probe(struct i2c_client *client,
 		return -ENODEV;
 
 	indio_dev->dev.parent = &client->dev;
-	indio_dev->info = &ltr501_info;
 	indio_dev->channels = ltr501_channels;
 	indio_dev->num_channels = ARRAY_SIZE(ltr501_channels);
 	indio_dev->name = LTR501_DRV_NAME;

@@ -371,6 +651,22 @@ static int ltr501_probe(struct i2c_client *client,
 	if (ret < 0)
 		return ret;
 
+	if (client->irq > 0) {
+		indio_dev->info = &ltr501_info;
+		ret = devm_request_threaded_irq(&client->dev, client->irq,
+						NULL, ltr501_interrupt_handler,
+						IRQF_TRIGGER_FALLING |
+						IRQF_ONESHOT,
+						"ltr501_thresh_event",
+						indio_dev);
+		if (ret) {
+			dev_err(&client->dev, "request irq (%d) failed\n",
+					client->irq);
+			return ret;
+		}
+	} else
+		indio_dev->info = &ltr501_info_no_irq;
+
 	ret = iio_triggered_buffer_setup(indio_dev, NULL,
 					 ltr501_trigger_handler, NULL);
 	if (ret)

Added rate control support for ALS and proximity threshold interrupts.

Setting <n> to ALS intr_persist sysfs node would generate interrupt whenever ALS data cross either upper or lower threshold limits <n> number of times. Similarly setting <m> to proximity intr_persist sysfs node would genere interrupt whenever proximity data falls outside threshold limit <m> number of times.

Signed-off-by Kuppuswamy Sathyanarayanan <[email protected]>

drivers/iio/light/ltr501.c +12 -0

 #define LTR501_ALS_CONTR_SW_RESET BIT(2)
 #define LTR501_CONTR_PS_GAIN_MASK (BIT(3) | BIT(2))

@@ -65,6 +66,9 @@
 #define LTR501_INTR_MODE_ALS BIT(1)
 #define LTR501_INTR_MODE_ALS_PS 3
 
+#define LTR501_INTR_PRST_ALS_MASK 0x0f
+#define LTR501_INTR_PRST_PS_MASK 0xf0
+
 #define LTR501_PS_DATA_MASK 0x7ff
 #define LTR501_PS_THRESH_MASK 0x7ff
 #define LTR501_ALS_THRESH_MASK 0xffff

@@ -127,6 +131,70 @@ static int ltr501_read_ps(struct ltr501_data *data)
 	return i2c_smbus_read_word_data(data->client, LTR501_PS_DATA);
 }
 
+static int ltr501_read_intr_prst(struct iio_dev *indio_dev,
+				 const struct iio_chan_spec *chan,
+				 int *val)
+{
+	struct ltr501_data *data = iio_priv(indio_dev);
+	int ret = -EINVAL;
+
+	switch (chan->type) {
+	case IIO_INTENSITY:

drivers/iio/light/ltr501.c +6 -0

+		if (ret >= 0)
+			*val = (ret & LTR501_INTR_PRST_PS_MASK) >> 4;
+		break;
+	default:
+		break;
+	}

drivers/iio/light/ltr501.c +33 -2

+
+	ret = i2c_smbus_read_byte_data(data->client, LTR501_INTR_PRST);
+	if (ret < 0)
+		return ret;
+
+	switch (chan->type) {
+	case IIO_INTENSITY:
+		mutex_lock(&data->lock_als);
+		new_val = (ret & ~LTR501_INTR_PRST_ALS_MASK) |
+				(new_val & LTR501_INTR_PRST_ALS_MASK);
+		ret = i2c_smbus_write_byte_data(data->client,
+						LTR501_INTR_PRST, new_val);
+		mutex_unlock(&data->lock_als);
+		break;
+	case IIO_PROXIMITY:
+		mutex_lock(&data->lock_ps);
+		new_val = (ret & ~LTR501_INTR_PRST_PS_MASK) |
+				((new_val << 4) & LTR501_INTR_PRST_PS_MASK);
+		ret = i2c_smbus_write_byte_data(data->client,
+						LTR501_INTR_PRST, new_val);
+		mutex_unlock(&data->lock_ps);
+		break;
+	default:
+		break;
+	}
+
+	return ret;
+}
+
 static const struct iio_event_spec ltr501_als_event_spec[] = {
 	{
 		.type = IIO_EV_TYPE_THRESH,

@@ -141,7 +209,8 @@ static const struct iio_event_spec ltr501_als_event_spec[] = {
 	{
 		.type = IIO_EV_TYPE_THRESH,
 		.dir = IIO_EV_DIR_EITHER,
-		.mask_separate = BIT(IIO_EV_INFO_ENABLE),
+		.mask_separate = BIT(IIO_EV_INFO_ENABLE) |
+				 BIT(IIO_EV_INFO_PERSISTENCE),
 	},
 
 };

@@ -160,7 +229,8 @@ static const struct iio_event_spec ltr501_pxs_event_spec[] = {
 	{
 		.type = IIO_EV_TYPE_THRESH,
 		.dir = IIO_EV_DIR_EITHER,
-		.mask_separate = BIT(IIO_EV_INFO_ENABLE),
+		.mask_separate = BIT(IIO_EV_INFO_ENABLE) |
+				 BIT(IIO_EV_INFO_PERSISTENCE),
 	},
 };
 

@@ -423,6 +493,49 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,
 	return ret < 0 ? ret : IIO_VAL_INT;

drivers/iio/light/ltr501.c +16 -0

+
+	switch (info) {
+	case IIO_EV_INFO_VALUE:
+		return ltr501_read_thresh(indio_dev, chan, type, dir,
+					  info, val, val2);
+	case IIO_EV_INFO_PERSISTENCE:
+		return ltr501_read_intr_prst(indio_dev, chan, val);
+	default:
+		return -EINVAL;
+	}
+
+	return IIO_VAL_INT;
+}
+
+static int ltr501_write_event(struct iio_dev *indio_dev,
+			      const struct iio_chan_spec *chan,

drivers/iio/light/ltr501.c +3 -2

+
 static int ltr501_read_event_config(struct iio_dev *indio_dev,
 		const struct iio_chan_spec *chan,
 		enum iio_event_type type,

@@ -502,8 +615,8 @@ static const struct iio_info ltr501_info = {
 	.read_raw = ltr501_read_raw,
 	.write_raw = ltr501_write_raw,
 	.attrs = &ltr501_attribute_group,
-	.read_event_value	= &ltr501_read_thresh,
-	.write_event_value	= &ltr501_write_thresh,
+	.read_event_value	= &ltr501_read_event,
+	.write_event_value	= &ltr501_write_event,
 	.read_event_config	= &ltr501_read_event_config,
 	.write_event_config	= &ltr501_write_event_config,
 	.driver_module = THIS_MODULE,