Skip to contentSkip to conversation

toaster: filtersnippet remove redefinition of filter type key

PATCH In review Alex DAMIAN 1 participant 3 messages May 4, 2015 – May 6, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1ddd6a9e4280a4adf971132ff1fe7ec9b3252905.1430498382.git.alexandru.damian@intel.com

#1 lore raw

PATCH 7/7 toaster: filtersnippet remove redefinition of filter type key

From: Michael Wood <[email protected]>

This redefinition is not needed and also used Mozilla specific API to access the data thus breaking the date filter in all other browsers.

[YOCTO #7577]

---
 lib/toaster/toastergui/static/js/filtersnippet.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
lib/toaster/toastergui/static/js/filtersnippet.js +1 -2
index 27b057e..2b84c54 100755
@@ -80,8 +80,7 @@ function date_init (key, from_date, to_date, min_date, max_date, initial_enable)
     $("form").unbind('submit');
     $("form").submit(function(e) {
         // format a composite daterange filter value so that it can be parsed and post-processed in the view
-        var key=e.originalEvent.explicitOriginalTarget.getAttribute("data-key")
-        if (typeof key != "undefined") {
+        if (key !== undefined) {
             if ($("#date_from_"+key).length) {
                 var filter=key+"__gte!"+key+"__lt:"+$("#date_from_"+key).val()+"!"+$("#date_to_"+key).val()+"_daterange";
                 $("#last_date_from_"+key).val($("#date_from_"+key).val());
Signature · 1 line
1.9.1
#2 lore raw

cover toaster patchset

From: Alexandru DAMIAN <[email protected]>

Hello,

This is a toaster patchset adding UI and build logger fixes.

Cheers,
Alex

The following changes since commit f8590547a198a78334debdf14bf40acb50c22ecc:

bitbake: reset build mtime cache before the build (2015-04-28 22:28:45 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib adamian/20150501-submission-bb
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=adamian/20150501-submission-bb

Alexandru DAMIAN (2):
toasterui: proper exit code on toaster errors
toasterui: close build on BuildCompleted event

Michael Wood (5):
toaster: Move project context variables to common scope
toaster: projectapp Implement machine select command
toaster: Refactor and expand layer add remove mechanism
toaster: Add links to the layer add notification
toaster: filtersnippet remove redefinition of filter type key

 bin/toaster-eventreplay                            |  13 +-
 lib/bb/ui/buildinfohelper.py                       |   5 +-
 lib/bb/ui/toasterui.py                             |  45 +++--
 lib/toaster/orm/views.py                           |   8 +-
 lib/toaster/toastergui/static/css/default.css      |   2 +-
 .../toastergui/static/html/layer_deps_modal.html   |  17 ++
 lib/toaster/toastergui/static/js/base.js           |  39 ++--
 lib/toaster/toastergui/static/js/filtersnippet.js  |   3 +-
 lib/toaster/toastergui/static/js/importlayer.js    |  20 +-
 lib/toaster/toastergui/static/js/layerBtn.js       |  63 ++++++
 lib/toaster/toastergui/static/js/layerDepsModal.js |  90 +++++++++
 lib/toaster/toastergui/static/js/layerdetails.js   |  99 ++-------
 lib/toaster/toastergui/static/js/libtoaster.js     |  96 ++++++++-
 lib/toaster/toastergui/static/js/machines.js       |  97 ---------
 lib/toaster/toastergui/static/js/projectapp.js     |  31 ++-
 lib/toaster/toastergui/templates/base.html         |  19 +-
 lib/toaster/toastergui/templates/importlayer.html  |   6 +-
 lib/toaster/toastergui/templates/layerdetails.html |   9 +-
 lib/toaster/toastergui/templates/layers.html       | 223 +++------------------
 .../toastergui/templates/layers_dep_modal.html     |  99 ---------
 lib/toaster/toastergui/templates/machines.html     |  36 ++--
 lib/toaster/toastergui/templates/targets.html      | 220 ++++----------------
 lib/toaster/toastergui/views.py                    |   2 +-
 23 files changed, 471 insertions(+), 771 deletions(-)
 create mode 100644 lib/toaster/toastergui/static/html/layer_deps_modal.html
 create mode 100644 lib/toaster/toastergui/static/js/layerBtn.js
 create mode 100644 lib/toaster/toastergui/static/js/layerDepsModal.js
 delete mode 100644 lib/toaster/toastergui/static/js/machines.js
 delete mode 100644 lib/toaster/toastergui/templates/layers_dep_modal.html
Signature · 1 line
1.9.1
#3 lore raw

Re: [PATCH 0/7] toaster patchset

Hello,

I've just noticed that the patch email never arrived, not sure why.

Can you please pull from the contrib branch ?

Thank you,
Alex

Quoted 69 lines · Alex DAMIAN

From: Alexandru DAMIAN <[email protected]>

Hello,

This is a toaster patchset adding UI and build logger fixes.

Cheers,
Alex

The following changes since commit
f8590547a198a78334debdf14bf40acb50c22ecc:

bitbake: reset build mtime cache before the build (2015-04-28 22:28:45
+0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib adamian/20150501-submission-bb

http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=adamian/20150501-submission-bb

Alexandru DAMIAN (2):
toasterui: proper exit code on toaster errors
toasterui: close build on BuildCompleted event

Michael Wood (5):
toaster: Move project context variables to common scope
toaster: projectapp Implement machine select command
toaster: Refactor and expand layer add remove mechanism
toaster: Add links to the layer add notification
toaster: filtersnippet remove redefinition of filter type key

 bin/toaster-eventreplay                            |  13 +-
 lib/bb/ui/buildinfohelper.py                       |   5 +-
 lib/bb/ui/toasterui.py                             |  45 +++--
 lib/toaster/orm/views.py                           |   8 +-
 lib/toaster/toastergui/static/css/default.css      |   2 +-
 .../toastergui/static/html/layer_deps_modal.html   |  17 ++
 lib/toaster/toastergui/static/js/base.js           |  39 ++--
 lib/toaster/toastergui/static/js/filtersnippet.js  |   3 +-
 lib/toaster/toastergui/static/js/importlayer.js    |  20 +-
 lib/toaster/toastergui/static/js/layerBtn.js       |  63 ++++++
 lib/toaster/toastergui/static/js/layerDepsModal.js |  90 +++++++++
 lib/toaster/toastergui/static/js/layerdetails.js   |  99 ++-------
 lib/toaster/toastergui/static/js/libtoaster.js     |  96 ++++++++-
 lib/toaster/toastergui/static/js/machines.js       |  97 ---------
 lib/toaster/toastergui/static/js/projectapp.js     |  31 ++-
 lib/toaster/toastergui/templates/base.html         |  19 +-
 lib/toaster/toastergui/templates/importlayer.html  |   6 +-
 lib/toaster/toastergui/templates/layerdetails.html |   9 +-
 lib/toaster/toastergui/templates/layers.html       | 223
+++------------------
 .../toastergui/templates/layers_dep_modal.html     |  99 ---------
 lib/toaster/toastergui/templates/machines.html     |  36 ++--
 lib/toaster/toastergui/templates/targets.html      | 220
++++----------------
 lib/toaster/toastergui/views.py                    |   2 +-
 23 files changed, 471 insertions(+), 771 deletions(-)
 create mode 100644
lib/toaster/toastergui/static/html/layer_deps_modal.html
 create mode 100644 lib/toaster/toastergui/static/js/layerBtn.js
 create mode 100644 lib/toaster/toastergui/static/js/layerDepsModal.js
 delete mode 100644 lib/toaster/toastergui/static/js/machines.js
 delete mode 100644 lib/toaster/toastergui/templates/layers_dep_modal.html

--
1.9.1

Signature · 3 lines
Alex Damian
Yocto Project
SSG / OTC