Add OnKey support for DA9063

From: Steve Twiss <[email protected]>

Hello,

This is a resend, now adding Andrew Morton and Jiri Kosina with the hope it might help to unblock this patch.

The OnKey patch originally reviewed by Dmitry Torokhov and re-submitted in return -- it has been resent several times in the past six weeks but has had no further responses to any e-mails.

- https://lkml.org/lkml/2015/6/3/99

I would like to promote this last remaining OnKey patch to other maintainers in the hierarchy with the hope I can get a reply.

The original patch set for adding OnKey driver support for the Dialog Semiconductor DA9063 PMIC contained MFD core support, DT bindings and the OnKey driver itself.

All files have been reviewed by the maintainers and my reponses have been sent quickly. Two out of the three patches in this set were Acked and have already been applied to linux-next kernel:

a5df460 mfd: dt: Add bindings for DA9063 OnKey d497c625 mfd: da9063: Add support for OnKey driver

This is the remaining patch being resent:

[RESEND PATCH V4 1/1]: kernel driver onkey support for DA9063

This particular OnKey patch will only support the DA9063 PMIC. If this patch makes it into the kernel it was the request of the maintainers and is my intention to use this OnKey driver as the starting point for other Dialog Semiconductor chips which also use a functionally similar OnKey block.

One of these PMIC chips is currently under submission to the kernel and the MFD part has already been reviewed and my replies for that one sent. I expect this hanging patch for OnKey will eventually block further development in other Dialog chips: this is another reason I have for wanting to promote the DA9063 OnKey driver further.

I would like to move this driver development forward again, so if there are any issues relating to this OnKey driver I would very much appreciate any response so I can unblock things.

Thank you,
Steve Twiss, Dialog Semiconductor Ltd.

S Twiss (1):
input: misc: da9063: OnKey driver

 drivers/input/misc/Kconfig        |  10 ++
 drivers/input/misc/Makefile       |   1 +
 drivers/input/misc/da9063_onkey.c | 227 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 238 insertions(+)
 create mode 100644 drivers/input/misc/da9063_onkey.c

end-of-patch for RESEND PATCH V4

From: Steve Twiss <[email protected]>

Add OnKey driver support for DA9063

---
The changes made in PATCH V3 have been taken from the DA9062 OnKey review thread. Please see https://lkml.org/lkml/2015/4/29/406 for more information on this.

Version History

Changes in V4
- No change, just a resend.

Changes in V3
- Move the MFD code changes into a separate patch [PATCH V3 3/3]
- Rename OnKey driver to use underscore: da9063_onkey.c
- Header and MODULE_LICENSE macro update for GPL and filename change
- Remove MAINTAINERS file (no longer needed due to rename of onkey driver)
- Delete input_unregister_device call from platform driver remove function
- Replaced dev_notice() with dev_dbg() for key press notification

Changes in V2
- Remove the circular dependency comment in the main e-mail body linking PATCH V1 1/2 and 2/2
- Alter the copyright header information to match expected GPLv2 text from http://www.gnu.org/licenses/gpl-2.0.html

This patch applies against linux-next and v4.1-rc3

 drivers/input/misc/Kconfig        |  10 ++
 drivers/input/misc/Makefile       |   1 +
 drivers/input/misc/da9063_onkey.c | 227 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 238 insertions(+)
 create mode 100644 drivers/input/misc/da9063_onkey.c

index 4436ab1..d917883 100644
@@ -610,6 +610,16 @@ config INPUT_DA9055_ONKEY
 	  To compile this driver as a module, choose M here: the module
 	  will be called da9055_onkey.
 
+config INPUT_DA9063_ONKEY
+	tristate "Dialog DA9063 OnKey"
+	depends on MFD_DA9063
+	help
+	  Support the ONKEY of Dialog DA9063 Power Management IC as an
+	  input device reporting power button statue.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called da9063-onkey.
+
 config INPUT_DM355EVM
 	tristate "TI DaVinci DM355 EVM Keypad and IR Remote"
 	depends on MFD_DM355EVM_MSP

index 78ba4c1..4f95c56 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000_I2C)		+= cma3000_d0x_i2c.o
 obj-$(CONFIG_INPUT_COBALT_BTNS)		+= cobalt_btns.o
 obj-$(CONFIG_INPUT_DA9052_ONKEY)	+= da9052_onkey.o
 obj-$(CONFIG_INPUT_DA9055_ONKEY)	+= da9055_onkey.o
+obj-$(CONFIG_INPUT_DA9063_ONKEY)	+= da9063_onkey.o
 obj-$(CONFIG_INPUT_DM355EVM)		+= dm355evm_keys.o
 obj-$(CONFIG_INPUT_E3X0_BUTTON)		+= e3x0-button.o
 obj-$(CONFIG_INPUT_DRV260X_HAPTICS)	+= drv260x.o

end-of-patch for RESEND PATCH V4

Hi Steve,

Sorry for the delay.

I took the liberty of rearranging the code a bit and converting it to devm* fully, does the version below still work for you?

Thanks.

Dmitry


Input: add OnKey driver for DA9063 MFD part

From: Steve Twiss <[email protected]>

Add OnKey driver support for DA9063

Signed-off-by: Steve Twiss <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---
 drivers/input/misc/Kconfig        |   10 ++
 drivers/input/misc/Makefile       |    1 
 drivers/input/misc/da9063_onkey.c |  226 +++++++++++++++++++++++++++++++++++++
 3 files changed, 237 insertions(+)
 create mode 100644 drivers/input/misc/da9063_onkey.c

index e5c4de2..d4f0a81 100644
@@ -610,6 +610,16 @@ config INPUT_DA9055_ONKEY
 	  To compile this driver as a module, choose M here: the module
 	  will be called da9055_onkey.
 
+config INPUT_DA9063_ONKEY
+	tristate "Dialog DA9063 OnKey"
+	depends on MFD_DA9063
+	help
+	  Support the ONKEY of Dialog DA9063 Power Management IC as an
+	  input device reporting power button statue.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called da9063_onkey.
+
 config INPUT_DM355EVM
 	tristate "TI DaVinci DM355 EVM Keypad and IR Remote"
 	depends on MFD_DM355EVM_MSP

index d317947..53df07d 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000_I2C)		+= cma3000_d0x_i2c.o
 obj-$(CONFIG_INPUT_COBALT_BTNS)		+= cobalt_btns.o
 obj-$(CONFIG_INPUT_DA9052_ONKEY)	+= da9052_onkey.o
 obj-$(CONFIG_INPUT_DA9055_ONKEY)	+= da9055_onkey.o
+obj-$(CONFIG_INPUT_DA9063_ONKEY)	+= da9063_onkey.o
 obj-$(CONFIG_INPUT_DM355EVM)		+= dm355evm_keys.o
 obj-$(CONFIG_INPUT_E3X0_BUTTON)		+= e3x0-button.o
 obj-$(CONFIG_INPUT_DRV260X_HAPTICS)	+= drv260x.o

Hi Dmitry,

No problem. Thank you for getting back to me and for taking the time to work through this code.

Everything looks fine for me thank you.

I see now: in future I will make use of the devm_add_action() and use the devm* properly & your changes have simplified the error handling and negated the need for a .remove function. The devm release cleans up in reverse -- preserving the free_irq() and cancel_delayed_work_sync() ordering ...

Regards,
Steve.

[...]

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html