Skip to contentSkip to conversation

OMAPDSS: Fix of-node refcount issues

PATCH In review Jyri Sarha 2 participants 2 messages Aug 7, 2015 – Aug 10, 2015 Framebuffer layer

lore
Share & tools
lore

Jyri Sarha

author
#0 lore raw

v2 cover OMAPDSS: Fix of-node refcount issues

Changes since the first version:
- Fix commit descriptions and subject according to Tomi's comments

I found couple of refcounting issues related to OMAP DSS of-node handling. Second patch should fix the "ERROR: Bad of_node_put() on /encoder@0/ports/port@1" -problem.

In the long run it would make sense start using of_graph_*() functions in OMAP DSS too. However the semantics of of_graph_*() functions are quite different from omapdss_of_*() counterparts. So it better to just fix these bugs first.

Jyri Sarha (2):
OMAPDSS: Fix node refcount leak in omapdss_of_get_next_port()
OMAPDSS: Fix omap_dss_find_output_by_port_node() port refcount
decrement

 drivers/video/fbdev/omap2/dss/dss-of.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 12 lines · Jyri Sarha

Changes since the first version:
- Fix commit descriptions and subject according to Tomi's comments

I found couple of refcounting issues related to OMAP DSS of-node handling. Second patch should fix the "ERROR: Bad of_node_put() on /encoder@0/ports/port@1" -problem.

In the long run it would make sense start using of_graph_*() functions in OMAP DSS too. However the semantics of of_graph_*() functions are quite different from omapdss_of_*() counterparts. So it better to just fix these bugs first.

Quoted 7 lines

Jyri Sarha (2):
OMAPDSS: Fix node refcount leak in omapdss_of_get_next_port()
OMAPDSS: Fix omap_dss_find_output_by_port_node() port refcount
decrement

 drivers/video/fbdev/omap2/dss/dss-of.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, I've picked these up for 4.2 fixes.

Tomi