Skip to contentSkip to conversation

v2: Fix presentation issues on "all builds" page

PATCH New Elliot Smith 1 participant 4 messages Sep 8, 2015

lore
Share & tools
lore
#0 lore raw

cover v2: Fix presentation issues on "all builds" page

This branch fixes some small presentation issues in the all builds page.

Note that this patch series supersedes the previous one with the same title, as that one lacked the correct "Signed-off-by" footers.

The following changes since commit c1df471feacaf2590216aa476ce242908dac38cf:

pseudo_1.7.3.bb: New version of pseudo (2015-09-06 15:26:27 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib elliot/submit/bbarrosp/all-builds
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/submit/bbarrosp/all-builds

Belen Barros Pena (3):
toaster: remove unnecessary white space
toaster: fix project names in latest builds
toaster: replace ETA with % of tasks done

 lib/toaster/toastergui/templates/mrb_section.html | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

--
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#1 lore raw

PATCH 1/3 toaster: remove unnecessary white space

From: Belen Barros Pena <[email protected]>

There was too much white space above the first heading in the all builds page. This patch removes the class that was adding the extra space.

---
 lib/toaster/toastergui/templates/mrb_section.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/toaster/toastergui/templates/mrb_section.html +1 -1
index d37b694..903635d 100644
@@ -5,7 +5,7 @@
 
 {%if mru.count > 0%}
 
-  <div class="page-header top-air">
+  <div class="page-header">
       <h1>
           Latest builds
        </h1>
Signature · 12 lines
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
#2 lore raw

PATCH 2/3 toaster: fix project names in latest builds

From: Belen Barros Pena <[email protected]>

Make sure that the project name we show for each build in the latest builds section of the all builds page:

* Has the same styles as the build, depending on the build status (in progress, failed or success)

* Links to the project page

---
 lib/toaster/toastergui/templates/mrb_section.html | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
lib/toaster/toastergui/templates/mrb_section.html +5 -1
index 903635d..57a6f9b 100644
@@ -13,7 +13,11 @@
   <div id="latest-builds">
   {% for build in mru %}
     <div class="alert {%if build.outcome == build.SUCCEEDED%}alert-success{%elif build.outcome == build.FAILED%}alert-error{%else%}alert-info{%endif%} project-name ">
-       <span class="label {%if build.outcome == build.SUCCEEDED%}label-success{%elif build.outcome == build.FAILED%}label-danger{%else%}label-info{%endif%}"> {{build.project.name}} </span>
+       <span class="label {%if build.outcome == build.SUCCEEDED%}label-success{%elif build.outcome == build.FAILED%}label-important{%else%}label-info{%endif%}">
+         <a href={% url 'project' build.project.pk %}>
+           {{build.project.name}}
+         </a>
+       </span>
 
         <div class="row-fluid">
             <div class="span3 lead">
Signature · 12 lines
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
#3 lore raw

PATCH 3/3 toaster: replace ETA with % of tasks done

In reply to Elliot Smith

From: Belen Barros Pena <[email protected]>

The ETA we show for builds in progress is woefully inaccurate. In the 1.8 release we replaced it with the % of tasks completed. Somehow, we regressed to the ETA, so bringing the task % back.

---
 lib/toaster/toastergui/templates/mrb_section.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/toaster/toastergui/templates/mrb_section.html +1 -1
index 57a6f9b..396fb8e 100644
@@ -84,7 +84,7 @@
                     <div style="width: {{build.completeper}}%;" class="bar"></div>
                 </div>
             </div>
-            <div class="lead pull-right">ETA: in {{build.eta|naturaltime}}</div>
+            <div class="lead pull-right">{{build.completeper}}% of tasks complete</div>
     {%endif%}
         </div>
     </div>
Signature · 12 lines
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.