Skip to contentSkip to conversation

Fix coding style issues and a consistence change.

PATCH New Maitesin 1 participant 3 messages Sep 9, 2015 Isofs filesystem

lore
Share & tools
lore

Maitesin

author
#0 lore raw

cover Fix coding style issues and a consistence change.

Some fixes for coding style issues and consistence in a conditional.

Maitesin (2):
fs: isofs: Fix a coding style issue and change conditional to make it
consistence
fs: isofs: Fix several coding style issues

 fs/isofs/compress.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
Signature · 1 line
2.5.1
author
#1 lore raw

PATCH 1/2 fs: isofs: Fix a coding style issue and change conditional to make it consistence

The coding style issue is the white spaces after and before the brackets in the for. The change in the conditional is to make it consistence with the other ones in the file. All other conditionals are tested like that.

---
 fs/isofs/compress.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/isofs/compress.c +2 -2
index f311bf0..5750830 100644
@@ -66,8 +66,8 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start,
 		return 0;
 	}
 	/* Empty block? */
-	if (block_size == 0) {
-		for ( i = 0 ; i < pcount ; i++ ) {
+	if (!block_size) {
+		for (i = 0 ; i < pcount ; i++) {
 			if (!pages[i])
 				continue;
 			memset(page_address(pages[i]), 0, PAGE_CACHE_SIZE);
Signature · 1 line
2.5.1
author
#2 lore raw

PATCH 2/2 fs: isofs: Fix several coding style issues

In reply to Maitesin

As recommended I fixed several coding style issues related with whitespaces.

---
 fs/isofs/compress.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
fs/isofs/compress.c +5 -6
index 5750830..107a078 100644
@@ -67,7 +67,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start,
 	}
 	/* Empty block? */
 	if (!block_size) {
-		for (i = 0 ; i < pcount ; i++) {
+		for (i = 0; i < pcount; i++) {
 			if (!pages[i])
 				continue;
 			memset(page_address(pages[i]), 0, PAGE_CACHE_SIZE);
@@ -103,7 +103,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start,
 
 	stream.workspace = zisofs_zlib_workspace;
 	mutex_lock(&zisofs_zlib_lock);
-		
+
 	zerr = zlib_inflateInit(&stream);
 	if (zerr != Z_OK) {
 		if (zerr == Z_MEM_ERROR)
@@ -134,7 +134,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start,
 				*errp = -EIO;
 				break;
 			}
-			stream.next_in  = bhs[curbh]->b_data +
+			stream.next_in = bhs[curbh]->b_data +
 						(block_start & bufmask);
 			stream.avail_in = min_t(unsigned, bufsize -
 						(block_start & bufmask),
@@ -353,7 +353,7 @@ static int zisofs_readpage(struct file *file, struct page *page)
 			if (i != full_page)
 				page_cache_release(pages[i]);
 		}
-	}			
+	}
 
 	/* At this point, err contains 0 or -EIO depending on the "critical" page */
 	return err;
@@ -368,9 +368,8 @@ const struct address_space_operations zisofs_aops = {
 int __init zisofs_init(void)
 {
 	zisofs_zlib_workspace = vmalloc(zlib_inflate_workspacesize());
-	if ( !zisofs_zlib_workspace )
+	if (!zisofs_zlib_workspace)
 		return -ENOMEM;
-
 	return 0;
 }
 
Signature · 1 line
2.5.1