Skip to contentSkip to conversation

perf and autotools.bbclass: mkdir ${B} -> mkdir -p ${B}

PATCH New Robert Yang 1 participant 3 messages Sep 16, 2015

lore
Share & tools
lore
#0 lore raw

cover perf and autotools.bbclass: mkdir ${B} -> mkdir -p ${B}

The following changes since commit f0189829498e30231d826c9f55aad73e622d076e:

qemu: Update to upstream patches (2015-09-14 11:22:02 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/mkdir
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/mkdir

Robert Yang (2):
perf: mkdir ${B} -> mkdir -p ${B}
autotools.bbclass: mkdir ${B} -> mkdir -p ${B}

 meta/classes/autotools.bbclass   |    2 +-
 meta/recipes-kernel/perf/perf.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/2 perf: mkdir ${B} -> mkdir -p ${B}

${B} is the default cwd of tasks, so there might be race issues such as:
| mkdir: cannot create directory `/path/to/work/qemux86-poky-linux/perf/1.0-r9/perf-1.0/': File exists [snip]
NOTE: recipe perf-1.0-r9: task do_configure: Failed

---
 meta/recipes-kernel/perf/perf.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/perf/perf.bb +1 -1
index adb3a2c..242cf62 100644
@@ -120,7 +120,7 @@ do_install() {
 do_configure_prepend () {
     # Fix for rebuilding
     rm -rf ${B}/
-    mkdir ${B}/
+    mkdir -p ${B}/
 
     # If building a multlib based perf, the incorrect library path will be
     # detected by perf, since it triggers via: ifeq ($(ARCH),x86_64). In a 32 bit
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/2 autotools.bbclass: mkdir ${B} -> mkdir -p ${B}

In reply to Robert Yang

${B} is the default cwd of tasks, so there might be race issues such as:
| mkdir: cannot create directory `${B}': File exists
[snip]
NOTE: recipe perf-1.0-r9: task do_configure: Failed

---
 meta/classes/autotools.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/autotools.bbclass +1 -1
index 9ccd7d2..819045a 100644
@@ -105,7 +105,7 @@ autotools_preconfigure() {
 			if [ "${S}" != "${B}" ]; then
 				echo "Previously configured separate build directory detected, cleaning ${B}"
 				rm -rf ${B}
-				mkdir ${B}
+				mkdir -p ${B}
 			else
 				# At least remove the .la files since automake won't automatically
 				# regenerate them even if CFLAGS/LDFLAGS are different
Signature · 1 line
1.7.9.5